[{"id":1760442,"web_url":"http://patchwork.ozlabs.org/comment/1760442/","msgid":"<541ece36-e015-22b9-7559-3e687717a0e9@redhat.com>","list_archive_url":null,"date":"2017-08-30T19:51:18","subject":"Re: [Qemu-devel] [PATCH v2 6/7] block/curl: fix minor memory leaks","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 08/30/2017 11:57 AM, Jeff Cody wrote:\n> Signed-off-by: Jeff Cody \n> ---\n> block/curl.c | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n\n> +++ b/block/curl.c\n> @@ -857,6 +857,9 @@ out_noclean:\n> qemu_mutex_destroy(&s->mutex);\n> g_free(s->cookie);\n> g_free(s->url);\n> + g_free(s->username);\n> + g_free(s->proxyusername);\n> + g_free(s->proxypassword);\n\nWould it be any simpler to call curl_close(s) instead of open-coding it\nhere in this cleanup path?\n\n> @@ -955,6 +958,9 @@ static void curl_close(BlockDriverState *bs)\n> \n> g_free(s->cookie);\n> g_free(s->url);\n> + g_free(s->username);\n> + g_free(s->proxyusername);\n> + g_free(s->proxypassword);\n> }\n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjGP26FNHz9s8P\n\tfor ;\n\tThu, 31 Aug 2017 05:52:06 +1000 (AEST)","from localhost ([::1]:52433 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn91x-0003JB-1r\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 15:52:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48643)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn91L-00037k-ER\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:51:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn91K-0003Uu-Gh\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:51:27 -0400","from mx1.redhat.com ([209.132.183.28]:38854)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn91F-0003Py-Sj; Wed, 30 Aug 2017 15:51:22 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CCF87883AC;\n\tWed, 30 Aug 2017 19:51:20 +0000 (UTC)","from [10.10.122.186] (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6F63D619CF;\n\tWed, 30 Aug 2017 19:51:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CCF87883AC","To":"Jeff Cody , qemu-devel@nongnu.org","References":"\n\t<131d9e66f5046317565c7d17af65823ebebb4b50.1504112061.git.jcody@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<541ece36-e015-22b9-7559-3e687717a0e9@redhat.com>","Date":"Wed, 30 Aug 2017 14:51:18 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<131d9e66f5046317565c7d17af65823ebebb4b50.1504112061.git.jcody@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"hi1Iik5StrqhVL7wNndF9hTsD0Q7scG5M\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 30 Aug 2017 19:51:20 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 6/7] block/curl: fix minor memory leaks","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, qemu-block@nongnu.org,\n\trjones@redhat.com, kwolf@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]