[{"id":1760419,"web_url":"http://patchwork.ozlabs.org/comment/1760419/","msgid":"","list_archive_url":null,"date":"2017-08-30T19:11:30","subject":"Re: [Qemu-devel] [PATCH v1 10/11] target/s390x: use\n\ttrigger_pgm_exception() in s390_cpu_handle_mmu_fault()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 19:06, David Hildenbrand wrote:\n> This looks cleaner.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/excp_helper.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c\n> index 2ac36535f7..f5f5967833 100644\n> --- a/target/s390x/excp_helper.c\n> +++ b/target/s390x/excp_helper.c\n> @@ -59,8 +59,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr address,\n> {\n> S390CPU *cpu = S390_CPU(cs);\n> \n> - cs->exception_index = EXCP_PGM;\n> - cpu->env.int_pgm_code = PGM_ADDRESSING;\n> + trigger_pgm_exception(&cpu->env, PGM_ADDRESSING, ILEN_AUTO);\n> /* On real machines this value is dropped into LowMem. Since this\n> is userland, simply put this someplace that cpu_loop can find it. */\n> cpu->env.__excp_addr = address;\n\ntrigger_pgm_exception() additionally sets int_pgm_ilen ... I assume\nthat's OK here? A comment in the patch description would be helpful.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjFVy1K8Tz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 05:12:09 +1000 (AEST)","from localhost ([::1]:52283 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn8PG-0006P7-D5\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 15:12:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39748)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn8Ou-0006Or-58\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:11:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn8Or-0006qE-0j\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:11:44 -0400","from mx1.redhat.com ([209.132.183.28]:38828)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dn8Oq-0006q1-Px\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 15:11:40 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9FEE580E6A;\n\tWed, 30 Aug 2017 19:11:39 +0000 (UTC)","from [10.36.116.20] (ovpn-116-20.ams2.redhat.com [10.36.116.20])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5535A7095A;\n\tWed, 30 Aug 2017 19:11:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9FEE580E6A","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-11-david@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Wed, 30 Aug 2017 21:11:30 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830170601.15855-11-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 30 Aug 2017 19:11:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 10/11] target/s390x: use\n\ttrigger_pgm_exception() in s390_cpu_handle_mmu_fault()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761000,"web_url":"http://patchwork.ozlabs.org/comment/1761000/","msgid":"","list_archive_url":null,"date":"2017-08-31T13:34:50","subject":"Re: [Qemu-devel] [PATCH v1 10/11] target/s390x: use\n\ttrigger_pgm_exception() in s390_cpu_handle_mmu_fault()","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 30.08.2017 21:11, Thomas Huth wrote:\n> On 30.08.2017 19:06, David Hildenbrand wrote:\n>> This looks cleaner.\n>>\n>> Signed-off-by: David Hildenbrand \n>> ---\n>> target/s390x/excp_helper.c | 3 +--\n>> 1 file changed, 1 insertion(+), 2 deletions(-)\n>>\n>> diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c\n>> index 2ac36535f7..f5f5967833 100644\n>> --- a/target/s390x/excp_helper.c\n>> +++ b/target/s390x/excp_helper.c\n>> @@ -59,8 +59,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr address,\n>> {\n>> S390CPU *cpu = S390_CPU(cs);\n>> \n>> - cs->exception_index = EXCP_PGM;\n>> - cpu->env.int_pgm_code = PGM_ADDRESSING;\n>> + trigger_pgm_exception(&cpu->env, PGM_ADDRESSING, ILEN_AUTO);\n>> /* On real machines this value is dropped into LowMem. Since this\n>> is userland, simply put this someplace that cpu_loop can find it. */\n>> cpu->env.__excp_addr = address;\n> \n> trigger_pgm_exception() additionally sets int_pgm_ilen ... I assume\n> that's OK here? A comment in the patch description would be helpful.\n> \n\nAs far as I can tell, ilen is completely ignored for linux-user (see\ncpu_loop() in linux-user/main.c)\n\nWill add a comment, thanks!\n\n> Thomas\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjk1H015Rz9sPm\n\tfor ;\n\tThu, 31 Aug 2017 23:36:34 +1000 (AEST)","from localhost ([::1]:55857 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnPe5-0003Ws-36\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 09:36:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59409)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnPce-0002o5-Q1\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:35:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnPcX-0007me-68\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:35:04 -0400","from mx1.redhat.com ([209.132.183.28]:56908)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnPcX-0007mN-0O\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:34:57 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AB0877570C;\n\tThu, 31 Aug 2017 13:34:55 +0000 (UTC)","from [10.36.118.11] (unknown [10.36.118.11])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 995AF94B59;\n\tThu, 31 Aug 2017 13:34:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AB0877570C","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170830170601.15855-1-david@redhat.com>\n\t<20170830170601.15855-11-david@redhat.com>\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Thu, 31 Aug 2017 15:34:50 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 31 Aug 2017 13:34:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 10/11] target/s390x: use\n\ttrigger_pgm_exception() in s390_cpu_handle_mmu_fault()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]