[{"id":1761114,"web_url":"http://patchwork.ozlabs.org/comment/1761114/","msgid":"<08aeadde-8a44-c49f-bc64-5b91226d4cec@lwfinger.net>","list_archive_url":null,"date":"2017-08-31T15:25:30","subject":"Re: [PATCH] rtlwifi: refactor code in halbtcoutsrc module","submitter":{"id":190,"url":"http://patchwork.ozlabs.org/api/people/190/","name":"Larry Finger","email":"Larry.Finger@lwfinger.net"},"content":"On 08/30/2017 11:46 AM, Gustavo A. R. Silva wrote:\n> Function halbtc_get_wifi_rssi always returns rtlpriv->dm.undec_sm_pwdb.\n> So this function can be removed and the value of\n> rtlpriv->dm.undec_sm_pwdb assigned to *s32_tmp directly.\n> \n> This issue was first reported by Coverity as \"identical code for different\n> branches\" in function halbtc_get_wifi_rssi.\n> \n> Addresses-Coverity-ID: 1226793\n> Signed-off-by: Gustavo A. R. Silva \n> ---\n> This code was reported by Coverity and it was tested by compilation only.\n> Chances are this may be a copy/paste error in function\n> halbtc_get_wifi_rssi. Please, verify.\n> Also, notice this code has been there since 2014.\n\nThe value of *s32_tmp is not dependent on the link state, thus this patch is \ncorrect, but I request that it be changed. Future developments will modify \nhalbtc_get_wifi_rssi() making it more complicated and not as easily inlined as \nthis patch. In short, if you remove it here, we will have to add it later.\n\nThanks,\n\nLarrt\n\n> \n> .../net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 13 +------------\n> 1 file changed, 1 insertion(+), 12 deletions(-)\n> \n> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n> index c1eacd8..2a47b97 100644\n> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n> @@ -373,17 +373,6 @@ u32 halbtc_get_wifi_link_status(struct btc_coexist *btcoexist)\n> \treturn ret_val;\n> }\n> \n> -static s32 halbtc_get_wifi_rssi(struct rtl_priv *rtlpriv)\n> -{\n> -\tint undec_sm_pwdb = 0;\n> -\n> -\tif (rtlpriv->mac80211.link_state >= MAC80211_LINKED)\n> -\t\tundec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;\n> -\telse /* associated entry pwdb */\n> -\t\tundec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;\n> -\treturn undec_sm_pwdb;\n> -}\n> -\n> static bool halbtc_get(void *void_btcoexist, u8 get_type, void *out_buf)\n> {\n> \tstruct btc_coexist *btcoexist = (struct btc_coexist *)void_btcoexist;\n> @@ -479,7 +468,7 @@ static bool halbtc_get(void *void_btcoexist, u8 get_type, void *out_buf)\n> \t\t*bool_tmp = false;\n> \t\tbreak;\n> \tcase BTC_GET_S4_WIFI_RSSI:\n> -\t\t*s32_tmp = halbtc_get_wifi_rssi(rtlpriv);\n> +\t\t*s32_tmp = rtlpriv->dm.undec_sm_pwdb;\n> \t\tbreak;\n> \tcase BTC_GET_S4_HS_RSSI:\n> \t\t*s32_tmp = 0;\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hkdHtON+\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjmRH4ccjz9sD5\n\tfor ;\n\tFri, 1 Sep 2017 01:25:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751828AbdHaPZe (ORCPT );\n\tThu, 31 Aug 2017 11:25:34 -0400","from mail-oi0-f67.google.com ([209.85.218.67]:38806 \"EHLO\n\tmail-oi0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751040AbdHaPZc (ORCPT\n\t); Thu, 31 Aug 2017 11:25:32 -0400","by mail-oi0-f67.google.com with SMTP id r203so832456oih.5;\n\tThu, 31 Aug 2017 08:25:32 -0700 (PDT)","from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com.\n\t[24.31.249.175]) by smtp.gmail.com with ESMTPSA id\n\tc131sm7174279oib.43.2017.08.31.08.25.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Aug 2017 08:25:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=cQa4rUCNdSTuLnvxWCrA4cYRnhxEfkzqQqsdsFRyoCU=;\n\tb=hkdHtON+u6uOst/sXi7RJtoAcR314xF4PvNtd+VnwqX0350PO5dLFvALBisYzV4woB\n\tm/20aSnuCN+dUEpHR32bpGxTzFLupeKnvPH/7s9pVyIZ1zfkT9+CJngZePJSDiIJ2q6r\n\ty+tJUzndorMDgooWYYLwq2J+upiRMsEEPwJsvpbVzdEfd31SMsougsRWmI3Qi1qSBdYz\n\tkdQGi/b1UZvLvq2a7pP+0vB2U8lyHaeh5iMnlzLLAmJ8JRCqyiSGZX35Q/gmEInmFMMi\n\tlvtvIBpyipGnVCdW6q3cahsAL/bD5qeX3j0lD2EHP7vaq0sjlN/5m/wLz2LtW2cUjj+N\n\tH5Xw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=cQa4rUCNdSTuLnvxWCrA4cYRnhxEfkzqQqsdsFRyoCU=;\n\tb=GLfnSA2Uo/zz6Biys1NdlAxm5WKnLgdpS98GFWkBbOTpBvNICOVKO48rSkSYtq1Sh9\n\tD8Mrd0kK9aYB2dtyPZOlG/wxMzUCxeTMVT4l1jpKKu7OQq3CmvNYBBiJcq1evZEAJhcf\n\tOS6u7rNfkwsRxmS1/gPlFIrUTk0pjC76Bz635cbTIVD4kB8VIZZmKKdnJdYcHZIgG+93\n\ttd6+/SuWGB9SrUFQh5a6ZvffhjNfAVyB98BNF3nfTgswoG+IFh60Ke57jq18VkFHwMZJ\n\tTHt89kU67wzhYphQtwBJYvH/6iJg7fOayPlw5dczivAssuCm5eZ/U3poqoce6yWsvder\n\tEbsQ==","X-Gm-Message-State":"AHYfb5ifZBLBUsvk9oLJJVLMZ1eO6zF38i6GdCNHZ4eOugk7aMt9blY7\n\tmtBSrGXtajzF/yY/","X-Google-Smtp-Source":"ADKCNb4uaGfnM9zczUB1k+TNhQxqyasWKGL4NMaEWHeZu8Y+DaBWpPKJyQI9+Pl2KVIutjBEs7V6JQ==","X-Received":"by 10.202.72.19 with SMTP id v19mr6392029oia.307.1504193131800; \n\tThu, 31 Aug 2017 08:25:31 -0700 (PDT)","Subject":"Re: [PATCH] rtlwifi: refactor code in halbtcoutsrc module","To":"\"Gustavo A. R. Silva\" ,\n\tChaoming Li ,\n\tKalle Valo ","Cc":"linux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","References":"<20170830164602.GA16413@embeddedgus>","From":"Larry Finger ","Message-ID":"<08aeadde-8a44-c49f-bc64-5b91226d4cec@lwfinger.net>","Date":"Thu, 31 Aug 2017 10:25:30 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830164602.GA16413@embeddedgus>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]