[{"id":1760640,"web_url":"http://patchwork.ozlabs.org/comment/1760640/","msgid":"","list_archive_url":null,"date":"2017-08-31T04:42:18","subject":"Re: [PATCH] rtlwifi: rtl8723be: fix duplicated code for different\n\tbranches","submitter":{"id":190,"url":"http://patchwork.ozlabs.org/api/people/190/","name":"Larry Finger","email":"Larry.Finger@lwfinger.net"},"content":"On 08/30/2017 12:04 PM, Gustavo A. R. Silva wrote:\n> Refactor code in order to avoid identical code for different branches.\n> \n> Addresses-Coverity-ID: 1248728\n> Signed-off-by: Gustavo A. R. Silva \n\nAccording to Realtek, this change is OK.\n\nAcked-by: Larry Finger \n\nThanks,\n\nLarry\n\n> ---\n> This issue was reported by Coverity and it was tested by compilation only.\n> Please, verify if this is not a copy/paste error.\n> Also, notice this code has been there since 2014.\n> \n> drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 8 ++------\n> 1 file changed, 2 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c\n> index 131c0d1..15c117e 100644\n> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c\n> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c\n> @@ -883,12 +883,8 @@ static void rtl8723be_dm_txpower_tracking_callback_thermalmeter(\n> \tif ((rtldm->power_index_offset[RF90_PATH_A] != 0) &&\n> \t (rtldm->txpower_track_control)) {\n> \t\trtldm->done_txpower = true;\n> -\t\tif (thermalvalue > rtlefuse->eeprom_thermalmeter)\n> -\t\t\trtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,\n> -\t\t\t\t\t\t\t index_for_channel);\n> -\t\telse\n> -\t\t\trtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,\n> -\t\t\t\t\t\t\t index_for_channel);\n> +\t\trtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,\n> +\t\t\t\t\t\t index_for_channel);\n> \n> \t\trtldm->swing_idx_cck_base = rtldm->swing_idx_cck;\n> \t\trtldm->swing_idx_ofdm_base[RF90_PATH_A] =\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TWx4mSsC\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjV9D4KsYz9s7c\n\tfor ;\n\tThu, 31 Aug 2017 14:42:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751397AbdHaEmY (ORCPT );\n\tThu, 31 Aug 2017 00:42:24 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:34011 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751097AbdHaEmW (ORCPT\n\t); Thu, 31 Aug 2017 00:42:22 -0400","by mail-oi0-f68.google.com with SMTP id w10so7311691oie.1;\n\tWed, 30 Aug 2017 21:42:22 -0700 (PDT)","from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com.\n\t[24.31.249.175]) by smtp.gmail.com with ESMTPSA id\n\th125sm8218637oic.54.2017.08.30.21.42.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 21:42:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=NLHcrFgLkH6DdHq73bMEEub2TABFdN+Ze1+ousd8xCg=;\n\tb=TWx4mSsChDPLUZHS2TUhKXbe5A9A62wQBM1pyapI73CsSjFq4tmzEKZkEPjg/FE1MZ\n\tEfpDCFPSv+Dtwc7644yOYwBCuJ/50ua6Ujg2Iq5wLAIrWmyveYJc0hATJD7wNVrv+lDV\n\t386MqFM/IGV72IdxYXCuB1+h9FFXEynV4k0Bdr8hVxAj0/S8qKE7A/jpbIuqSyTeDxqM\n\tihbL+k5EfG3yXewbuZsy402rU2CQBD37mPXnp/aPOTHaT0mvxLsulHTgeWtuXVp7mfik\n\to7APUVxis7iUpv7kAXG4uorctDv9tPqyNnkiZo6nHs5ZR+WgaG1TfLSJoG+qfLvyR9UH\n\tYjuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=NLHcrFgLkH6DdHq73bMEEub2TABFdN+Ze1+ousd8xCg=;\n\tb=Hhc10aBUmiUjjiilUuDZL4MK0DB/m9MfD1Y4duZnk8++IyGw9zMSqaId82MwIC3siP\n\tjHUGGMcxEaq9ZYLCkLAExesaElyycdW3CNb+4e4VtURYJOUvfIS6Fk0FVTX+Drg9Hm0O\n\tvGBx6EuryvICyPdFRijbYiAaE8jocs3X9DRkeLygUOa/JYKhnI/ITY7wLU+FasF5gbYL\n\teKhIRojj2o0C7zuH2XNfuDg25GkuNsolm+PpGKG1twe6T+nu5OgB+imaS8jp1jIPyHmv\n\treY6gfCfF8Wq0eLxnTx7yusmhHWJyCEb15m7TyMl96HRjO4qwwFzBSCSGf5BVQkbfgOI\n\tdppg==","X-Gm-Message-State":"AHYfb5jhTz+p1EwetAbKqn4AtkyaQHOpmpJ6US30mK2Sedi8IJAcqePZ\n\ts3ZuPQSFFQAAbkit","X-Received":"by 10.202.212.149 with SMTP id l143mr4542835oig.90.1504154541903;\n\tWed, 30 Aug 2017 21:42:21 -0700 (PDT)","Subject":"Re: [PATCH] rtlwifi: rtl8723be: fix duplicated code for different\n\tbranches","To":"\"Gustavo A. R. Silva\" ,\n\tChaoming Li ,\n\tKalle Valo ","Cc":"linux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","References":"<20170830170424.GA19424@embeddedgus>","From":"Larry Finger ","Message-ID":"","Date":"Wed, 30 Aug 2017 23:42:18 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830170424.GA19424@embeddedgus>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760953,"web_url":"http://patchwork.ozlabs.org/comment/1760953/","msgid":"<20170831130020.259C56182F@smtp.codeaurora.org>","list_archive_url":null,"date":"2017-08-31T13:00:20","subject":"Re: rtlwifi: rtl8723be: fix duplicated code for different branches","submitter":{"id":65411,"url":"http://patchwork.ozlabs.org/api/people/65411/","name":"Kalle Valo","email":"kvalo@codeaurora.org"},"content":"\"Gustavo A. R. Silva\" wrote:\n\n> Refactor code in order to avoid identical code for different branches.\n> \n> Addresses-Coverity-ID: 1248728\n> Signed-off-by: Gustavo A. R. Silva \n> Acked-by: Larry Finger \n\nPatch applied to wireless-drivers-next.git, thanks.\n\na9a65a6b2b69 rtlwifi: rtl8723be: fix duplicated code for different branches","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"JWeGRLuR\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"nx9l4jkC\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=kvalo@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjCk2jVnz9sPm\n\tfor ;\n\tThu, 31 Aug 2017 23:00:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751291AbdHaNAW (ORCPT );\n\tThu, 31 Aug 2017 09:00:22 -0400","from smtp.codeaurora.org ([198.145.29.96]:57110 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750828AbdHaNAV (ORCPT\n\t); Thu, 31 Aug 2017 09:00:21 -0400","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 259C56182F; Thu, 31 Aug 2017 13:00:20 +0000 (UTC)","from potku.adurom.net (a88-114-240-52.elisa-laajakaista.fi\n\t[88.114.240.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: kvalo@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id BB23761824;\n\tThu, 31 Aug 2017 13:00:17 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504184420;\n\tbh=F+CfcHbHLo1mvyTLVbU2v6adxk8pI8TT4JOccZTNer0=;\n\th=Subject:From:In-Reply-To:References:To:Cc:Date:From;\n\tb=JWeGRLuRrMe9SA8RyzH33f42CYTg/DDwVKFm9UKwLGtqOmzpHezOOwTeEuzj4o1Yt\n\t0M2jsQzYPTosfX1c037YOQRAMM8tvq3hf4/IIafEgKPskemgyuJZCOPtOZI31yUK62\n\tto67XViycUq+y9/kBMhhUq8xkJdwtZvAi5IOhgUQ=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504184419;\n\tbh=F+CfcHbHLo1mvyTLVbU2v6adxk8pI8TT4JOccZTNer0=;\n\th=Subject:From:In-Reply-To:References:To:Cc:From;\n\tb=nx9l4jkCDNYUuY+tY1pWt1cyrh/W6XWrLvkImgLO7xoTNXcm3zV0fCQnGRwloqc/5\n\tGVr55snptZRdWrykdxXMM+ZLc5EB+LVvOth5/zBej5hkWzB6IlHUi0WS3P8yCh6iTO\n\tBdVBkmIDXvoUd8sga3gjwqRsobjDX6mOH1xPpvCg="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED, MISSING_DATE, MISSING_MID, T_DKIM_INVALID,\n\tURIBL_BLACK autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org BB23761824","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Subject":"Re: rtlwifi: rtl8723be: fix duplicated code for different branches","From":"Kalle Valo ","In-Reply-To":"<20170830170424.GA19424@embeddedgus>","References":"<20170830170424.GA19424@embeddedgus>","To":"\"Gustavo A. R. Silva\" ","Cc":"Larry Finger ,\n\tChaoming Li ,\n\tlinux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\t\"Gustavo A. R. Silva\" ","User-Agent":"pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12","Message-Id":"<20170831130020.259C56182F@smtp.codeaurora.org>","Date":"Thu, 31 Aug 2017 13:00:20 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]