[{"id":1760533,"web_url":"http://patchwork.ozlabs.org/comment/1760533/","msgid":"<7dc65a38-c92e-32d5-8b35-c790ee09bd68@redhat.com>","list_archive_url":null,"date":"2017-08-30T22:17:01","subject":"Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup\n\tfrom bash tests","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 08/30/2017 12:52 PM, Jeff Cody wrote:\n> All files for a given test are now self-contained in a subdirectory,\n> and therefore the \"./check\" script can do all file-related cleanup\n> without any help.\n> \n> This removes file cleanups from the bash tests. The only cleanup left\n> is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu.\n> \n> Reviewed-by: Eric Blake \n> Signed-off-by: Jeff Cody \n> ---\n> tests/qemu-iotests/001 | 6 ------\n> tests/qemu-iotests/002 | 6 ------\n> tests/qemu-iotests/003 | 6 ------\n> tests/qemu-iotests/004 | 6 ------\n> tests/qemu-iotests/005 | 6 ------\n> tests/qemu-iotests/007 | 7 -------\n> tests/qemu-iotests/008 | 6 ------\n> tests/qemu-iotests/009 | 6 ------\n> tests/qemu-iotests/010 | 6 ------\n> tests/qemu-iotests/011 | 6 ------\n> tests/qemu-iotests/012 | 6 ------\n> tests/qemu-iotests/013 | 6 ------\n> tests/qemu-iotests/014 | 6 ------\n> tests/qemu-iotests/015 | 7 -------\n> tests/qemu-iotests/017 | 6 ------\n> tests/qemu-iotests/018 | 6 ------\n> tests/qemu-iotests/019 | 8 --------\n> tests/qemu-iotests/020 | 8 --------\n> tests/qemu-iotests/021 | 6 ------\n> tests/qemu-iotests/022 | 6 ------\n> tests/qemu-iotests/023 | 6 ------\n> tests/qemu-iotests/024 | 8 --------\n> tests/qemu-iotests/025 | 6 ------\n> tests/qemu-iotests/026 | 7 -------\n> tests/qemu-iotests/027 | 6 ------\n> tests/qemu-iotests/028 | 8 --------\n> tests/qemu-iotests/029 | 7 -------\n> tests/qemu-iotests/031 | 6 ------\n> tests/qemu-iotests/032 | 6 ------\n> tests/qemu-iotests/033 | 6 ------\n> tests/qemu-iotests/034 | 6 ------\n> tests/qemu-iotests/035 | 6 ------\n> tests/qemu-iotests/036 | 6 ------\n> tests/qemu-iotests/037 | 6 ------\n> tests/qemu-iotests/038 | 6 ------\n> tests/qemu-iotests/039 | 6 ------\n> tests/qemu-iotests/042 | 6 ------\n> tests/qemu-iotests/043 | 7 -------\n> tests/qemu-iotests/046 | 6 ------\n> tests/qemu-iotests/047 | 6 ------\n> tests/qemu-iotests/048 | 8 --------\n> tests/qemu-iotests/048.out | 1 -\n> tests/qemu-iotests/049 | 6 ------\n> tests/qemu-iotests/050 | 8 --------\n> tests/qemu-iotests/051 | 6 ------\n> tests/qemu-iotests/052 | 6 ------\n> tests/qemu-iotests/053 | 7 -------\n> tests/qemu-iotests/054 | 6 ------\n> tests/qemu-iotests/058 | 8 +-------\n> tests/qemu-iotests/059 | 7 -------\n> tests/qemu-iotests/060 | 6 ------\n> tests/qemu-iotests/061 | 6 ------\n> tests/qemu-iotests/062 | 6 ------\n> tests/qemu-iotests/063 | 7 -------\n> tests/qemu-iotests/064 | 6 ------\n> tests/qemu-iotests/066 | 6 ------\n> tests/qemu-iotests/068 | 6 ------\n> tests/qemu-iotests/069 | 6 ------\n> tests/qemu-iotests/070 | 6 ------\n> tests/qemu-iotests/071 | 6 ------\n> tests/qemu-iotests/072 | 6 ------\n> tests/qemu-iotests/073 | 6 ------\n> tests/qemu-iotests/074 | 9 ---------\n> tests/qemu-iotests/074.out | 1 -\n> tests/qemu-iotests/075 | 6 ------\n> tests/qemu-iotests/076 | 6 ------\n> tests/qemu-iotests/077 | 6 ------\n> tests/qemu-iotests/078 | 6 ------\n> tests/qemu-iotests/079 | 6 ------\n> tests/qemu-iotests/080 | 7 -------\n> tests/qemu-iotests/081 | 8 --------\n> tests/qemu-iotests/082 | 6 ------\n> tests/qemu-iotests/084 | 6 ------\n> tests/qemu-iotests/085 | 13 +------------\n> tests/qemu-iotests/086 | 6 ------\n> tests/qemu-iotests/088 | 7 -------\n> tests/qemu-iotests/089 | 6 ------\n> tests/qemu-iotests/090 | 6 ------\n> tests/qemu-iotests/091 | 8 +-------\n> tests/qemu-iotests/092 | 7 -------\n> tests/qemu-iotests/094 | 9 +--------\n> tests/qemu-iotests/095 | 8 +-------\n> tests/qemu-iotests/097 | 7 -------\n> tests/qemu-iotests/098 | 7 -------\n> tests/qemu-iotests/099 | 6 ------\n> tests/qemu-iotests/101 | 6 ------\n> tests/qemu-iotests/102 | 7 +------\n> tests/qemu-iotests/103 | 6 ------\n> tests/qemu-iotests/104 | 2 --\n> tests/qemu-iotests/105 | 6 ------\n> tests/qemu-iotests/106 | 6 ------\n> tests/qemu-iotests/107 | 6 ------\n> tests/qemu-iotests/108 | 6 ------\n> tests/qemu-iotests/109 | 8 +-------\n> tests/qemu-iotests/110 | 6 ------\n> tests/qemu-iotests/111 | 6 ------\n> tests/qemu-iotests/112 | 6 ------\n> tests/qemu-iotests/113 | 6 ------\n> tests/qemu-iotests/114 | 6 ------\n> tests/qemu-iotests/115 | 6 ------\n> tests/qemu-iotests/116 | 6 ------\n> tests/qemu-iotests/117 | 7 +------\n> tests/qemu-iotests/119 | 6 ------\n> tests/qemu-iotests/120 | 6 ------\n> tests/qemu-iotests/121 | 6 ------\n> tests/qemu-iotests/122 | 7 -------\n> tests/qemu-iotests/123 | 7 -------\n> tests/qemu-iotests/125 | 6 ------\n> tests/qemu-iotests/130 | 7 +------\n> tests/qemu-iotests/131 | 6 ------\n> tests/qemu-iotests/133 | 6 ------\n> tests/qemu-iotests/134 | 6 ------\n> tests/qemu-iotests/135 | 6 ------\n> tests/qemu-iotests/137 | 6 ------\n> tests/qemu-iotests/138 | 6 ------\n> tests/qemu-iotests/140 | 8 +-------\n> tests/qemu-iotests/141 | 8 +-------\n> tests/qemu-iotests/142 | 7 -------\n> tests/qemu-iotests/143 | 7 +------\n> tests/qemu-iotests/144 | 8 +-------\n> tests/qemu-iotests/145 | 7 -------\n> tests/qemu-iotests/146 | 7 +------\n> tests/qemu-iotests/150 | 6 ------\n> tests/qemu-iotests/153 | 12 ------------\n> tests/qemu-iotests/154 | 6 ------\n> tests/qemu-iotests/156 | 7 +------\n> tests/qemu-iotests/157 | 6 ------\n> tests/qemu-iotests/158 | 6 ------\n> tests/qemu-iotests/159 | 7 -------\n> tests/qemu-iotests/160 | 7 -------\n> tests/qemu-iotests/162 | 7 -------\n> tests/qemu-iotests/170 | 7 -------\n> tests/qemu-iotests/171 | 6 ------\n> tests/qemu-iotests/172 | 8 --------\n> tests/qemu-iotests/173 | 8 +-------\n> tests/qemu-iotests/174 | 6 ------\n> tests/qemu-iotests/175 | 6 ------\n> tests/qemu-iotests/176 | 7 -------\n> tests/qemu-iotests/177 | 6 ------\n> tests/qemu-iotests/178 | 7 -------\n> tests/qemu-iotests/179 | 7 -------\n> tests/qemu-iotests/181 | 8 +-------\n> tests/qemu-iotests/182 | 6 ------\n> tests/qemu-iotests/183 | 9 +--------\n> tests/qemu-iotests/185 | 9 +--------\n> tests/qemu-iotests/186 | 6 ------\n> tests/qemu-iotests/187 | 8 --------\n> tests/qemu-iotests/188 | 6 ------\n> tests/qemu-iotests/189 | 6 ------\n> tests/qemu-iotests/190 | 7 -------\n> tests/qemu-iotests/192 | 6 ------\n> 151 files changed, 19 insertions(+), 965 deletions(-)\n\nwild diffstat.\n\nReviewed-by: John Snow ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjKct5Cqrz9s81\n\tfor ;\n\tThu, 31 Aug 2017 08:17:34 +1000 (AEST)","from localhost ([::1]:52997 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnBIi-0006f3-S7\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 18:17:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55012)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnBIO-0006cp-0r\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 18:17:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnBIM-00071U-SL\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 18:17:11 -0400","from mx1.redhat.com ([209.132.183.28]:46634)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnBIH-000700-VN; Wed, 30 Aug 2017 18:17:06 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0B1CA5F7BD;\n\tWed, 30 Aug 2017 22:17:05 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 486D9176AA;\n\tWed, 30 Aug 2017 22:17:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0B1CA5F7BD","To":"Jeff Cody , qemu-devel@nongnu.org","References":"\n\t<9b840c1229f3e25cf8ccf0d27bfabf37c751d5e1.1504111803.git.jcody@redhat.com>","From":"John Snow ","Message-ID":"<7dc65a38-c92e-32d5-8b35-c790ee09bd68@redhat.com>","Date":"Wed, 30 Aug 2017 18:17:01 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<9b840c1229f3e25cf8ccf0d27bfabf37c751d5e1.1504111803.git.jcody@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 30 Aug 2017 22:17:05 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup\n\tfrom bash tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, stefanha@redhat.com, armbru@redhat.com,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763240,"web_url":"http://patchwork.ozlabs.org/comment/1763240/","msgid":"<20170905111744.GH4633@localhost.localdomain>","list_archive_url":null,"date":"2017-09-05T11:17:44","subject":"Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup\n\tfrom bash tests","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 30.08.2017 um 18:52 hat Jeff Cody geschrieben:\n> All files for a given test are now self-contained in a subdirectory,\n> and therefore the \"./check\" script can do all file-related cleanup\n> without any help.\n> \n> This removes file cleanups from the bash tests. The only cleanup left\n> is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu.\n> \n> Reviewed-by: Eric Blake \n> Signed-off-by: Jeff Cody \n\nWhat about non-file protocols? _cleanup_test_img() does more than just a\nfew 'rm' commands. For NBD and vxhs it also kills the server process and\nfor sheepdog and rbd it uses their specific tools to delete the image\nfrom the cluster because it's not simply a local file.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmkpY4Q9fz9sPs\n\tfor ;\n\tTue, 5 Sep 2017 21:22:45 +1000 (AEST)","from localhost ([::1]:58177 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpBwJ-0000mX-MG\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 07:22:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46934)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpBrx-0005qz-3V\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 07:18:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpBrs-0000Z7-0x\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 07:18:13 -0400","from mx1.redhat.com ([209.132.183.28]:45859)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpBrd-0000Ep-4u; Tue, 05 Sep 2017 07:17:53 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1976381DFE;\n\tTue, 5 Sep 2017 11:17:52 +0000 (UTC)","from localhost.localdomain (ovpn-117-102.ams2.redhat.com\n\t[10.36.117.102])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 61CEF7F399;\n\tTue, 5 Sep 2017 11:17:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1976381DFE","Date":"Tue, 5 Sep 2017 13:17:44 +0200","From":"Kevin Wolf ","To":"Jeff Cody ","Message-ID":"<20170905111744.GH4633@localhost.localdomain>","References":"\n\t<9b840c1229f3e25cf8ccf0d27bfabf37c751d5e1.1504111803.git.jcody@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<9b840c1229f3e25cf8ccf0d27bfabf37c751d5e1.1504111803.git.jcody@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 05 Sep 2017 11:17:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup\n\tfrom bash tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, jsnow@redhat.com, qemu-devel@nongnu.org,\n\tarmbru@redhat.com, stefanha@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]