[{"id":1760317,"web_url":"http://patchwork.ozlabs.org/comment/1760317/","msgid":"<54b8a86e-0480-9cdb-9b82-7cadf6c16e42@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:29:52","subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","submitter":{"id":22438,"url":"http://patchwork.ozlabs.org/api/people/22438/","name":"Carlos O'Donell","email":"carlos@redhat.com"},"content":"On 08/30/2017 11:04 AM, Florian Weimer wrote:\n> Clean up calls to malloc_printerr and trim its argument list.\n> \n> This also removes a few bits of work done before calling\n> malloc_printerr (such as unlocking operations).\n> \n> The tunable/environment variable still enables the lightweight\n> additional malloc checking, but mallopt (M_CHECK_ACTION)\n> no longer has any effect.\n> \n> 2017-08-30  Florian Weimer  <fweimer@redhat.com>\n> \n> \t[BZ #21754]\n> \t* malloc/arena.c (TUNABLE_CALLBACK set_mallopt_check): Do not set\n> \tcheck_action.\n> \t(ptmalloc_init): Do not set or use check_action.\n> \t* malloc/hooks.c (malloc_check_get_size, realloc_check): Adjust\n> \tcall to malloc_printerr.  Remove return statement.\n> \t(free_check): Likewise.  Remove arena unlock.\n> \t(top_check): Update comment.  Adjust call to malloc_printerr.\n> \tRemove heap repair code.\n> \t* malloc/malloc.c (unlink): Adjust calls to malloc_printerr.\n> \t(DEFAULT_CHECK_ACTION, check_action): Remove definitions.\n> \t(sysmalloc): Adjust call to malloc_printerr.\n> \t(munmap_chunk, __libc_realloc): Likewise.  Remove return\n> \tstatement.\n> \t(_int_malloc, int_realloc): Likewise.  Remove errstr variable.\n> \tRemove errout label and corresponding gotos.\n> \t(_int_free): Likewise.  Remove arena unlock.\n> \t(do_set_mallopt_check): Do not set check_action.\n> \t(malloc_printerr): Adjust parameter list.  Do not mark arena as\n> \tcorrupt.\n\nShould we update the documentation?\n\n(a) manual/tunables.texi needs an update of glibc.malloc.check documentation\n    to remove those values which no longer do anything.\n\n(B) Please remove '@comment TODO: @item M_CHECK_ACTION' from manual/memory.texi.\n\nOK with that change.\n\nDo you plan to submit a manual update for linux man pages which document mallopt?","headers":{"Return-Path":"<libc-alpha-return-83879-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83879-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"RQVMmDW5\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj9vz5lgjz9sNn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 02:30:07 +1000 (AEST)","(qmail 127062 invoked by alias); 30 Aug 2017 16:30:00 -0000","(qmail 127039 invoked by uid 89); 30 Aug 2017 16:30:00 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=wi9Grfq1cjl70KtM\n\tfJqkLlMYOcunFiMctWeZ4v2dtdRkAqtJtKnx/XxoJPZE8+GQBg7NzoKXcsCON9US\n\tE8miISTesM499+VTU0qMpVexMhbtoxWsWS3gPaH1NuoK6twH60ZU50DiyY3KFq+8\n\tyw92eE6nNryaZJPvpUTEH2XpCmU=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=OKCwrzj3uBVOLCre5oC5dP\n\ti6saY=; b=RQVMmDW5nHcbLyfkNadn5ijrhRKI0/mtBYstN+Mzve6VvW3iPA/5ca\n\tOkYl9jz+YbZlMURrc8K/SAYFgN7xRlLXQH+Oc7uSNs7QX9txUfY4SeknvG3If5w1\n\tj2OFax/c6WH3i+OggXdfbdGJVQCxK4724gAaCziwVU4NxLj7mC2KI=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.3 required=5.0 tests=AWL, BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=no version=3.3.2\n\tspammy=Hx-languages-length:1793","X-HELO":"mail-qk0-f180.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=a2OG1s5VHGdBJwAjt3y4l9rZD9dI6vdDb530cfN3QhU=;\n\tb=czxibAVYZvimE5xtQsX4PwvsgNs/lmn+c3MrLuyXrOK2akLlTgwAjSzNiLN6X0YuTp\n\tWmZiSOPT3Hf6iCofBb5e/UVgJ5mtNOCVvBffCcLfYoyVjvdYNAbK/pc/DCOWhGEJjhs2\n\t4VaNixPuOS4x6wPbJpCSa7nDWOVjZSBPs0dTdo9wUTU/Mo86Yacs5BjlmMoXvxwmfnHz\n\t9yhYBdpjtUYlQ/kqQoJybLMzSTUb2ZF0INLyDnQGuHM1w7RH0vDFovxrE6aZvTwrVo/h\n\tD/ijKrlbmggq6ylG8P3/IB+bEhMF9hVR7xgV0Ip8N6815POt5ObH9BCMkHEcHGnrPjfv\n\tSM1A==","X-Gm-Message-State":"AHYfb5jfSVV04fAfNo+BMoMv+1Xa68EaXnB1/wH5sZ4mHoeTaTXmqbFn\n\tBo4eWs2V8oN/SXKHMz8tzA==","X-Google-Smtp-Source":"ADKCNb580AarWu/T5nWA0Sw+SNL2TmJ6ttBAJXvpIKQvvJn+wjiGVaMeJy4UeOSL9PdgzJuX6INvEA==","X-Received":"by 10.55.70.75 with SMTP id t72mr10848541qka.14.1504110597059;\n\tWed, 30 Aug 2017 09:29:57 -0700 (PDT)","Subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","To":"Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org","References":"<20170830160402.4D42140C0E092@oldenburg.str.redhat.com>","From":"Carlos O'Donell <carlos@redhat.com>","Message-ID":"<54b8a86e-0480-9cdb-9b82-7cadf6c16e42@redhat.com>","Date":"Wed, 30 Aug 2017 11:29:52 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170830160402.4D42140C0E092@oldenburg.str.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1760361,"web_url":"http://patchwork.ozlabs.org/comment/1760361/","msgid":"<f2bf0c33-1aef-7d0a-817e-85d2bea05763@redhat.com>","list_archive_url":null,"date":"2017-08-30T17:31:55","subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 08/30/2017 06:29 PM, Carlos O'Donell wrote:\n\n> Should we update the documentation?\n> \n> (a) manual/tunables.texi needs an update of glibc.malloc.check documentation\n>     to remove those values which no longer do anything.\n\nThat's already in master.  However, I'm going to remove the\ndocumentation of the check_action probe and the probe itself.\n\n> (B) Please remove '@comment TODO: @item M_CHECK_ACTION' from manual/memory.texi.\n\nSure.\n\n> Do you plan to submit a manual update for linux man pages which document mallopt?\n\nYes, eventually, once we have decided what to do with the header file\nand malloc checking in general.\n\nThanks,\nFlorian","headers":{"Return-Path":"<libc-alpha-return-83881-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83881-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Njs3VsZD\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCHk5sRkz9sP5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 03:32:18 +1000 (AEST)","(qmail 22710 invoked by alias); 30 Aug 2017 17:32:12 -0000","(qmail 22310 invoked by uid 89); 30 Aug 2017 17:32:12 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:cc:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=wFRR2JXL2oYRSLDh\n\t43PQMJloy9TVEQJ/TOJp/65r53a4sHvjBuDm/ktJQE+aPsIieVqm2aZZ8fsBU5lP\n\tGBvd99G/KydUsSzUfzRQvW9vYVYHL/Ww2EpiAmUtw66VX8QxfmJwLPpoce+p2bJR\n\tUCl95fWJu5altfQ8+m29+ILwjrA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:cc:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=MwohQXLV0FcDaFNHPcfKCQ\n\tpE+os=; b=Njs3VsZDzh8xLcW7XfGgvpxHsyeEAgaio4EZLMQBxTLplVl0A61k9d\n\tx7yMdGCDQH47YHy4Xr56AUWYm9s7aAjxKrv8d8YbEKwUScE9P4oE+1XnD9zhwX5B\n\tlKJBnC/YVyAWnNTJe4mqXpIMmtQtRFEN09vNp4pNuknGLt7uxojUU=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2\n\tspammy=HContent-Transfer-Encoding:8bit","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 17BE75F795","Subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","To":"Carlos O'Donell <carlos@redhat.com>","References":"<20170830160402.4D42140C0E092@oldenburg.str.redhat.com>\n\t<54b8a86e-0480-9cdb-9b82-7cadf6c16e42@redhat.com>","From":"Florian Weimer <fweimer@redhat.com>","Cc":"libc-alpha@sourceware.org","Message-ID":"<f2bf0c33-1aef-7d0a-817e-85d2bea05763@redhat.com>","Date":"Wed, 30 Aug 2017 19:31:55 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<54b8a86e-0480-9cdb-9b82-7cadf6c16e42@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}},{"id":1760622,"web_url":"http://patchwork.ozlabs.org/comment/1760622/","msgid":"<CAMe9rOoNa+ARsWbZO=RstE7FQO2QedKe2rd-8S=eCRMY70m_3Q@mail.gmail.com>","list_archive_url":null,"date":"2017-08-31T03:55:05","subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Wed, Aug 30, 2017 at 10:31 AM, Florian Weimer <fweimer@redhat.com> wrote:\n> On 08/30/2017 06:29 PM, Carlos O'Donell wrote:\n>\n>> Should we update the documentation?\n>>\n>> (a) manual/tunables.texi needs an update of glibc.malloc.check documentation\n>>     to remove those values which no longer do anything.\n>\n> That's already in master.  However, I'm going to remove the\n> documentation of the check_action probe and the probe itself.\n>\n>> (B) Please remove '@comment TODO: @item M_CHECK_ACTION' from manual/memory.texi.\n>\n> Sure.\n>\n>> Do you plan to submit a manual update for linux man pages which document mallopt?\n>\n> Yes, eventually, once we have decided what to do with the header file\n> and malloc checking in general.\n>\n\nOne of malloc change caused:\n\nhttps://sourceware.org/bugzilla/show_bug.cgi?id=22052","headers":{"Return-Path":"<libc-alpha-return-83895-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83895-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"YNrQ3DQd\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjT6h53ymz9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 13:55:24 +1000 (AEST)","(qmail 53291 invoked by alias); 31 Aug 2017 03:55:18 -0000","(qmail 53282 invoked by uid 89); 31 Aug 2017 03:55:17 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=O8Lu\n\tbvPPbqR+rGYHlX4YMnUgHws9u1IyXpAmj5FuikQXjWGPrj2U1Mk/YUJtX8pkcTbj\n\t0vZ3e8Suq8m/bIyDBWvhqMAUNuTv6pUE+Zv3jykzFK5x4Qp2woqZupvX7Of30i4J\n\tRKAD5HkP+fxepLe52qrgKIw/wl/EBnlzYtUEE9Y=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=sFxdUHbP4b\n\tZptM5vihR5kTZD1GE=; b=YNrQ3DQdGm0E1BFj6MMLlMPBTZL1pzGcMoEZd3EJPa\n\txBaigUcr8v6RQ+WBobNX2M1sjAJivhnaaebZlhzhTVeOGReDzPB2DGlPxxhFjyE1\n\tdBBr0BrrUdJZyneWIqJK9l0w7RYBpCiDH7nvCMdCWWxskIOcIG7o//P4yUUVWUy6\n\tc=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-oi0-f66.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=I/+gvtvbxnejYlxipQa33u+9+q4nD9rRRIeb8VD+Ey8=;\n\tb=V+cF2t5bT+HdRfi9qxLp99UdjSlRouqNxkgCSWnfeslehEUD5rIG2T/EsqSM5xKWtq\n\tbGZhLiFBIRiDVWBaMXfOLQsYS03QMZhPyk3snCjWSemifUudFcNn+ogwwwQje1xieVCY\n\tQ8/5EkYU1X0yFhg3mhLmEH7J73uYINdSHBrP8BNLDTCVgTSlq5+YeNIk5CXyGQ9wz2me\n\tIH+4Vr3IKzniPXtIrhwNla1xGbALs1x3k9p48cuQERx7rIAxNghUPnSoIujJi6SYRcsW\n\tXqP2++Ae0UN4EIrb/OW4RCQliqYX1rRP+fB7aZr3C+AByuxa1dy6hou1f/FGZ55jSayM\n\thdTA==","X-Gm-Message-State":"AHYfb5jeSn3lpfTmstOOsiD5pY5g1/vaOg/N0N+wtlTxp2jfE42XtZaA\n\twVhFw6HU/6zNCr8wfmoJDhObRWZbng==","X-Received":"by 10.202.4.194 with SMTP id 185mr3399095oie.240.1504151706020; \n\tWed, 30 Aug 2017 20:55:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<f2bf0c33-1aef-7d0a-817e-85d2bea05763@redhat.com>","References":"<20170830160402.4D42140C0E092@oldenburg.str.redhat.com>\n\t<54b8a86e-0480-9cdb-9b82-7cadf6c16e42@redhat.com>\n\t<f2bf0c33-1aef-7d0a-817e-85d2bea05763@redhat.com>","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","Date":"Wed, 30 Aug 2017 20:55:05 -0700","Message-ID":"<CAMe9rOoNa+ARsWbZO=RstE7FQO2QedKe2rd-8S=eCRMY70m_3Q@mail.gmail.com>","Subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","To":"Florian Weimer <fweimer@redhat.com>","Cc":"\"Carlos O'Donell\" <carlos@redhat.com>,\n\tGNU C Library <libc-alpha@sourceware.org>","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1761197,"web_url":"http://patchwork.ozlabs.org/comment/1761197/","msgid":"<80b26276-5343-ae8d-34e1-afa035f32830@redhat.com>","list_archive_url":null,"date":"2017-08-31T17:01:29","subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 08/31/2017 05:55 AM, H.J. Lu wrote:\n\n> One of malloc change caused:\n> \n> https://sourceware.org/bugzilla/show_bug.cgi?id=22052\n\n(uninit warning with -O3)\n\nI have not yet found a good way to suppress this. I don't know yet why\nGCC loses the information that the maybe_p variable is initialized if\nmem2chunk_check returns a non-null pointer.\n\nThanks,\nFlorian","headers":{"Return-Path":"<libc-alpha-return-83969-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83969-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"nbdTn6uo\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjpbT440qz9sD5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 03:03:01 +1000 (AEST)","(qmail 80941 invoked by alias); 31 Aug 2017 17:01:48 -0000","(qmail 80863 invoked by uid 89); 31 Aug 2017 17:01:48 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=RYmRLmY8+92giS37\n\t4tw17aic8o73uVr77udJTjscoLe7VxKUf9dRk4PAX6+GO2yaAWvxcam/r1NLgZ89\n\t/XvXh9CRSNvaXKq6GJLqY5bDzEaZQNaE5GD5ZOpHoi9cVjJOrJgYpKhY7i9cewmZ\n\tk0uJuNX5Vhx9szY5FrlVbkhDUNI=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=wVSq67nSdYINszZp0FZ93g\n\tgUE2U=; b=nbdTn6uoRl9sZmLkzfWyu4VVdjD6jmOsBGgWQVRy8MWSh/E9jW7Vn9\n\tIJ0lxYAlDfj3ll+Bq0DgBA2AVYyiDGVeFoWWJcTOYzdy8ta4Nf6lKPXAitt6I1Yq\n\ta3wEzM+Te9F5cc4R8gDawC2pG06JepPvRHTgbZsBM+3Bj/tpeysj0=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A896A827","Subject":"Re: [PATCH] malloc: Remove check_action variable [BZ #21754]","To":"\"H.J. Lu\" <hjl.tools@gmail.com>","Cc":"Carlos O'Donell <carlos@redhat.com>,\n\tGNU C Library <libc-alpha@sourceware.org>","References":"<20170830160402.4D42140C0E092@oldenburg.str.redhat.com>\n\t<54b8a86e-0480-9cdb-9b82-7cadf6c16e42@redhat.com>\n\t<f2bf0c33-1aef-7d0a-817e-85d2bea05763@redhat.com>\n\t<CAMe9rOoNa+ARsWbZO=RstE7FQO2QedKe2rd-8S=eCRMY70m_3Q@mail.gmail.com>","From":"Florian Weimer <fweimer@redhat.com>","Message-ID":"<80b26276-5343-ae8d-34e1-afa035f32830@redhat.com>","Date":"Thu, 31 Aug 2017 19:01:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<CAMe9rOoNa+ARsWbZO=RstE7FQO2QedKe2rd-8S=eCRMY70m_3Q@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]