[{"id":1766584,"web_url":"http://patchwork.ozlabs.org/comment/1766584/","msgid":"<20170911214421.fayhxjvxo6cosjcf@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T21:44:21","subject":"Re: [PATCH 09/17] ARM: dts: Add missing iss node and binding for\n\tomap4","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 08:19:45AM -0700, Tony Lindgren wrote:\n> On omap4 we're missing the iss node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Cc: Laurent Pinchart \n> Cc: Mark Rutland \n> Cc: Mauro Carvalho Chehab \n> Cc: Rob Herring \n> Cc: Sakari Ailus \n> Signed-off-by: Tony Lindgren \n> ---\n> Documentation/devicetree/bindings/media/ti-iss.txt | 33 ++++++++++++++++++++++\n> arch/arm/boot/dts/omap4.dtsi | 7 +++++\n> 2 files changed, 40 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/media/ti-iss.txt\n> \n> diff --git a/Documentation/devicetree/bindings/media/ti-iss.txt b/Documentation/devicetree/bindings/media/ti-iss.txt\n> new file mode 100644\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/media/ti-iss.txt\n> @@ -0,0 +1,33 @@\n> +Texas Instruments Imaging Subsystem (ISS) binding\n> +\n> +ISS is used for cameras on Texas Instruments SoCs. Note that this\n> +binding is still missing the connections to the external devices\n> +modeled for the driver.\n> +\n> +Required properties:\n> +\n> +compatible: Shall be one of the following:\n> +\t \"ti,omap4-iss\"\n> +\n> +reg: Shall contain the device instance IO range\n> +\n> +interrupts: Shall contain the device instance interrupt\n> +\n> +\n> +Optional properties:\n> +\n> +reg-names: Shall contain the IO range names if multiple IO\n> +\t ranges are used by the SoC\n\nNeed to define how many. *-names is pointless if there's only ever 1 \nentry.\n\n> +\n> +ti,hwmods: Shall contain the TI interconnect module name if needed\n> +\t by the SoC\n> +\n> +\n> +Example:\n> +\n> +\tiss: iss@52000000 {\n> +\t\tcompatible = \"ti,omap4-iss\";\n> +\t\treg = <0x52000000 0x1000000>;\n> +\t\tinterrupts = ;\n> +\t\tti,hwmods = \"iss\";\n> +\t};\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -674,6 +674,13 @@\n> \t\t\t#iommu-cells = <0>;\n> \t\t};\n> \n> +\t\tiss: iss@52000000 {\n> +\t\t\tcompatible = \"ti,omap4-iss\";\n> +\t\t\treg = <0x52000000 0x1000000>;\n> +\t\t\tinterrupts = ;\n> +\t\t\tti,hwmods = \"iss\";\n> +\t\t};\n> +\n> \t\tmmu_ipu: mmu@55082000 {\n> \t\t\tcompatible = \"ti,omap4-iommu\";\n> \t\t\treg = <0x55082000 0x100>;\n> -- \n> 2.14.1\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrhK555HDz9s7M\n\tfor ;\n\tTue, 12 Sep 2017 07:44:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751405AbdIKVoY (ORCPT\n\t);\n\tMon, 11 Sep 2017 17:44:24 -0400","from mail-ua0-f193.google.com ([209.85.217.193]:34995 \"EHLO\n\tmail-ua0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751399AbdIKVoX (ORCPT\n\t); Mon, 11 Sep 2017 17:44:23 -0400","by mail-ua0-f193.google.com with SMTP id g47so2783344uad.2;\n\tMon, 11 Sep 2017 14:44:23 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tx192sm8750918oix.50.2017.09.11.14.44.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 14:44:21 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=l/yphVF95M9xha+KPgL7r/Oywgu3TOTLmNxR9E49Ais=;\n\tb=Vo9bB0aCDX5jocLgU4vWMMRiXPesutA3KKnteMXL6iJOF+3/h6YKTUN9zKev+wRjyn\n\thEp0fLdsaGJzGikhduBEUDv7OMfxx6q8PbZz7aVN0IoOvCZHCyKojQSqpDQJqUw1PUH8\n\tzu4B4uuNK83xBB4h6znw6sNfA4MpRKQWbxCwNNuQZcw0L/hQfml+PbWpGPtjq9eW9wUi\n\twCj7tZH9y/MOGebLxlVkIMuqzLteORfbNs8ya+vTC4TbJkStTzyDQS1qBdx2P608LPQF\n\tyuhl954FuWgjuZEySiuT6Q16340820fbUiweCvhRWaXQZP2FFtoaGnQznzOvGPts9gUb\n\tMyQg==","X-Gm-Message-State":"AHPjjUhtvq+PKH8OFpg8GTyL73GAuRayFpYF2rN3phA2487ekhv3t3+D\n\tzz6AoM1KTKNGlJ6L/+4=","X-Google-Smtp-Source":"AOwi7QCDU4s7WtP/azgYLNPFmZf5XfiB7laLCdU12W/ebi8pMYZaT5MID1S12oAThulNZKEi+pOhpQ==","X-Received":"by 10.202.208.193 with SMTP id j62mr11598202oiy.12.1505166262467;\n\tMon, 11 Sep 2017 14:44:22 -0700 (PDT)","Date":"Mon, 11 Sep 2017 16:44:21 -0500","From":"Rob Herring ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tLaurent Pinchart , \n\tMark Rutland , Mauro Carvalho Chehab\n\t, Sakari Ailus ","Subject":"Re: [PATCH 09/17] ARM: dts: Add missing iss node and binding for\n\tomap4","Message-ID":"<20170911214421.fayhxjvxo6cosjcf@rob-hp-laptop>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-10-tony@atomide.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830151953.30856-10-tony@atomide.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]