[{"id":1766588,"web_url":"http://patchwork.ozlabs.org/comment/1766588/","msgid":"<20170911215016.far2rpihdd423ybt@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T21:50:16","subject":"Re: [PATCH 14/17] ARM: dts: Add missing gpu node and binding for\n\tomap4","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 08:19:50AM -0700, Tony Lindgren wrote:\n> On omap4 we're missing the PowerVR SGX GPU node with it's related\n> \"ti,hwmods\" property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Cc: Mark Rutland \n> Cc: Rob Herring \n> Cc: Tomi Valkeinen \n> Signed-off-by: Tony Lindgren \n> ---\n> .../devicetree/bindings/gpu/ti-powervr-sgx.txt | 39 ++++++++++++++++++++++\n\nWhile the compatible strings should be TI specific, the doc shouldn't \nbe. \n\n> arch/arm/boot/dts/omap4.dtsi | 7 ++++\n> 2 files changed, 46 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/gpu/ti-powervr-sgx.txt\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrhRx29V3z9s7F\n\tfor ;\n\tTue, 12 Sep 2017 07:50:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750911AbdIKVuT (ORCPT\n\t);\n\tMon, 11 Sep 2017 17:50:19 -0400","from mail-vk0-f68.google.com ([209.85.213.68]:37815 \"EHLO\n\tmail-vk0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750853AbdIKVuT (ORCPT\n\t); Mon, 11 Sep 2017 17:50:19 -0400","by mail-vk0-f68.google.com with SMTP id 184so2384036vkn.4;\n\tMon, 11 Sep 2017 14:50:18 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tp188sm9022431oic.9.2017.09.11.14.50.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 14:50:17 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=WvwAUZryTG6e/QAZ/rhYXmxOEKZGRDhItHk+PXOWngw=;\n\tb=fEB5YBZUF+AyiNiCccjE7Ol/HgtUfZ87ZL1C/Hnk5cV2o15y4eZkjIbks8lRIOBARF\n\t6/iMnBxbhc/d8Wlw1zmlcFN4i2tQ9/cxfZwMr6hYZOh7VQAdQc+n3C+N7KhJvpfJFlPv\n\tCuwMFn3n7H97xxvzRxrybleeE5ddnvGRXRBi64+pSrsAs2UCDxMngXkUzXScxof5sCLR\n\trYg7pQ8oXRU04ezf7RWCRy6ECMsLTuLbOhKKarVzY4kjyneZM1VbdFYw9Fk2FlHdWtY8\n\tQuacU9NWHje6jOPSwmrbn6Tl/cBEKVPlkfAn04WaJs7VVBYmnVPgcdXutwLxbg9+7wHV\n\tU2mg==","X-Gm-Message-State":"AHPjjUi75Rn5xzS9w3KMVjDDJVbnxcBAwy50dlh4KiY0BWZf92he7i8h\n\tY8TyCg7oQD43sg==","X-Google-Smtp-Source":"AOwi7QBfL1aMEzzp6dIe3nW2p4qu8+nGVEJdsGSOaeuAQQhFf4jH/oYDJ0Z/CAPi5YQqG7prOrPd9w==","X-Received":"by 10.202.252.22 with SMTP id a22mr14041009oii.94.1505166617830; \n\tMon, 11 Sep 2017 14:50:17 -0700 (PDT)","Date":"Mon, 11 Sep 2017 16:50:16 -0500","From":"Rob Herring ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Tomi Valkeinen\n\t","Subject":"Re: [PATCH 14/17] ARM: dts: Add missing gpu node and binding for\n\tomap4","Message-ID":"<20170911215016.far2rpihdd423ybt@rob-hp-laptop>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-15-tony@atomide.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830151953.30856-15-tony@atomide.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1814424,"web_url":"http://patchwork.ozlabs.org/comment/1814424/","msgid":"","list_archive_url":null,"date":"2017-12-02T00:18:08","subject":"Re: [PATCH 14/17] ARM: dts: Add missing gpu node and binding for\n\tomap4","submitter":{"id":67132,"url":"http://patchwork.ozlabs.org/api/people/67132/","name":"Adam Ford","email":"aford173@gmail.com"},"content":"On Mon, Sep 11, 2017 at 4:50 PM, Rob Herring wrote:\n> On Wed, Aug 30, 2017 at 08:19:50AM -0700, Tony Lindgren wrote:\n>> On omap4 we're missing the PowerVR SGX GPU node with it's related\n>> \"ti,hwmods\" property that the SoC interconnect code needs.\n>>\n>> Note that this will only show up as a bug with \"doesn't have\n>> mpu register target base\" boot errors when the legacy platform\n>> data is removed.\n>>\n>> Cc: Mark Rutland \n>> Cc: Rob Herring \n>> Cc: Tomi Valkeinen \n>> Signed-off-by: Tony Lindgren \n>> ---\n\nOut of curiosity, is anything being done with this? I'm really\ninterested to see the PVR working in a modern kernel. I'd like to\nhelp more, but I am afraid I don't fully understand the interconnects\nand how the driver componenets interact with the omap processor.\n\nPlease let me know if there are sub-tasks that I can assist.\n\nadam\n\n>> .../devicetree/bindings/gpu/ti-powervr-sgx.txt | 39 ++++++++++++++++++++++\n>\n> While the compatible strings should be TI specific, the doc shouldn't\n> be.\n>\n>> arch/arm/boot/dts/omap4.dtsi | 7 ++++\n>> 2 files changed, 46 insertions(+)\n>> create mode 100644 Documentation/devicetree/bindings/gpu/ti-powervr-sgx.txt\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SdqzAbxy\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ypWv86KKNz9sMN\n\tfor ;\n\tSat, 2 Dec 2017 11:18:12 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751847AbdLBASK (ORCPT\n\t);\n\tFri, 1 Dec 2017 19:18:10 -0500","from mail-ua0-f195.google.com ([209.85.217.195]:41068 \"EHLO\n\tmail-ua0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751811AbdLBASJ (ORCPT\n\t); Fri, 1 Dec 2017 19:18:09 -0500","by mail-ua0-f195.google.com with SMTP id q13so9104625uaq.8;\n\tFri, 01 Dec 2017 16:18:09 -0800 (PST)","by 10.176.69.193 with HTTP; Fri, 1 Dec 2017 16:18:08 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=cwW9XIcdP4fJVZxvWtlfcLYjAF50iKdcSn/KDoP38cI=;\n\tb=SdqzAbxyeiZKXzh9NXb9knW2E9pNEeNu8UU//1yWYyQRwC0LmflqQPaAIEg4cf0jDG\n\tq7cvfm588TyXPscKqpsHgEpuXYV/XMUUEudqhlgXwMDOWzrzRLnenc2gH/BtxEb1ZT91\n\tLEtqMuOLcqy9NpNOIPIc66/epnRaWGddt90uVQ+/zfIA8qq3S/zJqnWB6JY3oQOM4AfE\n\tk1qjIv0jSpKyu/Igtgvd1mMS1hZUGty4cmw/ZipUNoHBWowTMGtNFVVLhgAilhQFMvhu\n\t6kCBl5vo3jGtCFClzfPy1gx+8w5uwoPLe7ElQmFtBtrcWkJRSCuLs2fR6mP28dRMt6A4\n\tC5DA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=cwW9XIcdP4fJVZxvWtlfcLYjAF50iKdcSn/KDoP38cI=;\n\tb=Gt2SNtQbTuYskwgLKNFS8H393A1LOTgVPcVqOX3ed8Q8qa9SARAuZaIwYhn46QtJIZ\n\tnnn+IkSM2AtfyMQ2CQ482Uv4pIcYSrD3toRaGgZkcxA7uw7aVNx1YZFzC8AvLNYISZqQ\n\tavB1hmlPiRKKYsTyndQfo9hK9a7a55WG6iXx0BuyjU88VV8YnJf/YcAD+ZKPLIxJx+5Z\n\tVQmzPS4GD4UeWwbitnT1MWgwOJ6URd60nxyM/bzj4FMM/rCFaC3rSAo323kY/od12h/6\n\tJ4Eq5Hs1jRMV9wRsg2xkJLM9FCVajctULwsnNfkTCzUk4dFTtAi1aje3U6uImhbS2S+7\n\tWRfw==","X-Gm-Message-State":"AKGB3mL7sHwjVJkntXl7rFwWpVRv/596FkjUq6aSdsksAAKWrKgI6EVv\n\tYrBsPBjNv3B55imQC+Ppczzx8r0NRP8FNbgDk+M=","X-Google-Smtp-Source":"AGs4zMamrscBkpJAikrvIpZcdBN743SJ5+AVZURiw4sBYoQp0nqMz4dtXRbm2uDdIEtkgZt7SUt/Gxwa2bmdnRYv3IQ=","X-Received":"by 10.176.89.242 with SMTP id k47mr5929700uad.122.1512173888740; \n\tFri, 01 Dec 2017 16:18:08 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<20170911215016.far2rpihdd423ybt@rob-hp-laptop>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-15-tony@atomide.com>\n\t<20170911215016.far2rpihdd423ybt@rob-hp-laptop>","From":"Adam Ford ","Date":"Fri, 1 Dec 2017 18:18:08 -0600","Message-ID":"","Subject":"Re: [PATCH 14/17] ARM: dts: Add missing gpu node and binding for\n\tomap4","To":"Rob Herring ","Cc":"Tony Lindgren , linux-omap@vger.kernel.org,\n\t=?utf-8?q?Beno=C3=AEt_Cousson?= ,\n\tdevicetree@vger.kernel.org, Mark Rutland , \n\tTomi Valkeinen ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1814630,"web_url":"http://patchwork.ozlabs.org/comment/1814630/","msgid":"<20171202170046.GT28152@atomide.com>","list_archive_url":null,"date":"2017-12-02T17:00:46","subject":"Re: [PATCH 14/17] ARM: dts: Add missing gpu node and binding for\n\tomap4","submitter":{"id":365,"url":"http://patchwork.ozlabs.org/api/people/365/","name":"Tony Lindgren","email":"tony@atomide.com"},"content":"* Adam Ford [171202 00:20]:\n> On Mon, Sep 11, 2017 at 4:50 PM, Rob Herring wrote:\n> > On Wed, Aug 30, 2017 at 08:19:50AM -0700, Tony Lindgren wrote:\n> >> On omap4 we're missing the PowerVR SGX GPU node with it's related\n> >> \"ti,hwmods\" property that the SoC interconnect code needs.\n> >>\n> >> Note that this will only show up as a bug with \"doesn't have\n> >> mpu register target base\" boot errors when the legacy platform\n> >> data is removed.\n> >>\n> >> Cc: Mark Rutland \n> >> Cc: Rob Herring \n> >> Cc: Tomi Valkeinen \n> >> Signed-off-by: Tony Lindgren \n> >> ---\n> \n> Out of curiosity, is anything being done with this? I'm really\n> interested to see the PVR working in a modern kernel. I'd like to\n> help more, but I am afraid I don't fully understand the interconnects\n> and how the driver componenets interact with the omap processor.\n> \n> Please let me know if there are sub-tasks that I can assist.\n\nWell the powervr node should use a powervr generic binding that\ndoes not yet exist. I think the TI tree binding could be easily\nmodified for a generic binding. So first doing a binding patch\nfor powervr and Cc dt list and SoC maintainers with powervr on\nthem would help.\n\nAnd then eventually the powervr generic node should be a child\nnode under the \"target-module\" node in the dtsi file. See what\nwe have for gpu target-module@56000000 in omap4.dtsi.\n\nNote that the interconnect target module does not yet work for\nomap3 as the clocks are different. I'll be posting patches for\nthe clocks over next few weeks.\n\nRegards,\n\nTony\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ypy846h26z9sPt\n\tfor ;\n\tSun, 3 Dec 2017 04:00:52 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751878AbdLBRAv (ORCPT\n\t);\n\tSat, 2 Dec 2017 12:00:51 -0500","from muru.com ([72.249.23.125]:53158 \"EHLO muru.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751848AbdLBRAu (ORCPT );\n\tSat, 2 Dec 2017 12:00:50 -0500","from atomide.com (localhost [127.0.0.1])\n\tby muru.com (Postfix) with ESMTPS id 457A080FE;\n\tSat, 2 Dec 2017 17:02:59 +0000 (UTC)"],"Date":"Sat, 2 Dec 2017 09:00:46 -0800","From":"Tony Lindgren ","To":"Adam Ford ","Cc":"Rob Herring , linux-omap@vger.kernel.org, =?utf-8?q?B?=\n\t=?utf-8?b?ZW5vw650?= Cousson ,\n\tdevicetree@vger.kernel.org, Mark Rutland , \n\tTomi Valkeinen ","Subject":"Re: [PATCH 14/17] ARM: dts: Add missing gpu node and binding for\n\tomap4","Message-ID":"<20171202170046.GT28152@atomide.com>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-15-tony@atomide.com>\n\t<20170911215016.far2rpihdd423ybt@rob-hp-laptop>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]