[{"id":1760342,"web_url":"http://patchwork.ozlabs.org/comment/1760342/","msgid":"<18349253.zZQUxBsrvU@avalon>","list_archive_url":null,"date":"2017-08-30T17:05:59","subject":"Re: [PATCH 13/17] ARM: dts: Add missing fdif node and binding for\n\tomap4","submitter":{"id":11034,"url":"http://patchwork.ozlabs.org/api/people/11034/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tony,\n\nThank you for the patch.\n\nOn Wednesday, 30 August 2017 18:19:49 EEST Tony Lindgren wrote:\n> On omap4 we're missing the fdif node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Cc: Laurent Pinchart \n> Cc: Mark Rutland \n> Cc: Mauro Carvalho Chehab \n> Cc: Rob Herring \n> Cc: Sakari Ailus \n> Signed-off-by: Tony Lindgren \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .../devicetree/bindings/media/ti-fdif.txt | 29 +++++++++++++++++++\n> arch/arm/boot/dts/omap4.dtsi | 7 ++++++\n> 2 files changed, 36 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/media/ti-fdif.txt\n> \n> diff --git a/Documentation/devicetree/bindings/media/ti-fdif.txt\n> b/Documentation/devicetree/bindings/media/ti-fdif.txt new file mode 100644\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/media/ti-fdif.txt\n> @@ -0,0 +1,29 @@\n> +Texas Instruments Face Detect (FDIF) binding\n> +\n> +FDIF can be used for face detection on Texas Instruments SoCs.\n> +\n> +Required properties:\n> +\n> +compatible: Shall be one of the following:\n> +\t \"ti,omap4-fdif\"\n> +\n> +reg: Shall contain the device instance IO range\n> +\n> +interrupts: Shall contain the device instance interrupt\n> +\n> +\n> +Optional properties:\n> +\n> +ti,hwmods: Shall contain the TI interconnect module name if needed\n> +\t by the SoC\n> +\n> +\n> +Example:\n> +\n> +\tfdif: fdif@4a10a000 {\n> +\t\tcompatible = \"ti,omap4-fdif\";\n> +\t\treg = <0x4a10a000 0x1000>;\n> +\t\tinterrupts = ;\n> +\t\tti,hwmods = \"fdif\";\n> +\t};\n> +\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -889,6 +889,13 @@\n> \t\t\t};\n> \t\t};\n> \n> +\t\tfdif: fdif@4a10a000 {\n> +\t\t\tcompatible = \"ti,omap4-fdif\";\n> +\t\t\treg = <0x4a10a000 0x1000>;\n> +\t\t\tinterrupts = ;\n> +\t\t\tti,hwmods = \"fdif\";\n> +\t\t};\n> +\n> \t\ttimer1: timer@4a318000 {\n> \t\t\tcompatible = \"ti,omap3430-timer\";\n> \t\t\treg = <0x4a318000 0x80>;","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PiThwMGB\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjBhl23wBz9s7C\n\tfor ;\n\tThu, 31 Aug 2017 03:05:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752055AbdH3RFZ (ORCPT\n\t);\n\tWed, 30 Aug 2017 13:05:25 -0400","from galahad.ideasonboard.com ([185.26.127.97]:34462 \"EHLO\n\tgalahad.ideasonboard.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751351AbdH3RFY (ORCPT\n\t); Wed, 30 Aug 2017 13:05:24 -0400","from avalon.localnet (unknown\n\t[IPv6:2a02:a03f:eb2:ce00:202c:bd4b:ef51:3811])\n\tby galahad.ideasonboard.com (Postfix) with ESMTPSA id A4309200AD;\n\tWed, 30 Aug 2017 19:03:37 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1504112617;\n\tbh=vAFN5mMxDFANjV+H7nRed7rR4td8/di9TsOrNyhigws=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PiThwMGBm1/aKyPwvIWzAUo4nl5mlqMB5/KSIzdCgi2bKF77HLjZkW1XSdRc3eRmS\n\tTGqX/LpzRfv30PU84cH4a+IlDijDRx29YLPyGlE7fFiJx1847Fwl28epJUok1hbC/p\n\tGE6aHB+yZPgz0aI1Yj1He8s6lPgveNu05MipOvWM=","From":"Laurent Pinchart ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Mauro Carvalho Chehab\n\t, Rob Herring ,\n\tSakari Ailus ","Subject":"Re: [PATCH 13/17] ARM: dts: Add missing fdif node and binding for\n\tomap4","Date":"Wed, 30 Aug 2017 20:05:59 +0300","Message-ID":"<18349253.zZQUxBsrvU@avalon>","In-Reply-To":"<20170830151953.30856-14-tony@atomide.com>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-14-tony@atomide.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766586,"web_url":"http://patchwork.ozlabs.org/comment/1766586/","msgid":"<20170911214737.nty5fgl4hhctwdr6@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T21:47:37","subject":"Re: [PATCH 13/17] ARM: dts: Add missing fdif node and binding for\n\tomap4","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 08:19:49AM -0700, Tony Lindgren wrote:\n> On omap4 we're missing the fdif node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Cc: Laurent Pinchart \n> Cc: Mark Rutland \n> Cc: Mauro Carvalho Chehab \n> Cc: Rob Herring \n> Cc: Sakari Ailus \n> Signed-off-by: Tony Lindgren \n> ---\n> .../devicetree/bindings/media/ti-fdif.txt | 29 ++++++++++++++++++++++\n> arch/arm/boot/dts/omap4.dtsi | 7 ++++++\n> 2 files changed, 36 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/media/ti-fdif.txt\n\nAcked-by: Rob Herring \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrhNt2kq6z9sBZ\n\tfor ;\n\tTue, 12 Sep 2017 07:47:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750957AbdIKVrk (ORCPT\n\t);\n\tMon, 11 Sep 2017 17:47:40 -0400","from mail-ua0-f196.google.com ([209.85.217.196]:34010 \"EHLO\n\tmail-ua0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750853AbdIKVrk (ORCPT\n\t); Mon, 11 Sep 2017 17:47:40 -0400","by mail-ua0-f196.google.com with SMTP id c27so2782498uah.1;\n\tMon, 11 Sep 2017 14:47:39 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\te18sm15131126oih.38.2017.09.11.14.47.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 14:47:38 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=bHoMyzyra1l2OLWSO6VhVJVO6Xzt7VLqxx8ZrOajFtk=;\n\tb=tjRIone/J1t2ZL7ViV40vVGWvioRQRKeJPk9wYTgmKgvKeMGy9vaKRi9gjmxA3paOJ\n\t+iARra9axFCfxOAnUPDlhD5eYV22bNbPcv62z4WMh9C9rAIxL3q2HvG95mkl6iuNFuRb\n\tDWJKGg3pKQGCd4fXmpvX3k6kb5BJtLAZY5qKPbQI8w+v0DJaIR/xBn+wb1kG98825jxj\n\tstezkKXMn6W74oVRzHs/ECKHaXHwLykP4EXtxw5elZiemco/wqDw6Ndq4+i2QVWateFA\n\tPIJ+MqyKAI+j2ozqROIFMMFQ1Obs3y10yY9VLe2XBGuWLU7zJWwaYe/6xzBDcjXPphJe\n\tVnqw==","X-Gm-Message-State":"AHPjjUj1utS3cAbbePgl4jRBTNsXOi/2y1ZbHyz1IDQv5adeObypzmxO\n\tzpgo9kXgiMsoxw==","X-Google-Smtp-Source":"AOwi7QCMU5QZzUU+TOQbvSLSP/B3b3QYvRBSn8YXF9VPV38mSMl6KuRU5bQP344EpWQTRhQVbBCF+g==","X-Received":"by 10.202.172.8 with SMTP id v8mr13873281oie.310.1505166459125; \n\tMon, 11 Sep 2017 14:47:39 -0700 (PDT)","Date":"Mon, 11 Sep 2017 16:47:37 -0500","From":"Rob Herring ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tLaurent Pinchart , \n\tMark Rutland , Mauro Carvalho Chehab\n\t, Sakari Ailus ","Subject":"Re: [PATCH 13/17] ARM: dts: Add missing fdif node and binding for\n\tomap4","Message-ID":"<20170911214737.nty5fgl4hhctwdr6@rob-hp-laptop>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-14-tony@atomide.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830151953.30856-14-tony@atomide.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]