[{"id":1760661,"web_url":"http://patchwork.ozlabs.org/comment/1760661/","msgid":"","list_archive_url":null,"date":"2017-08-31T05:47:32","subject":"Re: [PATCH 11/17] ARM: dts: Add missing mcasp node for omap4","submitter":{"id":9142,"url":"http://patchwork.ozlabs.org/api/people/9142/","name":"Peter Ujfalusi","email":"peter.ujfalusi@ti.com"},"content":"\n\n\nTexas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki\n\nOn 2017-08-30 18:19, Tony Lindgren wrote:\n> On omap4 we're missing the mcasp node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Cc: Liam Girdwood \n> Cc: Mark Brown \n> Cc: Mark Rutland \n> Cc: Peter Ujfalusi \n> Cc: Rob Herring \n> Signed-off-by: Tony Lindgren \n> ---\n> Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt | 1 +\n> arch/arm/boot/dts/omap4.dtsi | 9 +++++++++\n> 2 files changed, 10 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt\n> --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt\n> +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt\n> @@ -6,6 +6,7 @@ Required properties:\n> \t\"ti,da830-mcasp-audio\"\t: for both DA830 & DA850 platforms\n> \t\"ti,am33xx-mcasp-audio\"\t: for AM33xx platforms (AM33xx, AM43xx, TI81xx)\n> \t\"ti,dra7-mcasp-audio\"\t: for DRA7xx platforms\n> +\t\"ti,omap4-mcasp-audio\"\t: for OMAP4 platforms\n> \n> - reg : Should contain reg specifiers for the entries in the reg-names property.\n> - reg-names : Should contain:\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -775,6 +775,15 @@\n> \t\t\tstatus = \"disabled\";\n> \t\t};\n> \n> +\t\tmcasp: mcasp@40128000 {\n> +\t\t\tcompatible = \"ti,omap4-mcasp-audio\";\n> +\t\t\treg = <0x40128000 0x400>, /* MPU private access */\n> +\t\t\t <0x49028000 0x400>; /* L3 Interconnect */\n> +\t\t\treg-names = \"mpu\", \"dma\";\n> +\t\t\tinterrupts = ;\n> +\t\t\tti,hwmods = \"mcasp\";\n> +\t\t};\n\nI would not do this. We don't support the NcASP on OMAP4 or OMAP5 for\nthat matter.\nIn theory it is the same IP as found in other SoCs, but in OMAP4 the TX\npath is disabled and (in theory) the i2s support is also a thing which\nis not supported - only DIT mode.\nWe do not even have any hardware where it can be tested (Galaxy Nexus\nuses McASP for S/PDIF output when it is docked.\nFor Android we have had omap-mcasp driver, but it is not upstream and is\nnever will as if we are going to support McASP it should be done via the\ndavinci-mcasp driver.\n\nBy adding the node we might give the impression that McASP on OMAP4/5 is\nusable, which is not.\n\nOn the other hand, the DT describes the HW, so it should be OK to add\nall peripherals even if there is no driver to support it. In this case\nthe status = \"disabled\"; must be there.\n\n> +\n> \t\tslimbus1: slimbus@4012c000 {\n> \t\t\tcompatible = \"ti,omap4-slimbus\";\n> \t\t\treg = <0x4012c000 0x400>, /* MPU private access */\n> \n\n- Péter\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"TUfSZUbF\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjWd66vdsz9sMN\n\tfor ;\n\tThu, 31 Aug 2017 15:48:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750880AbdHaFsZ (ORCPT\n\t);\n\tThu, 31 Aug 2017 01:48:25 -0400","from fllnx209.ext.ti.com ([198.47.19.16]:10364 \"EHLO\n\tfllnx209.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750864AbdHaFsY (ORCPT\n\t); Thu, 31 Aug 2017 01:48:24 -0400","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v7V5lGZX016575; \n\tThu, 31 Aug 2017 00:47:16 -0500","from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v7V5lBFm022685;\n\tThu, 31 Aug 2017 00:47:11 -0500","from DFLE104.ent.ti.com (10.64.6.25) by DFLE114.ent.ti.com\n\t(10.64.6.35) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tThu, 31 Aug 2017 00:47:10 -0500","from dflp33.itg.ti.com (10.64.6.16) by DFLE104.ent.ti.com\n\t(10.64.6.25) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Thu, 31 Aug 2017 00:47:10 -0500","from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v7V5l8ap006918;\n\tThu, 31 Aug 2017 00:47:09 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1504158436;\n\tbh=mfZmUGfC2m9uHNnIkCXDeAPwGTIYh+a0MmzczUnWFwA=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=TUfSZUbF385uSIFs1jsYQzgMAzZth0DV88InZgMbTfzVPpL1fHfF11R6dECj0TWIN\n\tmbEvO7F3iirFzayRsSPAErVyyWrEmEjlwtv0y1AImSQvTsJ1TGdLG4qVclT2jzoXbB\n\tKiRfnJIe+HpHdKGfwLlWE/cMLJxm311uLiYfoav8=","Subject":"Re: [PATCH 11/17] ARM: dts: Add missing mcasp node for omap4","To":"Tony Lindgren , ","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-12-tony@atomide.com>","CC":"=?utf-8?q?Beno=C3=AEt_Cousson?= ,\n\t, Liam Girdwood , \n\tMark Brown , Mark Rutland , \n\tRob Herring ","From":"Peter Ujfalusi ","Message-ID":"","Date":"Thu, 31 Aug 2017 08:47:32 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170830151953.30856-12-tony@atomide.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1761073,"web_url":"http://patchwork.ozlabs.org/comment/1761073/","msgid":"<20170831144425.GP3930@atomide.com>","list_archive_url":null,"date":"2017-08-31T14:44:25","subject":"Re: [PATCH 11/17] ARM: dts: Add missing mcasp node for omap4","submitter":{"id":365,"url":"http://patchwork.ozlabs.org/api/people/365/","name":"Tony Lindgren","email":"tony@atomide.com"},"content":"* Peter Ujfalusi [170830 22:48]:\n> On 2017-08-30 18:19, Tony Lindgren wrote:\n> > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> > --- a/arch/arm/boot/dts/omap4.dtsi\n> > +++ b/arch/arm/boot/dts/omap4.dtsi\n> > @@ -775,6 +775,15 @@\n> > \t\t\tstatus = \"disabled\";\n> > \t\t};\n> > \n> > +\t\tmcasp: mcasp@40128000 {\n> > +\t\t\tcompatible = \"ti,omap4-mcasp-audio\";\n> > +\t\t\treg = <0x40128000 0x400>, /* MPU private access */\n> > +\t\t\t <0x49028000 0x400>; /* L3 Interconnect */\n> > +\t\t\treg-names = \"mpu\", \"dma\";\n> > +\t\t\tinterrupts = ;\n> > +\t\t\tti,hwmods = \"mcasp\";\n> > +\t\t};\n> \n> I would not do this. We don't support the NcASP on OMAP4 or OMAP5 for\n> that matter.\n> In theory it is the same IP as found in other SoCs, but in OMAP4 the TX\n> path is disabled and (in theory) the i2s support is also a thing which\n> is not supported - only DIT mode.\n> We do not even have any hardware where it can be tested (Galaxy Nexus\n> uses McASP for S/PDIF output when it is docked.\n> For Android we have had omap-mcasp driver, but it is not upstream and is\n> never will as if we are going to support McASP it should be done via the\n> davinci-mcasp driver.\n\nOK\n\n> By adding the node we might give the impression that McASP on OMAP4/5 is\n> usable, which is not.\n\nOK. Yeah we need to make sure this is for the interconnect\ntarget module, and not for it's child device(s) mcasp.\n\n> On the other hand, the DT describes the HW, so it should be OK to add\n> all peripherals even if there is no driver to support it. In this case\n> the status = \"disabled\"; must be there.\n\nYeah well this is for the interconnect target module that we are\nalready accessing during init to idle it. But it's actually the\nchildren of this node that should have the status = \"disabled\"!\n\nI think we can solve your concernd by adding the generic minimal\nbinding and compatible properites for the interconnect target\nmodule for which I already posted an RFC a while back.\n\nSo we can just use compatibles \"ti,sysc-type1\", \"ti,sysc-type2\"\nand \"ti,sysc-type3\" as are going to need those anyways soonish.\n\nSo the McASP interconnect target module would just become:\n\n\ttarget_module@40128000 {\n\t\tcompatible = \"ti,sysc-type2\";\n\t\treg = <0x40128000 0x400>, /* MPU private access */\n\t\t <0x49028000 0x400>; /* L3 Interconnect */\n\t\treg-names = \"mpu\", \"dma\";\n\t\tti,hwmods = \"mcasp\";\n\t};\n\nAnd if there ever is a McASP driver, it can be a child of\nthis node. And eventually we will just drop ti,hwmods too.\n\nRegards,\n\nTony\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjlWg50blz9s7c\n\tfor ;\n\tFri, 1 Sep 2017 00:44:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751683AbdHaOoa (ORCPT\n\t);\n\tThu, 31 Aug 2017 10:44:30 -0400","from muru.com ([72.249.23.125]:39022 \"EHLO muru.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751674AbdHaOo3 (ORCPT );\n\tThu, 31 Aug 2017 10:44:29 -0400","from atomide.com (localhost [127.0.0.1])\n\tby muru.com (Postfix) with ESMTPS id 8B5E581E6;\n\tThu, 31 Aug 2017 14:44:51 +0000 (UTC)"],"Date":"Thu, 31 Aug 2017 07:44:25 -0700","From":"Tony Lindgren ","To":"Peter Ujfalusi ","Cc":"linux-omap@vger.kernel.org, =?utf-8?q?Beno=C3=AEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tLiam Girdwood , Mark Brown ,\n\tMark Rutland , Rob Herring ","Subject":"Re: [PATCH 11/17] ARM: dts: Add missing mcasp node for omap4","Message-ID":"<20170831144425.GP3930@atomide.com>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-12-tony@atomide.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]