[{"id":1760433,"web_url":"http://patchwork.ozlabs.org/comment/1760433/","msgid":"<20170830193745.ygotb3nuyfmdlaaf@earth>","list_archive_url":null,"date":"2017-08-30T19:37:45","subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","submitter":{"id":62589,"url":"http://patchwork.ozlabs.org/api/people/62589/","name":"Sebastian Reichel","email":"sre@kernel.org"},"content":"On Wed, Aug 30, 2017 at 08:19:44AM -0700, Tony Lindgren wrote:\n> On omap4 we're missing the hsi node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Let's also update the binding accrodingly while at it.\n> \n> Cc: Mark Rutland \n> Cc: Rob Herring \n> Cc: Sebastian Reichel \n> Signed-off-by: Tony Lindgren \n> ---\n> Documentation/devicetree/bindings/hsi/omap-ssi.txt | 7 ++++-\n> arch/arm/boot/dts/omap4.dtsi | 34 ++++++++++++++++++++++\n> 2 files changed, 40 insertions(+), 1 deletion(-)\n> \n> diff --git a/Documentation/devicetree/bindings/hsi/omap-ssi.txt b/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n> --- a/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n> +++ b/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n> @@ -4,7 +4,7 @@ OMAP Synchronous Serial Interface (SSI) controller implements a legacy\n> variant of MIPI's High Speed Synchronous Serial Interface (HSI).\n\nMaybe change the leading text:\n\nOMAP3's Synchronous Serial Interface (SSI) controller implements a\nlegacy variant of MIPI's High Speed Synchronous Serial Interface (HSI),\nwhile the controller found inside OMAP4 is supposed to be fully compliant\nwith the HSI standard.\n\n> Required properties:\n> -- compatible:\t\tShould include \"ti,omap3-ssi\".\n> +- compatible:\t\tShould include \"ti,omap3-ssi\" or \"ti,omap4-hsi\"\n> - reg-names:\t\tContains the values \"sys\" and \"gdd\" (in this order).\n> - reg:\t\t\tContains a matching register specifier for each entry\n> \t\t\tin reg-names.\n> @@ -27,6 +27,7 @@ Each port is represented as a sub-node of the ti,omap3-ssi device.\n> Required Port sub-node properties:\n> - compatible:\t\tShould be set to the following value\n> \t\t\tti,omap3-ssi-port (applicable to OMAP34xx devices)\n> +\t\t\tti,omap4-ssi-port (applicable to OMAP44xx devices)\n ^^^\n\nthis should be hsi.\n\n> - reg-names:\t\tContains the values \"tx\" and \"rx\" (in this order).\n> - reg:\t\t\tContains a matching register specifier for each entry\n> \t\t\tin reg-names.\n> @@ -38,6 +39,10 @@ Required Port sub-node properties:\n> \t\t\tproperty. If it's missing the port will not be\n> \t\t\tenabled.\n> \n> +Optional properties:\n> +- ti,hwmods:\t\tShall contain TI interconnect module name if needed\n> +\t\t\tby the SoC\n> +\n> Example for Nokia N900:\n> \n> ssi-controller@48058000 {\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -632,6 +632,40 @@\n> \t\t\tdma-names = \"tx\", \"rx\";\n> \t\t};\n> \n> +\t\thsi: hsi@4a058000 {\n> +\t\t\tcompatible = \"ti,omap4-hsi\";\n> +\t\t\treg = <0x4a058000 0x4000>,\n> +\t\t\t <0x4a05c000 0x1000>;\n> +\t\t\treg-names = \"sys\", \"gdd\";\n> +\t\t\tti,hwmods = \"hsi\";\n> +\n> +\t\t\tclocks = <&hsi_fck>;\n> +\t\t\tclock-names = \"hsi_fck\";\n> +\n> +\t\t\tinterrupts = ;\n> +\t\t\tinterrupt-names = \"gdd_mpu\";\n> +\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <1>;\n> +\t\t\tranges = <0 0x4a058000 0x4000>;\n> +\n> +\t\t\thsi_port1: hsi-port@2000 {\n> +\t\t\t\tcompatible = \"ti,omap4-hsi-port\";\n> +\t\t\t\treg = <0x2000 0x800>,\n> +\t\t\t\t <0x2800 0x800>;\n> +\t\t\t\treg-names = \"tx\", \"rx\";\n> +\t\t\t\tinterrupts = ;\n> +\t\t\t};\n> +\n> +\t\t\thsi_port2: hsi-port@3000 {\n> +\t\t\t\tcompatible = \"ti,omap4-hsi-port\";\n> +\t\t\t\treg = <0x3000 0x800>,\n> +\t\t\t\t <0x3800 0x800>;\n> +\t\t\t\treg-names = \"tx\", \"rx\";\n> +\t\t\t\tinterrupts = ;\n> +\t\t\t};\n> +\t\t};\n> +\n> \t\tmmu_dsp: mmu@4a066000 {\n> \t\t\tcompatible = \"ti,omap4-iommu\";\n> \t\t\treg = <0x4a066000 0x100>;\n\notherwise:\n\nReviewed-by: Sebastian Reichel \n\n-- Sebastian","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=sre@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjG4d6rfwz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 05:37:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751191AbdH3Thw (ORCPT\n\t);\n\tWed, 30 Aug 2017 15:37:52 -0400","from mail.kernel.org ([198.145.29.99]:33046 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750995AbdH3Thv (ORCPT );\n\tWed, 30 Aug 2017 15:37:51 -0400","from mail.kernel.org (unknown [185.189.112.11])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 2E1402199E;\n\tWed, 30 Aug 2017 19:37:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 2E1402199E","Date":"Wed, 30 Aug 2017 21:37:45 +0200","From":"Sebastian Reichel ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Rob Herring ","Subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","Message-ID":"<20170830193745.ygotb3nuyfmdlaaf@earth>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-9-tony@atomide.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"enuq3hee5crnh5vl\"","Content-Disposition":"inline","In-Reply-To":"<20170830151953.30856-9-tony@atomide.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1760466,"web_url":"http://patchwork.ozlabs.org/comment/1760466/","msgid":"<20170830202519.GI6008@atomide.com>","list_archive_url":null,"date":"2017-08-30T20:25:20","subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","submitter":{"id":365,"url":"http://patchwork.ozlabs.org/api/people/365/","name":"Tony Lindgren","email":"tony@atomide.com"},"content":"* Sebastian Reichel [170830 12:38]:\n> On Wed, Aug 30, 2017 at 08:19:44AM -0700, Tony Lindgren wrote:\n> Maybe change the leading text:\n> \n> OMAP3's Synchronous Serial Interface (SSI) controller implements a\n> legacy variant of MIPI's High Speed Synchronous Serial Interface (HSI),\n> while the controller found inside OMAP4 is supposed to be fully compliant\n> with the HSI standard.\n\nOK\n\n> > Required properties:\n> > -- compatible:\t\tShould include \"ti,omap3-ssi\".\n> > +- compatible:\t\tShould include \"ti,omap3-ssi\" or \"ti,omap4-hsi\"\n> > - reg-names:\t\tContains the values \"sys\" and \"gdd\" (in this order).\n> > - reg:\t\t\tContains a matching register specifier for each entry\n> > \t\t\tin reg-names.\n> > @@ -27,6 +27,7 @@ Each port is represented as a sub-node of the ti,omap3-ssi device.\n> > Required Port sub-node properties:\n> > - compatible:\t\tShould be set to the following value\n> > \t\t\tti,omap3-ssi-port (applicable to OMAP34xx devices)\n> > +\t\t\tti,omap4-ssi-port (applicable to OMAP44xx devices)\n> ^^^\n> \n> this should be hsi.\n\nOops fixed.\n\n> otherwise:\n> \n> Reviewed-by: Sebastian Reichel \n\nThanks, updated patch below.\n\nRegards,\n\nTony\n\n8< --------------------\n>From tony Mon Sep 17 00:00:00 2001\nFrom: Tony Lindgren \nDate: Wed, 30 Aug 2017 08:07:51 -0700\nSubject: [PATCH] ARM: dts: Add missing hsi node for omap4\n\nOn omap4 we're missing the hsi node with it's related \"ti,hwmods\"\nproperty that the SoC interconnect code needs.\n\nNote that this will only show up as a bug with \"doesn't have\nmpu register target base\" boot errors when the legacy platform\ndata is removed.\n\nLet's also update the binding accrodingly while at it.\n\nCc: Mark Rutland \nCc: Rob Herring \nReviewed-by: Sebastian Reichel \nSigned-off-by: Tony Lindgren \n---\n Documentation/devicetree/bindings/hsi/omap-ssi.txt | 13 +++++++--\n arch/arm/boot/dts/omap4.dtsi | 34 ++++++++++++++++++++++\n 2 files changed, 44 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/devicetree/bindings/hsi/omap-ssi.txt b/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n--- a/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n+++ b/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n@@ -1,10 +1,12 @@\n OMAP SSI controller bindings\n \n-OMAP Synchronous Serial Interface (SSI) controller implements a legacy\n-variant of MIPI's High Speed Synchronous Serial Interface (HSI).\n+OMAP3's Synchronous Serial Interface (SSI) controller implements a\n+legacy variant of MIPI's High Speed Synchronous Serial Interface (HSI),\n+while the controller found inside OMAP4 is supposed to be fully compliant\n+with the HSI standard.\n \n Required properties:\n-- compatible:\t\tShould include \"ti,omap3-ssi\".\n+- compatible:\t\tShould include \"ti,omap3-ssi\" or \"ti,omap4-hsi\"\n - reg-names:\t\tContains the values \"sys\" and \"gdd\" (in this order).\n - reg:\t\t\tContains a matching register specifier for each entry\n \t\t\tin reg-names.\n@@ -27,6 +29,7 @@ Each port is represented as a sub-node of the ti,omap3-ssi device.\n Required Port sub-node properties:\n - compatible:\t\tShould be set to the following value\n \t\t\tti,omap3-ssi-port (applicable to OMAP34xx devices)\n+\t\t\tti,omap4-hsi-port (applicable to OMAP44xx devices)\n - reg-names:\t\tContains the values \"tx\" and \"rx\" (in this order).\n - reg:\t\t\tContains a matching register specifier for each entry\n \t\t\tin reg-names.\n@@ -38,6 +41,10 @@ Required Port sub-node properties:\n \t\t\tproperty. If it's missing the port will not be\n \t\t\tenabled.\n \n+Optional properties:\n+- ti,hwmods:\t\tShall contain TI interconnect module name if needed\n+\t\t\tby the SoC\n+\n Example for Nokia N900:\n \n ssi-controller@48058000 {\ndiff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n--- a/arch/arm/boot/dts/omap4.dtsi\n+++ b/arch/arm/boot/dts/omap4.dtsi\n@@ -632,6 +632,40 @@\n \t\t\tdma-names = \"tx\", \"rx\";\n \t\t};\n \n+\t\thsi: hsi@4a058000 {\n+\t\t\tcompatible = \"ti,omap4-hsi\";\n+\t\t\treg = <0x4a058000 0x4000>,\n+\t\t\t <0x4a05c000 0x1000>;\n+\t\t\treg-names = \"sys\", \"gdd\";\n+\t\t\tti,hwmods = \"hsi\";\n+\n+\t\t\tclocks = <&hsi_fck>;\n+\t\t\tclock-names = \"hsi_fck\";\n+\n+\t\t\tinterrupts = ;\n+\t\t\tinterrupt-names = \"gdd_mpu\";\n+\n+\t\t\t#address-cells = <1>;\n+\t\t\t#size-cells = <1>;\n+\t\t\tranges = <0 0x4a058000 0x4000>;\n+\n+\t\t\thsi_port1: hsi-port@2000 {\n+\t\t\t\tcompatible = \"ti,omap4-hsi-port\";\n+\t\t\t\treg = <0x2000 0x800>,\n+\t\t\t\t <0x2800 0x800>;\n+\t\t\t\treg-names = \"tx\", \"rx\";\n+\t\t\t\tinterrupts = ;\n+\t\t\t};\n+\n+\t\t\thsi_port2: hsi-port@3000 {\n+\t\t\t\tcompatible = \"ti,omap4-hsi-port\";\n+\t\t\t\treg = <0x3000 0x800>,\n+\t\t\t\t <0x3800 0x800>;\n+\t\t\t\treg-names = \"tx\", \"rx\";\n+\t\t\t\tinterrupts = ;\n+\t\t\t};\n+\t\t};\n+\n \t\tmmu_dsp: mmu@4a066000 {\n \t\t\tcompatible = \"ti,omap4-iommu\";\n \t\t\treg = <0x4a066000 0x100>;","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjH7V063nz9sNw\n\tfor ;\n\tThu, 31 Aug 2017 06:25:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751456AbdH3UZY convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 30 Aug 2017 16:25:24 -0400","from muru.com ([72.249.23.125]:38962 \"EHLO muru.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751016AbdH3UZY (ORCPT );\n\tWed, 30 Aug 2017 16:25:24 -0400","from atomide.com (localhost [127.0.0.1])\n\tby muru.com (Postfix) with ESMTPS id 31EA782B9;\n\tWed, 30 Aug 2017 20:25:45 +0000 (UTC)"],"Date":"Wed, 30 Aug 2017 13:25:20 -0700","From":"Tony Lindgren ","To":"Sebastian Reichel ","Cc":"linux-omap@vger.kernel.org, =?utf-8?q?Beno=C3=AEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Rob Herring ","Subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","Message-ID":"<20170830202519.GI6008@atomide.com>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-9-tony@atomide.com>\n\t<20170830193745.ygotb3nuyfmdlaaf@earth>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","Content-Transfer-Encoding":"8BIT","In-Reply-To":"<20170830193745.ygotb3nuyfmdlaaf@earth>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766581,"web_url":"http://patchwork.ozlabs.org/comment/1766581/","msgid":"<20170911214220.xgixksncsncolzx3@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T21:42:20","subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 08:19:44AM -0700, Tony Lindgren wrote:\n> On omap4 we're missing the hsi node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Let's also update the binding accrodingly while at it.\n> \n> Cc: Mark Rutland \n> Cc: Rob Herring \n> Cc: Sebastian Reichel \n> Signed-off-by: Tony Lindgren \n> ---\n> Documentation/devicetree/bindings/hsi/omap-ssi.txt | 7 ++++-\n> arch/arm/boot/dts/omap4.dtsi | 34 ++++++++++++++++++++++\n> 2 files changed, 40 insertions(+), 1 deletion(-)\n\nAcked-by: Rob Herring \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrhGm6Bj3z9sBZ\n\tfor ;\n\tTue, 12 Sep 2017 07:42:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751148AbdIKVmX (ORCPT\n\t);\n\tMon, 11 Sep 2017 17:42:23 -0400","from mail-it0-f68.google.com ([209.85.214.68]:38837 \"EHLO\n\tmail-it0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751078AbdIKVmW (ORCPT\n\t); Mon, 11 Sep 2017 17:42:22 -0400","by mail-it0-f68.google.com with SMTP id z81so4921087itb.5;\n\tMon, 11 Sep 2017 14:42:22 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\ty124sm9511700oiy.20.2017.09.11.14.42.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 14:42:21 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=fCRfbJl56ApfTtH2xwa1EGeksOW0tAGXNhh/GQwtY90=;\n\tb=gcZ/EAi8NT9SXCzuKC1MDhygcdtKm6IjHWa1456dJgeObLmCVt+pMhv3J7ALoiRD4z\n\t/KzSD0iDKaBkPLv3ZjVP3A3R7fggwlPGvgPUmHPjtfSFauIuPtSkhEwrtfoT+upQoRjf\n\tcGKPj0Xc7a1uPXimGE6O+qr/Z2yTvhJzADj2+KPKXQX+uz4C3fnHXLhYoInyrPAkWA5z\n\tpvkls9YFDPQBv8hucTkpmKrK5Wcmq01EqYrFZneYvIr0goQRRJITuIwovtS1TqkF4mGq\n\tOxYRAOHBIJ8pqLzGj11DDqEv0unVCaXE/xucIDZa0hcKxg/JQXwJmznKdTS+iu/uAyCV\n\tBAiA==","X-Gm-Message-State":"AHPjjUjCTcYvlElaN9bT54JnPY0s6llJXELc6XbYqV1rsO0oJFqLU4IE\n\tPiVBhpu6DITRKPyawAs=","X-Google-Smtp-Source":"ADKCNb6ATGlAW+oDcTyzFG/hX16AL+G88lOXBsVhP/OwdL2EoP9lZZB4xC1CIWplWg+bQjFIDZ5MEw==","X-Received":"by 10.202.102.71 with SMTP id a68mr13503076oic.242.1505166142027;\n\tMon, 11 Sep 2017 14:42:22 -0700 (PDT)","Date":"Mon, 11 Sep 2017 16:42:20 -0500","From":"Rob Herring ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Sebastian Reichel ","Subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","Message-ID":"<20170911214220.xgixksncsncolzx3@rob-hp-laptop>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-9-tony@atomide.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830151953.30856-9-tony@atomide.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1778026,"web_url":"http://patchwork.ozlabs.org/comment/1778026/","msgid":"<20171001152514.hjoa5osvadfpnkim@earth>","list_archive_url":null,"date":"2017-10-01T15:25:14","subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","submitter":{"id":62589,"url":"http://patchwork.ozlabs.org/api/people/62589/","name":"Sebastian Reichel","email":"sre@kernel.org"},"content":"Hi,\n\nOn Wed, Aug 30, 2017 at 01:25:20PM -0700, Tony Lindgren wrote:\n> Thanks, updated patch below.\n\nThanks, I applied the DT binding part to the HSI subsystem:\n\nhttps://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=8635d6b3afe68cdde2f646c2a3bbd8149c031e8c\n\n-- Sebastian\n\n> 8< --------------------\n> From tony Mon Sep 17 00:00:00 2001\n> From: Tony Lindgren \n> Date: Wed, 30 Aug 2017 08:07:51 -0700\n> Subject: [PATCH] ARM: dts: Add missing hsi node for omap4\n> \n> On omap4 we're missing the hsi node with it's related \"ti,hwmods\"\n> property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Let's also update the binding accrodingly while at it.\n> \n> Cc: Mark Rutland \n> Cc: Rob Herring \n> Reviewed-by: Sebastian Reichel \n> Signed-off-by: Tony Lindgren \n> ---\n> Documentation/devicetree/bindings/hsi/omap-ssi.txt | 13 +++++++--\n> arch/arm/boot/dts/omap4.dtsi | 34 ++++++++++++++++++++++\n> 2 files changed, 44 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/hsi/omap-ssi.txt b/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n> --- a/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n> +++ b/Documentation/devicetree/bindings/hsi/omap-ssi.txt\n> @@ -1,10 +1,12 @@\n> OMAP SSI controller bindings\n> \n> -OMAP Synchronous Serial Interface (SSI) controller implements a legacy\n> -variant of MIPI's High Speed Synchronous Serial Interface (HSI).\n> +OMAP3's Synchronous Serial Interface (SSI) controller implements a\n> +legacy variant of MIPI's High Speed Synchronous Serial Interface (HSI),\n> +while the controller found inside OMAP4 is supposed to be fully compliant\n> +with the HSI standard.\n> \n> Required properties:\n> -- compatible:\t\tShould include \"ti,omap3-ssi\".\n> +- compatible:\t\tShould include \"ti,omap3-ssi\" or \"ti,omap4-hsi\"\n> - reg-names:\t\tContains the values \"sys\" and \"gdd\" (in this order).\n> - reg:\t\t\tContains a matching register specifier for each entry\n> \t\t\tin reg-names.\n> @@ -27,6 +29,7 @@ Each port is represented as a sub-node of the ti,omap3-ssi device.\n> Required Port sub-node properties:\n> - compatible:\t\tShould be set to the following value\n> \t\t\tti,omap3-ssi-port (applicable to OMAP34xx devices)\n> +\t\t\tti,omap4-hsi-port (applicable to OMAP44xx devices)\n> - reg-names:\t\tContains the values \"tx\" and \"rx\" (in this order).\n> - reg:\t\t\tContains a matching register specifier for each entry\n> \t\t\tin reg-names.\n> @@ -38,6 +41,10 @@ Required Port sub-node properties:\n> \t\t\tproperty. If it's missing the port will not be\n> \t\t\tenabled.\n> \n> +Optional properties:\n> +- ti,hwmods:\t\tShall contain TI interconnect module name if needed\n> +\t\t\tby the SoC\n> +\n> Example for Nokia N900:\n> \n> ssi-controller@48058000 {\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -632,6 +632,40 @@\n> \t\t\tdma-names = \"tx\", \"rx\";\n> \t\t};\n> \n> +\t\thsi: hsi@4a058000 {\n> +\t\t\tcompatible = \"ti,omap4-hsi\";\n> +\t\t\treg = <0x4a058000 0x4000>,\n> +\t\t\t <0x4a05c000 0x1000>;\n> +\t\t\treg-names = \"sys\", \"gdd\";\n> +\t\t\tti,hwmods = \"hsi\";\n> +\n> +\t\t\tclocks = <&hsi_fck>;\n> +\t\t\tclock-names = \"hsi_fck\";\n> +\n> +\t\t\tinterrupts = ;\n> +\t\t\tinterrupt-names = \"gdd_mpu\";\n> +\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <1>;\n> +\t\t\tranges = <0 0x4a058000 0x4000>;\n> +\n> +\t\t\thsi_port1: hsi-port@2000 {\n> +\t\t\t\tcompatible = \"ti,omap4-hsi-port\";\n> +\t\t\t\treg = <0x2000 0x800>,\n> +\t\t\t\t <0x2800 0x800>;\n> +\t\t\t\treg-names = \"tx\", \"rx\";\n> +\t\t\t\tinterrupts = ;\n> +\t\t\t};\n> +\n> +\t\t\thsi_port2: hsi-port@3000 {\n> +\t\t\t\tcompatible = \"ti,omap4-hsi-port\";\n> +\t\t\t\treg = <0x3000 0x800>,\n> +\t\t\t\t <0x3800 0x800>;\n> +\t\t\t\treg-names = \"tx\", \"rx\";\n> +\t\t\t\tinterrupts = ;\n> +\t\t\t};\n> +\t\t};\n> +\n> \t\tmmu_dsp: mmu@4a066000 {\n> \t\t\tcompatible = \"ti,omap4-iommu\";\n> \t\t\treg = <0x4a066000 0x100>;\n> -- \n> 2.14.1","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=sre@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y4pyS3PpTz9t62\n\tfor ;\n\tMon, 2 Oct 2017 02:25:20 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751043AbdJAPZS (ORCPT\n\t);\n\tSun, 1 Oct 2017 11:25:18 -0400","from mail.kernel.org ([198.145.29.99]:35244 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750965AbdJAPZR (ORCPT );\n\tSun, 1 Oct 2017 11:25:17 -0400","from mail.kernel.org (dyndsl-095-033-175-164.ewe-ip-backbone.de\n\t[95.33.175.164])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 9B165218D7;\n\tSun, 1 Oct 2017 15:25:16 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 9B165218D7","Date":"Sun, 1 Oct 2017 17:25:14 +0200","From":"Sebastian Reichel ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Rob Herring ","Subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","Message-ID":"<20171001152514.hjoa5osvadfpnkim@earth>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-9-tony@atomide.com>\n\t<20170830193745.ygotb3nuyfmdlaaf@earth>\n\t<20170830202519.GI6008@atomide.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"q5p4z63maywwxm6i\"","Content-Disposition":"inline","In-Reply-To":"<20170830202519.GI6008@atomide.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1778034,"web_url":"http://patchwork.ozlabs.org/comment/1778034/","msgid":"<20171001164748.GK4394@atomide.com>","list_archive_url":null,"date":"2017-10-01T16:47:49","subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","submitter":{"id":365,"url":"http://patchwork.ozlabs.org/api/people/365/","name":"Tony Lindgren","email":"tony@atomide.com"},"content":"* Sebastian Reichel [171001 08:26]:\n> Hi,\n> \n> On Wed, Aug 30, 2017 at 01:25:20PM -0700, Tony Lindgren wrote:\n> > Thanks, updated patch below.\n> \n> Thanks, I applied the DT binding part to the HSI subsystem:\n> \n> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=8635d6b3afe68cdde2f646c2a3bbd8149c031e8c\n\nOK thanks.\n\nTony\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y4rqZ2Qvfz9t62\n\tfor ;\n\tMon, 2 Oct 2017 03:49:30 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751398AbdJAQrx convert rfc822-to-8bit (ORCPT\n\t);\n\tSun, 1 Oct 2017 12:47:53 -0400","from muru.com ([72.249.23.125]:42264 \"EHLO muru.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751326AbdJAQrx (ORCPT );\n\tSun, 1 Oct 2017 12:47:53 -0400","from atomide.com (localhost [127.0.0.1])\n\tby muru.com (Postfix) with ESMTPS id 18ADF82A4;\n\tSun, 1 Oct 2017 16:48:50 +0000 (UTC)"],"Date":"Sun, 1 Oct 2017 09:47:49 -0700","From":"Tony Lindgren ","To":"Sebastian Reichel ","Cc":"linux-omap@vger.kernel.org, =?utf-8?q?Beno=C3=AEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Rob Herring ","Subject":"Re: [PATCH 08/17] ARM: dts: Add missing hsi node for omap4","Message-ID":"<20171001164748.GK4394@atomide.com>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-9-tony@atomide.com>\n\t<20170830193745.ygotb3nuyfmdlaaf@earth>\n\t<20170830202519.GI6008@atomide.com>\n\t<20171001152514.hjoa5osvadfpnkim@earth>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","Content-Transfer-Encoding":"8BIT","In-Reply-To":"<20171001152514.hjoa5osvadfpnkim@earth>","User-Agent":"Mutt/1.9.0 (2017-09-02)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]