[{"id":1766580,"web_url":"http://patchwork.ozlabs.org/comment/1766580/","msgid":"<20170911214109.35o4anadormbvyrc@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T21:41:09","subject":"Re: [PATCH 06/17] ARM: dts: Add missing slimbus node and binding for\n\tomap4","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 08:19:42AM -0700, Tony Lindgren wrote:\n> On omap4 we're missing the slimbus node and it's related\n> \"ti,hwmods\" property that the SoC interconnect code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> Let's also add the missing slimbus device tree binding\n> documentation while at it.\n> \n> Cc: Liam Girdwood <lgirdwood@gmail.com>\n> Cc: Mark Brown <broonie@kernel.org>\n> Cc: Mark Rutland <mark.rutland@arm.com>\n> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>\n> Cc: Rob Herring <robh+dt@kernel.org>\n> Signed-off-by: Tony Lindgren <tony@atomide.com>\n> ---\n>  .../devicetree/bindings/sound/ti-slimbus.txt       | 34 ++++++++++++++++++++++\n>  arch/arm/boot/dts/omap4.dtsi                       | 17 +++++++++++\n>  2 files changed, 51 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/sound/ti-slimbus.txt\n> \n> diff --git a/Documentation/devicetree/bindings/sound/ti-slimbus.txt b/Documentation/devicetree/bindings/sound/ti-slimbus.txt\n> new file mode 100644\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/sound/ti-slimbus.txt\n> @@ -0,0 +1,34 @@\n> +Texas Instruments Serial Low-power Inter-chip Media Bus (SLIMbus) binding\n> +\n> +SLIMbus is used for communication between digital audio components and the SoC.\n> +\n> +\n> +Required properties:\n> +\n> +compatible: Shall be one of the following:\n> +\t    \"ti,omap4-slimbus\"\n> +\n> +reg: Shall contain the device instance IO range\n\nIf there's more than 1, you need to state how many.\n\n> +\n> +interrupts: Shall contain the device instance interrupt\n> +\n> +\n> +Optional properties:\n> +\n> +reg-names: Shall contain the IO range names if multiple IO\n> +\t   ranges are used by the SoC\n\nNeed to define what the names are.\n\n> +\n> +ti,hwmods: Shall contain the TI interconnect module name if needed\n> +\t   by the SoC\n> +\n> +\n> +Example:\n> +\n> +\tslimbus1: slimbus@4012c000 {\n> +\t\tcompatible = \"ti,omap4-slimbus\";\n> +\t\treg = <0x4012c000 0x400>, /* MPU private access */\n> +\t\t      <0x4902c000 0x400>; /* L3 Interconnect */\n> +\t\treg-names = \"mpu\", \"dma\";\n> +\t\tinterrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;\n> +\t\tti,hwmods = \"slimbus1\";\n> +\t};\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -382,6 +382,14 @@\n>  \t\t\t#interrupt-cells = <2>;\n>  \t\t};\n>  \n> +\t\tslimbus2: slimbus@48076000 {\n> +\t\t\tcompatible = \"ti,omap4-slimbus\";\n> +\t\t\treg = <0x48076000 0x400>;\n> +\t\t\treg-names = \"mpu\";\n> +\t\t\tinterrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;\n> +\t\t\tti,hwmods = \"slimbus2\";\n> +\t\t};\n> +\n>  \t\telm: elm@48078000 {\n>  \t\t\tcompatible = \"ti,am3352-elm\";\n>  \t\t\treg = <0x48078000 0x2000>;\n> @@ -711,6 +719,15 @@\n>  \t\t\tstatus = \"disabled\";\n>  \t\t};\n>  \n> +\t\tslimbus1: slimbus@4012c000 {\n> +\t\t\tcompatible = \"ti,omap4-slimbus\";\n> +\t\t\treg = <0x4012c000 0x400>, /* MPU private access */\n> +\t\t\t      <0x4902c000 0x400>; /* L3 Interconnect */\n> +\t\t\treg-names = \"mpu\", \"dma\";\n> +\t\t\tinterrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;\n> +\t\t\tti,hwmods = \"slimbus1\";\n> +\t\t};\n> +\n>  \t\tmcbsp4: mcbsp@48096000 {\n>  \t\t\tcompatible = \"ti,omap4-mcbsp\";\n>  \t\t\treg = <0x48096000 0xff>; /* L4 Interconnect */\n> -- \n> 2.14.1\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrhFP4GSpz9sBZ\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 07:41:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751330AbdIKVlL (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tMon, 11 Sep 2017 17:41:11 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:34393 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751304AbdIKVlL (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Mon, 11 Sep 2017 17:41:11 -0400","by mail-pg0-f68.google.com with SMTP id v82so5226146pgb.1;\n\tMon, 11 Sep 2017 14:41:10 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\t188sm9141691oid.5.2017.09.11.14.41.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 14:41:09 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=rEc+ZYAY71Sv7Tb2r118v5tUX3rzzqfIZQYiGVYhGRw=;\n\tb=sGdsgYeD8V70Gt15+pZiCrU6MoJQAT/Ij6GkhEKONOK3d9dnxu9X6jTlG1kSDZgfOP\n\tTD1OBZtt2gTSZDKY8aRwHubxgx1+mpLxn4BrFk/FcEOr4t+yDMznb80PB1JYFR+nM8kL\n\teV4nxUYQNisIGsjkAkSgMLeURfTFnujYQF7OhzubF9F/w90/q8YloPWwypLxkCAUHZrg\n\t84iLEi28G6rOKJAa8RjwJFDEMYir31IwFadfejg1gFyi80jBHzRR5MLtJh3/xKrSOWqT\n\tOZTMm+hmEywUNl6aTe0oYNA4l/mr+buBVTQiaY3mjJUDvBWB/PO+EbV3Qv4Y8Pz8ewkD\n\tFZoA==","X-Gm-Message-State":"AHPjjUh3wRf0WtK2BdS1zJYF8xG6iLktjtJrtaqMso2BtwrNGFNzB/J2\n\tK9JgYiQW0jNqhA==","X-Google-Smtp-Source":"AOwi7QBwm0soLwEI8+Qi4vmReBs+ak6NPMPQQqf2jP0/blQuCPpCkFtZyj5cbb9Gnty6Mdg+eKqpYQ==","X-Received":"by 10.202.173.11 with SMTP id w11mr11622483oie.239.1505166070252;\n\tMon, 11 Sep 2017 14:41:10 -0700 (PDT)","Date":"Mon, 11 Sep 2017 16:41:09 -0500","From":"Rob Herring <robh@kernel.org>","To":"Tony Lindgren <tony@atomide.com>","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson <bcousson@baylibre.com>, devicetree@vger.kernel.org,\n\tLiam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,\n\tMark Rutland <mark.rutland@arm.com>, Peter Ujfalusi\n\t<peter.ujfalusi@ti.com>","Subject":"Re: [PATCH 06/17] ARM: dts: Add missing slimbus node and binding for\n\tomap4","Message-ID":"<20170911214109.35o4anadormbvyrc@rob-hp-laptop>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-7-tony@atomide.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830151953.30856-7-tony@atomide.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]