[{"id":1766578,"web_url":"http://patchwork.ozlabs.org/comment/1766578/","msgid":"<20170911213924.eancjdiiauluejgl@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T21:39:24","subject":"Re: [PATCH 05/17] ARM: dts: Add missing smartreflex node and binding\n\tfor omap4","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 08:19:41AM -0700, Tony Lindgren wrote:\n> We are missing smartreflex device tree nodes for omap4 with\n> their related \"ti,hwmods\" properties that the SoC interconnect\n> code needs.\n> \n> Note that this will only show up as a bug with \"doesn't have\n> mpu register target base\" boot errors when the legacy platform\n> data is removed.\n> \n> And since we're missing the device tree binding for smartreflex,\n> let's also add it and document the existing omap3 use too.\n> \n> Note that the related driver also needs to be updated to probe\n> using device tree and get the platform data passed to it using\n> auxdata with arch/arm/mach-omap2/pdata-quirks.c.\n> \n> Cc: Mark Rutland \n> Cc: Nishanth Menon \n> Cc: Rafael J. Wysocki \n> Cc: Rob Herring \n> Cc: Tero Kristo \n> Signed-off-by: Tony Lindgren \n> ---\n> .../devicetree/bindings/power/ti-smartreflex.txt | 47 ++++++++++++++++++++++\n> arch/arm/boot/dts/omap4.dtsi | 21 ++++++++++\n> 2 files changed, 68 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/power/ti-smartreflex.txt\n> \n> diff --git a/Documentation/devicetree/bindings/power/ti-smartreflex.txt b/Documentation/devicetree/bindings/power/ti-smartreflex.txt\n> new file mode 100644\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/power/ti-smartreflex.txt\n> @@ -0,0 +1,47 @@\n> +Texas Instruments SmartReflex binding\n> +\n> +SmartReflex is used to set and adjust the SoC operating points.\n> +\n> +\n> +Required properties:\n> +\n> +compatible: Shall be one of the following:\n> +\t \"ti,omap3-smartreflex-core\"\n> +\t \"ti,omap3-smartreflex-iva\"\n> +\t \"ti,omap4-smartreflex-core\"\n> +\t \"ti,omap4-smartreflex-mpu\"\n> +\t \"ti,omap4-smartreflex-iva\"\n> +\n> +reg: Shall contain the device instance IO range\n> +\n> +interrupts: Shall contain the device instance interrupt\n> +\n> +\n> +Optional properties:\n> +\n> +ti,hwmods: Shall contain the TI interconnect module name if needed\n> +\t by the SoC\n> +\n> +\n> +Example:\n> +\n> +\tsmartreflex_iva: smartreflex@4a0db000 {\n> +\t\tcompatible = \"ti,omap4-smartreflex-iva\";\n> +\t\treg = <0x4a0db000 0x80>;\n> +\t\tinterrupts = ;\n> +\t\tti,hwmods = \"smartreflex_iva\";\n> +\t};\n> +\n> +\tsmartreflex_core: smartreflex4a0dd000 {\n ^ missing '@'\n\n> +\t\tcompatible = \"ti,omap4-smartreflex-core\";\n> +\t\treg = <0x4a0dd000 0x80>;\n> +\t\tinterrupts = ;\n> +\t\tti,hwmods = \"smartreflex_core\";\n> +\t};\n> +\n> +\tsmartreflex_mpu: smartreflex@4a0d9000 {\n> +\t\tcompatible = \"ti,omap4-smartreflex-mpu\";\n> +\t\treg = <0x4a0d9000 0x80>;\n> +\t\tinterrupts = ;\n> +\t\tti,hwmods = \"smartreflex_mpu\";\n> +\t};\n> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi\n> --- a/arch/arm/boot/dts/omap4.dtsi\n> +++ b/arch/arm/boot/dts/omap4.dtsi\n> @@ -442,6 +442,27 @@\n> \t\t\tclock-frequency = <48000000>;\n> \t\t};\n> \n> +\t\tsmartreflex_iva: smartreflex@4a0db000 {\n> +\t\t\tcompatible = \"ti,omap4-smartreflex-iva\";\n> +\t\t\treg = <0x4a0db000 0x80>;\n> +\t\t\tinterrupts = ;\n> +\t\t\tti,hwmods = \"smartreflex_iva\";\n> +\t\t};\n> +\n> +\t\tsmartreflex_core: smartreflex4a0dd000 {\n\nDitto. Build with W=2 and you should get a warning here.\n\nWith that fixed,\n\nAcked-by: Rob Herring \n\n> +\t\t\tcompatible = \"ti,omap4-smartreflex-core\";\n> +\t\t\treg = <0x4a0dd000 0x80>;\n> +\t\t\tinterrupts = ;\n> +\t\t\tti,hwmods = \"smartreflex_core\";\n> +\t\t};\n> +\n> +\t\tsmartreflex_mpu: smartreflex@4a0d9000 {\n> +\t\t\tcompatible = \"ti,omap4-smartreflex-mpu\";\n> +\t\t\treg = <0x4a0d9000 0x80>;\n> +\t\t\tinterrupts = ;\n> +\t\t\tti,hwmods = \"smartreflex_mpu\";\n> +\t\t};\n> +\n> \t\thwspinlock: spinlock@4a0f6000 {\n> \t\t\tcompatible = \"ti,omap4-hwspinlock\";\n> \t\t\treg = <0x4a0f6000 0x1000>;\n> -- \n> 2.14.1\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrhCN6fcNz9sDB\n\tfor ;\n\tTue, 12 Sep 2017 07:39:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750911AbdIKVj1 (ORCPT\n\t);\n\tMon, 11 Sep 2017 17:39:27 -0400","from mail-oi0-f67.google.com ([209.85.218.67]:37763 \"EHLO\n\tmail-oi0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750853AbdIKVj0 (ORCPT\n\t); Mon, 11 Sep 2017 17:39:26 -0400","by mail-oi0-f67.google.com with SMTP id l9so4287979oib.4;\n\tMon, 11 Sep 2017 14:39:26 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tx192sm8742823oix.50.2017.09.11.14.39.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 14:39:24 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=4uruqdwc4cOJefnTKYRwPnL11b5xooxdLLnQsjvnYqk=;\n\tb=kunDQEBcWel2878b38ty6Izbb5mtLt7EJiV/RQLH9bDXtTbv+CGZEjhiVCUvvHZaFB\n\tPDUyLDfnmgHJ563rS5EvYWk3a72bddiMkr75mQt/61+LctKQuHVRTYbXZegH/ReuBALR\n\t5cw/gszdqKw+DSkpIGDuJLi9PqPPAS022RmSYWyBWGu5c4YCJwJugx72n1+ZY/900SDz\n\tpL6wye8ea7bFs/RggLAySHoWF5HSgufutQd1ZRZ6L3PnR5UigYMY5jwMTXNVeDzIog/4\n\t/cjrOe5RIMtO+Y68Ujglchj5/MVLyFHqL+JsM/TMKOfb4Iy6VmqusCkdZ71RdQTLObkM\n\t4g6A==","X-Gm-Message-State":"AHPjjUi9xQlDCeCSQTopVFmuSavGvL97ZLE1sEzetgeSZMqxrafRKuE4\n\tjzTUMa5evRSKbw==","X-Google-Smtp-Source":"AOwi7QB0UKwTSYcce9GGgDkb9ANlMaMv9VpOBk//zUhXkhdPEvOay2SeFDzzvyd+KU8b1eafswrTbg==","X-Received":"by 10.202.206.70 with SMTP id e67mr11977961oig.118.1505165965518;\n\tMon, 11 Sep 2017 14:39:25 -0700 (PDT)","Date":"Mon, 11 Sep 2017 16:39:24 -0500","From":"Rob Herring ","To":"Tony Lindgren ","Cc":"linux-omap@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?=\n\tCousson , devicetree@vger.kernel.org,\n\tMark Rutland , Nishanth Menon ,\n\t\"Rafael J . Wysocki\" , \n\tTero Kristo ","Subject":"Re: [PATCH 05/17] ARM: dts: Add missing smartreflex node and binding\n\tfor omap4","Message-ID":"<20170911213924.eancjdiiauluejgl@rob-hp-laptop>","References":"<20170830151953.30856-1-tony@atomide.com>\n\t<20170830151953.30856-6-tony@atomide.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830151953.30856-6-tony@atomide.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]