[{"id":1772714,"web_url":"http://patchwork.ozlabs.org/comment/1772714/","msgid":"","list_archive_url":null,"date":"2017-09-21T11:23:44","subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"I really need Alexander Shiyan to look at this patch.\n\nThe way i percieve it, .set is NULL if the chip does not\nsupport output.\n\nWe should print the right error messages and bail out\nif the user is anyway trying to set a line like that.\n\nYours,\nLinus Walleij\n\nOn Wed, Aug 30, 2017 at 4:50 PM, Vladimir Murzin\n wrote:\n\n> \"set\" callback is optional and can be NULL, instead use chip->set\n> which always points at proper callback function.\n>\n> Fixes 2c341d62eb4b (\"gpio: syscon: add soc specific callback to assign output value\")\n>\n> Signed-off-by: Vladimir Murzin \n> ---\n> drivers/gpio/gpio-syscon.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c\n> index 537cec7..cf88a0b 100644\n> --- a/drivers/gpio/gpio-syscon.c\n> +++ b/drivers/gpio/gpio-syscon.c\n> @@ -122,7 +122,7 @@ static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val)\n> BIT(offs % SYSCON_REG_BITS));\n> }\n>\n> - priv->data->set(chip, offset, val);\n> + chip->set(chip, offset, val);\n>\n> return 0;\n> }\n> --\n> 1.9.1\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XTNk9bHT\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyZ4j3jwzz9t3v\n\tfor ;\n\tThu, 21 Sep 2017 21:24:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751940AbdIULXs (ORCPT );\n\tThu, 21 Sep 2017 07:23:48 -0400","from mail-it0-f50.google.com ([209.85.214.50]:46733 \"EHLO\n\tmail-it0-f50.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751948AbdIULXp (ORCPT\n\t); Thu, 21 Sep 2017 07:23:45 -0400","by mail-it0-f50.google.com with SMTP id d192so257585itd.1\n\tfor ;\n\tThu, 21 Sep 2017 04:23:45 -0700 (PDT)","by 10.79.164.78 with HTTP; Thu, 21 Sep 2017 04:23:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=9WMhB+mDvql7JZgWgYYP2x5FYUA9Ia438fGcTfsJFA8=;\n\tb=XTNk9bHTrDpTTai88OwHIAQSqA+Dh4N8bnCuHXw1wqvdbCJcbPD710B9P2HKqo7c1Q\n\t8LPmwSOZ2srSYOk0HSWNVIPoDgO+iSsS0e5Uptq2BTgX1BsT52yFEKmNIkls12V7nwjo\n\tNMhnvA5tCb7djk5HdGuyLtZ1ZgrudRLa2hH3U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=9WMhB+mDvql7JZgWgYYP2x5FYUA9Ia438fGcTfsJFA8=;\n\tb=gy1OaH28EYm24NSG8NCsDrNhA+R5Vt7K24IoXzuRDUYSSbyxL7e1DCoVA69AptdRFy\n\td0HQxXeKTd7QBCu1aHHBHNb04QKBmwbkJdLI132PApQ4+VaEV2xQFOeo3yFoOsZZLfqb\n\tJvgLXChJr0zr6rvZPY7aFXCNlmLdOz0YpuoWfcGmpTqN9pGak3HFMLPVUXd4/QD6Kz95\n\tfMq5t58bnyQe4hl5ZDon0jDVLZxJMe3dbWBBd211b1zZ2xMd4AxKaISr9iwuAkU2XPX2\n\tQlsdA7UzMoJDJPwiuNeSdSr7vV2vPfbPd2QuGjLyudM8HpK0+C7tC8Q65TQ4zPgJJGJB\n\tcgig==","X-Gm-Message-State":"AHPjjUgAEYuSEBmJ7mNlIeWz9t3I68aed0ZTepx39Ohe2MqcII0Wltfj\n\txzb+u7siEZDNflpnSh5tUDRYRfsqvmzTqZZ9jXOOEiAd","X-Google-Smtp-Source":"AOwi7QA8ifTJtgQQ5sGZmqJQcn0TbEFhkg0EEcvHwAvI8ceXzOWPozWrRI+T/s3IQCFxSbKHbHbe8rMh6eDlgRh0EdI=","X-Received":"by 10.36.167.5 with SMTP id a5mr848069itf.69.1505993025113; Thu,\n\t21 Sep 2017 04:23:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>","References":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>","From":"Linus Walleij ","Date":"Thu, 21 Sep 2017 13:23:44 +0200","Message-ID":"","Subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","To":"Vladimir Murzin ,\n\tAlexander Shiyan ","Cc":"\"linux-gpio@vger.kernel.org\" ,\n\tGrygorii Strashko ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1772737,"web_url":"http://patchwork.ozlabs.org/comment/1772737/","msgid":"<1505994978.366886647@f249.i.mail.ru>","list_archive_url":null,"date":"2017-09-21T11:56:18","subject":"=?utf-8?q?Re=3A_=5BPATCH=5D_gpio=3A_syscon=3A_do_not_use_raw_=22?=\n\t=?utf-8?q?set=22_callback_in_syscon=5Fgpio=5Fdir=5Fout?=","submitter":{"id":13523,"url":"http://patchwork.ozlabs.org/api/people/13523/","name":"Alexander Shiyan","email":"shc_work@mail.ru"},"content":">Четверг, 21 сентября 2017, 14:23 +03:00 от Linus Walleij :\n>\n>I really need Alexander Shiyan to look at this patch.\n>\n>The way i percieve it, .set is NULL if the chip does not\n>support output.\n>\n>We should print the right error messages and bail out\n>if the user is anyway trying to set a line like that.\n\nHello.\n\nUsing \"chip->set\", instead of \"priv->data->set\", is more proper way on my opinion.\nHowever, if the driver is not configured for output, the any errors should not occur in any case.\n\n>On Wed, Aug 30, 2017 at 4:50 PM, Vladimir Murzin\n>< vladimir.murzin@arm.com > wrote:\n>\n>> \"set\" callback is optional and can be NULL, instead use chip->set\n>> which always points at proper callback function.\n>>\n>> Fixes 2c341d62eb4b (\"gpio: syscon: add soc specific callback to assign output value\")\n>>\n>> Signed-off-by: Vladimir Murzin < vladimir.murzin@arm.com >\n>> ---\n>> drivers/gpio/gpio-syscon.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c\n>> index 537cec7..cf88a0b 100644\n>> --- a/drivers/gpio/gpio-syscon.c\n>> +++ b/drivers/gpio/gpio-syscon.c\n>> @@ -122,7 +122,7 @@ static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val)\n>> BIT(offs % SYSCON_REG_BITS));\n>> }\n>>\n>> - priv->data->set(chip, offset, val);\n>> + chip->set(chip, offset, val);\n>>\n>> return 0;\n>> }\n\n---","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mail.ru header.i=@mail.ru header.b=\"ojsgJBNw\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=mail.ru header.i=@mail.ru header.b=\"ojsgJBNw\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyZp30l2Rz9s5L\n\tfor ;\n\tThu, 21 Sep 2017 21:56:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751773AbdIUL40 (ORCPT );\n\tThu, 21 Sep 2017 07:56:26 -0400","from fallback5.mail.ru ([94.100.181.253]:49596 \"EHLO\n\tfallback.mail.ru\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751768AbdIUL4Z (ORCPT\n\t); Thu, 21 Sep 2017 07:56:25 -0400","from [10.161.45.13] (port=57686 helo=f249.i.mail.ru)\n\tby fallback5.mail.ru with esmtp (envelope-from )\n\tid 1dv05f-0007Xt-0u\n\tfor linux-gpio@vger.kernel.org; Thu, 21 Sep 2017 14:56:23 +0300","by f249.i.mail.ru with local (envelope-from )\n\tid 1dv05a-0006pW-Ic; Thu, 21 Sep 2017 14:56:18 +0300","by e.mail.ru with HTTP;\n Thu, 21 Sep 2017 14:56:18 +0300"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru;\n\ts=mail2; \n\th=References:In-Reply-To:Content-Transfer-Encoding:Content-Type:Message-ID:Reply-To:Date:MIME-Version:Subject:Cc:To:From;\n\tbh=CMHk/33RPxj2DSvyX768MZjYxjF8p+w2yR/Ke70ZAbo=; \n\tb=ojsgJBNwbK2fioBXXxDorWlWIFY7GQgUfbVWITuE0pfICTGGw6k69iExz1fDwmMT/NUtFUQKXkMfqChCPGdki/ws1wn6GJjPkka21H+aPZzicWWuxyH62wJwKoccZhmrV+Ug7T9Wzh7MOQB0tg8A77IIqsxHReWxeevNxpc8iFw=;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru;\n\ts=mail2; \n\th=References:In-Reply-To:Content-Transfer-Encoding:Content-Type:Message-ID:Reply-To:Date:MIME-Version:Subject:Cc:To:From;\n\tbh=CMHk/33RPxj2DSvyX768MZjYxjF8p+w2yR/Ke70ZAbo=; \n\tb=ojsgJBNwbK2fioBXXxDorWlWIFY7GQgUfbVWITuE0pfICTGGw6k69iExz1fDwmMT/NUtFUQKXkMfqChCPGdki/ws1wn6GJjPkka21H+aPZzicWWuxyH62wJwKoccZhmrV+Ug7T9Wzh7MOQB0tg8A77IIqsxHReWxeevNxpc8iFw=;"],"From":"=?utf-8?q?Alexander_Shiyan?= ","To":"=?utf-8?q?Linus_Walleij?= ","Cc":"=?utf-8?q?linux-gpio=40vger=2Ekernel=2Eorg?=\n\t, =?utf-8?q?Grygorii_Strashko?=\n\t, =?utf-8?q?Vladimir_Murzin?=\n\t","Subject":"=?utf-8?q?Re=3A_=5BPATCH=5D_gpio=3A_syscon=3A_do_not_use_raw_=22?=\n\t=?utf-8?q?set=22_callback_in_syscon=5Fgpio=5Fdir=5Fout?=","MIME-Version":"1.0","X-Mailer":"Mail.Ru Mailer 1.0","Date":"Thu, 21 Sep 2017 14:56:18 +0300","Reply-To":"=?utf-8?q?Alexander_Shiyan?= ","X-Priority":"3 (Normal)","Message-ID":"<1505994978.366886647@f249.i.mail.ru>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"base64","X-7FA49CB5":"0D63561A33F958A58C8FEBFC81C99FA14DE47CF01701123F8916EAA03359DA22725E5C173C3A84C309A7649CC036878F7D88DE65E84B2EA925A4AB119743A3B3C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F5D41B9178041F3E72623479134186CDE6BA297DBC24807EABDAD6C7F3747799A","X-Mailru-Sender":"504CC1E875BF3E7D64085078125A4D0F5CB675606C8B87618859DE396301584026F77D3B084DA0C2154932F8EE4318A64B85512C0703DFEA3D54A43FE36706802CA1F4C27F84AF4383FE72BCEDE54D2A6F4BFBADAAE45399B4A721A3011E896F","X-Mras":["OK","OK"],"X-Spam":"undefined","In-Reply-To":"","References":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>\n\t","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1773447,"web_url":"http://patchwork.ozlabs.org/comment/1773447/","msgid":"<7e4a2e92-1186-4bad-986e-e3cb39b9c36c@arm.com>","list_archive_url":null,"date":"2017-09-22T10:23:05","subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","submitter":{"id":65248,"url":"http://patchwork.ozlabs.org/api/people/65248/","name":"Vladimir Murzin","email":"vladimir.murzin@arm.com"},"content":"On 21/09/17 12:56, Alexander Shiyan wrote:\n>> Четверг, 21 сентября 2017, 14:23 +03:00 от Linus Walleij :\n>>\n>> I really need Alexander Shiyan to look at this patch.\n>>\n>> The way i percieve it, .set is NULL if the chip does not\n>> support output.\n>>\n>> We should print the right error messages and bail out\n>> if the user is anyway trying to set a line like that.\n> \n> Hello.\n> \n> Using \"chip->set\", instead of \"priv->data->set\", is more proper way on my opinion.\n> However, if the driver is not configured for output, the any errors should not occur in any case.\n\nSo what is conclusion on this? I agree that there is nothing broken atm, but I faced\nthe issues when I tried to use gpio-syscon to fit into my case which is very\nsimilar to those pseudo-GPIOs in drivers/mfd/vexpress-sysreg.c\n\nThanks\nVladimir\n\n> \n>> On Wed, Aug 30, 2017 at 4:50 PM, Vladimir Murzin\n>> < vladimir.murzin@arm.com > wrote:\n>>\n>>> \"set\" callback is optional and can be NULL, instead use chip->set\n>>> which always points at proper callback function.\n>>>\n>>> Fixes 2c341d62eb4b (\"gpio: syscon: add soc specific callback to assign output value\")\n>>>\n>>> Signed-off-by: Vladimir Murzin < vladimir.murzin@arm.com >\n>>> ---\n>>> drivers/gpio/gpio-syscon.c | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c\n>>> index 537cec7..cf88a0b 100644\n>>> --- a/drivers/gpio/gpio-syscon.c\n>>> +++ b/drivers/gpio/gpio-syscon.c\n>>> @@ -122,7 +122,7 @@ static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val)\n>>> BIT(offs % SYSCON_REG_BITS));\n>>> }\n>>>\n>>> - priv->data->set(chip, offset, val);\n>>> + chip->set(chip, offset, val);\n>>>\n>>> return 0;\n>>> }\n> \n> ---\n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz8gx5bLzz9sNw\n\tfor ;\n\tFri, 22 Sep 2017 20:23:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751931AbdIVKXI (ORCPT );\n\tFri, 22 Sep 2017 06:23:08 -0400","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:55950 \"EHLO\n\tfoss.arm.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751903AbdIVKXI (ORCPT );\n\tFri, 22 Sep 2017 06:23:08 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE34515A2;\n\tFri, 22 Sep 2017 03:23:07 -0700 (PDT)","from [10.1.78.249] (unknown [10.1.78.249])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tD759D3F58C; Fri, 22 Sep 2017 03:23:06 -0700 (PDT)"],"Subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","To":"Alexander Shiyan ,\n\tLinus Walleij ","Cc":"\"linux-gpio@vger.kernel.org\" ,\n\tGrygorii Strashko ","References":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>\n\t\n\t<1505994978.366886647@f249.i.mail.ru>","From":"Vladimir Murzin ","Message-ID":"<7e4a2e92-1186-4bad-986e-e3cb39b9c36c@arm.com>","Date":"Fri, 22 Sep 2017 11:23:05 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1505994978.366886647@f249.i.mail.ru>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1773604,"web_url":"http://patchwork.ozlabs.org/comment/1773604/","msgid":"","list_archive_url":null,"date":"2017-09-22T13:42:52","subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Thu, Sep 21, 2017 at 1:56 PM, Alexander Shiyan wrote:\n>>Четверг, 21 сентября 2017, 14:23 +03:00 от Linus Walleij :\n>>\n>>I really need Alexander Shiyan to look at this patch.\n>>\n>>The way i percieve it, .set is NULL if the chip does not\n>>support output.\n>>\n>>We should print the right error messages and bail out\n>>if the user is anyway trying to set a line like that.\n>\n> Hello.\n>\n> Using \"chip->set\", instead of \"priv->data->set\", is more proper way on my opinion.\n> However, if the driver is not configured for output, the any errors should not occur in any case.\n\nIs that an Acked-by?\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"G2uoZwcW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzF6R00fBz9s06\n\tfor ;\n\tFri, 22 Sep 2017 23:42:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752319AbdIVNmx (ORCPT );\n\tFri, 22 Sep 2017 09:42:53 -0400","from mail-io0-f181.google.com ([209.85.223.181]:45265 \"EHLO\n\tmail-io0-f181.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752210AbdIVNmx (ORCPT\n\t); Fri, 22 Sep 2017 09:42:53 -0400","by mail-io0-f181.google.com with SMTP id g32so3128392ioj.2\n\tfor ;\n\tFri, 22 Sep 2017 06:42:53 -0700 (PDT)","by 10.79.164.78 with HTTP; Fri, 22 Sep 2017 06:42:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=eTLS5uJiSAHwEVNlUkKPkDlKTI8ewjWIUPxCJXfUjVE=;\n\tb=G2uoZwcW2lIqwSdOBcXqm8CVawf33iTG+wmjCOajHsmRgnSWhgT0ucHsP6Y40ByjIf\n\twx82E5IzVZeBRPx4t/5nJzn74AtTfxUWiAtX8iSxg5AaWvgG4NtMkFAzAokQJMPaHeKX\n\t8kHli/BWrT3f1mmbC58dXRO0mrVxp7qIjmUC8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=eTLS5uJiSAHwEVNlUkKPkDlKTI8ewjWIUPxCJXfUjVE=;\n\tb=UWPXU+PMunB92QYnbrL0vhl0ROz+ol/RtWSlQQ4eduvYSz8VSM/9Z72kD0LsOg0EnN\n\tu0NL5L+qKQpJjJjcNZ02sQM7bBjw6yneMt70rW6UaI2k+akVttMISK6V3rbGomVW8wQs\n\tBksTPauj2Ec0YCyfv2wBCrluGxRfmxEP+S+6jVmB0we5o7hRDwGVSXNof5iGQw3Fpkez\n\tqtC2ikKmKXrJYeM6Jd8WnsjuIkudu9W5xWlIGw+tKTRoT84jACU+6Pn9exIWreofU9mV\n\tQG47yagL+g+l7eyO+WWyHF4N81Hp+WU+xROG88LHJo1ycpXmMXmH/gAzw/aRYo6fvbid\n\tfvcg==","X-Gm-Message-State":"AHPjjUjzUhL4CgK5F4j7V4pMVxwSgCXCWfU2lJHnBSp+lDvqPmgZ0x1V\n\tgjnh3kzHqILv6urkKb1R31jWA98slSHrYmIOCMj0vWY5","X-Google-Smtp-Source":"AOwi7QB7vhACl1ubrGCcAcHyOHBoW5Q3pbE2Ojh8gNarM3tN4KHUfrPLCtFpyksZyqR646+pB/TDIn1nAWOPezyRmXQ=","X-Received":"by 10.107.139.215 with SMTP id\n\tn206mr8090215iod.155.1506087772566; \n\tFri, 22 Sep 2017 06:42:52 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505994978.366886647@f249.i.mail.ru>","References":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>\n\t\n\t<1505994978.366886647@f249.i.mail.ru>","From":"Linus Walleij ","Date":"Fri, 22 Sep 2017 15:42:52 +0200","Message-ID":"","Subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","To":"Alexander Shiyan ","Cc":"\"linux-gpio@vger.kernel.org\" ,\n\tGrygorii Strashko ,\n\tVladimir Murzin ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1773607,"web_url":"http://patchwork.ozlabs.org/comment/1773607/","msgid":"","list_archive_url":null,"date":"2017-09-22T13:47:20","subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Fri, Sep 22, 2017 at 12:23 PM, Vladimir Murzin\n wrote:\n\n> I tried to use gpio-syscon to fit into my case which is very\n> similar to those pseudo-GPIOs in drivers/mfd/vexpress-sysreg.c\n\nI do not like what that driver is doing and it should not be\ntaken as inspiration.\n\nI have several times slammed down on people trying to shoehorn\nthings that are not GPIO into the GPIO subsystem just out of\nconvenience.\n\nThe question to ask is always: is this bit/line/pin really\n\"general purpose input/output\"?\n\nNot \"how can I quickly code up something that makes this\nthing work?\"\n\nSee for example drivers/leds/leds-syscon.c\nThat was my response to someone trying to first use\nsyscon-gpio on a register and then gpio-leds on top of\nthat, hilarious layers of indirection!\n\nIf the use case is MMC card detect, we need card detection\nusing syscon directly in the MMC subsystem, not hacks\nlike what the Vexpress MFD driver is doing.\n\nI have the Versatile Express in my office and one day I will\nfix up this thing.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XA8vS+Fq\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzFCb4V4Fz9s06\n\tfor ;\n\tFri, 22 Sep 2017 23:47:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752078AbdIVNrW (ORCPT );\n\tFri, 22 Sep 2017 09:47:22 -0400","from mail-it0-f51.google.com ([209.85.214.51]:49480 \"EHLO\n\tmail-it0-f51.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752070AbdIVNrV (ORCPT\n\t); Fri, 22 Sep 2017 09:47:21 -0400","by mail-it0-f51.google.com with SMTP id c195so1388066itb.4\n\tfor ;\n\tFri, 22 Sep 2017 06:47:21 -0700 (PDT)","by 10.79.164.78 with HTTP; Fri, 22 Sep 2017 06:47:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=xhUiAjYWQ171AMm7XFqr2w2vHqEo08QWMlnKkL/ffxI=;\n\tb=XA8vS+FqVA3vKorTcMJt4wNawV3JwQRPg3f2td1wZj3BbC4Xwx34z6mApbO9/YakVt\n\tg7TVjpBut2GVoxrA441nvKixJ0mdmqqmM3d5hIW+Psb6Pp7Y+fL1x/oi2o1WytRvbjt/\n\t40Fv9Xnobq0Cef6qQ3WriCRfC0C3G5sQ+NvCk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=xhUiAjYWQ171AMm7XFqr2w2vHqEo08QWMlnKkL/ffxI=;\n\tb=ncD+u2uiruZlU2yDcVptO/W2+DTM139n71RpOVLOHZv+gPH3OepETVd8YXQBkzdgGL\n\ty5Z/wdDY/Byh7BZDZ/dPIfyyRIrNEPY2PLhQparm1HBj21eMxDVYRtJR20on3qfyjc2k\n\tAc9SVBSt5lNlBut7LcJU1DprMmdlezyZRdpxg8iz5iibTqMiUj3nWbAZxzt7VORdtYOh\n\t4ZYYvJFIjVp3M160jBmDya6IhJmu6DR38cFRrughaQJMMuh7b74w6yNkCjfoDnLB0nRr\n\tsxTbMXv7hyBWlwt4NhH/mkZJZYttttHpsA2zehExWkDeRJ45O/CGV3/LGjQyp0mVUx+Y\n\t5saA==","X-Gm-Message-State":"AHPjjUg/rU/u4g4ZcWkzfEGPijR7FqlxO5WSCF5HSILx9erS7UfJzAiw\n\t89gaedKFeJqQLE1M6C9BSIt+BN3SC9vD1qPRRluGMw==","X-Google-Smtp-Source":"AOwi7QBf9vNz1K/9kuRYrJgt5C509mRYZym3WpsZJNC71PXoflqDiPN7+ObPgh5ra1a0EM0nKB/GAD2s98FPfS9DwwE=","X-Received":"by 10.36.182.78 with SMTP id d14mr6967578itj.74.1506088041335;\n\tFri, 22 Sep 2017 06:47:21 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<7e4a2e92-1186-4bad-986e-e3cb39b9c36c@arm.com>","References":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>\n\t\n\t<1505994978.366886647@f249.i.mail.ru>\n\t<7e4a2e92-1186-4bad-986e-e3cb39b9c36c@arm.com>","From":"Linus Walleij ","Date":"Fri, 22 Sep 2017 15:47:20 +0200","Message-ID":"","Subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","To":"Vladimir Murzin ","Cc":"Alexander Shiyan ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\tGrygorii Strashko ,\n\tLee Jones ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1773626,"web_url":"http://patchwork.ozlabs.org/comment/1773626/","msgid":"","list_archive_url":null,"date":"2017-09-22T14:12:06","subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","submitter":{"id":65248,"url":"http://patchwork.ozlabs.org/api/people/65248/","name":"Vladimir Murzin","email":"vladimir.murzin@arm.com"},"content":"On 22/09/17 14:47, Linus Walleij wrote:\n> On Fri, Sep 22, 2017 at 12:23 PM, Vladimir Murzin\n> wrote:\n> \n>> I tried to use gpio-syscon to fit into my case which is very\n>> similar to those pseudo-GPIOs in drivers/mfd/vexpress-sysreg.c\n> \n> I do not like what that driver is doing and it should not be\n> taken as inspiration.\n> \n> I have several times slammed down on people trying to shoehorn\n> things that are not GPIO into the GPIO subsystem just out of\n> convenience.\n> \n\nIt is why I submitted only this patch, if you think there is no\nissue I'm fine :)\n\n> The question to ask is always: is this bit/line/pin really\n> \"general purpose input/output\"?\n\nIn my case definitely it is not. These are some bits which \ncontrol simple CLCD panel [1]. The only reason I've looked\ninto gpio-syscon is that I saw you forced keystone bits in\nthere with that \"it is not general purpose\" reason, but\nfrom your response it seems it is not the right place for\nsuch stuff.\n\n> \n> Not \"how can I quickly code up something that makes this\n> thing work?\"\n> \n> See for example drivers/leds/leds-syscon.c\n> That was my response to someone trying to first use\n> syscon-gpio on a register and then gpio-leds on top of\n> that, hilarious layers of indirection!\n> \n> If the use case is MMC card detect, we need card detection\n> using syscon directly in the MMC subsystem, not hacks\n> like what the Vexpress MFD driver is doing.\n\nNo, it is not MMC card detect.\n\n> \n> I have the Versatile Express in my office and one day I will\n> fix up this thing.\n\nUnderstood.\n\n[1] http://infocenter.arm.com/help/topic/com.arm.doc.dai0399c/index.html#arm_toc19 (FPGAIO->MISC)\n\nCheers\nVladimir\n\n> \n> Yours,\n> Linus Walleij\n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzFmB5wNbz9t3h\n\tfor ;\n\tSat, 23 Sep 2017 00:12:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752259AbdIVOMJ (ORCPT );\n\tFri, 22 Sep 2017 10:12:09 -0400","from foss.arm.com ([217.140.101.70]:57894 \"EHLO foss.arm.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752148AbdIVOMJ (ORCPT );\n\tFri, 22 Sep 2017 10:12:09 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FB9380D;\n\tFri, 22 Sep 2017 07:12:09 -0700 (PDT)","from [10.1.78.249] (unknown [10.1.78.249])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t38BD33F53D; Fri, 22 Sep 2017 07:12:08 -0700 (PDT)"],"Subject":"Re: [PATCH] gpio: syscon: do not use raw \"set\" callback in\n\tsyscon_gpio_dir_out","To":"Linus Walleij ","Cc":"Alexander Shiyan ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\tGrygorii Strashko ,\n\tLee Jones ","References":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>\n\t\n\t<1505994978.366886647@f249.i.mail.ru>\n\t<7e4a2e92-1186-4bad-986e-e3cb39b9c36c@arm.com>\n\t","From":"Vladimir Murzin ","Message-ID":"","Date":"Fri, 22 Sep 2017 15:12:06 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1774415,"web_url":"http://patchwork.ozlabs.org/comment/1774415/","msgid":"<1506316872.695438692@f503.i.mail.ru>","list_archive_url":null,"date":"2017-09-25T05:21:12","subject":"=?utf-8?q?Re=3A_=5BPATCH=5D_gpio=3A_syscon=3A_do_not_use_raw_=22?=\n\t=?utf-8?q?set=22_callback_in_syscon=5Fgpio=5Fdir=5Fout?=","submitter":{"id":13523,"url":"http://patchwork.ozlabs.org/api/people/13523/","name":"Alexander Shiyan","email":"shc_work@mail.ru"},"content":">Пятница, 22 сентября 2017, 16:42 +03:00 от Linus Walleij :\n>\n>On Thu, Sep 21, 2017 at 1:56 PM, Alexander Shiyan < shc_work@mail.ru > wrote:\n>>>Четверг, 21 сентября 2017, 14:23 +03:00 от Linus Walleij < linus.walleij@linaro.org >:\n>>>\n>>>I really need Alexander Shiyan to look at this patch.\n>>>\n>>>The way i percieve it, .set is NULL if the chip does not\n>>>support output.\n>>>\n>>>We should print the right error messages and bail out\n>>>if the user is anyway trying to set a line like that.\n>>\n>> Hello.\n>>\n>> Using \"chip->set\", instead of \"priv->data->set\", is more proper way on my opinion.\n>> However, if the driver is not configured for output, the any errors should not occur in any case.\n>\n>Is that an Acked-by?\nYes, if this need.\n\nAcked-by: Alexander Shiyan \n---","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mail.ru header.i=@mail.ru header.b=\"glJs2Ifn\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=mail.ru header.i=@mail.ru header.b=\"glJs2Ifn\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0srL3VlWz9t4B\n\tfor ;\n\tMon, 25 Sep 2017 15:21:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753372AbdIYFVV (ORCPT );\n\tMon, 25 Sep 2017 01:21:21 -0400","from fallback7.mail.ru ([94.100.181.128]:57110 \"EHLO\n\tfallback.mail.ru\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1753121AbdIYFVU (ORCPT\n\t); Mon, 25 Sep 2017 01:21:20 -0400","from [10.161.122.33] (port=55272 helo=f503.i.mail.ru)\n\tby fallback7.mail.ru with esmtp (envelope-from )\n\tid 1dwLpV-00060o-4v\n\tfor linux-gpio@vger.kernel.org; Mon, 25 Sep 2017 08:21:17 +0300","by f503.i.mail.ru with local (envelope-from )\n\tid 1dwLpQ-0004tX-PB; Mon, 25 Sep 2017 08:21:13 +0300","by e.mail.ru with HTTP;\n Mon, 25 Sep 2017 08:21:12 +0300"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru;\n\ts=mail2; \n\th=References:In-Reply-To:Content-Transfer-Encoding:Content-Type:Message-ID:Reply-To:Date:MIME-Version:Subject:Cc:To:From;\n\tbh=AGDUeOoQ/r0Ler24dbq2H+iUCosz8+fvAul/zbD2yP0=; \n\tb=glJs2Ifn9IH9s4Gm3uZo3Ceek5/j81w2wRKP6cf5NwvPU7lkFBbQp6BiV+57eQCtqrVxRlGjreqzNwUK0Ze5uPd8p3nCuWAzLwOTqNQ+VqVd92DOG4M5TDVSAmwR7gjnCbQror+3pLxVtGPchUDFrTC1dl59s5rlQ7B7uYjlbh4=;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru;\n\ts=mail2; \n\th=References:In-Reply-To:Content-Transfer-Encoding:Content-Type:Message-ID:Reply-To:Date:MIME-Version:Subject:Cc:To:From;\n\tbh=AGDUeOoQ/r0Ler24dbq2H+iUCosz8+fvAul/zbD2yP0=; \n\tb=glJs2Ifn9IH9s4Gm3uZo3Ceek5/j81w2wRKP6cf5NwvPU7lkFBbQp6BiV+57eQCtqrVxRlGjreqzNwUK0Ze5uPd8p3nCuWAzLwOTqNQ+VqVd92DOG4M5TDVSAmwR7gjnCbQror+3pLxVtGPchUDFrTC1dl59s5rlQ7B7uYjlbh4=;"],"From":"=?utf-8?q?Alexander_Shiyan?= ","To":"=?utf-8?q?Linus_Walleij?= ","Cc":"=?utf-8?q?linux-gpio=40vger=2Ekernel=2Eorg?=\n\t, =?utf-8?q?Grygorii_Strashko?=\n\t, =?utf-8?q?Vladimir_Murzin?=\n\t","Subject":"=?utf-8?q?Re=3A_=5BPATCH=5D_gpio=3A_syscon=3A_do_not_use_raw_=22?=\n\t=?utf-8?q?set=22_callback_in_syscon=5Fgpio=5Fdir=5Fout?=","MIME-Version":"1.0","X-Mailer":"Mail.Ru Mailer 1.0","Date":"Mon, 25 Sep 2017 08:21:12 +0300","Reply-To":"=?utf-8?q?Alexander_Shiyan?= ","X-Priority":"3 (Normal)","Message-ID":"<1506316872.695438692@f503.i.mail.ru>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"base64","X-7FA49CB5":"0D63561A33F958A5FA490408FB9F44A51CD648FD6213050F1F74D8C0B1237850725E5C173C3A84C309A7649CC036878F04CEC972E39550973218473BE5707D41C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F8DB212830C5B42F72623479134186CDE6BA297DBC24807EABDAD6C7F3747799A","X-Mailru-Sender":"504CC1E875BF3E7D64085078125A4D0FEBF1C33663FC9DAD410E04E82CB05AAD75BFCD32993F4455750778B24A6F60B94B85512C0703DFEA3D54A43FE36706802CA1F4C27F84AF4383FE72BCEDE54D2A6F4BFBADAAE45399B4A721A3011E896F","X-Mras":["OK","OK"],"X-Spam":"undefined","In-Reply-To":"","References":"<1504104641-8369-1-git-send-email-vladimir.murzin@arm.com>\n\t<1505994978.366886647@f249.i.mail.ru>\n\t","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]