[{"id":1760228,"web_url":"http://patchwork.ozlabs.org/comment/1760228/","msgid":"","list_archive_url":null,"date":"2017-08-30T14:44:53","subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non\n\timplemented cpu models","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 16:26, Igor Mammedov wrote:\n> only TODO escaped defines were meant to be removed,\n> but not TODO_USER_ONLY which are compiled in case of\n> *-user targets.\n> \n> So retirn back \"440\" model removed by mistake\n> \n> Spotted-by: Thomas Huth \n> Signed-off-by: Igor Mammedov \n> ---\n> target/ppc/cpu-models.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\n> index 611fc1b..08fb34b 100644\n> --- a/target/ppc/cpu-models.c\n> +++ b/target/ppc/cpu-models.c\n> @@ -150,6 +150,10 @@\n> POWERPC_DEF(\"x2vp20\", CPU_POWERPC_X2VP20, 405,\n> NULL)\n> /* PowerPC 440 family */\n> +#if defined(TODO_USER_ONLY)\n> + POWERPC_DEF(\"440\", CPU_POWERPC_440, 440GP,\n> + \"Generic PowerPC 440\")\n> +#endif\n> /* PowerPC 440 cores */\n> POWERPC_DEF(\"440-xilinx\", CPU_POWERPC_440_XILINX, 440x5,\n> \"PowerPC 440 Xilinx 5\")\n> \n\nWith this fixup patch added:\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7bM2R4Rz9s9Y\n\tfor ;\n\tThu, 31 Aug 2017 00:45:35 +1000 (AEST)","from localhost ([::1]:50962 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4FJ-0005pb-5b\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:45:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48995)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn4En-0005hm-MB\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:45:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn4El-0006s0-3Y\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:45:01 -0400","from mx1.redhat.com ([209.132.183.28]:35418)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn4Ek-0006rI-Sy; Wed, 30 Aug 2017 10:44:59 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6EBF281243;\n\tWed, 30 Aug 2017 14:44:57 +0000 (UTC)","from [10.36.116.68] (ovpn-116-68.ams2.redhat.com [10.36.116.68])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 95C969B523;\n\tWed, 30 Aug 2017 14:44:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6EBF281243","To":"Igor Mammedov , qemu-devel@nongnu.org","References":"<1504099475-241036-9-git-send-email-imammedo@redhat.com>\n\t<1504103170-259479-1-git-send-email-imammedo@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Wed, 30 Aug 2017 16:44:53 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504103170-259479-1-git-send-email-imammedo@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 30 Aug 2017 14:44:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non\n\timplemented cpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762617,"web_url":"http://patchwork.ozlabs.org/comment/1762617/","msgid":"<20170904111054.GB2735@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-04T11:10:54","subject":"Re: [Qemu-devel] [PATCH v2 9/8] fixup! ppc: remove non implemented\n\tcpu models","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Wed, Aug 30, 2017 at 04:26:10PM +0200, Igor Mammedov wrote:\n> only TODO escaped defines were meant to be removed,\n> but not TODO_USER_ONLY which are compiled in case of\n> *-user targets.\n> \n> So retirn back \"440\" model removed by mistake\n> \n> Spotted-by: Thomas Huth \n> Signed-off-by: Igor Mammedov \n\nI've applied patch 8 with this change folded in, so as not to break\nbisect.\n\n> ---\n> target/ppc/cpu-models.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\n> index 611fc1b..08fb34b 100644\n> --- a/target/ppc/cpu-models.c\n> +++ b/target/ppc/cpu-models.c\n> @@ -150,6 +150,10 @@\n> POWERPC_DEF(\"x2vp20\", CPU_POWERPC_X2VP20, 405,\n> NULL)\n> /* PowerPC 440 family */\n> +#if defined(TODO_USER_ONLY)\n> + POWERPC_DEF(\"440\", CPU_POWERPC_440, 440GP,\n> + \"Generic PowerPC 440\")\n> +#endif\n> /* PowerPC 440 cores */\n> POWERPC_DEF(\"440-xilinx\", CPU_POWERPC_440_XILINX, 440x5,\n> \"PowerPC 440 Xilinx 5\")","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"ogN0oqFd\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm90h333Zz9t2c\n\tfor ;\n\tMon, 4 Sep 2017 22:59:32 +1000 (AEST)","from localhost ([::1]:60450 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doqyQ-0005pY-Gw\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 08:59:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33966)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doqqD-0007ay-70\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:51:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doqq6-0005kY-IQ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:50:59 -0400","from ozlabs.org ([103.22.144.67]:48529)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1doqq5-0005iY-Ow; Mon, 04 Sep 2017 08:50:54 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xm8pg1fN1z9t2c; Mon, 4 Sep 2017 22:50:51 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504529451;\n\tbh=HsIYJ1UWHUs8NkE3J5AIYLZjoNW2Txjh8H6hCg5zprQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ogN0oqFdYMNXBssueDG1sCwqFhBcXl11oSHnXuow/HxvZ9wHNDGziXzB472O5zice\n\tqzpiu2dno1ljL9dI11c4bwnX2blQBes5xNyCMGgM6j7SRqneBW0yrPC6hkYJeUSIM3\n\tbA7BKtX3MGdlqZus74eH3O6AExz2ZmhgTFj+1YpA=","Date":"Mon, 4 Sep 2017 21:10:54 +1000","From":"David Gibson ","To":"Igor Mammedov ","Message-ID":"<20170904111054.GB2735@umbus.fritz.box>","References":"<1504099475-241036-9-git-send-email-imammedo@redhat.com>\n\t<1504103170-259479-1-git-send-email-imammedo@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"dTy3Mrz/UPE2dbVg\"","Content-Disposition":"inline","In-Reply-To":"<1504103170-259479-1-git-send-email-imammedo@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH v2 9/8] fixup! ppc: remove non implemented\n\tcpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762623,"web_url":"http://patchwork.ozlabs.org/comment/1762623/","msgid":"<20170904150524.7fdcc0a0@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-04T13:05:24","subject":"Re: [Qemu-devel] [PATCH v2 9/8] fixup! ppc: remove non implemented\n\tcpu models","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 4 Sep 2017 21:10:54 +1000\nDavid Gibson wrote:\n\n> On Wed, Aug 30, 2017 at 04:26:10PM +0200, Igor Mammedov wrote:\n> > only TODO escaped defines were meant to be removed,\n> > but not TODO_USER_ONLY which are compiled in case of\n> > *-user targets.\n> > \n> > So retirn back \"440\" model removed by mistake\n> > \n> > Spotted-by: Thomas Huth \n> > Signed-off-by: Igor Mammedov \n> \n> I've applied patch 8 with this change folded in, so as not to break\n> bisect.\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm9Cb2Zt7z9sR9\n\tfor ;\n\tMon, 4 Sep 2017 23:08:59 +1000 (AEST)","from localhost ([::1]:33334 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dor7Z-0005Xh-5B\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 09:08:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49089)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dor5v-0004qJ-94\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:08:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dor4B-0003VZ-Tz\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:07:15 -0400","from mx1.redhat.com ([209.132.183.28]:38594)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dor4B-0003UD-Mf; Mon, 04 Sep 2017 09:05:27 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 92375C054914;\n\tMon, 4 Sep 2017 13:05:26 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.241])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6C65477DE1;\n\tMon, 4 Sep 2017 13:05:25 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 92375C054914","Date":"Mon, 4 Sep 2017 15:05:24 +0200","From":"Igor Mammedov ","To":"David Gibson ","Message-ID":"<20170904150524.7fdcc0a0@nial.brq.redhat.com>","In-Reply-To":"<20170904111054.GB2735@umbus.fritz.box>","References":"<1504099475-241036-9-git-send-email-imammedo@redhat.com>\n\t<1504103170-259479-1-git-send-email-imammedo@redhat.com>\n\t<20170904111054.GB2735@umbus.fritz.box>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tMon, 04 Sep 2017 13:05:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 9/8] fixup! ppc: remove non implemented\n\tcpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]