[{"id":1760193,"web_url":"http://patchwork.ozlabs.org/comment/1760193/","msgid":"<20170830161327.4b199e9a.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T14:13:27","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 30 Aug 2017 15:39:03 +0200\nThomas Huth wrote:\n\n> The \"slow\" ivshmem-tests currently fail when they are running on a\n> big endian host:\n> \n> $ uname -m\n> ppc64\n> $ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/ivshmem-test -m slow\n> /x86_64/ivshmem/single: OK\n> /x86_64/ivshmem/hotplug: OK\n> /x86_64/ivshmem/memdev: OK\n> /x86_64/ivshmem/pair: OK\n> /x86_64/ivshmem/server-msi: qemu-system-x86_64:\n> -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid ID message\n> Broken pipe\n> \n> The problem is that the server side code in ivshmem_server_send_one_msg()\n> correctly translates all messages IDs into little endian 64-bit values,\n> but the client side code in the ivshmem_recv_msg() function does not swap\n> the byte order back. Fix it by passing the value through le64_to_cpu().\n> \n> Signed-off-by: Thomas Huth \n> ---\n> hw/misc/ivshmem.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c\n> index 47a015f..b3ef3ec 100644\n> --- a/hw/misc/ivshmem.c\n> +++ b/hw/misc/ivshmem.c\n> @@ -653,7 +653,7 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd, Error **errp)\n> } while (n < sizeof(msg));\n> \n> *pfd = qemu_chr_fe_get_msgfd(&s->server_chr);\n> - return msg;\n> + return le64_to_cpu(msg);\n> }\n> \n> static void ivshmem_recv_setup(IVShmemState *s, Error **errp)\n\nThis fixes the \"invalid ID message\" problem on s390x for me as well,\nand I run now into the same error as on x86 (which you also have a fix\nfor IIRC), so I guess this is\n\nTested-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj6v60S0Lz9s8J\n\tfor ;\n\tThu, 31 Aug 2017 00:14:08 +1000 (AEST)","from localhost ([::1]:50821 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn3kr-00086k-U3\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:14:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41469)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn3kU-00086T-21\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:13:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn3kP-0003gi-P3\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:13:41 -0400","from mx1.redhat.com ([209.132.183.28]:51104)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn3kP-0003gZ-Hz; Wed, 30 Aug 2017 10:13:37 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5FD357F755;\n\tWed, 30 Aug 2017 14:13:36 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8617387F86;\n\tWed, 30 Aug 2017 14:13:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5FD357F755","Date":"Wed, 30 Aug 2017 16:13:27 +0200","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20170830161327.4b199e9a.cohuck@redhat.com>","In-Reply-To":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 30 Aug 2017 14:13:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , qemu-trivial@nongnu.org,\n\tqemu-devel@nongnu.org, Philippe =?utf-8?q?Mathieu-Daud=C3=A9?=\n\t, =?utf-8?q?Marc-Andr=C3=A9?=\n\tLureau , David Gibson\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760221,"web_url":"http://patchwork.ozlabs.org/comment/1760221/","msgid":"","list_archive_url":null,"date":"2017-08-30T14:39:44","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"Hi\n\nOn Wed, Aug 30, 2017 at 3:43 PM Thomas Huth wrote:\n\n> The \"slow\" ivshmem-tests currently fail when they are running on a\n> big endian host:\n>\n> $ uname -m\n> ppc64\n> $ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64\n> tests/ivshmem-test -m slow\n> /x86_64/ivshmem/single: OK\n> /x86_64/ivshmem/hotplug: OK\n> /x86_64/ivshmem/memdev: OK\n> /x86_64/ivshmem/pair: OK\n> /x86_64/ivshmem/server-msi: qemu-system-x86_64:\n> -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid ID\n> message\n> Broken pipe\n>\n> The problem is that the server side code in ivshmem_server_send_one_msg()\n> correctly translates all messages IDs into little endian 64-bit values,\n> but the client side code in the ivshmem_recv_msg() function does not swap\n> the byte order back. Fix it by passing the value through le64_to_cpu().\n>\n>\nivshmem_read() is correct though\n\nSigned-off-by: Thomas Huth \n>\n\n Reviewed-by: Marc-André Lureau \n\n---\n> hw/misc/ivshmem.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c\n> index 47a015f..b3ef3ec 100644\n> --- a/hw/misc/ivshmem.c\n> +++ b/hw/misc/ivshmem.c\n> @@ -653,7 +653,7 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int\n> *pfd, Error **errp)\n> } while (n < sizeof(msg));\n>\n> *pfd = qemu_chr_fe_get_msgfd(&s->server_chr);\n> - return msg;\n> + return le64_to_cpu(msg);\n> }\n>\n> static void ivshmem_recv_setup(IVShmemState *s, Error **errp)\n> --\n> 1.8.3.1\n>\n>\n> --\nMarc-André Lureau","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SEiNfKuG\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7Tl355yz9s8P\n\tfor ;\n\tThu, 31 Aug 2017 00:40:39 +1000 (AEST)","from localhost ([::1]:50932 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4AX-00030Q-7t\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:40:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47594)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn49s-0002yv-AD\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:39:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn49r-0004rL-C4\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:39:56 -0400","from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:35186)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn49r-0004rF-70; Wed, 30 Aug 2017 10:39:55 -0400","by mail-vk0-x234.google.com with SMTP id z187so18061492vkd.2;\n\tWed, 30 Aug 2017 07:39:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=goh1E7jAclT+nR789HTdVtHtYOtPrcQypqmy2Gb6JGQ=;\n\tb=SEiNfKuGai1TjomznPUqiKHDgYuWS8hRSFo3w+x4fXGxpArV6i1EPzlhbdUWLPmHgO\n\td1EGOBHN+g/J6i6sB64cIZDlqM0l2a2teJ7OzTFkEqfMRJlwt9DsXDJfK+ZYAPnX5xmE\n\ti4wSrXlTBPMTtk2WYRuGYL0wz4ZaONG/3LyJLRX4J+aa0thSnTo/JXIy+xfWitMF2Kh2\n\tdGbjA4G9WBFRAOxkMD+mKd1O/fywr4wba/oxc7EXgay/vqjBU9YTmYQVZWJODXPXR1bJ\n\tMOFexOmDMbX2iM9OEnViU+yiRxMwgDgr6fNLbWMiBzBRHRsVfaH55uoUZwT1IXAe85Hg\n\tp6uQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=goh1E7jAclT+nR789HTdVtHtYOtPrcQypqmy2Gb6JGQ=;\n\tb=eo6HiuGtARiCLEClaanrsrRB0sbZIbvrg+sR4Uv5p8n4CcvCkO6C+jjiVfvCPmVF2B\n\tutSZPjcswMpNtrF328/y5EBIofLHF4RiXlq53/NAblxxQ6d1WY3DlybYlwLFuCFL0Ll3\n\t366vt2rw3sKcSv/5Il0yLHDyfeMQnlXo0RAqAeLfO+1nrbVkX9nUMlZpWl/tBkHuhIWn\n\tgms59j/52tEm6Ujt/dkPqtIDHo84+gp/Od/x13ptzVuBWInVLgkyDqD3/u0e9dxBvJXG\n\tByvpVnRuQAwaSsThnIFLEIoNyO4o7wNdGABRdEYd3WzGLjgWoYdnOocPTy6Ph7jaA5Rv\n\t4W1g==","X-Gm-Message-State":"AHYfb5iy2Sedtu0DA+I84rD5gUPKfh8V6lo0+t6n/SpVeEPeq2z5KynC\n\tzwthnAFTwNGiEPbAxJbQcG+M7jJ3Mw==","X-Received":"by 10.31.11.11 with SMTP id 11mr842709vkl.61.1504103994594; Wed,\n\t30 Aug 2017 07:39:54 -0700 (PDT)","MIME-Version":"1.0","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","In-Reply-To":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Wed, 30 Aug 2017 14:39:44 +0000","Message-ID":"","To":"Thomas Huth , qemu-devel@nongnu.org","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400c:c05::234","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Laurent Vivier ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760233,"web_url":"http://patchwork.ozlabs.org/comment/1760233/","msgid":"<9ce5a57f-a2b9-a7d0-fd88-639fb8f2e062@redhat.com>","list_archive_url":null,"date":"2017-08-30T14:48:47","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 16:13, Cornelia Huck wrote:\n> On Wed, 30 Aug 2017 15:39:03 +0200\n> Thomas Huth wrote:\n> \n>> The \"slow\" ivshmem-tests currently fail when they are running on a\n>> big endian host:\n>>\n>> $ uname -m\n>> ppc64\n>> $ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/ivshmem-test -m slow\n>> /x86_64/ivshmem/single: OK\n>> /x86_64/ivshmem/hotplug: OK\n>> /x86_64/ivshmem/memdev: OK\n>> /x86_64/ivshmem/pair: OK\n>> /x86_64/ivshmem/server-msi: qemu-system-x86_64:\n>> -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid ID message\n>> Broken pipe\n>>\n>> The problem is that the server side code in ivshmem_server_send_one_msg()\n>> correctly translates all messages IDs into little endian 64-bit values,\n>> but the client side code in the ivshmem_recv_msg() function does not swap\n>> the byte order back. Fix it by passing the value through le64_to_cpu().\n>>\n>> Signed-off-by: Thomas Huth \n[...]\n> This fixes the \"invalid ID message\" problem on s390x for me as well,\n> and I run now into the same error as on x86 (which you also have a fix\n> for IIRC)\nYes, you also need my other patch, look for \"tests: Fix broken\nivshmem-server-msi/-irq tests\" on the list.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7gh1Rbhz9s9Y\n\tfor ;\n\tThu, 31 Aug 2017 00:49:20 +1000 (AEST)","from localhost ([::1]:50990 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4Iw-0007w2-0S\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:49:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50588)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn4IZ-0007vk-4l\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:48:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn4IW-0000WP-GM\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:48:55 -0400","from mx1.redhat.com ([209.132.183.28]:50890)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn4IW-0000WF-9a; Wed, 30 Aug 2017 10:48:52 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 37B2A267D5;\n\tWed, 30 Aug 2017 14:48:51 +0000 (UTC)","from [10.36.116.68] (ovpn-116-68.ams2.redhat.com [10.36.116.68])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 091259B511;\n\tWed, 30 Aug 2017 14:48:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 37B2A267D5","To":"Cornelia Huck ","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t<20170830161327.4b199e9a.cohuck@redhat.com>","From":"Thomas Huth ","Message-ID":"<9ce5a57f-a2b9-a7d0-fd88-639fb8f2e062@redhat.com>","Date":"Wed, 30 Aug 2017 16:48:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830161327.4b199e9a.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 30 Aug 2017 14:48:51 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , qemu-trivial@nongnu.org,\n\tqemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760243,"web_url":"http://patchwork.ozlabs.org/comment/1760243/","msgid":"","list_archive_url":null,"date":"2017-08-30T14:53:03","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 08/30/2017 10:39 AM, Thomas Huth wrote:\n> The \"slow\" ivshmem-tests currently fail when they are running on a\n> big endian host:\n> \n> $ uname -m\n> ppc64\n> $ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/ivshmem-test -m slow\n> /x86_64/ivshmem/single: OK\n> /x86_64/ivshmem/hotplug: OK\n> /x86_64/ivshmem/memdev: OK\n> /x86_64/ivshmem/pair: OK\n> /x86_64/ivshmem/server-msi: qemu-system-x86_64:\n> -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid ID message\n> Broken pipe\n> \n> The problem is that the server side code in ivshmem_server_send_one_msg()\n> correctly translates all messages IDs into little endian 64-bit values,\n> but the client side code in the ivshmem_recv_msg() function does not swap\n> the byte order back. Fix it by passing the value through le64_to_cpu().\n\nYes, we lack BE testing :(\n\nI read we can run docker on s390x, I wonder if we can ask for a FOSS \naccount on some to run the test suite.\n\n> \n> Signed-off-by: Thomas Huth \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> hw/misc/ivshmem.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c\n> index 47a015f..b3ef3ec 100644\n> --- a/hw/misc/ivshmem.c\n> +++ b/hw/misc/ivshmem.c\n> @@ -653,7 +653,7 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd, Error **errp)\n> } while (n < sizeof(msg));\n> \n> *pfd = qemu_chr_fe_get_msgfd(&s->server_chr);\n> - return msg;\n> + return le64_to_cpu(msg);\n> }\n> \n> static void ivshmem_recv_setup(IVShmemState *s, Error **errp)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Sz3n7V+J\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7mz4z5sz9sMN\n\tfor ;\n\tThu, 31 Aug 2017 00:53:52 +1000 (AEST)","from localhost ([::1]:51005 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4NI-0001VC-SM\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:53:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51816)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dn4Mk-0001Pf-L1\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:53:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dn4Mj-00023c-MU\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:53:14 -0400","from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:38610)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn4Me-00021r-89; Wed, 30 Aug 2017 10:53:08 -0400","by mail-qk0-x243.google.com with SMTP id o63so5442690qkb.5;\n\tWed, 30 Aug 2017 07:53:08 -0700 (PDT)","from [192.168.43.33] ([170.51.34.109])\n\tby smtp.gmail.com with ESMTPSA id\n\tj61sm3693824qte.30.2017.08.30.07.53.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 07:53:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=YcBFut5fEB8mwXC5BcZgQOEcPUQ3ADwBAoKSu5458yo=;\n\tb=Sz3n7V+JEylvUWIHQRCNazcRgp5HZY2Iwl+lRE1NARDcKNG7TJqj1rAnQjDbq/2xH5\n\twNen+a12djrBVXaSb6P5cV3yfCsv1CWoTwlTZza6MR7FRXSQG0tW3T1f0ylcz4SMemht\n\txBbTBYSZtIO+RlUtbO3uEdL+yBvYw53A7b7LmXBsPcoaO74RtXR+Ur4WHzNFNNaBBm5s\n\tCLJOiRRKwTOhn8IQewaE410zABiTbZ7cCumeuUsnuwn3sUslpdCsZ5UDz3BMsRDOeDPI\n\tygKVmZIlNSmFiUdhlNRLPcLLGi8CkbTReNHceIh3vx3BhKtcboHSqEDLSsf9Pdv9hz91\n\tj7zA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=YcBFut5fEB8mwXC5BcZgQOEcPUQ3ADwBAoKSu5458yo=;\n\tb=ZBOnqLD2pnII5y/ohGCKlOtDPlMqkYmpHdSFnmGnj75h26YTMNaCvt8vL5xo44PQ2G\n\tGDal0BoFdOtBGMFcnvK2dNWjgz24LecsVdUDzB7N6IQlgx5JcxAoJaXRe5WQqs+v/qUQ\n\t+FaRuYffnIHnRr/qD+EZVHyWcU3u0E3SVrjy+VOTAxJBlSISZKi+NTEmh9C407P9P6uL\n\tWUQh+vBOQTRqhLNG0gMK9M5c1hEZr58OTKHcIHbPPNWlJcQD1Sv1DK6Ipl90q0hA6HE7\n\tqjte3/bHSLV8V/IJSNOD/8d+tvEIh9A1QZfPr31z8pdJQXbKpKKn1hXvPz7ucxKWRVxM\n\tV+vw==","X-Gm-Message-State":"AHYfb5hAa4A5UpUeobn0wvuMX3x0amNh9VcHGbVC+uqf/HPhK+3w9YwS\n\tTZfAn++bPN4s1hPKueGV8Bhh","X-Received":"by 10.55.93.67 with SMTP id r64mr10350078qkb.358.1504104787586; \n\tWed, 30 Aug 2017 07:53:07 -0700 (PDT)","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Wed, 30 Aug 2017 11:53:03 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::243","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Laurent Vivier ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760252,"web_url":"http://patchwork.ozlabs.org/comment/1760252/","msgid":"<52928093-36d5-89cf-bb89-ab5abf54b8f0@redhat.com>","list_archive_url":null,"date":"2017-08-30T14:59:03","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 16:53, Philippe Mathieu-Daudé wrote:\n> On 08/30/2017 10:39 AM, Thomas Huth wrote:\n>> The \"slow\" ivshmem-tests currently fail when they are running on a\n>> big endian host:\n>>\n>> $ uname -m\n>> ppc64\n>> $ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64\n>> tests/ivshmem-test -m slow\n>> /x86_64/ivshmem/single: OK\n>> /x86_64/ivshmem/hotplug: OK\n>> /x86_64/ivshmem/memdev: OK\n>> /x86_64/ivshmem/pair: OK\n>> /x86_64/ivshmem/server-msi: qemu-system-x86_64:\n>>   -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid\n>> ID message\n>> Broken pipe\n>>\n>> The problem is that the server side code in ivshmem_server_send_one_msg()\n>> correctly translates all messages IDs into little endian 64-bit values,\n>> but the client side code in the ivshmem_recv_msg() function does not swap\n>> the byte order back. Fix it by passing the value through le64_to_cpu().\n> \n> Yes, we lack BE testing :(\n\nAs far as I know, some people are already running the tests on s390x and\nppc64 ... the problem is that apparently nobody is running with\nSPEED=slow there - that's why this problem slipped through so far.\nMaybe we should switch to the SPEED=slow by default in the Makefile?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7vv24fxz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 00:59:55 +1000 (AEST)","from localhost ([::1]:51021 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4TB-0003gz-1m\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:59:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53212)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn4SY-0003fM-B6\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:59:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn4SU-0003lY-6a\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:59:14 -0400","from mx1.redhat.com ([209.132.183.28]:37720)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn4SU-0003lP-0Q; Wed, 30 Aug 2017 10:59:10 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9C5D67E439;\n\tWed, 30 Aug 2017 14:59:08 +0000 (UTC)","from [10.36.116.68] (ovpn-116-68.ams2.redhat.com [10.36.116.68])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2248F8D543;\n\tWed, 30 Aug 2017 14:59:04 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9C5D67E439","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tqemu-devel@nongnu.org","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t","From":"Thomas Huth ","Message-ID":"<52928093-36d5-89cf-bb89-ab5abf54b8f0@redhat.com>","Date":"Wed, 30 Aug 2017 16:59:03 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 30 Aug 2017 14:59:08 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Laurent Vivier ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760254,"web_url":"http://patchwork.ozlabs.org/comment/1760254/","msgid":"","list_archive_url":null,"date":"2017-08-30T14:59:07","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 30 August 2017 at 15:53, Philippe Mathieu-Daudé wrote:\n> On 08/30/2017 10:39 AM, Thomas Huth wrote:\n>> The problem is that the server side code in ivshmem_server_send_one_msg()\n>> correctly translates all messages IDs into little endian 64-bit values,\n>> but the client side code in the ivshmem_recv_msg() function does not swap\n>> the byte order back. Fix it by passing the value through le64_to_cpu().\n>\n>\n> Yes, we lack BE testing :(\n\nMy pre-pull-request test set includes s390 and ppc64 bigendian.\nThis one was just missed because the 'slow' tests aren't in\n'make check'.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"VW87E4e6\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7wF3B3gz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 01:00:13 +1000 (AEST)","from localhost ([::1]:51024 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4TT-0003zk-8n\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 11:00:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53354)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn4So-0003ps-1y\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:59:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn4Sn-0003sD-D3\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:59:30 -0400","from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:38366)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn4Sn-0003rZ-5s\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:59:29 -0400","by mail-wr0-x236.google.com with SMTP id 40so18729777wrv.5\n\tfor ; Wed, 30 Aug 2017 07:59:28 -0700 (PDT)","by 10.223.134.54 with HTTP; Wed, 30 Aug 2017 07:59:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=29PJUV4JWxbuxmdC2rrWSkNy5lGJgN5ywIOzbgbl2ig=;\n\tb=VW87E4e60N3wrt+LMOOMF9yJyyt0+R5acU2CrtD4QwMKHuMdrfIEE1Wm4b68u8bIzU\n\tHovbntMGURBT+hFt/9AcaOlIRwYs2qo1hz7+jRccjP2EMmNXamRYVuN7YhYRFuSFKb4b\n\tPA9yG0zguhU4vFt3NRHXoV/5HvwSi1N1oCh9A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=29PJUV4JWxbuxmdC2rrWSkNy5lGJgN5ywIOzbgbl2ig=;\n\tb=WDxiYE3I2xIZGSKOn9aWq1hbAhmKABVNFjxo+YZlY7c5IzvpcNC1tP7FNVD29OpSOz\n\txmFqiHBqRvjhD3cWkSPFkkSGLKLvy+qbHKZToQo+HsWqZZ/VQHFta3u9Az5CRh4mGM4B\n\t1CycVxGkJDgUEZqR+9kfzbtnfSTk8l1n7gUncly2JvEqum6mvF/AD9yRYEW5GSIneXL5\n\t14lWBO8cuz/BsxsbQAtTGZSSIV8IMUgz0dzd9Eccp4GMKvXHodvYjcZhMBYO7768trcW\n\tF7+eLSVoMdY18bBCI/25XSs/znY6+UJRAnkYYcdWEGZtB+BpMChtF/JrNiABvh8NuLWA\n\tFWFg==","X-Gm-Message-State":"AHYfb5hCzJhaSnKGhFoWlsHdL/2XxhogSerKBqYNLx1ofMCUbToZ3xF4\n\t9S8RQ5FROalhjO1aVpksC9jnrQIY5Cqw","X-Received":"by 10.223.132.98 with SMTP id 89mr1138193wrf.97.1504105167931;\n\tWed, 30 Aug 2017 07:59:27 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t","From":"Peter Maydell ","Date":"Wed, 30 Aug 2017 15:59:07 +0100","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::236","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Thomas Huth ,\n\tQEMU Trivial , QEMU Developers\n\t, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760268,"web_url":"http://patchwork.ozlabs.org/comment/1760268/","msgid":"<20170830171120.190439f5.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T15:11:20","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 30 Aug 2017 16:59:03 +0200\nThomas Huth wrote:\n\n> On 30.08.2017 16:53, Philippe Mathieu-Daudé wrote:\n> > On 08/30/2017 10:39 AM, Thomas Huth wrote: \n> >> The \"slow\" ivshmem-tests currently fail when they are running on a\n> >> big endian host:\n> >>\n> >> $ uname -m\n> >> ppc64\n> >> $ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64\n> >> tests/ivshmem-test -m slow\n> >> /x86_64/ivshmem/single: OK\n> >> /x86_64/ivshmem/hotplug: OK\n> >> /x86_64/ivshmem/memdev: OK\n> >> /x86_64/ivshmem/pair: OK\n> >> /x86_64/ivshmem/server-msi: qemu-system-x86_64:\n> >>   -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid\n> >> ID message\n> >> Broken pipe\n> >>\n> >> The problem is that the server side code in ivshmem_server_send_one_msg()\n> >> correctly translates all messages IDs into little endian 64-bit values,\n> >> but the client side code in the ivshmem_recv_msg() function does not swap\n> >> the byte order back. Fix it by passing the value through le64_to_cpu(). \n> > \n> > Yes, we lack BE testing :( \n> \n> As far as I know, some people are already running the tests on s390x and\n> ppc64 ... the problem is that apparently nobody is running with\n> SPEED=slow there - that's why this problem slipped through so far.\n> Maybe we should switch to the SPEED=slow by default in the Makefile?\n\nNot sure whether that is a good idea. /me adding this to my s390x tests\nshould help, though.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj8BZ2YVsz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 01:12:38 +1000 (AEST)","from localhost ([::1]:51096 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4fU-0003s8-5h\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 11:12:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58080)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn4eQ-0003MV-St\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:11:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn4eN-0000if-Ef\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:11:30 -0400","from mx1.redhat.com ([209.132.183.28]:58742)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn4eN-0000iC-8x; Wed, 30 Aug 2017 11:11:27 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4BB53495;\n\tWed, 30 Aug 2017 15:11:26 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2086F98163;\n\tWed, 30 Aug 2017 15:11:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4BB53495","Date":"Wed, 30 Aug 2017 17:11:20 +0200","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20170830171120.190439f5.cohuck@redhat.com>","In-Reply-To":"<52928093-36d5-89cf-bb89-ab5abf54b8f0@redhat.com>","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t\n\t<52928093-36d5-89cf-bb89-ab5abf54b8f0@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 30 Aug 2017 15:11:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , qemu-trivial@nongnu.org, Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= , \tqemu-devel@nongnu.org,\n\t=?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765897,"web_url":"http://patchwork.ozlabs.org/comment/1765897/","msgid":"<20170910032413.GB2735@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-10T03:24:13","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Wed, Aug 30, 2017 at 03:59:07PM +0100, Peter Maydell wrote:\n> On 30 August 2017 at 15:53, Philippe Mathieu-Daudé wrote:\n> > On 08/30/2017 10:39 AM, Thomas Huth wrote:\n> >> The problem is that the server side code in ivshmem_server_send_one_msg()\n> >> correctly translates all messages IDs into little endian 64-bit values,\n> >> but the client side code in the ivshmem_recv_msg() function does not swap\n> >> the byte order back. Fix it by passing the value through le64_to_cpu().\n> >\n> >\n> > Yes, we lack BE testing :(\n> \n> My pre-pull-request test set includes s390 and ppc64 bigendian.\n> This one was just missed because the 'slow' tests aren't in\n> 'make check'.\n\nI'm not what makes sense for staging this fix. I could take it\nthrough my tree, but it's not an obvious match, since this isn't\nreally related to ppc at all.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"CDpCl4X7\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqbyz5y5dz9sPk\n\tfor ;\n\tSun, 10 Sep 2017 13:24:59 +1000 (AEST)","from localhost ([::1]:51600 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqsrh-00019b-9j\n\tfor incoming@patchwork.ozlabs.org; Sat, 09 Sep 2017 23:24:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50531)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqsrA-00018Y-Pp\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 23:24:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqsr9-0005r1-SJ\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 23:24:24 -0400","from ozlabs.org ([2401:3900:2:1::2]:54667)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqsr9-0005pu-Gn; Sat, 09 Sep 2017 23:24:23 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xqbyF0vyGz9sRV; Sun, 10 Sep 2017 13:24:20 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505013861;\n\tbh=FjV197wXjN4CTqmwK4S2kAUHzM1pIxIaoTbHTMQ/bCo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CDpCl4X7XQ3dNClRr+7PPts75sinxQuu9CeZNyeW4S/t8FHd0SFuRGuwK1lRaGdC1\n\tWcAx/tNQP3h+AoeTUbv1UQvKSCylLHzUv58VLIJtL0FjAbYAVUNR7hNW//9Pwxbwn/\n\tfOnQPLkTm4bEaf12pZsnQyB5k2dIBBdLgSID0GiM=","Date":"Sun, 10 Sep 2017 13:24:13 +1000","From":"David Gibson ","To":"Peter Maydell ","Message-ID":"<20170910032413.GB2735@umbus.fritz.box>","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"sPkBZsy7C+1fV4MN\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Thomas Huth ,\n\tQEMU Trivial , Philippe =?iso-8859-1?q?Mathie?=\n\t=?iso-8859-1?q?u-Daud=E9?= ,\n\tQEMU Developers , =?iso-8859-1?q?Marc-Andr=E9?=\n\tLureau ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765974,"web_url":"http://patchwork.ozlabs.org/comment/1765974/","msgid":"","list_archive_url":null,"date":"2017-09-10T17:01:05","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/10/2017 12:24 AM, David Gibson wrote:\n> I'm not what makes sense for staging this fix. I could take it\n> through my tree, but it's not an obvious match, since this isn't\n> really related to ppc at all.\n\nPaolo's misc? :D","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CreSl/in\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqy5Z5JbSz9s7C\n\tfor ;\n\tMon, 11 Sep 2017 03:01:53 +1000 (AEST)","from localhost ([::1]:53655 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dr5cE-0008Eg-D0\n\tfor incoming@patchwork.ozlabs.org; Sun, 10 Sep 2017 13:01:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51244)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dr5bh-00089Y-Ks\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 13:01:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dr5bh-00037x-0v\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 13:01:17 -0400","from mail-qt0-x229.google.com ([2607:f8b0:400d:c0d::229]:35037)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dr5bc-00036Q-Qt; Sun, 10 Sep 2017 13:01:12 -0400","by mail-qt0-x229.google.com with SMTP id k2so15212898qte.2;\n\tSun, 10 Sep 2017 10:01:11 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tz50sm5145011qta.19.2017.09.10.10.01.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Sep 2017 10:01:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=vKsLWS+h0QnAkhe0yKYoocPVjAbCx4xX/m9vDv/erKk=;\n\tb=CreSl/inYMlv+g6dWx8YffZ67KfWt+TbUb6sSt39obZkweRlO6FNxUoedY8jVugbdD\n\t4CtwvBLjd3zFnwZLJ5apwSPnNzpohVHrVDyiwvwsl09JkGCEu477udX7+cB4S664OquX\n\tp/nK/zg5rmllDwXRrnNTObZIBjX+KWLA7r8phvGF0NOABX173YlEsYHvMCNSkS57scCy\n\twaD9Tn+pm6k45TiyyipIF1TjK1TpMXry2vBii6FalcbGdXhr0iCO3FzbT3Zarx3K8C4i\n\t9eV6nvLVAqdQxpxV38eXahJdwDwIsGMWBaEG404J0LUXAw1rl5Iz6pz2XRCs49bFcjK6\n\tQh2Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=vKsLWS+h0QnAkhe0yKYoocPVjAbCx4xX/m9vDv/erKk=;\n\tb=n2CLLwbmHqRi8FZ4JMfAEdziIegPQiFmZVpMFQjSKYSC0vfrjBb1jOu0une9T7M0or\n\tIJ8RdWHzFL75ukebjdUelg350BJE/ZlRzNHcXsuRvTbldD2kodfVvq4dRahrgVPMNDwJ\n\tvxh1teYWdgBCh14YI1NszL9fglke+Gj/DkUjRD4GI9tr1Ookqnf+1ckZfrM88xd7YIrL\n\tgMacUCqwdXJQQY+e4eHJHgqNOrVzIdB5SUNvQwu2vC3ugha10aUtiyKo4ELI3WV5YTPz\n\tYsdCKLLwdgHUMeV+NGA5jDxjbr+FYGDmXA+guXtPDzPJLC3ZLEy9SEFWRrDTD/ItYKNd\n\t6ZqA==","X-Gm-Message-State":"AHPjjUjhOJwjywTvEzNsDRAK/fScIakRl5C5t5EkXi7q8qxOZlOl9j86\n\tnhMhFE6lWNpLWg==","X-Google-Smtp-Source":"AOwi7QCa47uI4EbLgw1Tf5MJE7/DVQGFAmcEwy7ySGSbBVNFrv4vw/YB2KONcdsQk5UVMctNWtYEvw==","X-Received":"by 10.200.45.73 with SMTP id o9mr12271668qta.292.1505062870957; \n\tSun, 10 Sep 2017 10:01:10 -0700 (PDT)","To":"David Gibson ","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t\n\t\n\t<20170910032413.GB2735@umbus.fritz.box>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Sun, 10 Sep 2017 14:01:05 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170910032413.GB2735@umbus.fritz.box>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::229","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Peter Maydell\n\t, Thomas Huth , QEMU Trivial\n\t, \tQEMU Developers ,\n\tPaolo Bonzini , =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766034,"web_url":"http://patchwork.ozlabs.org/comment/1766034/","msgid":"<9058bb80-4e5c-3316-576f-1c21924a8a07@redhat.com>","list_archive_url":null,"date":"2017-09-11T02:35:08","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 10.09.2017 05:24, David Gibson wrote:\n> On Wed, Aug 30, 2017 at 03:59:07PM +0100, Peter Maydell wrote:\n>> On 30 August 2017 at 15:53, Philippe Mathieu-Daudé wrote:\n>>> On 08/30/2017 10:39 AM, Thomas Huth wrote:\n>>>> The problem is that the server side code in ivshmem_server_send_one_msg()\n>>>> correctly translates all messages IDs into little endian 64-bit values,\n>>>> but the client side code in the ivshmem_recv_msg() function does not swap\n>>>> the byte order back. Fix it by passing the value through le64_to_cpu().\n>>>\n>>>\n>>> Yes, we lack BE testing :(\n>>\n>> My pre-pull-request test set includes s390 and ppc64 bigendian.\n>> This one was just missed because the 'slow' tests aren't in\n>> 'make check'.\n> \n> I'm not what makes sense for staging this fix. I could take it\n> through my tree, but it's not an obvious match, since this isn't\n> really related to ppc at all.\n\nThere does not seem to be maintainer for ivshmem, as far as I can see,\nso I'd say any tree that is distantly related is fine. So I think you\ncould either take it through your ppc tree (since the bug affects big\nendian ppc machines), or maybe Cornelia could take it through the s390x\ntree (since we've seen the problem on the big endian s390x machines,\ntoo). Otherwise I have to wait and see whether it goes through misc or\ntrivial, I guess...\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrBqx3qCSz9s7g\n\tfor ;\n\tMon, 11 Sep 2017 12:35:56 +1000 (AEST)","from localhost ([::1]:55087 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drEZm-0004f7-2T\n\tfor incoming@patchwork.ozlabs.org; Sun, 10 Sep 2017 22:35:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57663)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drEZI-0004ev-8o\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 22:35:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drEZF-0005co-5e\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 22:35:24 -0400","from mx1.redhat.com ([209.132.183.28]:55828)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drEZE-0005cN-SO; Sun, 10 Sep 2017 22:35:21 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7A80931DC2C;\n\tMon, 11 Sep 2017 02:35:19 +0000 (UTC)","from [10.36.116.54] (ovpn-116-54.ams2.redhat.com [10.36.116.54])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 28EC45C8B9;\n\tMon, 11 Sep 2017 02:35:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7A80931DC2C","To":"David Gibson ,\n\tPeter Maydell ","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t\n\t\n\t<20170910032413.GB2735@umbus.fritz.box>","From":"Thomas Huth ","Message-ID":"<9058bb80-4e5c-3316-576f-1c21924a8a07@redhat.com>","Date":"Mon, 11 Sep 2017 04:35:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170910032413.GB2735@umbus.fritz.box>","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"GQHCXIGEsWoOcJ4EASUpJB3SX7A3CE837\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 11 Sep 2017 02:35:19 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier ,\n\tQEMU Trivial , Cornelia Huck\n\t, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tQEMU Developers ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lu?= =?utf-8?q?reau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766096,"web_url":"http://patchwork.ozlabs.org/comment/1766096/","msgid":"<20170911092911.27e0886e.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-11T07:29:11","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 11 Sep 2017 04:35:08 +0200\nThomas Huth wrote:\n\n> On 10.09.2017 05:24, David Gibson wrote:\n> > On Wed, Aug 30, 2017 at 03:59:07PM +0100, Peter Maydell wrote: \n> >> On 30 August 2017 at 15:53, Philippe Mathieu-Daudé wrote: \n> >>> On 08/30/2017 10:39 AM, Thomas Huth wrote: \n> >>>> The problem is that the server side code in ivshmem_server_send_one_msg()\n> >>>> correctly translates all messages IDs into little endian 64-bit values,\n> >>>> but the client side code in the ivshmem_recv_msg() function does not swap\n> >>>> the byte order back. Fix it by passing the value through le64_to_cpu(). \n> >>>\n> >>>\n> >>> Yes, we lack BE testing :( \n> >>\n> >> My pre-pull-request test set includes s390 and ppc64 bigendian.\n> >> This one was just missed because the 'slow' tests aren't in\n> >> 'make check'. \n> > \n> > I'm not what makes sense for staging this fix. I could take it\n> > through my tree, but it's not an obvious match, since this isn't\n> > really related to ppc at all. \n> \n> There does not seem to be maintainer for ivshmem, as far as I can see,\n> so I'd say any tree that is distantly related is fine. So I think you\n> could either take it through your ppc tree (since the bug affects big\n> endian ppc machines), or maybe Cornelia could take it through the s390x\n> tree (since we've seen the problem on the big endian s390x machines,\n> too). Otherwise I have to wait and see whether it goes through misc or\n> trivial, I guess...\n\nI'll queue it; and whoever sends the first pull request, 'wins' :)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrKM96jykz9s4q\n\tfor ;\n\tMon, 11 Sep 2017 17:29:56 +1000 (AEST)","from localhost ([::1]:55923 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drJAF-0007fU-F8\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 03:29:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41764)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drJ9p-0007fL-DN\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 03:29:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drJ9m-0004ds-Am\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 03:29:25 -0400","from mx1.redhat.com ([209.132.183.28]:50494)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drJ9m-0004ci-4o; Mon, 11 Sep 2017 03:29:22 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E1001FC0F9;\n\tMon, 11 Sep 2017 07:29:19 +0000 (UTC)","from gondolin (ovpn-116-234.ams2.redhat.com [10.36.116.234])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9616C649B5;\n\tMon, 11 Sep 2017 07:29:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E1001FC0F9","Date":"Mon, 11 Sep 2017 09:29:11 +0200","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20170911092911.27e0886e.cohuck@redhat.com>","In-Reply-To":"<9058bb80-4e5c-3316-576f-1c21924a8a07@redhat.com>","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>\n\t\n\t\n\t<20170910032413.GB2735@umbus.fritz.box>\n\t<9058bb80-4e5c-3316-576f-1c21924a8a07@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 11 Sep 2017 07:29:20 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Peter Maydell\n\t, \tQEMU Trivial ,\n\tQEMU Developers , Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= ,\n\t=?utf-8?q?Marc-Andr=C3=A9?= Lureau ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768381,"web_url":"http://patchwork.ozlabs.org/comment/1768381/","msgid":"","list_archive_url":null,"date":"2017-09-14T07:44:28","subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","submitter":{"id":183,"url":"http://patchwork.ozlabs.org/api/people/183/","name":"Michael Tokarev","email":"mjt@tls.msk.ru"},"content":"30.08.2017 16:39, Thomas Huth пишет:\n> The \"slow\" ivshmem-tests currently fail when they are running on a\n> big endian host:\n\nApplied to -trivial, thanks!\n\n/mjt","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9YD7579z9sRm\n\tfor ;\n\tThu, 14 Sep 2017 17:45:02 +1000 (AEST)","from localhost ([::1]:46161 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsOpX-0001M6-Al\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 03:44:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48030)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsOp8-0001Lo-LY\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:44:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsOp5-0000Iu-HN\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:44:34 -0400","from isrv.corpit.ru ([86.62.121.231]:46261)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dsOp5-0000IQ-7K; Thu, 14 Sep 2017 03:44:31 -0400","from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n\tby isrv.corpit.ru (Postfix) with ESMTP id D54DD412CF;\n\tThu, 14 Sep 2017 10:44:28 +0300 (MSK)","from [192.168.177.99] (mjt.vpn.tls.msk.ru [192.168.177.99])\n\tby tsrv.corpit.ru (Postfix) with ESMTP id B0F9F5B9;\n\tThu, 14 Sep 2017 10:44:26 +0300 (MSK)"],"To":"Thomas Huth , qemu-devel@nongnu.org","References":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","From":"Michael Tokarev ","Message-ID":"","Date":"Thu, 14 Sep 2017 10:44:28 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"86.62.121.231","Subject":"Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Laurent Vivier , David\n\tGibson , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]