[{"id":1760162,"web_url":"http://patchwork.ozlabs.org/comment/1760162/","msgid":"<69765b5d-273d-c695-9094-049e0a486718@redhat.com>","list_archive_url":null,"date":"2017-08-30T13:46:30","subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 15:24, Igor Mammedov wrote:\n> Remove cpu models that aren't implemented and are not\n> compiled/tested since they are under TODO ifdef\n> which isn't defined in sources.\n> \n> If someone really needs a removed model he/she should add\n> as regular one with corresponding implementation.\n> \n> Signed-off-by: Igor Mammedov \n> ---\n> target/ppc/cpu-models.c | 459 ------------------------------------------------\n> 1 file changed, 459 deletions(-)\n> \n> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\n> index cf878a9..611fc1b 100644\n> --- a/target/ppc/cpu-models.c\n> +++ b/target/ppc/cpu-models.c\n> @@ -19,11 +19,6 @@\n> * License along with this library; if not, see .\n> */\n[...]\n> /* PowerPC 440 family */\n> -#if defined(TODO_USER_ONLY)\n> - POWERPC_DEF(\"440\", CPU_POWERPC_440, 440GP,\n> - \"Generic PowerPC 440\")\n> -#endif\n\nPlease don't remove this TODO_USER_ONLY entry. It's still used if the\ncode is compiled with CONFIG_USER_ONLY.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj6JD3lmCz9sRW\n\tfor ;\n\tWed, 30 Aug 2017 23:47:24 +1000 (AEST)","from localhost ([::1]:50709 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn3L0-00022q-8l\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 09:47:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59407)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn3KH-00021Q-Hp\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:46:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn3KE-0001pT-C5\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:46:37 -0400","from mx1.redhat.com ([209.132.183.28]:36376)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn3KE-0001p5-6W; Wed, 30 Aug 2017 09:46:34 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2529C83F43;\n\tWed, 30 Aug 2017 13:46:33 +0000 (UTC)","from [10.36.116.68] (ovpn-116-68.ams2.redhat.com [10.36.116.68])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0B68960BEB;\n\tWed, 30 Aug 2017 13:46:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2529C83F43","To":"Igor Mammedov , qemu-devel@nongnu.org","References":"<1504099475-241036-1-git-send-email-imammedo@redhat.com>\n\t<1504099475-241036-9-git-send-email-imammedo@redhat.com>","From":"Thomas Huth ","Message-ID":"<69765b5d-273d-c695-9094-049e0a486718@redhat.com>","Date":"Wed, 30 Aug 2017 15:46:30 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504099475-241036-9-git-send-email-imammedo@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 30 Aug 2017 13:46:33 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760195,"web_url":"http://patchwork.ozlabs.org/comment/1760195/","msgid":"<20170830161416.07b6d533@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-08-30T14:14:16","subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Wed, 30 Aug 2017 15:46:30 +0200\nThomas Huth wrote:\n\n> On 30.08.2017 15:24, Igor Mammedov wrote:\n> > Remove cpu models that aren't implemented and are not\n> > compiled/tested since they are under TODO ifdef\n> > which isn't defined in sources.\n> > \n> > If someone really needs a removed model he/she should add\n> > as regular one with corresponding implementation.\n> > \n> > Signed-off-by: Igor Mammedov \n> > ---\n> > target/ppc/cpu-models.c | 459 ------------------------------------------------\n> > 1 file changed, 459 deletions(-)\n> > \n> > diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\n> > index cf878a9..611fc1b 100644\n> > --- a/target/ppc/cpu-models.c\n> > +++ b/target/ppc/cpu-models.c\n> > @@ -19,11 +19,6 @@\n> > * License along with this library; if not, see .\n> > */ \n> [...]\n> > /* PowerPC 440 family */\n> > -#if defined(TODO_USER_ONLY)\n> > - POWERPC_DEF(\"440\", CPU_POWERPC_440, 440GP,\n> > - \"Generic PowerPC 440\")\n> > -#endif \n> \n> Please don't remove this TODO_USER_ONLY entry. It's still used if the\n> code is compiled with CONFIG_USER_ONLY.\noops, thanks for catching it.\nit wasn't intentional, I'll send fixup\n\n> \n> Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj6w65tyLz9s8J\n\tfor ;\n\tThu, 31 Aug 2017 00:15:02 +1000 (AEST)","from localhost ([::1]:50825 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn3lk-0008WQ-Bv\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 10:15:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41594)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn3l9-0008TC-Mv\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:14:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn3l5-0003p0-I2\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 10:14:23 -0400","from mx1.redhat.com ([209.132.183.28]:40568)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn3l5-0003oq-Bl; Wed, 30 Aug 2017 10:14:19 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6BD0CC0587F5;\n\tWed, 30 Aug 2017 14:14:18 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.241])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9458A77557;\n\tWed, 30 Aug 2017 14:14:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6BD0CC0587F5","Date":"Wed, 30 Aug 2017 16:14:16 +0200","From":"Igor Mammedov ","To":"Thomas Huth ","Message-ID":"<20170830161416.07b6d533@nial.brq.redhat.com>","In-Reply-To":"<69765b5d-273d-c695-9094-049e0a486718@redhat.com>","References":"<1504099475-241036-1-git-send-email-imammedo@redhat.com>\n\t<1504099475-241036-9-git-send-email-imammedo@redhat.com>\n\t<69765b5d-273d-c695-9094-049e0a486718@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 30 Aug 2017 14:14:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760723,"web_url":"http://patchwork.ozlabs.org/comment/1760723/","msgid":"<6d03941e-d54e-dc80-4ba3-7c591b7fcddb@redhat.com>","list_archive_url":null,"date":"2017-08-31T07:58:45","subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 30.08.2017 15:24, Igor Mammedov wrote:\n> Remove cpu models that aren't implemented and are not\n> compiled/tested since they are under TODO ifdef\n> which isn't defined in sources.\n> \n> If someone really needs a removed model he/she should add\n> as regular one with corresponding implementation.\n> \n> Signed-off-by: Igor Mammedov \n> ---\n> target/ppc/cpu-models.c | 459 ------------------------------------------------\n> 1 file changed, 459 deletions(-)\n> \n> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\n> index cf878a9..611fc1b 100644\n> --- a/target/ppc/cpu-models.c\n> +++ b/target/ppc/cpu-models.c\n[...]\n> -#endif\n> #if defined(TODO_USER_ONLY)\n> POWERPC_DEF(\"440sp\", CPU_POWERPC_440SP, 440EP,\n> \"PowerPC 440 SP\")\n> @@ -396,20 +207,6 @@\n> POWERPC_DEF(\"440spe\", CPU_POWERPC_440SPE, 440EP,\n> \"PowerPC 440 SPE\")\n> #endif\n> - /* PowerPC 460 family */\n> -#if defined(TODO)\n> - POWERPC_DEF(\"464\", CPU_POWERPC_464, 460,\n> - \"Generic PowerPC 464\")\n> -#endif\n> - /* PowerPC 464 microcontrollers */\n> -#if defined(TODO)\n> - POWERPC_DEF(\"464h90\", CPU_POWERPC_464H90, 460,\n> - \"PowerPC 464H90\")\n> -#endif\n> -#if defined(TODO)\n> - POWERPC_DEF(\"464h90f\", CPU_POWERPC_464H90F, 460F,\n> - \"PowerPC 464H90F\")\n> -#endif\n\nBy the way, I guess you could also remove the 460 stuff from\ntranslate_init.c since there are no 460 CPUs defined in QEMU\n(but I guess that should go into a separate patch instead).\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjZXD536fz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 17:59:24 +1000 (AEST)","from localhost ([::1]:54383 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnKNm-0005rI-Tl\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 03:59:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37794)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnKNK-0005qz-SN\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 03:58:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnKNG-0004fY-1l\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 03:58:54 -0400","from mx1.redhat.com ([209.132.183.28]:54960)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnKNF-0004fA-RD; Thu, 31 Aug 2017 03:58:49 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 70A6D81DEE;\n\tThu, 31 Aug 2017 07:58:48 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2C8EE60842;\n\tThu, 31 Aug 2017 07:58:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 70A6D81DEE","To":"Igor Mammedov , qemu-devel@nongnu.org","References":"<1504099475-241036-1-git-send-email-imammedo@redhat.com>\n\t<1504099475-241036-9-git-send-email-imammedo@redhat.com>","From":"Thomas Huth ","Message-ID":"<6d03941e-d54e-dc80-4ba3-7c591b7fcddb@redhat.com>","Date":"Thu, 31 Aug 2017 09:58:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504099475-241036-9-git-send-email-imammedo@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 31 Aug 2017 07:58:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760741,"web_url":"http://patchwork.ozlabs.org/comment/1760741/","msgid":"<20170831103512.1bf5c908@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-08-31T08:35:12","subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Thu, 31 Aug 2017 09:58:45 +0200\nThomas Huth wrote:\n\n> On 30.08.2017 15:24, Igor Mammedov wrote:\n> > Remove cpu models that aren't implemented and are not\n> > compiled/tested since they are under TODO ifdef\n> > which isn't defined in sources.\n> > \n> > If someone really needs a removed model he/she should add\n> > as regular one with corresponding implementation.\n> > \n> > Signed-off-by: Igor Mammedov \n> > ---\n> > target/ppc/cpu-models.c | 459 ------------------------------------------------\n> > 1 file changed, 459 deletions(-)\n> > \n> > diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\n> > index cf878a9..611fc1b 100644\n> > --- a/target/ppc/cpu-models.c\n> > +++ b/target/ppc/cpu-models.c \n> [...]\n> > -#endif\n> > #if defined(TODO_USER_ONLY)\n> > POWERPC_DEF(\"440sp\", CPU_POWERPC_440SP, 440EP,\n> > \"PowerPC 440 SP\")\n> > @@ -396,20 +207,6 @@\n> > POWERPC_DEF(\"440spe\", CPU_POWERPC_440SPE, 440EP,\n> > \"PowerPC 440 SPE\")\n> > #endif\n> > - /* PowerPC 460 family */\n> > -#if defined(TODO)\n> > - POWERPC_DEF(\"464\", CPU_POWERPC_464, 460,\n> > - \"Generic PowerPC 464\")\n> > -#endif\n> > - /* PowerPC 464 microcontrollers */\n> > -#if defined(TODO)\n> > - POWERPC_DEF(\"464h90\", CPU_POWERPC_464H90, 460,\n> > - \"PowerPC 464H90\")\n> > -#endif\n> > -#if defined(TODO)\n> > - POWERPC_DEF(\"464h90f\", CPU_POWERPC_464H90F, 460F,\n> > - \"PowerPC 464H90F\")\n> > -#endif \n> \n> By the way, I guess you could also remove the 460 stuff from\n> translate_init.c since there are no 460 CPUs defined in QEMU\n> (but I guess that should go into a separate patch instead).\n\nI would leave it to someone who knows more about PPC.\nWould you like to post one?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjbLL4TyLz9s65\n\tfor ;\n\tThu, 31 Aug 2017 18:35:54 +1000 (AEST)","from localhost ([::1]:54526 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnKx5-0006xw-Gu\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 04:35:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45939)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnKwh-0006xp-Ln\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:35:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnKwe-0001l6-HC\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:35:27 -0400","from mx1.redhat.com ([209.132.183.28]:33440)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnKwe-0001kz-Aj; Thu, 31 Aug 2017 04:35:24 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1A49DC0C2E47;\n\tThu, 31 Aug 2017 08:35:15 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.241])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 12E1192D23;\n\tThu, 31 Aug 2017 08:35:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1A49DC0C2E47","Date":"Thu, 31 Aug 2017 10:35:12 +0200","From":"Igor Mammedov ","To":"Thomas Huth ","Message-ID":"<20170831103512.1bf5c908@nial.brq.redhat.com>","In-Reply-To":"<6d03941e-d54e-dc80-4ba3-7c591b7fcddb@redhat.com>","References":"<1504099475-241036-1-git-send-email-imammedo@redhat.com>\n\t<1504099475-241036-9-git-send-email-imammedo@redhat.com>\n\t<6d03941e-d54e-dc80-4ba3-7c591b7fcddb@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 31 Aug 2017 08:35:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760742,"web_url":"http://patchwork.ozlabs.org/comment/1760742/","msgid":"<756f38f0-9435-b05b-679e-fc7b40c6e7ac@redhat.com>","list_archive_url":null,"date":"2017-08-31T08:36:34","subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 31.08.2017 10:35, Igor Mammedov wrote:\n> On Thu, 31 Aug 2017 09:58:45 +0200\n> Thomas Huth wrote:\n> \n>> On 30.08.2017 15:24, Igor Mammedov wrote:\n>>> Remove cpu models that aren't implemented and are not\n>>> compiled/tested since they are under TODO ifdef\n>>> which isn't defined in sources.\n>>>\n>>> If someone really needs a removed model he/she should add\n>>> as regular one with corresponding implementation.\n>>>\n>>> Signed-off-by: Igor Mammedov \n>>> ---\n>>> target/ppc/cpu-models.c | 459 ------------------------------------------------\n>>> 1 file changed, 459 deletions(-)\n>>>\n>>> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c\n>>> index cf878a9..611fc1b 100644\n>>> --- a/target/ppc/cpu-models.c\n>>> +++ b/target/ppc/cpu-models.c \n>> [...]\n>>> -#endif\n>>> #if defined(TODO_USER_ONLY)\n>>> POWERPC_DEF(\"440sp\", CPU_POWERPC_440SP, 440EP,\n>>> \"PowerPC 440 SP\")\n>>> @@ -396,20 +207,6 @@\n>>> POWERPC_DEF(\"440spe\", CPU_POWERPC_440SPE, 440EP,\n>>> \"PowerPC 440 SPE\")\n>>> #endif\n>>> - /* PowerPC 460 family */\n>>> -#if defined(TODO)\n>>> - POWERPC_DEF(\"464\", CPU_POWERPC_464, 460,\n>>> - \"Generic PowerPC 464\")\n>>> -#endif\n>>> - /* PowerPC 464 microcontrollers */\n>>> -#if defined(TODO)\n>>> - POWERPC_DEF(\"464h90\", CPU_POWERPC_464H90, 460,\n>>> - \"PowerPC 464H90\")\n>>> -#endif\n>>> -#if defined(TODO)\n>>> - POWERPC_DEF(\"464h90f\", CPU_POWERPC_464H90F, 460F,\n>>> - \"PowerPC 464H90F\")\n>>> -#endif \n>>\n>> By the way, I guess you could also remove the 460 stuff from\n>> translate_init.c since there are no 460 CPUs defined in QEMU\n>> (but I guess that should go into a separate patch instead).\n> \n> I would leave it to someone who knows more about PPC.\n> Would you like to post one?\n\nSure, I'll try to come up with a patch once this one here has been merged.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=tempfail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjbNY2Xw6z9t2Q\n\tfor ;\n\tThu, 31 Aug 2017 18:37:49 +1000 (AEST)","from localhost ([::1]:54530 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnKyx-0007s5-DG\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 04:37:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46236)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnKyS-0007qj-0o\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:37:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnKyO-0002Vm-TV\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:37:16 -0400","from mx1.redhat.com ([209.132.183.28]:48034)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnKyO-0002Vc-N2; Thu, 31 Aug 2017 04:37:12 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 10B034E4C3;\n\tThu, 31 Aug 2017 08:36:37 +0000 (UTC)","from [10.36.116.27] (ovpn-116-27.ams2.redhat.com [10.36.116.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id EF5659ECC9;\n\tThu, 31 Aug 2017 08:36:35 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 10B034E4C3","To":"Igor Mammedov ","References":"<1504099475-241036-1-git-send-email-imammedo@redhat.com>\n\t<1504099475-241036-9-git-send-email-imammedo@redhat.com>\n\t<6d03941e-d54e-dc80-4ba3-7c591b7fcddb@redhat.com>\n\t<20170831103512.1bf5c908@nial.brq.redhat.com>","From":"Thomas Huth ","Message-ID":"<756f38f0-9435-b05b-679e-fc7b40c6e7ac@redhat.com>","Date":"Thu, 31 Aug 2017 10:36:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831103512.1bf5c908@nial.brq.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 31 Aug 2017 08:37:11 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non\n\timplemented cpu models","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]