[{"id":1760262,"web_url":"http://patchwork.ozlabs.org/comment/1760262/","msgid":"","list_archive_url":null,"date":"2017-08-30T15:06:47","subject":"Re: [LEDE-DEV] [PATCH ubox 1/3] kmodloader: fix endianess check","submitter":{"id":7496,"url":"http://patchwork.ozlabs.org/api/people/7496/","name":"John Crispin","email":"john@phrozen.org"},"content":"On 30/08/17 15:23, Hans Dedecker wrote:\n> Use __BYTE_ORDER macro to check system endianess as the macro's\n> __LITTLE_ENDIAN, __BIG_ENDIAN are defined irrespective of the\n> sytem endianess leading to an endianess check failure on big\n> endian systems.\n\n\nThanks !\n\nAcked-by: John Crispin ... feel free to push\n\n\n\n>\n> Signed-off-by: Hans Dedecker \n> ---\n> kmodloader.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/kmodloader.c b/kmodloader.c\n> index a6aa795..a4d492d 100644\n> --- a/kmodloader.c\n> +++ b/kmodloader.c\n> @@ -216,9 +216,9 @@ static int elf_find_section(char *map, const char *section, unsigned int *offset\n> \tint clazz = map[EI_CLASS];\n> \tint endian = map[EI_DATA];\n> \n> -#if defined(__LITTLE_ENDIAN)\n> +#if __BYTE_ORDER == __LITTLE_ENDIAN\n> \tif (endian != ELFDATA2LSB)\n> -#elif defined(__BIG_ENDIAN)\n> +#elif __BYTE_ORDER == __BIG_ENDIAN\n> \tif (endian != ELFDATA2MSB)\n> #else\n> #error \"unsupported endian\"","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"PwKxQVqe\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj84X4mQwz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 01:07:24 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn4aJ-0006fH-1J; Wed, 30 Aug 2017 15:07:15 +0000","from nbd.name ([2a01:4f8:131:30e2::2])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn4aF-0006eF-6a\n\tfor lede-dev@lists.infradead.org; Wed, 30 Aug 2017 15:07:13 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:Message-ID:\n\tFrom:References:To:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=pnm9l8GbGFZc9+CgYcRcLJBaH/6tBhGm1yA4O8ZjCls=;\n\tb=PwKxQVqec4X4qn3Jx8dj/ABMe\n\tVuo6eCu9y8nH/goXqJylH1iHW5hZPvK8a/60M9fmEK9OezMdB9mIPAcPePbyo2XP8t+SzTrmMD4Rz\n\tfMDCBJ7DknGodP9dY9PjZyJtZwEHK96CM2c+Brje01vrn+ldRspTRugtaBHDDtZaRrNtu8PTNtWX0\n\tRo7KXjM061j3s/HGgHjaY8U6MCXqvdVXZ42gWyq53ENZyHgWNN37MPMsudlXhkyHmlFEqBctxZgaH\n\tWL++1dgBq1+6tHEkpTj3F5UAGx3XmEBAdGgYosyd4CpoK6QVIjUHzAIfNeWGUwnrP+O1W+paBVoB7\n\tXTzprL5hQ==;","To":"Hans Dedecker , f.fainelli@gmail.com,\n\tlede-dev@lists.infradead.org","References":"<1504099438-25344-1-git-send-email-dedeckeh@gmail.com>","From":"John Crispin ","Message-ID":"","Date":"Wed, 30 Aug 2017 17:06:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504099438-25344-1-git-send-email-dedeckeh@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170830_080711_436539_661CCCF3 ","X-CRM114-Status":"UNSURE ( 8.92 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] [PATCH ubox 1/3] kmodloader: fix endianess check","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1760386,"web_url":"http://patchwork.ozlabs.org/comment/1760386/","msgid":"<29b204cd-a92a-62ea-5b66-75daac019b8e@gmail.com>","list_archive_url":null,"date":"2017-08-30T18:00:09","subject":"Re: [LEDE-DEV] [PATCH ubox 1/3] kmodloader: fix endianess check","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 08/30/2017 06:23 AM, Hans Dedecker wrote:\n> Use __BYTE_ORDER macro to check system endianess as the macro's\n> __LITTLE_ENDIAN, __BIG_ENDIAN are defined irrespective of the\n> sytem endianess leading to an endianess check failure on big\n> endian systems.\n\nGood catch, can you add a Fixes: tag for this?\n\n> \n> Signed-off-by: Hans Dedecker \n> ---\n> kmodloader.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/kmodloader.c b/kmodloader.c\n> index a6aa795..a4d492d 100644\n> --- a/kmodloader.c\n> +++ b/kmodloader.c\n> @@ -216,9 +216,9 @@ static int elf_find_section(char *map, const char *section, unsigned int *offset\n> \tint clazz = map[EI_CLASS];\n> \tint endian = map[EI_DATA];\n> \n> -#if defined(__LITTLE_ENDIAN)\n> +#if __BYTE_ORDER == __LITTLE_ENDIAN\n> \tif (endian != ELFDATA2LSB)\n> -#elif defined(__BIG_ENDIAN)\n> +#elif __BYTE_ORDER == __BIG_ENDIAN\n> \tif (endian != ELFDATA2MSB)\n> #else\n> #error \"unsupported endian\"\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"lev+UCOl\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fMPv5Xb6\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCwh2VwKz9s7f\n\tfor ;\n\tThu, 31 Aug 2017 04:00:52 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn7IC-00078P-IO; Wed, 30 Aug 2017 18:00:44 +0000","from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn7I8-0006PD-Pq\n\tfor lede-dev@lists.infradead.org; Wed, 30 Aug 2017 18:00:42 +0000","by mail-wm0-x244.google.com with SMTP id l19so2571967wmi.1\n\tfor ;\n\tWed, 30 Aug 2017 11:00:19 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tc9sm4463860wrd.93.2017.08.30.11.00.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 11:00:17 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Cc:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=AkbMj1sdER+ctLxSevYS01BCDfRe+SQMU1W1gZPbBj4=;\n\tb=lev+UCOlt5TzEj\n\tFPk4N+OyQp2KRkuO/AefRpeYrsFLrWm6s7ACCyAzBUHLyytxBWlQkHFQia7x1/xIPkUqt0Vmbi42N\n\tPtvZJ4jkbqcvqukC9vZJw00nW+PBD0CsXhDUKB1V9Bm71HcEE2+Z65SxlQNiJcmN11oGaVgyALfV0\n\t6KfFx+6Q1vd37ozFAuFEnfuC3xCYGQRLBjkJ5atJxsflky5+ouxKXWUDsQ6Hzc18l1A2vg6tsqeNG\n\t1Og/m9lenh8QWQBAHIoe4KKnAc6MPCzfnqxL+mvv7sv5nGZUcbNd751d5NUPX8FvtftqxVTSIdHGN\n\tY7xV4fjw3P8klsLy2S2A==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=kZuJcoefIpc0pcR+3yS7B/cP7r524g+ODakBq1l3xe4=;\n\tb=fMPv5Xb6LWeo8ICHPjC9j/kBrt5ZR8qvQ5cL+XQGSoWsjjjtaYcdJpgA5iOgMJqgi9\n\t0X4ihzULcFgu0O98y+zSrAblZRkr8VY6s5DdSH9yBMdo5UqZ6E3kvklqtjVm7RXgUNqE\n\tU61SNznYTpWAFqfvxU7F++KQ/dYgKpzum1L0qNsneV9xnc2RiaywJ/N3HiRkCt4m7MUk\n\tpXaah+lxWjVSxFmtwkNjFIL4lMysmhrXpOFmAB9S2cF9KV6C+YeazGGGkAckkjx2KNME\n\teaVWr4RWwUpGElFcuTwTlyVo1Q8SiCD0VFBxB6HL/8DnbRQ+pC9e4LMhKWgLWkmr4MMb\n\tM8VQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=kZuJcoefIpc0pcR+3yS7B/cP7r524g+ODakBq1l3xe4=;\n\tb=T5IDnCJJL1C8O9GAeutJM8inqPkhj6jqN7v6zcvAofqpz+EhiUe3Bih1Z1yctawE0P\n\tpZslVVQdYjV8G/SyiPam2Cx85B2IDDodj5G6+xJWZZO6kvRGixyiOq2qn5pezQodfQb8\n\tQhvqhDr5didgCkJJG3ZW3laJn5pPbEGyK41fVhQerkvHpTQzlO1lqNh8yxj+IqtlZ1Lz\n\t4vk2FJjb8mJ+lZ900+sX5b11W6nqbupPTCOlqzebzWdCI7e51JpQ+DXZxPStM0/oSSUf\n\t1Vdl96ANCuYiIqzqngKITni2OLEH+gAawq5L80DtP5hvbdaZZzJcdJ9YHR2bs6mty8Km\n\tFuuA==","X-Gm-Message-State":"AHYfb5h0CBdrPWo9VeZWM0kuamODySsoOJ1mvoIe3rfZFj572vXSz3kD\n\tUH+yZ3L0Yj+VoAv8z50=","X-Received":"by 10.28.1.79 with SMTP id 76mr1885258wmb.9.1504116018091;\n\tWed, 30 Aug 2017 11:00:18 -0700 (PDT)","To":"Hans Dedecker , john@phrozen.org,\n\tlede-dev@lists.infradead.org","References":"<1504099438-25344-1-git-send-email-dedeckeh@gmail.com>","From":"Florian Fainelli ","Message-ID":"<29b204cd-a92a-62ea-5b66-75daac019b8e@gmail.com>","Date":"Wed, 30 Aug 2017 11:00:09 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504099438-25344-1-git-send-email-dedeckeh@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170830_110041_113062_D2434DC3 ","X-CRM114-Status":"GOOD ( 11.71 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (f.fainelli[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH ubox 1/3] kmodloader: fix endianess check","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]