[{"id":1760187,"web_url":"http://patchwork.ozlabs.org/comment/1760187/","msgid":"<542c8ecb-6bb1-a27b-9335-70a443004482@linaro.org>","list_archive_url":null,"date":"2017-08-30T14:08:11","subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 30/08/2017 09:44, Florian Weimer wrote:\n> On very large multi-processor systems, creating hundreds of threads\n> runs into a test time out.  The tests do not seem to benefit from\n> massive over-scheduling.\n> \n> 2017-08-30  Florian Weimer  <fweimer@redhat.com>\n> \n> \tDo not scale NPTL tests with available number of CPUs.\n> \t* nptl/tst-cond16.c (count): Sett to constant value of 8.\n> \t* nptl/tst-cond18.c (count): Likewise.\n\nLGTM.\n\n> \n> diff --git a/nptl/tst-cond16.c b/nptl/tst-cond16.c\n> index 032677adcc..b3bfb90bd4 100644\n> --- a/nptl/tst-cond16.c\n> +++ b/nptl/tst-cond16.c\n> @@ -28,7 +28,7 @@ pthread_cond_t cv = PTHREAD_COND_INITIALIZER;\n>  pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;\n>  bool n, exiting;\n>  FILE *f;\n> -int count;\n> +enum { count = 8 };\t\t/* Number of worker threads.  */\n>  \n>  void *\n>  tf (void *dummy)\n> @@ -71,11 +71,6 @@ do_test (void)\n>        return 1;\n>      }\n>  \n> -  count = sysconf (_SC_NPROCESSORS_ONLN);\n> -  if (count <= 0)\n> -    count = 1;\n> -  count *= 4;\n> -\n>    pthread_t th[count];\n>    pthread_attr_t attr;\n>    int i, ret, sz;\n> diff --git a/nptl/tst-cond18.c b/nptl/tst-cond18.c\n> index 187f3af1df..6276110ec2 100644\n> --- a/nptl/tst-cond18.c\n> +++ b/nptl/tst-cond18.c\n> @@ -28,7 +28,8 @@\n>  pthread_cond_t cv = PTHREAD_COND_INITIALIZER;\n>  pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;\n>  bool exiting;\n> -int fd, count, spins, nn;\n> +int fd, spins, nn;\n> +enum { count = 8 };\t\t/* Number of worker threads.  */\n>  \n>  void *\n>  tf (void *id)\n> @@ -82,11 +83,6 @@ do_test (void)\n>        return 1;\n>      }\n>  \n> -  count = sysconf (_SC_NPROCESSORS_ONLN);\n> -  if (count <= 0)\n> -    count = 1;\n> -  count *= 8;\n> -\n>    pthread_t th[count + 1];\n>    pthread_attr_t attr;\n>    int i, ret, sz;\n>","headers":{"Return-Path":"<libc-alpha-return-83864-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83864-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"GyhZ148n\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj6mg0s4gz9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 00:08:33 +1000 (AEST)","(qmail 128984 invoked by alias); 30 Aug 2017 14:08:22 -0000","(qmail 128901 invoked by uid 89); 30 Aug 2017 14:08:21 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=hG/Vyi9rGSuQyn/l\n\tMBChcv1C0DDkpPdfB2ceHBh7pJ1aJkcDrTgMGpJQAgpXsVUFdt+KQGftndl21Ajk\n\tTpe7r7FT5bok0+3P/avQmtL4B+jXr7l/k29KU7TU4sJRKyHQ9B+R80QA5Hf4XPz9\n\tH9aiBVYaYK+Qedv1AZUmkQafIxY=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=ojUG+xXfmMTYAPeigqB2/e\n\tZTQDY=; b=GyhZ148nK89ghnHuEYVfVVcWyR/bT0qDie5e3APlTaPTrJT3zEvlqu\n\t9yG7jk6fzjUyrYgzcRFItPVE7a4LMjkagO1bmWxsSVCrfF1X0FDDb6sH1zuEt331\n\tDOki6NHBxOrg3g1uGSogO3me0Jv5VkWYyyg1buoKBvxyIFCKQEke8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.4 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=H*M:9335","X-HELO":"mail-qt0-f172.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=HPiShsGktvhARyvCttduTRS7tqqwDErfrB7bsVtdA2k=;\n\tb=qHT+NOo8wyznZWa5h81zHgZc+wWEbFVf6Je8F+v3RltWLpproW0pz3vhnd/hHBbOi5\n\tRETJBIp9yrU1pZakKjAiSaRD3JxxM3ubwdlHTQ7XtFbeKmB7Niwsvx1rWL3nJ+QUXb42\n\txZxtTr5yNc+PGUPeS6B/4YS9RJsV2cCKGANd9qEqbaLzigGlBDj2oePRGvU3vxbZ7dQy\n\tYaAtKFZMJKjaoTyXnyvsX8SZNzvMpHJuUaif22Mzo6nLEYMJN0a7tH9RaD+WbiGS7OQm\n\tIyuyTlBcNsUVDSMeAelFDJ8y3sypXvNSMcBKnjEEGA/DRTUW8YhsbeU3rdo9P+NEBc1R\n\tiKdQ==","X-Gm-Message-State":"AHPjjUgCdq7JJ3peG2K5ZEHvgTX7345bX4cXZom0X5rWoMrZOPZX4+E6\n\tpUKA337vKOv52HEhelj/bg==","X-Google-Smtp-Source":"ADKCNb68/ceInYicB89mQ04744km9TVRnrtTEvAcBaTM4reiYIty7rC2ULd1I+h0xQprnAupk0Oxmw==","X-Received":"by 10.200.1.4 with SMTP id e4mr2237264qtg.159.1504102096384;\n\tWed, 30 Aug 2017 07:08:16 -0700 (PDT)","Subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","To":"libc-alpha@sourceware.org","References":"<20170830124448.87C7741BE92E8@oldenburg.str.redhat.com>","From":"Adhemerval Zanella <adhemerval.zanella@linaro.org>","Message-ID":"<542c8ecb-6bb1-a27b-9335-70a443004482@linaro.org>","Date":"Wed, 30 Aug 2017 11:08:11 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170830124448.87C7741BE92E8@oldenburg.str.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1760199,"web_url":"http://patchwork.ozlabs.org/comment/1760199/","msgid":"<CAKCAbMjwxLqr4xi=gncTNDJRUvke+nNwUzhMzTiQ6NKyahzgWA@mail.gmail.com>","list_archive_url":null,"date":"2017-08-30T14:21:16","subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","submitter":{"id":65878,"url":"http://patchwork.ozlabs.org/api/people/65878/","name":"Zack Weinberg","email":"zackw@panix.com"},"content":"On Wed, Aug 30, 2017 at 10:08 AM, Adhemerval Zanella\n<adhemerval.zanella@linaro.org> wrote:\n> On 30/08/2017 09:44, Florian Weimer wrote:\n>> On very large multi-processor systems, creating hundreds of threads\n>> runs into a test time out.  The tests do not seem to benefit from\n>> massive over-scheduling.\n>>\n>> 2017-08-30  Florian Weimer  <fweimer@redhat.com>\n>>\n>>       Do not scale NPTL tests with available number of CPUs.\n>>       * nptl/tst-cond16.c (count): Sett to constant value of 8.\n\nThis verb is spelled \"set\" in English, not \"sett\".\n\nShould it maybe be min(8, ncpus) instead of just 8?\n\nzw","headers":{"Return-Path":"<libc-alpha-return-83865-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83865-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"YwO2tRIB\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj73W21rdz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 00:21:27 +1000 (AEST)","(qmail 30611 invoked by alias); 30 Aug 2017 14:21:21 -0000","(qmail 30577 invoked by uid 89); 30 Aug 2017 14:21:20 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=VZcC\n\tkuoN8E8XEWT9xXjbfk4bvUktGu4NCW2KKdj680BakAIR0GSMj4K+ige8GW7wS09t\n\tk1XWL7ZDbD/LYuOUWTG3whZ7qtk2OeZqNZYIeKf9DsVaQRFoNcUqC3YqBateF6K9\n\tEPSErBVzWEpfnducWB6QNyNlV9vkdAo6FAQTSMo=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=iTJtMCSIpi\n\tiTtGm4Lz7mhsUp984=; b=YwO2tRIBK2TrjZOg3zsOO6iOfB3B9se1g+TPDrm4WU\n\tOzI8gXCCdzLqNHJrYL4X1S7dkJ/J9C6cs/qZjGbQnIeRq5RKo4UYY3YnfX6ptjw7\n\tMhlbENWLG/UBG7ZpwFhFfjK40XzFM/scFtyUHnWBiRyvVe3Hg4LNFaphTkWOxl+o\n\tI=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.5 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mailbackend.panix.com","X-Gm-Message-State":"AHYfb5iVIDOUY5VDxPxI6j8Hy01twQN1WuaEynfJWhyqCP9n7d8iBmUD\n\tLJ8VlMl7/xrQB//t2qxnr6vmPPDGEg==","X-Google-Smtp-Source":"ADKCNb6o/7W9kt6GSByW4a2JRbdyQzAHladCTFATNawt3/29g2Vf6qIVh/cYTBlbOgN5+RxltvkLDAe2xphCLIB1pus=","X-Received":"by 10.36.7.21 with SMTP id f21mr1807106itf.77.1504102877243; Wed,\n\t30 Aug 2017 07:21:17 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<542c8ecb-6bb1-a27b-9335-70a443004482@linaro.org>","References":"<20170830124448.87C7741BE92E8@oldenburg.str.redhat.com>\n\t<542c8ecb-6bb1-a27b-9335-70a443004482@linaro.org>","From":"Zack Weinberg <zackw@panix.com>","Date":"Wed, 30 Aug 2017 10:21:16 -0400","X-Gmail-Original-Message-ID":"<CAKCAbMjwxLqr4xi=gncTNDJRUvke+nNwUzhMzTiQ6NKyahzgWA@mail.gmail.com>","Message-ID":"<CAKCAbMjwxLqr4xi=gncTNDJRUvke+nNwUzhMzTiQ6NKyahzgWA@mail.gmail.com>","Subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","To":"Adhemerval Zanella <adhemerval.zanella@linaro.org>","Cc":"GNU C Library <libc-alpha@sourceware.org>","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1760212,"web_url":"http://patchwork.ozlabs.org/comment/1760212/","msgid":"<7c537e36-87f4-f487-ebbb-3a32d62272c9@redhat.com>","list_archive_url":null,"date":"2017-08-30T14:32:39","subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 08/30/2017 04:21 PM, Zack Weinberg wrote:\n> On Wed, Aug 30, 2017 at 10:08 AM, Adhemerval Zanella\n> <adhemerval.zanella@linaro.org> wrote:\n>> On 30/08/2017 09:44, Florian Weimer wrote:\n>>> On very large multi-processor systems, creating hundreds of threads\n>>> runs into a test time out.  The tests do not seem to benefit from\n>>> massive over-scheduling.\n>>>\n>>> 2017-08-30  Florian Weimer  <fweimer@redhat.com>\n>>>\n>>>       Do not scale NPTL tests with available number of CPUs.\n>>>       * nptl/tst-cond16.c (count): Sett to constant value of 8.\n> \n> This verb is spelled \"set\" in English, not \"sett\".\n\nI fixed that before committing.\n\n> Should it maybe be min(8, ncpus) instead of just 8?\n\nI don't think that's worth the added complexity.  Even on a UP system,\nthe overscheduling does not introduce a significant delay in thread\ncreation and termination.\n\n$ time taskset 1 bash testrun.sh nptl/tst-cond16\n\nreal    0m20.005s\nuser    0m19.984s\nsys     0m0.020s\n\nThanks,\nFlorian","headers":{"Return-Path":"<libc-alpha-return-83867-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83867-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"sHy+TA9+\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7Jj58Qxz9s8P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 00:32:53 +1000 (AEST)","(qmail 102854 invoked by alias); 30 Aug 2017 14:32:45 -0000","(qmail 102838 invoked by uid 89); 30 Aug 2017 14:32:43 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:cc:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=nwuuoRR7Nifkze+w\n\tezS6dB1+/95GSO/y386Jjqorml956Ci+GmkJzoTJw2bigwNd9ox+PryiLcRbA+Nj\n\tKhY+rTOzcyemgj0GBKX8070gxZmFw2g6Bhb/rqaKPw06G6xZapGNn3Yalz1G604B\n\t9w6cQAIwS4hs+Qsj3e7Z5ljMJB8=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:cc:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=P+rrvn02Vg291NeCPViOoS\n\t0LbOw=; b=sHy+TA9+rFeE1PnbzgO/oTccXH46Rt0bnyn+dT5lF7xbpu7K1gyrk3\n\t2dSItu9roiFwfH6HSGIXf8r9Zf43i9tpGa7dcBirOjJaC/StvZN4RjRv/QXAmsf8\n\tvpeHYaSACAtae8OPcm7vq0TmUaBmtWHIZ6hGSTQSvWaOa7bE4kHyY=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2 spammy=termination,\n\tHContent-Transfer-Encoding:8bit","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BBA64C0587E8","Subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","To":"Zack Weinberg <zackw@panix.com>","References":"<20170830124448.87C7741BE92E8@oldenburg.str.redhat.com>\n\t<542c8ecb-6bb1-a27b-9335-70a443004482@linaro.org>\n\t<CAKCAbMjwxLqr4xi=gncTNDJRUvke+nNwUzhMzTiQ6NKyahzgWA@mail.gmail.com>","From":"Florian Weimer <fweimer@redhat.com>","Cc":"libc-alpha@sourceware.org","Message-ID":"<7c537e36-87f4-f487-ebbb-3a32d62272c9@redhat.com>","Date":"Wed, 30 Aug 2017 16:32:39 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<CAKCAbMjwxLqr4xi=gncTNDJRUvke+nNwUzhMzTiQ6NKyahzgWA@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit"}},{"id":1760223,"web_url":"http://patchwork.ozlabs.org/comment/1760223/","msgid":"<CAKCAbMg=QTwJ=1rF1Xi537VPCMTyc1J0VNrVobXLiPLt+WOjjQ@mail.gmail.com>","list_archive_url":null,"date":"2017-08-30T14:43:48","subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","submitter":{"id":65878,"url":"http://patchwork.ozlabs.org/api/people/65878/","name":"Zack Weinberg","email":"zackw@panix.com"},"content":"On Wed, Aug 30, 2017 at 10:32 AM, Florian Weimer <fweimer@redhat.com> wrote:\n> On 08/30/2017 04:21 PM, Zack Weinberg wrote:\n>> Should it maybe be min(8, ncpus) instead of just 8?\n>\n> I don't think that's worth the added complexity.  Even on a UP system,\n> the overscheduling does not introduce a significant delay in thread\n> creation and termination.\n\nOK, thanks for clarifying.\n\nzw","headers":{"Return-Path":"<libc-alpha-return-83868-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83868-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ANZZOXGi\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7YW3QB4z9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 00:43:59 +1000 (AEST)","(qmail 72375 invoked by alias); 30 Aug 2017 14:43:53 -0000","(qmail 72311 invoked by uid 89); 30 Aug 2017 14:43:52 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=H4wC\n\tgzGmcsROEQwvofVFF091o6wmv5cHO8X8X02dRdx+NNQvLhKbXrsUpe6XzLLKcq/6\n\tZgKA/uGezwcoik/PHUthrxwlx7nOVufp9i3DhKpTyIK6YKd1Q38T12PtHE3D1I/G\n\trKp4UA6aVR7LHqkdA0Tzx5AFZSIxzNSZxM6QYEI=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=w7vql4ZTUe\n\tHiRk/S+jxIpSBvXz4=; b=ANZZOXGirUr0jvguyqzhDzQfWglfBefwc7EYes0cUW\n\t6bEMYafZaavAREyTkTzjAEb/hsmRSjqBrQgzdpH0cXwcjz0CVOqgsn6vw8WBMjCZ\n\tv5J7E3yVd/Hr28334G9+lZ0q5CBeI3d/LXF1qZgFEPk8lNeBMndePNB6l6cpr73N\n\ts=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.5 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=termination,\n\tclarifying","X-HELO":"mailbackend.panix.com","X-Gm-Message-State":"AHYfb5iX7ky7shXySYw7/ryZjgBNr/FC1YcK2+0qjfYDk0SZFCp9vDND\n\trYUZSiumkdIERnm7p4TFmBBD3WK4ng==","X-Google-Smtp-Source":"ADKCNb7cVxbFFjgHE/qQyNAWz3ipUq4QLZ0yVaykT2Rd7h9dUBAUpjSXtxVaG3WgCIN0Vm9QK9B1kPIZd79JtUemH/g=","X-Received":"by 10.36.139.132 with SMTP id g126mr1778932ite.135.1504104229319;\n\tWed, 30 Aug 2017 07:43:49 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<7c537e36-87f4-f487-ebbb-3a32d62272c9@redhat.com>","References":"<20170830124448.87C7741BE92E8@oldenburg.str.redhat.com>\n\t<542c8ecb-6bb1-a27b-9335-70a443004482@linaro.org>\n\t<CAKCAbMjwxLqr4xi=gncTNDJRUvke+nNwUzhMzTiQ6NKyahzgWA@mail.gmail.com>\n\t<7c537e36-87f4-f487-ebbb-3a32d62272c9@redhat.com>","From":"Zack Weinberg <zackw@panix.com>","Date":"Wed, 30 Aug 2017 10:43:48 -0400","X-Gmail-Original-Message-ID":"<CAKCAbMg=QTwJ=1rF1Xi537VPCMTyc1J0VNrVobXLiPLt+WOjjQ@mail.gmail.com>","Message-ID":"<CAKCAbMg=QTwJ=1rF1Xi537VPCMTyc1J0VNrVobXLiPLt+WOjjQ@mail.gmail.com>","Subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","To":"Florian Weimer <fweimer@redhat.com>","Cc":"GNU C Library <libc-alpha@sourceware.org>","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1760240,"web_url":"http://patchwork.ozlabs.org/comment/1760240/","msgid":"<02dfefd3-cf34-01f9-df0e-f7e64969e7e0@redhat.com>","list_archive_url":null,"date":"2017-08-30T14:51:39","subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","submitter":{"id":22438,"url":"http://patchwork.ozlabs.org/api/people/22438/","name":"Carlos O'Donell","email":"carlos@redhat.com"},"content":"On 08/30/2017 07:44 AM, Florian Weimer wrote:\n> On very large multi-processor systems, creating hundreds of threads\n> runs into a test time out.  The tests do not seem to benefit from\n> massive over-scheduling.\n> \n> 2017-08-30  Florian Weimer  <fweimer@redhat.com>\n> \n> \tDo not scale NPTL tests with available number of CPUs.\n> \t* nptl/tst-cond16.c (count): Sett to constant value of 8.\n> \t* nptl/tst-cond18.c (count): Likewise.\n\nThe patch looks good to me.\n\nWhat I would *like* to see here is a support override for this.\n\nAn API which passes in a default, 8 cpus, and the output is 8 cpus,\nso long as the support library doesn't override the number of cpus\nto use.\n\nThis way I can re-run the entire testsuite with maximum number of\ncpus for tests that claim such scalability.","headers":{"Return-Path":"<libc-alpha-return-83870-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83870-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"yDXZ73+2\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj7kj2Q0kz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 00:51:57 +1000 (AEST)","(qmail 113866 invoked by alias); 30 Aug 2017 14:51:49 -0000","(qmail 113810 invoked by uid 89); 30 Aug 2017 14:51:48 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=exK8HXyMfd4uSKFk\n\tf8e0neHMJQBIpIjRczDwZwuYPeEvk1ceuEBZXJ9ZFEPET/K8e3mJ5DkChF8+ESme\n\t/j4x2RjnQ4XE5u6vYi9jPf+7U9djLky+W+sOwQDi4Ec+KbboIW83VAnf6/SUdmcy\n\t7XjVnh8XMtUAIVTEnDkBFQrzWiU=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=Eau73GUSZYXLiEhcJ38DWM\n\tegf1U=; b=yDXZ73+2XoEq1bwtc9rN0+SUN0OZihGXuRaWn9tlxS3KxjZ5mxguWi\n\tkoxCl764bhStfvjSZ3ELPg2fF/Z+MkkBmurwn5O7938z6ApL5q/ZgH2lyAItmHtE\n\tK3Wfv262G8QFacKpKzTdFrXiv2AgyvlZPC+J7lm6St2oJOZTfDcxk=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.7 required=5.0 tests=AWL, BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=no version=3.3.2\n\tspammy=Hx-languages-length:857, claim","X-HELO":"mail-qk0-f180.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=F7wl1vg5v8AffyFM+xNJg4etPt/OP1rOD1BCgpaSilM=;\n\tb=KgadCVvtqEb7fTjFlf1C2X56zs64X4fTRV09LGO3zXpByVeZGpOaoFkVklSU0Oy7yH\n\t46ppdXwO1AteRSG4PTh274XuatqwOvMoHQ8mC6FUDORpnEGmWxJnCLtSI6V9Se2ha4fF\n\t1xYZjJHaKwZT9Y+U5JloyMqCGRL27csg7Nkcz0+H8n2EimIm8z5hlHNIIQP0XbkuJsNt\n\t0DXbk/so2bqF0s9iWN503aFIPUsia7lTfZJJYo0dX8gHXmgGIneECO7UDx9nyVdGySh4\n\tSoZmszHtHyD7oRL0FJ7+2eLMrrjk3oXvKhGolBgdsRMLsBKE8Vl5GiIg6GCL/97qcbZp\n\trB2w==","X-Gm-Message-State":"AHYfb5jhg72cKcbIyU5apfgr2XCnBARz+lZzwvDMwQqU7D48a6YTioCS\n\t9qxf4zZm7IhXHciMhYaUCw==","X-Google-Smtp-Source":"ADKCNb6E2zTjAjHhw+misvXpBJ+eflbB1kJGjOlStuDcZDo/Udo9Iic2m3Ow5aRir4ycpKbtnXJ4eQ==","X-Received":"by 10.55.4.1 with SMTP id 1mr10209449qke.301.1504104705188;\n\tWed, 30 Aug 2017 07:51:45 -0700 (PDT)","Subject":"Re: [PATCH] Do not scale NPTL tests with available number of CPUs","To":"Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org","References":"<20170830124448.87C7741BE92E8@oldenburg.str.redhat.com>","From":"Carlos O'Donell <carlos@redhat.com>","Message-ID":"<02dfefd3-cf34-01f9-df0e-f7e64969e7e0@redhat.com>","Date":"Wed, 30 Aug 2017 09:51:39 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170830124448.87C7741BE92E8@oldenburg.str.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]