[{"id":1760374,"web_url":"http://patchwork.ozlabs.org/comment/1760374/","msgid":"","list_archive_url":null,"date":"2017-08-30T17:43:49","subject":"Re: [patch net-next 7/8] mlxsw: spectrum_router: Add support for\n\tsetting counters on IPv6 neighbors","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 8/30/17 6:03 AM, Jiri Pirko wrote:\n> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n> index db57c0c..0cf6810 100644\n> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n> @@ -1008,21 +1008,33 @@ mlxsw_sp_neigh_entry_remove(struct mlxsw_sp *mlxsw_sp,\n> }\n> \n> static bool\n> -mlxsw_sp_neigh4_counter_should_alloc(struct mlxsw_sp *mlxsw_sp)\n> +mlxsw_sp_neigh_counter_should_alloc(struct mlxsw_sp *mlxsw_sp,\n> +\t\t\t\t struct mlxsw_sp_neigh_entry *neigh_entry)\n> {\n> \tstruct devlink *devlink;\n> +\tconst char *table_name;\n> +\n> +\tswitch (mlxsw_sp_neigh_entry_type(neigh_entry)) {\n> +\tcase AF_INET:\n> +\t\ttable_name = MLXSW_SP_DPIPE_TABLE_NAME_HOST4;\n> +\t\tbreak;\n> +\tcase AF_INET6:\n> +\t\ttable_name = MLXSW_SP_DPIPE_TABLE_NAME_HOST6;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tWARN_ON(1);\n\nAnother unnecessary WARN_ON\n\n> +\t\treturn false;\n> +\t}\n> \n> \tdevlink = priv_to_devlink(mlxsw_sp->core);\n> -\treturn devlink_dpipe_table_counter_enabled(devlink,\n> -\t\t\t\t\t\t MLXSW_SP_DPIPE_TABLE_NAME_HOST4);\n> +\treturn devlink_dpipe_table_counter_enabled(devlink, table_name);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Xr7OPgdD\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjCY63C5Wz9sN5\n\tfor ;\n\tThu, 31 Aug 2017 03:43:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751728AbdH3Rnw (ORCPT );\n\tWed, 30 Aug 2017 13:43:52 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:33386 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751439AbdH3Rnv (ORCPT\n\t); Wed, 30 Aug 2017 13:43:51 -0400","by mail-pg0-f66.google.com with SMTP id m15so5562974pgc.0\n\tfor ; Wed, 30 Aug 2017 10:43:51 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:d89a:ab61:c4f1:b1cb])\n\tby smtp.googlemail.com with ESMTPSA id\n\tj187sm4844921pgc.10.2017.08.30.10.43.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 10:43:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=DAFyZsWQiaNmiN8em+FaZ0cq1F3/k4ulo3wtYIc2w40=;\n\tb=Xr7OPgdDu0tGTWNWfWxaPqfJqUuXr8iL78OjkZOFWXxGvaesfP78iqmqyEtzVBFpXd\n\tgEkbHBi7RT9umwzJMilKL/IFXxkb1RLOA8Q4/IS3BjGjnzVT8CrzH9iVVjzwhm+FDbpw\n\tadfjE/RxcgPw5ued8ZZ/S65SmJAKgekRrIm/1pWeFA2dv8x3TxerjaPs1JVcsfqHXWBy\n\tq2ZYheAz3w8QHvURLC14Xq1ELibrqaP31V0gcCBYjY2wyRYJ59C/+Qt4NRA9iTRmtGe0\n\t19VC42z8F4WJvq/nYxQtGgAWFVhu19mD5bju+ZG0PZ6fhEZmhAjoVrz6egHl1lLZngmf\n\tGR1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=DAFyZsWQiaNmiN8em+FaZ0cq1F3/k4ulo3wtYIc2w40=;\n\tb=tNR9XrnKb9nmPx3s+1N7dzP0FKJRwYzHrqMLlSFUbqaAL1qYANJ+4S4ClU2OFTekO4\n\t5V9eKvtLp2QIlVw9s0xUztlcsrndE9UX1ml6OFMuodxKn/sqHMOvufG6wMUqkBpUVSjh\n\twQUTYubWaTWvY+GJyTrL4/6Xrsy1Ns3tv8LHqjoxcVTWWY7PvpxZfemwHncwkC7gJLpg\n\taxWnU4KRSdQIc8hOlKKIV4pH0Vd5wVQ9HZvu0j6oGKsdKjQrBfmV2o3QL6wMzdU2ExZu\n\tVUtVTUePo+Z9PUNdyRONzxi4uhPimmDB9pCp6cBwazQeF2PvW2C+9CeFsUc/9+xsW7mc\n\tNhKw==","X-Gm-Message-State":"AHYfb5gfqdwYVqRFOdG9jgLdYYiCXeRdnWuTagvHxtfND3A5fEejs9YG\n\t7xDwRTsRWhTnxA==","X-Received":"by 10.84.238.195 with SMTP id l3mr2930345pln.230.1504115030733; \n\tWed, 30 Aug 2017 10:43:50 -0700 (PDT)","Subject":"Re: [patch net-next 7/8] mlxsw: spectrum_router: Add support for\n\tsetting counters on IPv6 neighbors","To":"Jiri Pirko , netdev@vger.kernel.org","Cc":"davem@davemloft.net, arkadis@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","References":"<20170830120306.6128-1-jiri@resnulli.us>\n\t<20170830120306.6128-8-jiri@resnulli.us>","From":"David Ahern ","Message-ID":"","Date":"Wed, 30 Aug 2017 11:43:49 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830120306.6128-8-jiri@resnulli.us>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]