[{"id":1760373,"web_url":"http://patchwork.ozlabs.org/comment/1760373/","msgid":"","list_archive_url":null,"date":"2017-08-30T17:42:36","subject":"Re: [patch net-next 6/8] mlxsw: spectrum_dpipe: Add support for IPv6\n\thost table dump","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 8/30/17 6:03 AM, Jiri Pirko wrote:\n> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c\n> index 5924e97..75da2ef 100644\n> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c\n> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c\n> @@ -386,8 +386,19 @@ mlxsw_sp_dpipe_table_host_match_action_prepare(struct devlink_dpipe_match *match\n> \n> \tmatch = &matches[MLXSW_SP_DPIPE_TABLE_HOST_MATCH_DIP];\n> \tmatch->type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n> -\tmatch->header = &devlink_dpipe_header_ipv4;\n> -\tmatch->field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n> +\tswitch (type) {\n> +\tcase AF_INET:\n> +\t\tmatch->header = &devlink_dpipe_header_ipv4;\n> +\t\tmatch->field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n> +\t\tbreak;\n> +\tcase AF_INET6:\n> +\t\tmatch->header = &devlink_dpipe_header_ipv6;\n> +\t\tmatch->field_id = DEVLINK_DPIPE_FIELD_IPV6_DST_IP;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tWARN_ON(1);\n\nHere as well.\n\n> +\t\treturn;\n> +\t}\n> \n> \taction->type = DEVLINK_DPIPE_ACTION_TYPE_FIELD_MODIFY;\n> \taction->header = &devlink_dpipe_header_ethernet;\n> @@ -424,7 +435,18 @@ mlxsw_sp_dpipe_table_host_entry_prepare(struct devlink_dpipe_entry *entry,\n> \tmatch_value = &match_values[MLXSW_SP_DPIPE_TABLE_HOST_MATCH_DIP];\n> \n> \tmatch_value->match = match;\n> -\tmatch_value->value_size = sizeof(u32);\n> +\tswitch (type) {\n> +\tcase AF_INET:\n> +\t\tmatch_value->value_size = sizeof(u32);\n> +\t\tbreak;\n> +\tcase AF_INET6:\n> +\t\tmatch_value->value_size = sizeof(struct in6_addr);\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tWARN_ON(1);\n\nAnd here. WARN_ON is overkill\n\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> \tmatch_value->value = kmalloc(match_value->value_size, GFP_KERNEL);\n> \tif (!match_value->value)\n> \t\treturn -ENOMEM;","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LORMcvw3\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjCWl2XDrz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 03:42:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751579AbdH3Rml (ORCPT );\n\tWed, 30 Aug 2017 13:42:41 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:34588 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751555AbdH3Rmj (ORCPT\n\t); Wed, 30 Aug 2017 13:42:39 -0400","by mail-pf0-f193.google.com with SMTP id l8so221365pfj.1\n\tfor ; Wed, 30 Aug 2017 10:42:38 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:d89a:ab61:c4f1:b1cb])\n\tby smtp.googlemail.com with ESMTPSA id\n\tn18sm10153010pgd.13.2017.08.30.10.42.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 10:42:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=2BszR57s9+tKgTgveNEkbpYeoeTsXcNCZC0UK9eFN0U=;\n\tb=LORMcvw38yhtCes8rtfvdSL0HdxjpuOz1NAKIXaSQf3Uwdkc4oDFsoyAMhNSyalyFq\n\tGOD+G0pjszeRRjPgduhqa3Mupte7YTLwjfqGSiq29CnxAiOeulwNZhf+F7NJz2RjnJuR\n\t9Enjuml+FEKU+XuCJLEJ+Gz71e6sle+9emj2V0CPx6sM07A2EsdJWDUOftfcsA0a8G/c\n\tDdyuxn9zqvB5dDMngriMP/8/4Zoh4O9gKLyzpVDYy2wVQ20BewbuX9lm+HL9o5DppMm2\n\tfxeRr54wgjAfxpnDKUGSpiiVLq1AcYI7hPxSG/TMiUCKazZMvk+mvAw+dwbUjVAmvsx9\n\tq0rQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=2BszR57s9+tKgTgveNEkbpYeoeTsXcNCZC0UK9eFN0U=;\n\tb=lo5e6vhFdbj6FXjF1AFV+9WRnmEAYChZnzXprcdqrObZfmCeIVZPbkli3aAzue6QhY\n\tOPYxhOY1RwLY00wnT5hDL/mzIyudCeXhHRg754mpfsr5gfTLM4mMDHIvIa8OD22pzfQo\n\tjoXgIFkp89zonDPBGjLWi+oQ0Gg73laEKnCSMwwqVIMKZz4B9wpxTHgOZ2x4cR61Rxnn\n\tad7UNw+ZYiW6TyskxJgVavyFG0ONXvxvIikWIXeJY19UUOKkLY+lhqb8R0xiLiLpI/pc\n\ti1RTvhnoRED/BAkzLCW/glfqv8Xn2iPVOmVOVmlMQiYAwladGnEFveNL30h2HXoSvio9\n\t4k7A==","X-Gm-Message-State":"AHYfb5hEtg2uUGsrNnpnPC9k2MNalvnvFy2WanU3nxpnSGQkSCQnOTGl\n\tCAD+0E/ge9JqwQ==","X-Received":"by 10.84.218.204 with SMTP id g12mr2870875plm.420.1504114958148; \n\tWed, 30 Aug 2017 10:42:38 -0700 (PDT)","Subject":"Re: [patch net-next 6/8] mlxsw: spectrum_dpipe: Add support for IPv6\n\thost table dump","To":"Jiri Pirko , netdev@vger.kernel.org","Cc":"davem@davemloft.net, arkadis@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","References":"<20170830120306.6128-1-jiri@resnulli.us>\n\t<20170830120306.6128-7-jiri@resnulli.us>","From":"David Ahern ","Message-ID":"","Date":"Wed, 30 Aug 2017 11:42:36 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830120306.6128-7-jiri@resnulli.us>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760701,"web_url":"http://patchwork.ozlabs.org/comment/1760701/","msgid":"<20170831071823.GB1973@nanopsycho>","list_archive_url":null,"date":"2017-08-31T07:18:23","subject":"Re: [patch net-next 6/8] mlxsw: spectrum_dpipe: Add support for IPv6\n\thost table dump","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Wed, Aug 30, 2017 at 07:42:36PM CEST, dsahern@gmail.com wrote:\n>On 8/30/17 6:03 AM, Jiri Pirko wrote:\n>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c\n>> index 5924e97..75da2ef 100644\n>> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c\n>> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c\n>> @@ -386,8 +386,19 @@ mlxsw_sp_dpipe_table_host_match_action_prepare(struct devlink_dpipe_match *match\n>> \n>> \tmatch = &matches[MLXSW_SP_DPIPE_TABLE_HOST_MATCH_DIP];\n>> \tmatch->type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n>> -\tmatch->header = &devlink_dpipe_header_ipv4;\n>> -\tmatch->field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n>> +\tswitch (type) {\n>> +\tcase AF_INET:\n>> +\t\tmatch->header = &devlink_dpipe_header_ipv4;\n>> +\t\tmatch->field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n>> +\t\tbreak;\n>> +\tcase AF_INET6:\n>> +\t\tmatch->header = &devlink_dpipe_header_ipv6;\n>> +\t\tmatch->field_id = DEVLINK_DPIPE_FIELD_IPV6_DST_IP;\n>> +\t\tbreak;\n>> +\tdefault:\n>> +\t\tWARN_ON(1);\n>\n>Here as well.\n>\n>> +\t\treturn;\n>> +\t}\n>> \n>> \taction->type = DEVLINK_DPIPE_ACTION_TYPE_FIELD_MODIFY;\n>> \taction->header = &devlink_dpipe_header_ethernet;\n>> @@ -424,7 +435,18 @@ mlxsw_sp_dpipe_table_host_entry_prepare(struct devlink_dpipe_entry *entry,\n>> \tmatch_value = &match_values[MLXSW_SP_DPIPE_TABLE_HOST_MATCH_DIP];\n>> \n>> \tmatch_value->match = match;\n>> -\tmatch_value->value_size = sizeof(u32);\n>> +\tswitch (type) {\n>> +\tcase AF_INET:\n>> +\t\tmatch_value->value_size = sizeof(u32);\n>> +\t\tbreak;\n>> +\tcase AF_INET6:\n>> +\t\tmatch_value->value_size = sizeof(struct in6_addr);\n>> +\t\tbreak;\n>> +\tdefault:\n>> +\t\tWARN_ON(1);\n>\n>And here. WARN_ON is overkill\n\nAgain, only in case of bug in kernel.\n\n\n>\n>> +\t\treturn -EINVAL;\n>> +\t}\n>> +\n>> \tmatch_value->value = kmalloc(match_value->value_size, GFP_KERNEL);\n>> \tif (!match_value->value)\n>> \t\treturn -ENOMEM;\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"RS7kLUi7\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjYd11n6xz9s7c\n\tfor ;\n\tThu, 31 Aug 2017 17:18:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751317AbdHaHS1 (ORCPT );\n\tThu, 31 Aug 2017 03:18:27 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:36682 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750897AbdHaHS0 (ORCPT\n\t); Thu, 31 Aug 2017 03:18:26 -0400","by mail-wr0-f194.google.com with SMTP id 40so5138068wrv.3\n\tfor ; Thu, 31 Aug 2017 00:18:25 -0700 (PDT)","from localhost (ip-89-177-136-28.net.upcbroadband.cz.\n\t[89.177.136.28]) by smtp.gmail.com with ESMTPSA id\n\tu1sm6858044wrd.77.2017.08.31.00.18.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 31 Aug 2017 00:18:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=uLsgLANZ3/7lvv7/hpqXEy/cLJpYXUNjm8lEjk2SuVU=;\n\tb=RS7kLUi7MiX+ogHw33VBzJ+vkIQc0mIIwfBySiax7Ienb1eRt3nKsbluvX1BkU3QgT\n\t19QxSYy5R3T+2Ug/H9ZncxK7GpdAmzqnwXr3uSmVOJ19ZEOxrdSMT/RYVpnTExMkLoTQ\n\tsXDMX0q2LiPTl3tMG4X8ZthgF3Aa6Irr5xfiEeWP1ESXGkXpGc3U54WkzhNjC2MtGbXV\n\t3FQrVYX4VWniKFIqIId0SQjIfalhGGMkHovyzdrHYKypA5ffsXd+8G3p9Zim3e3BpoEo\n\tfK3vGhQyQpPIZNFm+uKfPW92kknuk/rttQKgIS0EYekbQd13RTipbHIQYWYf+9HyV7jG\n\tHy7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=uLsgLANZ3/7lvv7/hpqXEy/cLJpYXUNjm8lEjk2SuVU=;\n\tb=Fm2DXi5BNVR0XaLauhPK4qMlkEy+OxcnkRyPec/RkNpbWDgd7BNmX2AhP+Eg01vPoj\n\tMkgTWhRyKqAxtG8Ag58mSPttmAfkIiKXfsAmuLxbCMWzL1l60rHpmn6WgDtQ7DE9fwRf\n\taifMU24fHU/NPl2M+tkog9F2HMvjMEsc4NZUHkZm95gvIyldqG9L7LBxmrs8jOGVuNTP\n\t4dDm8/Z5M68NN3zjUwbXxsfOjF7+JOdB/0qKJPXGBCycwcOP0PbBrpLY/LKxq1B9eR/I\n\trjRdap7qwKyUa90F0jxwN8oww+ZqJAEFWpcWpaE3uFCyi0QNgM43ooEXHQ6ldYXvzZUH\n\tR9QA==","X-Gm-Message-State":"AHYfb5jBTbtxnj4g6a2Jg18SuGnhzr9JceA6GSW6sNpW2Hk4tWhTWaCO\n\thllH9jZYe4D2GWL/","X-Received":"by 10.223.135.114 with SMTP id 47mr2327191wrz.112.1504163904870; \n\tThu, 31 Aug 2017 00:18:24 -0700 (PDT)","Date":"Thu, 31 Aug 2017 09:18:23 +0200","From":"Jiri Pirko ","To":"David Ahern ","Cc":"netdev@vger.kernel.org, davem@davemloft.net, arkadis@mellanox.com,\n\tidosch@mellanox.com, mlxsw@mellanox.com","Subject":"Re: [patch net-next 6/8] mlxsw: spectrum_dpipe: Add support for IPv6\n\thost table dump","Message-ID":"<20170831071823.GB1973@nanopsycho>","References":"<20170830120306.6128-1-jiri@resnulli.us>\n\t<20170830120306.6128-7-jiri@resnulli.us>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]