[{"id":1760365,"web_url":"http://patchwork.ozlabs.org/comment/1760365/","msgid":"<200b2c64-f252-c8cd-9e7c-e237bb7a8ce2@gmail.com>","list_archive_url":null,"date":"2017-08-30T17:36:13","subject":"Re: [patch net-next 3/8] mlxsw: spectrum_dpipe: Add IPv6 host table\n\tinitial support","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/","name":"David Ahern","email":"dsahern@gmail.com"},"content":"On 8/30/17 6:03 AM, Jiri Pirko wrote:\n> @@ -328,9 +329,21 @@ static int mlxsw_sp_dpipe_table_host_matches_dump(struct sk_buff *skb, int type)\n> \tif (err)\n> \t\treturn err;\n> \n> -\tmatch.type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n> -\tmatch.header = &devlink_dpipe_header_ipv4;\n> -\tmatch.field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n> +\tswitch (type) {\n> +\tcase AF_INET:\n> +\t\tmatch.type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n> +\t\tmatch.header = &devlink_dpipe_header_ipv4;\n> +\t\tmatch.field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n> +\t\tbreak;\n> +\tcase AF_INET6:\n> +\t\tmatch.type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n> +\t\tmatch.header = &devlink_dpipe_header_ipv6;\n> +\t\tmatch.field_id = DEVLINK_DPIPE_FIELD_IPV6_DST_IP;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tWARN_ON(1);\n\nWhy a warn for dump request of an unsupported family?\n\n> +\t\treturn -EINVAL;\n> +\t}\n> \n> \treturn devlink_dpipe_match_put(skb, &match);\n> }\n> @@ -342,7 +355,7 @@ mlxsw_sp_dpipe_table_host4_matches_dump(void *priv, struct sk_buff *skb)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LE8EWS8W\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjCNL58pWz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 03:36:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752144AbdH3RgQ (ORCPT );\n\tWed, 30 Aug 2017 13:36:16 -0400","from mail-pg0-f50.google.com ([74.125.83.50]:37213 \"EHLO\n\tmail-pg0-f50.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751929AbdH3RgP (ORCPT\n\t); Wed, 30 Aug 2017 13:36:15 -0400","by mail-pg0-f50.google.com with SMTP id 83so21673078pgb.4\n\tfor ; Wed, 30 Aug 2017 10:36:15 -0700 (PDT)","from dsa-mb.local ([2601:282:800:7292:d89a:ab61:c4f1:b1cb])\n\tby smtp.googlemail.com with ESMTPSA id\n\tz127sm10341939pfb.64.2017.08.30.10.36.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 10:36:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=vBjNbipxknZ+fm1lVDn5kZsLn9XSppii1YKQhfbU5ng=;\n\tb=LE8EWS8WCkDqN1amaUeGm0KGex5Xmoox69SE56f5PxPWuzn7qOl0BoD+cz+URrivP8\n\tfPE2JN7n+QmTy/b04gOaeD1sgKYjUuQETrCqp7P4OvIWCFBBT0N8N5jcmNqfbJuf83+s\n\tZR17MeaXterQu+PflY0czxEsZdd9qvtwJmwQRqbnt+cMFfKaXnWyzGdqu+QZA15px7lH\n\ttB2yaw2NpHy0uELntCuOQIob+ho6dGBb8TuCMy0krJyEu7XDVu9+VhwxxRcLLnPszkwj\n\t/YbpRXebRbqiTHLKBmP/DuheMlkJqLMsO0cSHbLCL6Z8f9ZdKiFBapFKfRo6RzkZOqfE\n\tlviw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=vBjNbipxknZ+fm1lVDn5kZsLn9XSppii1YKQhfbU5ng=;\n\tb=Exhbg6ETVHGvo6fNvtOnhUYTVGhrT6cRXS9MBiIiEB5iXTEcaaP4O0K3e9KZgNgLGP\n\tJLE/ux8MWDjIiiZEEJdxPvQNlabWaoUbp58O1MdCH5Sz4SBa7t4Gg0v8AnBSq9DzBnlK\n\tw/j4p8cI4LZgl8F2a/qGPyw+NxmUSrw6xQq1ym7KdxoFv76/qhWEk34bkXRb8PAov3/2\n\t9etPx4H8WVUbCYEWrHn7kCYvL9mK7pCAI193QEwcIlIhS4ZQwPJuz4wg1YS4pFU3r3FQ\n\txqDFt3xi4qAznGMswfuxA9sr8RGBhPR1Pu9ezUPoUezJPKx9VtJboTrJmOTbuYSXaQBR\n\t8JYQ==","X-Gm-Message-State":"AHYfb5ghNWijEOhvcDABTS8ZXyvXnYaIWscDil4g7Xmn7VrCBC+xv9ST\n\t0xFFyv8SJNeUJ2Sd","X-Received":"by 10.98.178.219 with SMTP id z88mr2427950pfl.182.1504114575031; \n\tWed, 30 Aug 2017 10:36:15 -0700 (PDT)","Subject":"Re: [patch net-next 3/8] mlxsw: spectrum_dpipe: Add IPv6 host table\n\tinitial support","To":"Jiri Pirko , netdev@vger.kernel.org","Cc":"davem@davemloft.net, arkadis@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com","References":"<20170830120306.6128-1-jiri@resnulli.us>\n\t<20170830120306.6128-4-jiri@resnulli.us>","From":"David Ahern ","Message-ID":"<200b2c64-f252-c8cd-9e7c-e237bb7a8ce2@gmail.com>","Date":"Wed, 30 Aug 2017 11:36:13 -0600","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830120306.6128-4-jiri@resnulli.us>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760700,"web_url":"http://patchwork.ozlabs.org/comment/1760700/","msgid":"<20170831071758.GA1973@nanopsycho>","list_archive_url":null,"date":"2017-08-31T07:17:58","subject":"Re: [patch net-next 3/8] mlxsw: spectrum_dpipe: Add IPv6 host table\n\tinitial support","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Wed, Aug 30, 2017 at 07:36:13PM CEST, dsahern@gmail.com wrote:\n>On 8/30/17 6:03 AM, Jiri Pirko wrote:\n>> @@ -328,9 +329,21 @@ static int mlxsw_sp_dpipe_table_host_matches_dump(struct sk_buff *skb, int type)\n>> \tif (err)\n>> \t\treturn err;\n>> \n>> -\tmatch.type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n>> -\tmatch.header = &devlink_dpipe_header_ipv4;\n>> -\tmatch.field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n>> +\tswitch (type) {\n>> +\tcase AF_INET:\n>> +\t\tmatch.type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n>> +\t\tmatch.header = &devlink_dpipe_header_ipv4;\n>> +\t\tmatch.field_id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP;\n>> +\t\tbreak;\n>> +\tcase AF_INET6:\n>> +\t\tmatch.type = DEVLINK_DPIPE_MATCH_TYPE_FIELD_EXACT;\n>> +\t\tmatch.header = &devlink_dpipe_header_ipv6;\n>> +\t\tmatch.field_id = DEVLINK_DPIPE_FIELD_IPV6_DST_IP;\n>> +\t\tbreak;\n>> +\tdefault:\n>> +\t\tWARN_ON(1);\n>\n>Why a warn for dump request of an unsupported family?\n\nIt's a handling of default case that should not happen unless there is a\nbug in kernel.\n\n\n>\n>> +\t\treturn -EINVAL;\n>> +\t}\n>> \n>> \treturn devlink_dpipe_match_put(skb, &match);\n>> }\n>> @@ -342,7 +355,7 @@ mlxsw_sp_dpipe_table_host4_matches_dump(void *priv, struct sk_buff *skb)\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"qUz5nvmL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjYcX0fbnz9s7c\n\tfor ;\n\tThu, 31 Aug 2017 17:18:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751286AbdHaHSC (ORCPT );\n\tThu, 31 Aug 2017 03:18:02 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:33584 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750907AbdHaHSA (ORCPT\n\t); Thu, 31 Aug 2017 03:18:00 -0400","by mail-wm0-f67.google.com with SMTP id m85so3481891wma.0\n\tfor ; Thu, 31 Aug 2017 00:18:00 -0700 (PDT)","from localhost (ip-89-177-136-28.net.upcbroadband.cz.\n\t[89.177.136.28]) by smtp.gmail.com with ESMTPSA id\n\t5sm5327602wrp.60.2017.08.31.00.17.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 31 Aug 2017 00:17:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=4+kwvsiweEObfQbvHU5c5sHtFjuy1NUUlXMPM5ludXs=;\n\tb=qUz5nvmL5/tvXndCzOjR0ZoJkuK0roANRe47KPs1uOL6ImV6gibDaJBbrXVeFl2YVo\n\t2VhjXbMrPxuu6hLYR9uyNvygjKiT/RSip0i4shMmBazzhs6p9V/y32Jy59PS0GuYhUuB\n\tGelFHdUzDkclRnH1zAJoSH25rkDhwtEDwNREWeF/yEts7rrnK2QrZ46WbH6PWFeGWpsp\n\t6Z1EApOtYbL1mulz0Cvh/gYDPO+EOFJ0CloDqqldTpi6NZHhmg8dvpIvfoGTbiGq4Z9E\n\tDXADtRMtxHHufcd8dcmNxhIQCWQwK5H/NClUwUxD4pFLIowA1p0yDkiXs+15XzP1Qn3o\n\tLBIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=4+kwvsiweEObfQbvHU5c5sHtFjuy1NUUlXMPM5ludXs=;\n\tb=YgPii71pxGAI44+S70YgWJdUp5Trb8Yv6fk4hWXjS/PxDJnolypeI8IsRvlQL4Kp/H\n\tWKqYzGcT89M18sbTjLU07iVn+aTbyJq94AKDEi6WtteNf7u7+CtpdDP11V+hafD8Ymnj\n\t9jaGrBPz1ERXEHWtV7bqUZ/UReiAr0oLk6mRdiy6MsppmYWUnpDqchggUMeNn6Acy5eO\n\tEIZmXMMTjdSp8+YM1+7CTRGz9uN3Xc4pnBsVZuh7tXfzUqRxtKINHe2bOcVvfJblrhqo\n\tEntbBo0ElT2mfA6aH5MJpNWx86ifdi9mhsrYlMdR9u7TJCSn4k5eqUED4U60of6beRdQ\n\tVSJQ==","X-Gm-Message-State":"AHYfb5gkD5c1PmG1RdYp8BcK8jiqt6C8NV+9lBaGNrpXGUac5DtVS4J0\n\tdSl03hkOaimFNLBj","X-Received":"by 10.28.139.202 with SMTP id n193mr3245362wmd.82.1504163879736; \n\tThu, 31 Aug 2017 00:17:59 -0700 (PDT)","Date":"Thu, 31 Aug 2017 09:17:58 +0200","From":"Jiri Pirko ","To":"David Ahern ","Cc":"netdev@vger.kernel.org, davem@davemloft.net, arkadis@mellanox.com,\n\tidosch@mellanox.com, mlxsw@mellanox.com","Subject":"Re: [patch net-next 3/8] mlxsw: spectrum_dpipe: Add IPv6 host table\n\tinitial support","Message-ID":"<20170831071758.GA1973@nanopsycho>","References":"<20170830120306.6128-1-jiri@resnulli.us>\n\t<20170830120306.6128-4-jiri@resnulli.us>\n\t<200b2c64-f252-c8cd-9e7c-e237bb7a8ce2@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<200b2c64-f252-c8cd-9e7c-e237bb7a8ce2@gmail.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]