[{"id":1765272,"web_url":"http://patchwork.ozlabs.org/comment/1765272/","msgid":"<20170908114630.GA13575@salvia>","list_archive_url":null,"date":"2017-09-08T11:46:30","subject":"Re: [PATCH] netfilter: nat: constify rhashtable_params","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Wed, Aug 30, 2017 at 05:18:04PM +0530, Arvind Yadav wrote:\n> rhashtable_params are not supposed to change at runtime. All\n> Functions rhashtable_* working with const rhashtable_params\n> provided by . So mark the non-const structs\n> as const.\n\nApplied to nf, thanks.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpbCb3Ch3z9sDB\n\tfor ;\n\tFri, 8 Sep 2017 21:47:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754358AbdIHLrF (ORCPT );\n\tFri, 8 Sep 2017 07:47:05 -0400","from ganesha.gnumonks.org ([213.95.27.120]:34422 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751577AbdIHLrE (ORCPT\n\t);\n\tFri, 8 Sep 2017 07:47:04 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dqHk0-0003GB-1T; Fri, 08 Sep 2017 13:46:33 +0200"],"Date":"Fri, 8 Sep 2017 13:46:30 +0200","From":"Pablo Neira Ayuso ","To":"Arvind Yadav ","Cc":"davem@davemloft.net, fw@strlen.de, kadlec@blackhole.kfki.hu,\n\tlinux-kernel@vger.kernel.org, netdev@vger.kernel.org,\n\tcoreteam@netfilter.org, netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH] netfilter: nat: constify rhashtable_params","Message-ID":"<20170908114630.GA13575@salvia>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}},{"id":1765549,"web_url":"http://patchwork.ozlabs.org/comment/1765549/","msgid":"<20170908174718.GA1727@salvia>","list_archive_url":null,"date":"2017-09-08T17:47:18","subject":"Re: [netfilter-core] [PATCH] netfilter: nat: constify\n\trhashtable_params","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Fri, Sep 08, 2017 at 01:46:30PM +0200, Pablo Neira Ayuso wrote:\n> On Wed, Aug 30, 2017 at 05:18:04PM +0530, Arvind Yadav wrote:\n> > rhashtable_params are not supposed to change at runtime. All\n> > Functions rhashtable_* working with const rhashtable_params\n> > provided by . So mark the non-const structs\n> > as const.\n> \n> Applied to nf, thanks.\n\nActually, I tossed this. NAT rhashtable has been reverted, so no need\nfor this constification anymore.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xplCl4fkLz9s8J\n\tfor ;\n\tSat, 9 Sep 2017 03:48:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932400AbdIHRrr (ORCPT );\n\tFri, 8 Sep 2017 13:47:47 -0400","from ganesha.gnumonks.org ([213.95.27.120]:37497 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932381AbdIHRrq (ORCPT\n\t);\n\tFri, 8 Sep 2017 13:47:46 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dqNNA-0005Ms-IX; Fri, 08 Sep 2017 19:47:22 +0200"],"Date":"Fri, 8 Sep 2017 19:47:18 +0200","From":"Pablo Neira Ayuso ","To":"Arvind Yadav ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tcoreteam@netfilter.org, netfilter-devel@vger.kernel.org,\n\tkadlec@blackhole.kfki.hu, davem@davemloft.net","Subject":"Re: [netfilter-core] [PATCH] netfilter: nat: constify\n\trhashtable_params","Message-ID":"<20170908174718.GA1727@salvia>","References":"\n\t<20170908114630.GA13575@salvia>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170908114630.GA13575@salvia>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]