[{"id":1767718,"web_url":"http://patchwork.ozlabs.org/comment/1767718/","msgid":"<184ab056-4ef0-706a-c8df-fa5b0b5998f1@sigma-star.at>","list_archive_url":null,"date":"2017-09-13T09:39:31","subject":"Re: [PATCH mtd-utils v3] nandmarkbad: new util to mark blocks as bad","submitter":{"id":65653,"url":"http://patchwork.ozlabs.org/api/people/65653/","name":"David Oberhollenzer","email":"david.oberhollenzer@sigma-star.at"},"content":"Hi,\n\n\nsorry for the late reply. After requesting the initial changes, I caught up on\nthe IRC discussion and came under the impression that it was pretty clear to\neveryone that there are a few major issues with this kind of tool.\n\nFirst of all, marking a block bad can currently not be undone. The changes this\ntool makes are thus both destructive and irreversible.\n\nIf the MTD contains UBI data, UBI has no way of moving the data somewhere else\nif a block just randomly goes bad completely out of the blue.\n\nBesides, if the MTD is attached to an UBI device, UBI already takes care of\ndetecting blocks that go bad *over time* and takes care of marking them as\nbad after moving the data somewhere else.\n\nIt might be interesting to have such a tool if nand scrub functionality was\nadded to the kernel (such as in [1]), allowing the changes done by the tool\nto be undone. But even then, what would be the practical use case for\nsuch a tool?\n\n\nThanks,\n\nDavid\n\n\n[1] http://patchwork.ozlabs.org/patch/764978/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Sx9feFLM\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsc8p3sbPz9rxj\n\tfor ;\n\tWed, 13 Sep 2017 19:40:26 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds49P-0000R3-Um; Wed, 13 Sep 2017 09:40:08 +0000","from mail.sigma-star.at ([95.130.255.111])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds49G-0000BN-WE\n\tfor linux-mtd@lists.infradead.org; Wed, 13 Sep 2017 09:40:01 +0000","from localhost (localhost.localdomain [127.0.0.1])\n\tby mail.sigma-star.at (Postfix) with ESMTP id 3ADEC24E0011;\n\tWed, 13 Sep 2017 11:39:25 +0200 (CEST)","from localhost.localdomain (unknown [82.150.214.1])\n\tby mail.sigma-star.at (Postfix) with ESMTPSA id 4BADA24E0010;\n\tWed, 13 Sep 2017 11:39:24 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=LGdaG9f8Pa+biumSWNWRpVupjMI+XNGV+DDesGiIfDU=;\n\tb=Sx9feFLM8+y4hD\n\te4Iczp96hSQdyUYD5bkGdCFqlzAl4ujpY04U/rra9YbVL1Hr+iY/AOFU/evvxRAeRAtSo2AbdD49/\n\tbRcUIXCqmWNEoaCGjCypKHTb+KzpJFA/OiznC0Z7XelZNX8CGKlphJjFdde51BZ4SHWkqJopkXiO6\n\ty9ERRtES2w3PwrSZ1iApyG18y5ySJOe4H5naG/b3IivYMBu1G8O+Go4JO/bfbZe0bdf4Fm/mfOaJk\n\tzpOz6qgGSZ8btdbD/XlLEPXXV3aVLN9EgdISM5bT/fgi5lm7SnYmVXs6vhOieyXFWvPWlMQh+igg3\n\tRMTvtkrVjWvsRx5lm9Nw==;","Subject":"Re: [PATCH mtd-utils v3] nandmarkbad: new util to mark blocks as bad","To":"=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= ","References":"<20170824152227.30394-1-ukleinek@debian.org>\n\t<20170830113146.26929-1-u.kleine-koenig@pengutronix.de>","From":"David Oberhollenzer ","Organization":"sigma star gmbh","Message-ID":"<184ab056-4ef0-706a-c8df-fa5b0b5998f1@sigma-star.at>","Date":"Wed, 13 Sep 2017 11:39:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170830113146.26929-1-u.kleine-koenig@pengutronix.de>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170913_023959_277834_5273D856 ","X-CRM114-Status":"GOOD ( 11.30 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Richard Weinberger , linux-mtd@lists.infradead.org,\n\tkernel@pengutronix.de,\n\tBoris Brezillon ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1767741,"web_url":"http://patchwork.ozlabs.org/comment/1767741/","msgid":"<20170913095318.nnrbcs5giszgjhd4@pengutronix.de>","list_archive_url":null,"date":"2017-09-13T09:53:18","subject":"Re: [PATCH mtd-utils v3] nandmarkbad: new util to mark blocks as bad","submitter":{"id":1476,"url":"http://patchwork.ozlabs.org/api/people/1476/","name":"Uwe Kleine-König","email":"u.kleine-koenig@pengutronix.de"},"content":"Hello David,\n\nOn Wed, Sep 13, 2017 at 11:39:31AM +0200, David Oberhollenzer wrote:\n> \n> sorry for the late reply. After requesting the initial changes, I caught up on\n> the IRC discussion and came under the impression that it was pretty clear to\n> everyone that there are a few major issues with this kind of tool.\n> \n> First of all, marking a block bad can currently not be undone. The changes this\n> tool makes are thus both destructive and irreversible.\n> \n> If the MTD contains UBI data, UBI has no way of moving the data somewhere else\n> if a block just randomly goes bad completely out of the blue.\n> \n> Besides, if the MTD is attached to an UBI device, UBI already takes care of\n> detecting blocks that go bad *over time* and takes care of marking them as\n> bad after moving the data somewhere else.\n> \n> It might be interesting to have such a tool if nand scrub functionality was\n> added to the kernel (such as in [1]), allowing the changes done by the tool\n> to be undone. But even then, what would be the practical use case for\n> such a tool?\n\nI needed it as part of reproducing a problem I was told to fix. I only\nused it on a nandsim device for testing. I could imagine though that the\ntool could also come handy while developping a mtd driver. But yes, it\nwould be more useful in combination with a possibility to unmark a bad\nblock.\n\nIn sum: I don't care much if you take it or not. I just thought it might\ncome handy for someone else and so I shared my work.\n\nBest regards\nUwe","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ZJstC2on\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xscSr3LRCz9s9Y\n\tfor ;\n\tWed, 13 Sep 2017 19:54:20 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds4Me-0000Hv-Cg; Wed, 13 Sep 2017 09:53:48 +0000","from metis.ext.pengutronix.de\n\t([2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds4MZ-0008Ri-P0\n\tfor linux-mtd@lists.infradead.org; Wed, 13 Sep 2017 09:53:46 +0000","from [2001:67c:670:100:5054:ff:fe2a:3aa]\n\t(helo=pty.hi.pengutronix.de)\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1ds4MA-0002SI-QL; Wed, 13 Sep 2017 11:53:18 +0200","from ukl by pty.hi.pengutronix.de with local (Exim 4.89)\n\t(envelope-from )\n\tid 1ds4MA-0007D3-D3; Wed, 13 Sep 2017 11:53:18 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=9g+aDjJGimfxaiHYcc0/Az4wIDG+gOJx50P1DfkrXj0=;\n\tb=ZJstC2onlQvF9z\n\tjM0myI3bsGiWcC5na5QLQelXS0VZBB9RqQ8qew+bd00x7il5p0vdqRvAd1fCvCZ06IHfmwCK9TC9P\n\tvWkAX5YENForXQ3H1pt6eyRRHHgOGQbA+ZR7Yovm/otOGnoVrMYuMeAuqgScX7q6WA3MD+x35cdGE\n\tO5AIPNponaDp+Y9yVYiOa1OE+MVE0ey/B++lCV2E8oXOCmuiBM4OnuiCRwahW4Y1TFRmfQDAO9IpH\n\tmKlYw/Lv6zQC+KoVFAmPzMNRsxMoYF8K4kf6yX/TfZGdgICFweVS11Tu2U0crM1Bnxn6JIwhCJjje\n\tA7l/OPbw/Hm70z4UKE3A==;","Date":"Wed, 13 Sep 2017 11:53:18 +0200","From":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ","To":"David Oberhollenzer ","Subject":"Re: [PATCH mtd-utils v3] nandmarkbad: new util to mark blocks as bad","Message-ID":"<20170913095318.nnrbcs5giszgjhd4@pengutronix.de>","References":"<20170824152227.30394-1-ukleinek@debian.org>\n\t<20170830113146.26929-1-u.kleine-koenig@pengutronix.de>\n\t<184ab056-4ef0-706a-c8df-fa5b0b5998f1@sigma-star.at>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<184ab056-4ef0-706a-c8df-fa5b0b5998f1@sigma-star.at>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-SA-Exim-Connect-IP":"2001:67c:670:100:5054:ff:fe2a:3aa","X-SA-Exim-Mail-From":"ukl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"linux-mtd@lists.infradead.org","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170913_025344_077723_5C09D9FC ","X-CRM114-Status":"GOOD ( 18.91 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Richard Weinberger , linux-mtd@lists.infradead.org,\n\tkernel@pengutronix.de,\n\tBoris Brezillon ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]