[{"id":1760350,"web_url":"http://patchwork.ozlabs.org/comment/1760350/","msgid":"<20170830.101532.1535425571044102908.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-30T17:15:32","subject":"Re: [PATCH v3 net-next] staging: irda: fix init level for irda core","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Greg KH <gregkh@linuxfoundation.org>\nDate: Wed, 30 Aug 2017 13:16:49 +0200\n\n> When moving the IRDA code out of net/ into drivers/staging/irda/net, the\n> link order changes when IRDA is built into the kernel.  That causes a\n> kernel crash at boot time as netfilter isn't initialized yet.\n> \n> To fix this, move the init call level of the irda core to be\n> device_initcall() as the link order keeps this being initialized at the\n> correct time.\n> \n> Reported-by: kernel test robot <fengguang.wu@intel.com>\n> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>\n> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n> ---\n> \n> v3 - just change the initcall level, works so much simpler, thanks to\n>      DaveM for the idea.\n> v2 - don't force irda to be a module, make the Makefiles put irda back\n>      where it was before in the link order.\n\nApplied, thanks for following up on this Greg.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjBwk3FMlz9s8P\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 03:15:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752388AbdH3RPf (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 13:15:35 -0400","from shards.monkeyblade.net ([184.105.139.130]:57216 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752366AbdH3RPd (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 30 Aug 2017 13:15:33 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 5702613401117;\n\tWed, 30 Aug 2017 10:15:33 -0700 (PDT)"],"Date":"Wed, 30 Aug 2017 10:15:32 -0700 (PDT)","Message-Id":"<20170830.101532.1535425571044102908.davem@davemloft.net>","To":"gregkh@linuxfoundation.org","Cc":"devel@driverdev.osuosl.org, netdev@vger.kernel.org,\n\tsamuel@sortiz.org, linux-kernel@vger.kernel.org,\n\tfengguang.wu@intel.com, geert@linux-m68k.org","Subject":"Re: [PATCH v3 net-next] staging: irda: fix init level for irda core","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<20170830111649.GA13000@kroah.com>","References":"<20170829173129.GA11029@kroah.com>\n\t<20170829174622.GA25926@kroah.com>\n\t<20170830111649.GA13000@kroah.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 30 Aug 2017 10:15:33 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]