[{"id":1760543,"web_url":"http://patchwork.ozlabs.org/comment/1760543/","msgid":"<20170830.153007.110092081024877123.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-30T22:30:07","subject":"Re: [PATCH net-next] net: hns3: Fixes the wrong IS_ERR check on\n\tthe returned phydev value","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Salil Mehta <salil.mehta@huawei.com>\nDate: Wed, 30 Aug 2017 12:06:03 +0100\n\n> This patch removes the wrong check being done for the phy device being\n> returned by the mdiobus_get_phy() function. This function never returns\n> the error pointers.\n> \n> Fixes: 256727da7395 (\"net: hns3: Add MDIO support to HNS3 Ethernet\n> Driver for hip08 SoC\")\n> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>\n> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>\n\nApplied.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjKvc5dmNz9s83\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 08:30:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751422AbdH3WaJ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 18:30:09 -0400","from shards.monkeyblade.net ([184.105.139.130]:35492 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750973AbdH3WaI (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 30 Aug 2017 18:30:08 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id CE3A8133FDE79;\n\tWed, 30 Aug 2017 15:30:07 -0700 (PDT)"],"Date":"Wed, 30 Aug 2017 15:30:07 -0700 (PDT)","Message-Id":"<20170830.153007.110092081024877123.davem@davemloft.net>","To":"salil.mehta@huawei.com","Cc":"yisen.zhuang@huawei.com, mehta.salil.lnk@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com","Subject":"Re: [PATCH net-next] net: hns3: Fixes the wrong IS_ERR check on\n\tthe returned phydev value","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<20170830110603.12372-1-salil.mehta@huawei.com>","References":"<20170830110603.12372-1-salil.mehta@huawei.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 30 Aug 2017 15:30:08 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]