[{"id":1760353,"web_url":"http://patchwork.ozlabs.org/comment/1760353/","msgid":"<20170830171759.GC22289@lunn.ch>","list_archive_url":null,"date":"2017-08-30T17:17:59","subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv)\n> +{\n> +\tstruct phy_device *phydev = priv->ndev->phydev;\n> +\tu32 value = 0;\n> +\n> +\tvalue = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON :\n> +\t\t\t\t NETSEC_GMAC_MCR_REG_HALF_DUPLEX_COMMON;\n> +\n> +\tif (phydev->speed != SPEED_1000)\n> +\t\tvalue |= NETSEC_MCR_PS;\n> +\n> +\tif ((priv->phy_interface != PHY_INTERFACE_MODE_GMII) &&\n> +\t (phydev->speed == SPEED_100))\n> +\t\tvalue |= NETSEC_GMAC_MCR_REG_FES;\n> +\n> +\tvalue |= NETSEC_GMAC_MCR_REG_CST | NETSEC_GMAC_MCR_REG_JE;\n> +\n> +\tif (priv->phy_interface == PHY_INTERFACE_MODE_RGMII)\n> +\t\tvalue |= NETSEC_GMAC_MCR_REG_IBN;\n> +\n> +\tif (netsec_mac_write(priv, GMAC_REG_MCR, value))\n> +\t\treturn -ETIMEDOUT;\n> +\n> +\tpriv->actual_link_speed = phydev->speed;\n> +\tpriv->actual_duplex = phydev->duplex;\n> +\tnetif_info(priv, drv, priv->ndev, \"%s: %uMbps, duplex:%d\\n\",\n> +\t\t __func__, phydev->speed, phydev->duplex);\n\nphy_print_status()\n\n> +\tmac = of_get_mac_address(pdev->dev.of_node);\n> +\tif (mac)\n> +\t\tether_addr_copy(ndev->dev_addr, mac);\n> +\n> +\tif (!is_valid_ether_addr(ndev->dev_addr)) {\n> +\t\teth_hw_addr_random(ndev);\n> +\t\tdev_warn(&pdev->dev, \"No MAC address found, using random\\n\");\n> +\t}\n\nSo the mac address is optional, unlike what the binding document says.\n\n> +\tpriv->phy_np = of_parse_phandle(pdev->dev.of_node, \"phy-handle\", 0);\n> +\tif (!priv->phy_np) {\n> +\t\tnetif_err(priv, probe, ndev, \"missing phy in DT\\n\");\n\nIt is the phy-handle which is missing, not the phy.\n\n> +\n> +\t/* MTU range */\n> +\tndev->min_mtu = ETH_MIN_MTU;\n\nNo need to set this, it is the default.\n\nOtherwise, this looks good, in terms of phy and mdio.\n\n\t Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjBzN19R9z9sPt\n\tfor ;\n\tThu, 31 Aug 2017 03:18:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752209AbdH3RSG (ORCPT );\n\tWed, 30 Aug 2017 13:18:06 -0400","from vps0.lunn.ch ([178.209.37.122]:45296 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751984AbdH3RSF (ORCPT );\n\tWed, 30 Aug 2017 13:18:05 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dn6cp-0007in-Nt; Wed, 30 Aug 2017 19:17:59 +0200"],"Date":"Wed, 30 Aug 2017 19:17:59 +0200","From":"Andrew Lunn ","To":"Jassi Brar ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, davem@davemloft.net,\n\tmark.rutland@arm.com, arnd@arndb.de, patches@linaro.org,\n\tJassi Brar , robh+dt@kernel.org,\n\tandy@warmcat.com","Subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","Message-ID":"<20170830171759.GC22289@lunn.ch>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760674,"web_url":"http://patchwork.ozlabs.org/comment/1760674/","msgid":"","list_archive_url":null,"date":"2017-08-31T06:33:06","subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","submitter":{"id":4220,"url":"http://patchwork.ozlabs.org/api/people/4220/","name":"Jassi Brar","email":"jassisinghbrar@gmail.com"},"content":"On Wed, Aug 30, 2017 at 10:47 PM, Andrew Lunn wrote:\n>> +static int netsec_mac_update_to_phy_state(struct netsec_priv *priv)\n>> +{\n>> + struct phy_device *phydev = priv->ndev->phydev;\n>> + u32 value = 0;\n>> +\n>> + value = phydev->duplex ? NETSEC_GMAC_MCR_REG_FULL_DUPLEX_COMMON :\n>> + NETSEC_GMAC_MCR_REG_HALF_DUPLEX_COMMON;\n>> +\n>> + if (phydev->speed != SPEED_1000)\n>> + value |= NETSEC_MCR_PS;\n>> +\n>> + if ((priv->phy_interface != PHY_INTERFACE_MODE_GMII) &&\n>> + (phydev->speed == SPEED_100))\n>> + value |= NETSEC_GMAC_MCR_REG_FES;\n>> +\n>> + value |= NETSEC_GMAC_MCR_REG_CST | NETSEC_GMAC_MCR_REG_JE;\n>> +\n>> + if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII)\n>> + value |= NETSEC_GMAC_MCR_REG_IBN;\n>> +\n>> + if (netsec_mac_write(priv, GMAC_REG_MCR, value))\n>> + return -ETIMEDOUT;\n>> +\n>> + priv->actual_link_speed = phydev->speed;\n>> + priv->actual_duplex = phydev->duplex;\n>> + netif_info(priv, drv, priv->ndev, \"%s: %uMbps, duplex:%d\\n\",\n>> + __func__, phydev->speed, phydev->duplex);\n>\n> phy_print_status()\n>\n>> + mac = of_get_mac_address(pdev->dev.of_node);\n>> + if (mac)\n>> + ether_addr_copy(ndev->dev_addr, mac);\n>> +\n>> + if (!is_valid_ether_addr(ndev->dev_addr)) {\n>> + eth_hw_addr_random(ndev);\n>> + dev_warn(&pdev->dev, \"No MAC address found, using random\\n\");\n>> + }\n>\n> So the mac address is optional, unlike what the binding document says.\n>\n>> + priv->phy_np = of_parse_phandle(pdev->dev.of_node, \"phy-handle\", 0);\n>> + if (!priv->phy_np) {\n>> + netif_err(priv, probe, ndev, \"missing phy in DT\\n\");\n>\n> It is the phy-handle which is missing, not the phy.\n>\n>> +\n>> + /* MTU range */\n>> + ndev->min_mtu = ETH_MIN_MTU;\n>\n> No need to set this, it is the default.\n>\n> Otherwise, this looks good, in terms of phy and mdio.\n>\nWill fix these.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lQ+wPlfd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjXcn2Tmwz9s7F\n\tfor ;\n\tThu, 31 Aug 2017 16:33:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750826AbdHaGdK (ORCPT );\n\tThu, 31 Aug 2017 02:33:10 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:35929 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750757AbdHaGdI (ORCPT\n\t); Thu, 31 Aug 2017 02:33:08 -0400","by mail-wm0-f65.google.com with SMTP id i76so3872089wme.3;\n\tWed, 30 Aug 2017 23:33:08 -0700 (PDT)","by 10.80.214.21 with HTTP; Wed, 30 Aug 2017 23:33:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=/jYBGw2te320D+oU/5/+wX+I/ZHHU4acVsbbajvX944=;\n\tb=lQ+wPlfdiB2T3RhTesOOwe82xHs6GCJq9Tz5g7fHUrRfMS9cCWyea1kP/9Fx2tdS0F\n\tQJ0MN1jedgWx3V01tUzR27abWBc/5768SaLTh26eK1A14LZoJymkctcWHqaTKOaLcI+R\n\tHTTByzs0JVk1XKhn/mCv9fX1lk/Fyj79nF8lfkVKQfEwSaETMSKOk55HHVsod2D9GjdN\n\tuRgczQFsmINgmwE2nijlimYTXxjLBxPMvOid35JCfN5CWKEzV95H93G8NLbHvrTV5tFg\n\tyGVtiZr3SSD1/ZgHzwLPFl/3pQW8qMgEX2TtTQcxAGV39hMQGWIHuQCLOLX/lzfKjehc\n\tKbzQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/jYBGw2te320D+oU/5/+wX+I/ZHHU4acVsbbajvX944=;\n\tb=H58/69NetlLuV17T2Y8TqAUM3JvD9QShN4nSEKxFgYbWw+Nfl6HZD7qwdi9TyRB/J5\n\tKyJG/n1hnHAajFdU6Mbd5qYsBOSe80Pv3YuC/synOu2DVThLTrn4tt3j61ATqquukgZ4\n\trf7NsF9tXhMjS9oEIkfQ9pNUptLayDrYRiu2+/zbdlvLTi8wUE9b2Ul6VLD4r44AyFgG\n\teMygf2tmMF6Ic8FLV9UzeuBeN8SEeyW2/3R1x4dOgNNMaQWj5MCKz1aILrFuB12mR04V\n\tDBEGxUR7K1Hd5m6TqLXXFgWEoNQrBp7m7DoFEoY5tbMgEUCZq4x+EgDbpetmTE8GMsta\n\tUrXg==","X-Gm-Message-State":"AHYfb5ilt8msYuS0GCSgda/mQFO4fQXlqsa9pC1YZNKszWAQ2/x1XUia\n\t0bh8J3f4V/2QLGT1TZdD38jXBcIC9CXm","X-Received":"by 10.80.196.66 with SMTP id w2mr659267edf.225.1504161187398;\n\tWed, 30 Aug 2017 23:33:07 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170830171759.GC22289@lunn.ch>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>\n\t<20170830171759.GC22289@lunn.ch>","From":"Jassi Brar ","Date":"Thu, 31 Aug 2017 12:03:06 +0530","Message-ID":"","Subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","To":"Andrew Lunn ","Cc":"netdev@vger.kernel.org, Devicetree List ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"David S . Miller\" ,\n\tMark Rutland , \"arnd@arndb.de\" ,\n\t\"patches@linaro.org\" ,\n\tJassi Brar ,\n\tRob Herring , Andy Green ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762112,"web_url":"http://patchwork.ozlabs.org/comment/1762112/","msgid":"<201709021953.EGQtVEDs%fengguang.wu@intel.com>","list_archive_url":null,"date":"2017-09-02T11:53:59","subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Jassi,\n\n[auto build test WARNING on net-next/master]\n\nurl: https://github.com/0day-ci/linux/commits/Jassi-Brar/net-ethernet-Socionext-Netsec/20170902-181854\nconfig: i386-allmodconfig (attached as .config)\ncompiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901\nreproduce:\n # save the attached .config to linux build tree\n make ARCH=i386 \n\nAll warnings (new ones prefixed by >>):\n\n drivers/net/ethernet/socionext/netsec/netsec_netdev.c: In function 'netsec_configure_normal_mode':\n>> drivers/net/ethernet/socionext/netsec/netsec_netdev.c:86:51: warning: left shift count >= width of type [-Wshift-count-overflow]\n netsec_desc_start_reg_addr_up[NETSEC_RING_TX]) << 32;\n ^~\n>> drivers/net/ethernet/socionext/netsec/netsec_netdev.c:92:51: warning: right shift count >= width of type [-Wshift-count-overflow]\n priv->desc_ring[NETSEC_RING_RX].desc_phys >> 32);\n ^~\n drivers/net/ethernet/socionext/netsec/netsec_netdev.c:97:51: warning: right shift count >= width of type [-Wshift-count-overflow]\n priv->desc_ring[NETSEC_RING_TX].desc_phys >> 32);\n ^~\n drivers/net/ethernet/socionext/netsec/netsec_netdev.c: In function 'netsec_change_mode_to_taiki':\n drivers/net/ethernet/socionext/netsec/netsec_netdev.c:148:39: warning: right shift count >= width of type [-Wshift-count-overflow]\n priv->scb_set_normal_tx_paddr >> 32);\n ^~\n--\n drivers/net/ethernet/socionext/netsec/netsec_desc_ring_access.c: In function 'netsec_set_rx_de':\n>> drivers/net/ethernet/socionext/netsec/netsec_desc_ring_access.c:184:40: warning: right shift count >= width of type [-Wshift-count-overflow]\n de->data_buf_addr_up = info->dma_addr >> 32;\n ^~\n drivers/net/ethernet/socionext/netsec/netsec_desc_ring_access.c: In function 'netsec_set_tx_desc_entry':\n drivers/net/ethernet/socionext/netsec/netsec_desc_ring_access.c:247:50: warning: right shift count >= width of type [-Wshift-count-overflow]\n tx_desc_entry.data_buf_addr_up = frag->dma_addr >> 32;\n ^~\n\nvim +86 drivers/net/ethernet/socionext/netsec/netsec_netdev.c\n\n 78\t\n 79\tstatic int netsec_configure_normal_mode(struct netsec_priv *priv)\n 80\t{\n 81\t\tint ret = 0;\n 82\t\tu32 value;\n 83\t\n 84\t\t/* save scb set value */\n 85\t\tpriv->scb_set_normal_tx_paddr = (phys_addr_t)netsec_readl(priv,\n > 86\t\t\t\tnetsec_desc_start_reg_addr_up[NETSEC_RING_TX]) << 32;\n 87\t\tpriv->scb_set_normal_tx_paddr |= (phys_addr_t)netsec_readl(priv,\n 88\t\t\t\tnetsec_desc_start_reg_addr_lw[NETSEC_RING_TX]);\n 89\t\n 90\t\t/* set desc_start addr */\n 91\t\tnetsec_writel(priv, netsec_desc_start_reg_addr_up[NETSEC_RING_RX],\n > 92\t\t\t priv->desc_ring[NETSEC_RING_RX].desc_phys >> 32);\n 93\t\tnetsec_writel(priv, netsec_desc_start_reg_addr_lw[NETSEC_RING_RX],\n 94\t\t\t priv->desc_ring[NETSEC_RING_RX].desc_phys & 0xffffffff);\n 95\t\n 96\t\tnetsec_writel(priv, netsec_desc_start_reg_addr_up[NETSEC_RING_TX],\n 97\t\t\t priv->desc_ring[NETSEC_RING_TX].desc_phys >> 32);\n 98\t\tnetsec_writel(priv, netsec_desc_start_reg_addr_lw[NETSEC_RING_TX],\n 99\t\t\t priv->desc_ring[NETSEC_RING_TX].desc_phys & 0xffffffff);\n 100\t\n 101\t\t/* set normal tx desc ring config */\n 102\t\tvalue = (cpu_to_le32(1) == 1) << NETSEC_REG_DESC_ENDIAN |\n 103\t\t\tNETSEC_REG_DESC_RING_CONFIG_CFG_UP |\n 104\t\t\tNETSEC_REG_DESC_RING_CONFIG_CH_RST;\n 105\t\tnetsec_writel(priv, desc_ads[NETSEC_RING_TX], value);\n 106\t\n 107\t\tvalue = (cpu_to_le32(1) == 1) << NETSEC_REG_DESC_ENDIAN |\n 108\t\t\tNETSEC_REG_DESC_RING_CONFIG_CFG_UP |\n 109\t\t\tNETSEC_REG_DESC_RING_CONFIG_CH_RST;\n 110\t\tnetsec_writel(priv, desc_ads[NETSEC_RING_RX], value);\n 111\t\n 112\t\tif (netsec_wait_for_ring_config_ready(priv, NETSEC_RING_TX) ||\n 113\t\t netsec_wait_for_ring_config_ready(priv, NETSEC_RING_RX))\n 114\t\t\treturn -ETIMEDOUT;\n 115\t\n 116\t\treturn ret;\n 117\t}\n 118\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkvff2XdTz9s7p\n\tfor ;\n\tSat, 2 Sep 2017 21:54:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752360AbdIBLyU (ORCPT );\n\tSat, 2 Sep 2017 07:54:20 -0400","from mga05.intel.com ([192.55.52.43]:28979 \"EHLO mga05.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751652AbdIBLyS (ORCPT );\n\tSat, 2 Sep 2017 07:54:18 -0400","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP; 02 Sep 2017 04:54:17 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby fmsmga006.fm.intel.com with ESMTP; 02 Sep 2017 04:54:15 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1do74e-000955-RZ; Sat, 02 Sep 2017 19:58:52 +0800"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,463,1498546800\"; \n\td=\"gz'50?scan'50,208,50\";a=\"147397819\"","Date":"Sat, 2 Sep 2017 19:53:59 +0800","From":"kbuild test robot ","To":"Jassi Brar ","Cc":"kbuild-all@01.org, netdev@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tdavem@davemloft.net, patches@linaro.org, arnd@arndb.de,\n\tmark.rutland@arm.com, robh+dt@kernel.org, andy@warmcat.com,\n\tJassi Brar ","Subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","Message-ID":"<201709021953.EGQtVEDs%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"9jxsPFA5p3P2qPhR\"","Content-Disposition":"inline","In-Reply-To":"<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762113,"web_url":"http://patchwork.ozlabs.org/comment/1762113/","msgid":"<201709022034.p6dCjEt6%fengguang.wu@intel.com>","list_archive_url":null,"date":"2017-09-02T12:07:26","subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Jassi,\n\n[auto build test ERROR on net-next/master]\n\nurl: https://github.com/0day-ci/linux/commits/Jassi-Brar/net-ethernet-Socionext-Netsec/20170902-181854\nconfig: x86_64-allmodconfig (attached as .config)\ncompiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901\nreproduce:\n # save the attached .config to linux build tree\n make ARCH=x86_64 \n\nAll errors (new ones prefixed by >>):\n\n drivers/net/ethernet/socionext/netsec/netsec_platform.c: In function 'netsec_runtime_suspend':\n>> drivers/net/ethernet/socionext/netsec/netsec_platform.c:246:3: error: implicit declaration of function 'disable_irq' [-Werror=implicit-function-declaration]\n disable_irq(priv->ndev->irq);\n ^~~~~~~~~~~\n drivers/net/ethernet/socionext/netsec/netsec_platform.c: In function 'netsec_runtime_resume':\n>> drivers/net/ethernet/socionext/netsec/netsec_platform.c:272:3: error: implicit declaration of function 'enable_irq' [-Werror=implicit-function-declaration]\n enable_irq(priv->ndev->irq);\n ^~~~~~~~~~\n cc1: some warnings being treated as errors\n\nvim +/disable_irq +246 drivers/net/ethernet/socionext/netsec/netsec_platform.c\n\n 236\t\n 237\t#ifdef CONFIG_PM\n 238\tstatic int netsec_runtime_suspend(struct device *dev)\n 239\t{\n 240\t\tstruct netsec_priv *priv = dev_get_drvdata(dev);\n 241\t\tint n;\n 242\t\n 243\t\tnetif_dbg(priv, drv, priv->ndev, \"%s\\n\", __func__);\n 244\t\n 245\t\tif (priv->irq_registered)\n > 246\t\t\tdisable_irq(priv->ndev->irq);\n 247\t\n 248\t\tnetsec_writel(priv, NETSEC_REG_CLK_EN, 0);\n 249\t\n 250\t\tfor (n = priv->clock_count - 1; n >= 0; n--)\n 251\t\t\tclk_disable_unprepare(priv->clk[n]);\n 252\t\n 253\t\treturn 0;\n 254\t}\n 255\t\n 256\tstatic int netsec_runtime_resume(struct device *dev)\n 257\t{\n 258\t\tstruct netsec_priv *priv = dev_get_drvdata(dev);\n 259\t\tint n;\n 260\t\n 261\t\tnetif_dbg(priv, drv, priv->ndev, \"%s\\n\", __func__);\n 262\t\n 263\t\t/* first let the clocks back on */\n 264\t\n 265\t\tfor (n = 0; n < priv->clock_count; n++)\n 266\t\t\tclk_prepare_enable(priv->clk[n]);\n 267\t\n 268\t\tnetsec_writel(priv, NETSEC_REG_CLK_EN, NETSEC_CLK_EN_REG_DOM_D |\n 269\t\t\t\tNETSEC_CLK_EN_REG_DOM_C | NETSEC_CLK_EN_REG_DOM_G);\n 270\t\n 271\t\tif (priv->irq_registered)\n > 272\t\t\tenable_irq(priv->ndev->irq);\n 273\t\n 274\t\treturn 0;\n 275\t}\n 276\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkvyk4jbzz9sNr\n\tfor ;\n\tSat, 2 Sep 2017 22:08:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752646AbdIBMIX (ORCPT );\n\tSat, 2 Sep 2017 08:08:23 -0400","from mga14.intel.com ([192.55.52.115]:56028 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751762AbdIBMIW (ORCPT );\n\tSat, 2 Sep 2017 08:08:22 -0400","from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Sep 2017 05:08:20 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby orsmga001.jf.intel.com with ESMTP; 02 Sep 2017 05:08:17 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1do7IE-000AXt-W7; Sat, 02 Sep 2017 20:12:55 +0800"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,463,1498546800\"; \n\td=\"gz'50?scan'50,208,50\";a=\"1168487937\"","Date":"Sat, 2 Sep 2017 20:07:26 +0800","From":"kbuild test robot ","To":"Jassi Brar ","Cc":"kbuild-all@01.org, netdev@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tdavem@davemloft.net, patches@linaro.org, arnd@arndb.de,\n\tmark.rutland@arm.com, robh+dt@kernel.org, andy@warmcat.com,\n\tJassi Brar ","Subject":"Re: [net-next PATCHv6 2/2] net: socionext: Add NetSec driver","Message-ID":"<201709022034.p6dCjEt6%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"BXVAT5kNtrzKuDFl\"","Content-Disposition":"inline","In-Reply-To":"<1504088771-6255-1-git-send-email-jaswinder.singh@linaro.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]