[{"id":1760274,"web_url":"http://patchwork.ozlabs.org/comment/1760274/","msgid":"<20170830151942.GB22289@lunn.ch>","list_archive_url":null,"date":"2017-08-30T15:19:42","subject":"Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for\n\tSocionext Netsec","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Wed, Aug 30, 2017 at 03:55:52PM +0530, Jassi Brar wrote:\n> This patch adds documentation for Device-Tree bindings for the\n> Socionext NetSec Controller driver.\n> \n> Signed-off-by: Jassi Brar \n> ---\n> .../devicetree/bindings/net/socionext-netsec.txt | 46 ++++++++++++++++++++++\n> 1 file changed, 46 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/net/socionext-netsec.txt\n> \n> diff --git a/Documentation/devicetree/bindings/net/socionext-netsec.txt b/Documentation/devicetree/bindings/net/socionext-netsec.txt\n> new file mode 100644\n> index 0000000..12d596c\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/net/socionext-netsec.txt\n> @@ -0,0 +1,46 @@\n> +* Socionext NetSec Ethernet Controller IP\n> +\n> +Required properties:\n> +- compatible: Should be \"socionext,netsecv5\"\n> +- reg: Address and length of the register sets, the first is the main\n> +\tregisters, then the rdlar and tdlar regions for the SoC\n> +- interrupts: Should contain ethernet controller interrupt\n> +- clocks: phandle to any clocks to be switched by runtime_pm\n> +- phy-mode: See ethernet.txt file in the same directory\n\n> +- max-speed: See ethernet.txt file in the same directory\n> +- max-frame-size: See ethernet.txt file in the same directory, if 9000 or\n> +\tabove jumbo frames are enabled\n> +- local-mac-address: See ethernet.txt file in the same directory\n\nThese three are required, not optimal?\n\n> +- phy-handle: phandle to select child phy\n> +\n> +Optional properties:\n> +- use-jumbo: Boolean property to suggest if jumbo packets should be used or not\n> +\n> +For the child phy\n> +\n> +- compatible \"ethernet-phy-ieee802.3-c22\" is needed\n\nThis is normally considered optional. Why require it?\n\n Andrew\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj8Lr4Xszz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 01:19:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751358AbdH3PTr (ORCPT\n\t);\n\tWed, 30 Aug 2017 11:19:47 -0400","from vps0.lunn.ch ([178.209.37.122]:45175 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751317AbdH3PTq (ORCPT );\n\tWed, 30 Aug 2017 11:19:46 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dn4mM-0006md-IR; Wed, 30 Aug 2017 17:19:42 +0200"],"Date":"Wed, 30 Aug 2017 17:19:42 +0200","From":"Andrew Lunn ","To":"Jassi Brar ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, davem@davemloft.net,\n\tmark.rutland@arm.com, arnd@arndb.de, patches@linaro.org,\n\tJassi Brar , robh+dt@kernel.org,\n\tandy@warmcat.com","Subject":"Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for\n\tSocionext Netsec","Message-ID":"<20170830151942.GB22289@lunn.ch>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<1504088752-6204-1-git-send-email-jaswinder.singh@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504088752-6204-1-git-send-email-jaswinder.singh@linaro.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1760610,"web_url":"http://patchwork.ozlabs.org/comment/1760610/","msgid":"","list_archive_url":null,"date":"2017-08-31T03:13:03","subject":"Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for\n\tSocionext Netsec","submitter":{"id":4220,"url":"http://patchwork.ozlabs.org/api/people/4220/","name":"Jassi Brar","email":"jassisinghbrar@gmail.com"},"content":"On Wed, Aug 30, 2017 at 8:49 PM, Andrew Lunn wrote:\n> On Wed, Aug 30, 2017 at 03:55:52PM +0530, Jassi Brar wrote:\n>> This patch adds documentation for Device-Tree bindings for the\n>> Socionext NetSec Controller driver.\n>>\n>> Signed-off-by: Jassi Brar \n>> ---\n>> .../devicetree/bindings/net/socionext-netsec.txt | 46 ++++++++++++++++++++++\n>> 1 file changed, 46 insertions(+)\n>> create mode 100644 Documentation/devicetree/bindings/net/socionext-netsec.txt\n>>\n>> diff --git a/Documentation/devicetree/bindings/net/socionext-netsec.txt b/Documentation/devicetree/bindings/net/socionext-netsec.txt\n>> new file mode 100644\n>> index 0000000..12d596c\n>> --- /dev/null\n>> +++ b/Documentation/devicetree/bindings/net/socionext-netsec.txt\n>> @@ -0,0 +1,46 @@\n>> +* Socionext NetSec Ethernet Controller IP\n>> +\n>> +Required properties:\n>> +- compatible: Should be \"socionext,netsecv5\"\n>> +- reg: Address and length of the register sets, the first is the main\n>> + registers, then the rdlar and tdlar regions for the SoC\n>> +- interrupts: Should contain ethernet controller interrupt\n>> +- clocks: phandle to any clocks to be switched by runtime_pm\n>> +- phy-mode: See ethernet.txt file in the same directory\n>\n>> +- max-speed: See ethernet.txt file in the same directory\n>> +- max-frame-size: See ethernet.txt file in the same directory, if 9000 or\n>> + above jumbo frames are enabled\n>> +- local-mac-address: See ethernet.txt file in the same directory\n>\n> These three are required, not optimal?\n>\noptional :)\n\n>> +- phy-handle: phandle to select child phy\n>> +\n>> +Optional properties:\n>> +- use-jumbo: Boolean property to suggest if jumbo packets should be used or not\n>> +\n>> +For the child phy\n>> +\n>> +- compatible \"ethernet-phy-ieee802.3-c22\" is needed\n>\n> This is normally considered optional. Why require it?\n>\nYes, will do.\n\nThanks.\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aHp/+7d6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjS9v6kRzz9s83\n\tfor ;\n\tThu, 31 Aug 2017 13:13:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750995AbdHaDNG (ORCPT\n\t);\n\tWed, 30 Aug 2017 23:13:06 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:37397 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750864AbdHaDNF (ORCPT\n\t); Wed, 30 Aug 2017 23:13:05 -0400","by mail-wm0-f66.google.com with SMTP id x189so3570773wmg.4;\n\tWed, 30 Aug 2017 20:13:04 -0700 (PDT)","by 10.80.214.21 with HTTP; Wed, 30 Aug 2017 20:13:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=epMQs0m6MgmTbQU0tLzBRPawKhdok90QSv547xwRoVM=;\n\tb=aHp/+7d6o00ISf/CCZkhb2o8cfDXaibjyDYGdubEjC+26hhc/mrzmrcI9qgy8+KLZU\n\tQwo8ttWg6Iohlu6bO1AmTaskVPwb2fp88ZFg6CML5/9uta31OowACTuwIn/Vs4T3ALem\n\tJGatw2/PQi7CUuvTkPsLUJQyZRslGwfqzh3heDKkVTFAQCzktXxUpW49nyepx9A8T+tw\n\tDtiNfkiN3Q5kqTUWONBcvdwWF6U1p/TTin4KAoBZ5S2KDrAW82C1ivQBSulJiAKXtmvW\n\tukw8H/+hRU0E3MwkqthXVhd1JBtZksr6IO/hnD1ghiuVS0JRQHVU3EIFNnWFsoyZYVQx\n\tyAuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=epMQs0m6MgmTbQU0tLzBRPawKhdok90QSv547xwRoVM=;\n\tb=KvvHzMO0Saa8e6mL9dImgxh/3fmeDXo74NgcqBzIYehwKhe0yDUvvGyO8hk8G5Iz5j\n\tT+HRpZvK/p44uG9YefTwkRpquPzMz+GVAObqtvK4iGrFLZLOM+rMybsWUks2c6RKUu98\n\tJ4IGaZHSG97WrucNNH9gPT2SHtEoByqWewf6AzFRKLhH9vRemHOa+X8RRK3YiVHWsEY9\n\tsa1reOjbatSTrUJBtAaIkdINOpAmYxz3wnNRMPv7s5XncF8KebLjk0baZ3x5fozcDN6u\n\tXZP1d3rNuuMnIA1C4Wy++v+kVdQeVZDz9bDBcdtZoQJBqgCH54eFk1xoqBGMtLhbB5PK\n\tPvHA==","X-Gm-Message-State":"AHYfb5j6oJLPT6I3JGYNKXlxO7M/RIisYy+9DZuDXQGeLUm8AWiCNOrl\n\toSQKD6W9Si9rx0uwabzzYD715YYwUA==","X-Received":"by 10.80.210.211 with SMTP id q19mr378397edg.186.1504149184253; \n\tWed, 30 Aug 2017 20:13:04 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170830151942.GB22289@lunn.ch>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<1504088752-6204-1-git-send-email-jaswinder.singh@linaro.org>\n\t<20170830151942.GB22289@lunn.ch>","From":"Jassi Brar ","Date":"Thu, 31 Aug 2017 08:43:03 +0530","Message-ID":"","Subject":"Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for\n\tSocionext Netsec","To":"Andrew Lunn ","Cc":"netdev@vger.kernel.org, Devicetree List ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"David S . Miller\" ,\n\tMark Rutland , \"arnd@arndb.de\" , \n\t\"patches@linaro.org\" ,\n\tJassi Brar ,\n\tRob Herring , Andy Green ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766539,"web_url":"http://patchwork.ozlabs.org/comment/1766539/","msgid":"<20170911203738.gco3nv2kynytkxuj@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-11T20:37:38","subject":"Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for\n\tSocionext Netsec","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 03:55:52PM +0530, Jassi Brar wrote:\n> This patch adds documentation for Device-Tree bindings for the\n> Socionext NetSec Controller driver.\n> \n> Signed-off-by: Jassi Brar \n> ---\n> .../devicetree/bindings/net/socionext-netsec.txt | 46 ++++++++++++++++++++++\n> 1 file changed, 46 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/net/socionext-netsec.txt\n> \n> diff --git a/Documentation/devicetree/bindings/net/socionext-netsec.txt b/Documentation/devicetree/bindings/net/socionext-netsec.txt\n> new file mode 100644\n> index 0000000..12d596c\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/net/socionext-netsec.txt\n> @@ -0,0 +1,46 @@\n> +* Socionext NetSec Ethernet Controller IP\n> +\n> +Required properties:\n> +- compatible: Should be \"socionext,netsecv5\"\n\nThis should be SoC specific, or also have an SoC specific string.\n\n> +- reg: Address and length of the register sets, the first is the main\n> +\tregisters, then the rdlar and tdlar regions for the SoC\n> +- interrupts: Should contain ethernet controller interrupt\n> +- clocks: phandle to any clocks to be switched by runtime_pm\n> +- phy-mode: See ethernet.txt file in the same directory\n> +- max-speed: See ethernet.txt file in the same directory\n> +- max-frame-size: See ethernet.txt file in the same directory, if 9000 or\n> +\tabove jumbo frames are enabled\n> +- local-mac-address: See ethernet.txt file in the same directory\n> +- phy-handle: phandle to select child phy\n> +\n> +Optional properties:\n> +- use-jumbo: Boolean property to suggest if jumbo packets should be used or not\n\nIs this common or vendor specific. The former should refer to a common \ndoc. The latter should have a vendor prefix. I'd think the former makes \nsense here.\n\nBut then why do you need this and max-frame-size?\n\n> +\n> +For the child phy\n> +\n> +- compatible \"ethernet-phy-ieee802.3-c22\" is needed\n> +- device_type \"ethernet-phy\"\n> +- reg: phy address\n> +\n> +\n> +Example:\n> +\teth0: ethernet {\n> +\t\tcompatible = \"socionext,netsecv5\";\n> +\t\treg = <0 0x31600000 0x10000>, <0 0x31618000 0x4000>, <0 0x3161c000 0x4000>;\n> +\t\tinterrupts = <0 163 0x4>;\n> +\t\tclocks = <&clk_alw_0_8>;\n> +\t\tphy-mode = \"rgmii\";\n> +\t\tmax-speed = <1000>;\n> +\t\tmax-frame-size = <9000>;\n> +\t\tlocal-mac-address = [ a4 17 31 00 00 ed ];\n> +\t\tphy-handle = <ðphy0>;\n> +\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <0>;\n> +\n> +\t\tethphy0: ethernet-phy@1 {\n> +\t\t\tdevice_type = \"ethernet-phy\";\n> +\t\t\tcompatible = \"ethernet-phy-ieee802.3-c22\";\n> +\t\t\treg = <1>;\n> +\t\t};\n> +\t};\n> -- \n> 2.7.4\n> \n> --\n> To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrfr64cRMz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 06:37:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751004AbdIKUhl (ORCPT\n\t);\n\tMon, 11 Sep 2017 16:37:41 -0400","from mail-io0-f194.google.com ([209.85.223.194]:37854 \"EHLO\n\tmail-io0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750987AbdIKUhk (ORCPT\n\t); Mon, 11 Sep 2017 16:37:40 -0400","by mail-io0-f194.google.com with SMTP id 93so5297989iol.4;\n\tMon, 11 Sep 2017 13:37:40 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\to93sm12122305oik.14.2017.09.11.13.37.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 11 Sep 2017 13:37:39 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=RA4hiQiDts5iMhttthaSsAKTTvPJifh+Zbg1kgcUcjY=;\n\tb=e+SL0Cw2VJWyW83qU/OPAkZ/kdwsC//FLQpwAxBV+j6B801Zy9d1dOKcu+o3oq8/IK\n\tuuF4XK8q243+BCdGX60iduYEx2+gLFUB9MKi2gWCFg8hX+9IeCZSIbTm9I9ZtX3idcMS\n\tIuHxcJgWADtYRH7RWQSCd+p6S0kYVGvg3fiOpHYHNSmAS0r7WesfKp4vL6A97zi8XNSR\n\thAkncC6AAejdqj1FLCot/kBXQ24ijCTJrun5rLYaoZA6I6MYllU9YSk6Pv36BydzWTxA\n\t3WF61dR3Gl78+ARFbGLrjEcYIg1Pfk1CE06hG1YV4jbfR27P5yRysNDLXwhWTPJevnXq\n\t+JWQ==","X-Gm-Message-State":"AHPjjUjtBrjPtbif0ebYxpWb6riWIEzIyKDnsgY3emogP7rCP+QT1/p6\n\tLP1ai5+mbw/x0sWuF2M=","X-Google-Smtp-Source":"AOwi7QDqj9D8/1P2C7uh3rZ9vC1ij4f6psZt+H6DKimbUhRgyN0vzwPmPOw2IUDjLM5cioypMweGWA==","X-Received":"by 10.202.205.76 with SMTP id d73mr11874091oig.29.1505162259673; \n\tMon, 11 Sep 2017 13:37:39 -0700 (PDT)","Date":"Mon, 11 Sep 2017 15:37:38 -0500","From":"Rob Herring ","To":"Jassi Brar ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, davem@davemloft.net,\n\tpatches@linaro.org, arnd@arndb.de, mark.rutland@arm.com,\n\tandy@warmcat.com, Jassi Brar ","Subject":"Re: [net-next PATCHv6 1/2] dt-bindings: net: Add DT bindings for\n\tSocionext Netsec","Message-ID":"<20170911203738.gco3nv2kynytkxuj@rob-hp-laptop>","References":"<1504088657-6102-1-git-send-email-jaswinder.singh@linaro.org>\n\t<1504088752-6204-1-git-send-email-jaswinder.singh@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504088752-6204-1-git-send-email-jaswinder.singh@linaro.org>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]