[{"id":1760032,"web_url":"http://patchwork.ozlabs.org/comment/1760032/","msgid":"","list_archive_url":null,"date":"2017-08-30T10:24:04","subject":"Re: [PATCH v2] ipv6: sr: fix get_srh() to comply with IPv6 standard\n\t\"RFC 8200\"","submitter":{"id":69771,"url":"http://patchwork.ozlabs.org/api/people/69771/","name":"David Lebrun","email":"david.lebrun@uclouvain.be"},"content":"On 08/30/2017 10:50 AM, Ahmed Abdelsalam wrote:\n> This patch fixes the get_srh(), so it gets the segment routing header\n> regardless of its position in the chain of the extension headers in IPv6\n> packet, and makes sure that the IPv6 routing extension header is of Type 4.\n> \n> Signed-off-by: Ahmed Abdelsalam \n\nNote that this patch applies to net-next.\n\nAcked-by: David Lebrun ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=uclouvain.be header.i=@uclouvain.be\n\theader.b=\"HRpIaozp\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj1n40Nb3z9s83\n\tfor ;\n\tWed, 30 Aug 2017 20:23:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751385AbdH3KXe (ORCPT );\n\tWed, 30 Aug 2017 06:23:34 -0400","from smtp.sgsi.ucl.ac.be ([130.104.5.67]:35832 \"EHLO\n\tsmtp5.sgsi.ucl.ac.be\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751319AbdH3KXd (ORCPT\n\t); Wed, 30 Aug 2017 06:23:33 -0400","from mailboxes.uclouvain.be (mailboxes.uclouvain.be\n\t[130.104.6.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp5.sgsi.ucl.ac.be (Postfix) with ESMTPS id E643D67DA80;\n\tWed, 30 Aug 2017 12:23:23 +0200 (CEST)","from [130.104.228.78] (130.104.228.78) by\n\tucl-mbx04.OASIS.UCLOUVAIN.BE (10.10.10.24) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Wed, 30 Aug 2017 12:23:23 +0200"],"DKIM-Filter":"OpenDKIM Filter v2.9.2 smtp5.sgsi.ucl.ac.be E643D67DA80","DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple; d=uclouvain.be;\n\ts=selucl; t=1504088603;\n\tbh=lPEyt75tjcN+phNtLV7oQsJjJYSTMsHZzSCEqINNTyw=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=HRpIaozplpkvnRaUaBpqua5FtH2vvCrLdWo57Qtrhy9Pa8HV1ey5Q9iba2fgIS4ot\n\tkvmzpc1fAgp3q8WDAKtboFpkAr8qsCKsFwj0ZnixYCw0NyT5AUozZDeLpF94OHmLm5\n\tgDskR4x0o6qNEztX5AaWPfLxiaWrCXLpCSxuxq5k=","X-Virus-Status":"Clean","X-Virus-Scanned":"clamav-milter 0.99.2 at smtp-5","Subject":"Re: [PATCH v2] ipv6: sr: fix get_srh() to comply with IPv6 standard\n\t\"RFC 8200\"","To":"Ahmed Abdelsalam , ","References":"<1504083037-1605-1-git-send-email-amsalam20@gmail.com>","CC":"","From":"David Lebrun ","Message-ID":"","Date":"Wed, 30 Aug 2017 12:24:04 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<1504083037-1605-1-git-send-email-amsalam20@gmail.com>","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"IFuMCiPlQXlJF29IfTfxkvLCKJr3cegvV\"","X-Originating-IP":"[130.104.228.78]","X-ClientProxiedBy":"UCL-CAS02.OASIS.UCLOUVAIN.BE (10.10.10.42) To\n\tucl-mbx04.OASIS.UCLOUVAIN.BE (10.10.10.24)","X-SGSI-Information":"","X-SGSI-MailScanner-ID":"E643D67DA80.A3D55","X-SGSI-MailScanner":"Found to be clean","X-SGSI-SpamCheck":"n'est pas un polluriel, SpamAssassin (not cached,\n\tscore=-2.101, requis 5, ALL_TRUSTED -2.00, DKIM_SIGNED 0.10,\n\tDKIM_VALID -0.10, DKIM_VALID_AU -0.10, RP_MATCHES_RCVD -0.00)","X-SGSI-From":"david.lebrun@uclouvain.be","X-SGSI-Spam-Status":"No","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760535,"web_url":"http://patchwork.ozlabs.org/comment/1760535/","msgid":"<20170830.151947.1646224839367558973.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-30T22:19:47","subject":"Re: [PATCH v2] ipv6: sr: fix get_srh() to comply with IPv6\n\tstandard \"RFC 8200\"","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Ahmed Abdelsalam \nDate: Wed, 30 Aug 2017 10:50:37 +0200\n\n> IPv6 packet may carry more than one extension header, and IPv6 nodes must\n> accept and attempt to process extension headers in any order and occurring\n> any number of times in the same packet. Hence, there should be no\n> assumption that Segment Routing extension header is to appear immediately\n> after the IPv6 header.\n> \n> Moreover, section 4.1 of RFC 8200 gives a recommendation on the order of\n> appearance of those extension headers within an IPv6 packet. According to\n> this recommendation, Segment Routing extension header should appear after\n> Hop-by-Hop and Destination Options headers (if they present).\n> \n> This patch fixes the get_srh(), so it gets the segment routing header\n> regardless of its position in the chain of the extension headers in IPv6\n> packet, and makes sure that the IPv6 routing extension header is of Type 4.\n> \n> Signed-off-by: Ahmed Abdelsalam \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjKgV72XDz9s81\n\tfor ;\n\tThu, 31 Aug 2017 08:19:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750919AbdH3WTs (ORCPT );\n\tWed, 30 Aug 2017 18:19:48 -0400","from shards.monkeyblade.net ([184.105.139.130]:35206 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750814AbdH3WTs (ORCPT\n\t); Wed, 30 Aug 2017 18:19:48 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id A6009126CD4D7;\n\tWed, 30 Aug 2017 15:19:47 -0700 (PDT)"],"Date":"Wed, 30 Aug 2017 15:19:47 -0700 (PDT)","Message-Id":"<20170830.151947.1646224839367558973.davem@davemloft.net>","To":"amsalam20@gmail.com","Cc":"netdev@vger.kernel.org, david.lebrun@uclouvain.be","Subject":"Re: [PATCH v2] ipv6: sr: fix get_srh() to comply with IPv6\n\tstandard \"RFC 8200\"","From":"David Miller ","In-Reply-To":"<1504083037-1605-1-git-send-email-amsalam20@gmail.com>","References":"<1504083037-1605-1-git-send-email-amsalam20@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 30 Aug 2017 15:19:47 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]