[{"id":1760733,"web_url":"http://patchwork.ozlabs.org/comment/1760733/","msgid":"<20170831082015.GF13619@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-08-31T08:20:15","subject":"Re: [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page\n\ttracking","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Wed, Aug 30, 2017 at 03:26:59AM -0500, Sergio Andres Gomez Del Real wrote:\n> +static void hvf_log_start(MemoryListener *listener,\n> + MemoryRegionSection *section, int old, int new)\n> +{\n> + if (old != 0)\n> + return;\n\nQEMU coding style uses curly braces even when the if statement body only\nhas 1 line.\n\n> +\n> + hvf_set_dirty_tracking(section, 1);\n> +}\n> +\n> +static void hvf_log_stop(MemoryListener *listener,\n> + MemoryRegionSection *section, int old, int new)\n> +{\n> + if (new != 0)\n> + return;\n\nSame here.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"b9dp8W9q\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjb0x09F6z9s3w\n\tfor ;\n\tThu, 31 Aug 2017 18:20:47 +1000 (AEST)","from localhost ([::1]:54452 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnKiR-0004Ox-Qx\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 04:20:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41808)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnKi6-0004Nn-J6\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:20:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnKi2-0004k6-Jy\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:20:22 -0400","from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:37661)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dnKi2-0004jt-CQ\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:20:18 -0400","by mail-wm0-x22e.google.com with SMTP id u26so24200083wma.0\n\tfor ; Thu, 31 Aug 2017 01:20:18 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tx76sm5286676wma.36.2017.08.31.01.20.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 31 Aug 2017 01:20:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=tmHMhQyTVvMas2PEs5h2xEo6RxTLUMqh3Si7MOtjfiI=;\n\tb=b9dp8W9qmpxb2WKXfe6CoGT9DuK/KORMbzmnkTejYlbo22WVZTJYGH4yQe8nSY4a6p\n\tjEsAAHVal9gMltlgV8XZ9nqCRNcxYNyQp1e3GLA9HsmB0SgIUh9VLGcTpZOPDTH5cP1J\n\t9ix55rRhKfK2S9PJskVSXIGlASU1owMbbpRizSTrB9xFkCSbgJ//aC0nD6GMTZuojKut\n\t46gphjdi2GEIJLhhyxogX3soTe7RZa6Jd5qsk8wA+HjhfdepPrpy1ZC8MF5w2m1ftsk9\n\tlkPFIAsszD6PxkZcMbw2JbJY64zfMVxFB9WZ6leNoqiLt/pj7z/Ru++DamwQK5nDkRUq\n\tORXw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=tmHMhQyTVvMas2PEs5h2xEo6RxTLUMqh3Si7MOtjfiI=;\n\tb=RNSGxiAWdIxfZG+hQDWF1IxrI7xVGfPDo6h8s5XnEhzibJFfEypmFYZIsyLS0Mr/9b\n\tBPm2Ql9DxF+I71Hp3uLY15E1q4jauuyc2b0K6krPJ+2d4xnO3NuAU154LwuETfSO8Q/S\n\t1zbvIOUW1dKjcO1sDG97HRrzVwdcTa0X1HBuD8DpL5ZS2L/YB8DdCyzEoEepPpVocjWe\n\tswcfqxwKBsblm+eyPA49VE4Z4aCvFMbrIHPQEYDTj0dXjeFmpInJiTVI/v6CMxyVWYVx\n\tM1IXQKYfXZxiSMCIREBcGEDay8NF0NHdHMRnOtjYYgevZmfWbj5lhWnG5P8qc9nRl1Vn\n\tL60A==","X-Gm-Message-State":"AHPjjUhA+yCSYJz/RNmmlOeI7+RMGIAHn/kldggjGmAyVgaWMdlMKP5t\n\tfq6x0MK7B54CwA==","X-Received":"by 10.28.20.80 with SMTP id 77mr701646wmu.172.1504167617408;\n\tThu, 31 Aug 2017 01:20:17 -0700 (PDT)","Date":"Thu, 31 Aug 2017 09:20:15 +0100","From":"Stefan Hajnoczi ","To":"Sergio Andres Gomez Del Real ","Message-ID":"<20170831082015.GF13619@stefanha-x1.localdomain>","References":"<20170830082702.3011-1-Sergio.G.DelReal@gmail.com>\n\t<20170830082702.3011-11-Sergio.G.DelReal@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830082702.3011-11-Sergio.G.DelReal@gmail.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22e","Subject":"Re: [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page\n\ttracking","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]