[{"id":1760523,"web_url":"http://patchwork.ozlabs.org/comment/1760523/","msgid":"<20170830.145031.1158341283102125578.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-30T21:50:31","subject":"Re: [PATCH net-next] dp83640: don't hold spinlock while calling\n\tnetif_rx_ni","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Stefan Sørensen \nDate: Wed, 30 Aug 2017 08:58:47 +0200\n\n> We should not hold a spinlock while pushing the skb into the networking\n> stack, so move the call to netif_rx_ni out of the critical region to where\n> we have dropped the spinlock.\n> \n> Signed-off-by: Stefan Sørensen \n\nLooks good, applied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjK1l1z2Vz9sN5\n\tfor ;\n\tThu, 31 Aug 2017 07:50:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751386AbdH3Vud convert rfc822-to-8bit (ORCPT\n\t);\n\tWed, 30 Aug 2017 17:50:33 -0400","from shards.monkeyblade.net ([184.105.139.130]:34640 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750973AbdH3Vuc (ORCPT\n\t); Wed, 30 Aug 2017 17:50:32 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 4DB591210FA62;\n\tWed, 30 Aug 2017 14:50:32 -0700 (PDT)"],"Date":"Wed, 30 Aug 2017 14:50:31 -0700 (PDT)","Message-Id":"<20170830.145031.1158341283102125578.davem@davemloft.net>","To":"stefan.sorensen@spectralink.com","Cc":"richardcochran@gmail.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net-next] dp83640: don't hold spinlock while calling\n\tnetif_rx_ni","From":"David Miller ","In-Reply-To":"<20170830065847.2444-1-stefan.sorensen@spectralink.com>","References":"<20170830065847.2444-1-stefan.sorensen@spectralink.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=iso-8859-1","Content-Transfer-Encoding":"8BIT","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 30 Aug 2017 14:50:32 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760708,"web_url":"http://patchwork.ozlabs.org/comment/1760708/","msgid":"<20170831072557.i5tnrb64fohlj56p@localhost>","list_archive_url":null,"date":"2017-08-31T07:25:57","subject":"Re: [PATCH net-next] dp83640: don't hold spinlock while calling\n\tnetif_rx_ni","submitter":{"id":4009,"url":"http://patchwork.ozlabs.org/api/people/4009/","name":"Richard Cochran","email":"richardcochran@gmail.com"},"content":"On Wed, Aug 30, 2017 at 02:50:31PM -0700, David Miller wrote:\n> From: Stefan Sørensen \n> Date: Wed, 30 Aug 2017 08:58:47 +0200\n> \n> > We should not hold a spinlock while pushing the skb into the networking\n> > stack, so move the call to netif_rx_ni out of the critical region to where\n> > we have dropped the spinlock.\n> > \n> > Signed-off-by: Stefan Sørensen \n> \n> Looks good, applied, thanks.\n\nAnd thanks, Stefan, for following up on this. For the record, we\ndiscussed this fix back in April.\n\n https://patchwork.ozlabs.org/patch/752201/\n\nCheers,\nRichard","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vEjtnfT7\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjYnn5Xffz9sNc\n\tfor ;\n\tThu, 31 Aug 2017 17:26:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751419AbdHaH0D (ORCPT );\n\tThu, 31 Aug 2017 03:26:03 -0400","from mail-wr0-f193.google.com ([209.85.128.193]:36275 \"EHLO\n\tmail-wr0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751291AbdHaH0C (ORCPT\n\t); Thu, 31 Aug 2017 03:26:02 -0400","by mail-wr0-f193.google.com with SMTP id 40so5148629wrv.3\n\tfor ; Thu, 31 Aug 2017 00:26:01 -0700 (PDT)","from localhost (213-225-35-115.nat.highway.a1.net.\n\t[213.225.35.115]) by smtp.gmail.com with ESMTPSA id\n\tf142sm1584079wmf.27.2017.08.31.00.25.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 31 Aug 2017 00:25:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=2NmsGzaig0L68O1BheJ/Ia5WSRGsBb/s2iywSif4u40=;\n\tb=vEjtnfT7t+KBv+YBdkydkbAolrI9mDAtxTjBezecJn3QofyEixinvaBMXrNZEbXso+\n\tFRi13K5R+tDNrVsXbjapVRGmoe+zRPavipWZnUk9fqRM10M0ZiVbY13HU0wsygz7cpkt\n\tsR1GYcB5B21sQ9bJxXmJtmYrt3SRqGplv050qN4gY95uHV9xhA/dYvPbMKz4GcQulLmn\n\t/LQLvXSfgjb2xSVhVoDxCvoub2MsvxHnqdzip0Zw2EGn0GSW0a4qo9yenMt/3tO4mN/+\n\tORNB13qkjVKHVu0MGb2IrC2ArV3FuGdBd2kzvQx00K93m3zJCDdOHs0Hz3CqaRFI51hj\n\tXaIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=2NmsGzaig0L68O1BheJ/Ia5WSRGsBb/s2iywSif4u40=;\n\tb=txuvw190m7qQREih/7bUIaDdO+H93EKGJ751E3Qow6i18J12oCIq5CmwiZ8N3WxxrP\n\tOUt0vQ3ZIjyoGkt+7lskZlYSFk6m4h02SFwpMUwx7ST6vY3aA4wfGtqjynRwwMgZaa2N\n\tPzIgoEnCf2qN3NcHT2/yTOJeqw6bOHtdqQnqWWVHuMZDwUJoHs1CHPmCwiT0d8PitRXM\n\tWkVZ/mMcnOz6XvUWAT35IQlDGiQFVuIZ4x/qsXVErKdqHgdC9Agfm3pkt1ytVF90uwMl\n\tyJGqWM/H8XS69t0iooqUZ00ATLsBFv+FdF4F+GCyn46+5Pa/B9gLOr5Mll25mhnVpUq+\n\tkMXg==","X-Gm-Message-State":"AHYfb5jqtocQlxYQMohP6bGBK0FfogdiXLrzEmUuwAWDWqU/TYj+uZf7\n\thHGWdq6dJrZWqj/mC5U=","X-Received":"by 10.223.135.142 with SMTP id b14mr2545831wrb.12.1504164361173; \n\tThu, 31 Aug 2017 00:26:01 -0700 (PDT)","Date":"Thu, 31 Aug 2017 09:25:57 +0200","From":"Richard Cochran ","To":"David Miller ","Cc":"stefan.sorensen@spectralink.com, netdev@vger.kernel.org","Subject":"Re: [PATCH net-next] dp83640: don't hold spinlock while calling\n\tnetif_rx_ni","Message-ID":"<20170831072557.i5tnrb64fohlj56p@localhost>","References":"<20170830065847.2444-1-stefan.sorensen@spectralink.com>\n\t<20170830.145031.1158341283102125578.davem@davemloft.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170830.145031.1158341283102125578.davem@davemloft.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]