[{"id":1760099,"web_url":"http://patchwork.ozlabs.org/comment/1760099/","msgid":"<5b54f1c5-688a-5a7d-25bd-05dc9cbecebd@mojatatu.com>","list_archive_url":null,"date":"2017-08-30T12:11:10","subject":"Re: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx\n\tmodules to use IDR","submitter":{"id":9380,"url":"http://patchwork.ozlabs.org/api/people/9380/","name":"Jamal Hadi Salim","email":"jhs@mojatatu.com"},"content":"On 17-08-30 02:31 AM, Chris Mi wrote:\n> Typically, each TC filter has its own action. All the actions of the\n> same type are saved in its hash table. But the hash buckets are too\n> small that it degrades to a list. And the performance is greatly\n> affected. For example, it takes about 0m11.914s to insert 64K rules.\n> If we convert the hash table to IDR, it only takes about 0m1.500s.\n> The improvement is huge.\n> \n> But please note that the test result is based on previous patch that\n> cls_flower uses IDR.\n> \n> Signed-off-by: Chris Mi \n> Signed-off-by: Jiri Pirko \n\nAcked-by: Jamal Hadi Salim \n\nAlso already acked this before but you left it out in this\nversion. If you make changes to the patch then you will need\na new ACK.\n\nDont forget to update selftests please.\n\ncheers,\njamal","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"XpHHf5wI\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj49J66mdz9sQl\n\tfor ;\n\tWed, 30 Aug 2017 22:11:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751347AbdH3MLO (ORCPT );\n\tWed, 30 Aug 2017 08:11:14 -0400","from mail-it0-f65.google.com ([209.85.214.65]:35044 \"EHLO\n\tmail-it0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751282AbdH3MLN (ORCPT\n\t); Wed, 30 Aug 2017 08:11:13 -0400","by mail-it0-f65.google.com with SMTP id b76so912846itb.2\n\tfor ; Wed, 30 Aug 2017 05:11:13 -0700 (PDT)","from [10.0.0.4] (135-23-93-187.cpe.pppoe.ca. [135.23.93.187])\n\tby smtp.googlemail.com with ESMTPSA id\n\t188sm2501337ioy.62.2017.08.30.05.11.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 05:11:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=+bdOlHq39mm4JKQ5JFTaJuvU9CCwuBOIIuvGSR99kKQ=;\n\tb=XpHHf5wIcf6e1sRwlLqZWclsC8P4F8XmA8g3eKDuOxy1gMQf0wqmVbe0AcrIZ/89fq\n\tWMuBfq5oVG9J3bSGKxyMbPS9aZ2FZcJTM2ikfZmG6w8lKjMcS0S01NYDBeGvUBBBygmH\n\tjWT1DbsTEHCfvuzSfhXsKZGZcnIeRNW2dbdHJxMiXJDNEEQc5oK0qftosmCoWPM8g3CI\n\tkFyon3lFaoh5SigHmTSOsnNK0U5nG6zAhswCfVTCGo1h31Qz/s+S8Ik0D3kzSCPgXbN5\n\tr1yo4nGfiSutU3k/zpOzHyv+3HaWMJIJKfazkD+MUQTH6OcRzI0TIl7ndlRaC6qsiKNa\n\tOmTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=+bdOlHq39mm4JKQ5JFTaJuvU9CCwuBOIIuvGSR99kKQ=;\n\tb=EZyrsBaZ5hHnlLWyxEVMDZ6ZASAGRkpR4bIC29/aKULxw6/VUfjcZ63yojXpLDWFlI\n\tFJWuvPSty+YdpRankf27/FA0xP1F43sXIJASoA6k4/wHMhOZINqbqb8y0o9a0cgWLMAS\n\tsQYHv4qF0CrYVXUlqUp+N7SeNG25u/psZ6KWopDpAnFAj0MpiLIGrdgOoTQi7H/vWykE\n\tfVHejaU54WXoQWRpBmTE80EEMQnWHcY9U3CTVepIiumDkFVZToYodabjteXO970pUxll\n\t+iUeuXoZAKsQulz9G/ZjsMYuSAee8h+W+HTadCr9nR95aqbSx6KfeI9pazth7P3drbvB\n\tCHuA==","X-Gm-Message-State":"AHYfb5gRmtpaHfi3xjCIXITvYFXfXIvYq1R/iuuZiq6pjOS/EUFkg/fx\n\tbGz5rykdrCCcslkc","X-Received":"by 10.36.225.7 with SMTP id n7mr1273165ith.96.1504095073008;\n\tWed, 30 Aug 2017 05:11:13 -0700 (PDT)","Subject":"Re: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx\n\tmodules to use IDR","To":"Chris Mi , netdev@vger.kernel.org","Cc":"xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,\n\tmawilcox@microsoft.com","References":"<1504074719-15147-1-git-send-email-chrism@mellanox.com>\n\t<1504074719-15147-4-git-send-email-chrism@mellanox.com>","From":"Jamal Hadi Salim ","Message-ID":"<5b54f1c5-688a-5a7d-25bd-05dc9cbecebd@mojatatu.com>","Date":"Wed, 30 Aug 2017 08:11:10 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504074719-15147-4-git-send-email-chrism@mellanox.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1760590,"web_url":"http://patchwork.ozlabs.org/comment/1760590/","msgid":"","list_archive_url":null,"date":"2017-08-31T01:05:04","subject":"RE: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx\n\tmodules to use IDR","submitter":{"id":72170,"url":"http://patchwork.ozlabs.org/api/people/72170/","name":"Chris Mi","email":"chrism@mellanox.com"},"content":"> -----Original Message-----\r\n> From: Jamal Hadi Salim [mailto:jhs@mojatatu.com]\r\n> Sent: Wednesday, August 30, 2017 8:11 PM\r\n> To: Chris Mi ; netdev@vger.kernel.org\r\n> Cc: xiyou.wangcong@gmail.com; jiri@resnulli.us; davem@davemloft.net;\r\n> mawilcox@microsoft.com\r\n> Subject: Re: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx\r\n> modules to use IDR\r\n> \r\n> On 17-08-30 02:31 AM, Chris Mi wrote:\r\n> > Typically, each TC filter has its own action. All the actions of the\r\n> > same type are saved in its hash table. But the hash buckets are too\r\n> > small that it degrades to a list. And the performance is greatly\r\n> > affected. For example, it takes about 0m11.914s to insert 64K rules.\r\n> > If we convert the hash table to IDR, it only takes about 0m1.500s.\r\n> > The improvement is huge.\r\n> >\r\n> > But please note that the test result is based on previous patch that\r\n> > cls_flower uses IDR.\r\n> >\r\n> > Signed-off-by: Chris Mi \r\n> > Signed-off-by: Jiri Pirko \r\n> \r\n> Acked-by: Jamal Hadi Salim \r\n> \r\n> Also already acked this before but you left it out in this version. If you make\r\n> changes to the patch then you will need a new ACK.\r\nSorry about that, Jamal. I think I need to make a note of the review comment\r\nIn case I forget it.\r\n> \r\n> Dont forget to update selftests please.\r\nSure, we will work on that.\r\n\r\nThanks,\r\nChris\r\n> \r\n> cheers,\r\n> jamal","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"S4hy3sJc\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=chrism@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjPLL6VBRz9s7G\n\tfor ;\n\tThu, 31 Aug 2017 11:05:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751306AbdHaBFJ (ORCPT );\n\tWed, 30 Aug 2017 21:05:09 -0400","from mail-ve1eur01on0086.outbound.protection.outlook.com\n\t([104.47.1.86]:49056\n\t\"EHLO EUR01-VE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750822AbdHaBFI (ORCPT );\n\tWed, 30 Aug 2017 21:05:08 -0400","from VI1PR0501MB2143.eurprd05.prod.outlook.com (10.167.196.23) by\n\tVI1SPR00MB110.eurprd05.prod.outlook.com (10.173.72.151) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Thu, 31 Aug 2017 01:05:05 +0000","from VI1PR0501MB2143.eurprd05.prod.outlook.com\n\t([fe80::2d4b:bf44:cd0:3725]) by\n\tVI1PR0501MB2143.eurprd05.prod.outlook.com\n\t([fe80::2d4b:bf44:cd0:3725%13]) with mapi id 15.20.0013.012;\n\tThu, 31 Aug 2017 01:05:05 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=LC6V4eijzg+F7XjkZuCbAWfPG5AbbmIQYQsf8B1D9Jk=;\n\tb=S4hy3sJcSTtn/cHASxRknhE/l54wzCEXhQsrr2PxOs5DYuVXd+StUVKG2PHdbzsriYTD/OjcczJp2ejcj85dVmm0maxlpFu5GnVKJCYqyCRr3LPPbgC0t+Qo4/c+1hh1JhuCjjnFFGPeITWAZCP6e1ItKkYI4GYgBiKVQ4Lfbuk=","From":"Chris Mi ","To":"Jamal Hadi Salim ,\n\t\"netdev@vger.kernel.org\" ","CC":"\"xiyou.wangcong@gmail.com\" ,\n\t\"jiri@resnulli.us\" ,\n\t\"davem@davemloft.net\" ,\n\t\"mawilcox@microsoft.com\" ","Subject":"RE: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx\n\tmodules to use IDR","Thread-Topic":"[patch net-next v2 3/3] net/sched: Change act_api and act_xxx\n\tmodules to use IDR","Thread-Index":"AQHTIYkUyjFTpl9fNEadt34iuFufNaKdpgBw","Date":"Thu, 31 Aug 2017 01:05:04 +0000","Message-ID":"","References":"<1504074719-15147-1-git-send-email-chrism@mellanox.com>\n\t<1504074719-15147-4-git-send-email-chrism@mellanox.com>\n\t<5b54f1c5-688a-5a7d-25bd-05dc9cbecebd@mojatatu.com>","In-Reply-To":"<5b54f1c5-688a-5a7d-25bd-05dc9cbecebd@mojatatu.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"S4hy3sJc\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=chrism@mellanox.com; "],"x-originating-ip":"[202.225.191.18]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1SPR00MB110;\n\t6:bCE9pqK0UKunP1SD0PdvQ6LoqvoAidiex+4wb/WTQf6/numW6w/o47w8zLIPVVhti8E/cfedx9LsSOExIajyTSZa9kgPdZR8Y/5CKVtJu0XPSxdnJMLSeXFN0vQ5sBVlvucNn7txmLXjQtxGQ7PbS0PAChHLT4KxKRFl85nul7x1si/kHUU+gMI7xxW1A4dcS4A7lgFIQc4Gmi4oNfYhG9P+UEYydGUfKkgKNmbFxrriLpjtvVmcc4AZocdhiR72LgKVXkmZT8O6GHUqHS7EVZtG1LV0tcDpJ5nGKUcshM4CtgVJuJ/PCOnhbznB71Oi6v/KjYMTowgHNN6FX7W8/A==;\n\t5:yrW4wGjrCsOgmH6jV7UHnZgYN7NvneyqwQzealbx6ACBXckeiDUHhfzFEeyHhbfrb9Uz2eZSj3aUFiypRZSiZjxup65Nl+cU6I1cs73wyfr0A0W+cQyfFE3V1lFXygV8e63LL44mQyaWMLm+Rjn8xQ==;\n\t24:VdWn/nxvzon/dxmxDl8C+HYX/XfPGbZSoGyjBFCwO/kdSpBfw69MwD1UZOpy2z3RPJOkBwFBQK9k3a3AHy4JBZlABjYp4HBjDp0WgNbCskM=;\n\t7:JnMKqRODpsSVjP7wi40xzFguQW/3IY8hwrfaiSK0KMIrE4NleFQLtbIv/AMl4tgrRBKGINqw/jLIgcPt8yTEAfSm838J0dbXBDr1H690t8Vd6ipqAX4TkxzVo02tIMSgWwyWC7i548sG4Uvq7LcDCc0MCc5T+OpQl1nys++apCwh0of2eYo2Y548OPwkAm7/Li7SgHuuczhIVPe6g+Pn3La7lWUAm4tJN+iDTJhYLLc=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"02d3c9e5-b860-43b6-635d-08d4f00c50d3","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1SPR00MB110; ","x-ms-traffictypediagnostic":"VI1SPR00MB110:","x-exchange-antispam-report-test":"UriScan:(9452136761055);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1SPR00MB110; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1SPR00MB110; ","x-forefront-prvs":"04163EF38A","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(189002)(377424004)(377454003)(13464003)(24454002)(6246003)(25786009)(4326008)(39060400002)(5660300001)(2950100002)(55016002)(74316002)(7696004)(2906002)(99286003)(68736007)(3280700002)(8666007)(2501003)(5250100002)(106356001)(105586002)(3660700001)(189998001)(86362001)(6116002)(102836003)(6506006)(7736002)(2900100001)(81166006)(66066001)(81156014)(50986999)(6436002)(3846002)(53546010)(76176999)(54356999)(33656002)(97736004)(8676002)(9686003)(54906002)(101416001)(53936002)(14454004)(478600001)(45080400002)(8936002)(305945005)(229853002)(21314002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1SPR00MB110;\n\tH:VI1PR0501MB2143.eurprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"31 Aug 2017 01:05:05.0043\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1SPR00MB110","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]