[{"id":1760097,"web_url":"http://patchwork.ozlabs.org/comment/1760097/","msgid":"<38cea4fa-1ca2-1055-0595-4febf3c08e27@mojatatu.com>","list_archive_url":null,"date":"2017-08-30T12:09:14","subject":"Re: [patch net-next v2 2/3] net/sched: Change cls_flower to use IDR","submitter":{"id":9380,"url":"http://patchwork.ozlabs.org/api/people/9380/","name":"Jamal Hadi Salim","email":"jhs@mojatatu.com"},"content":"On 17-08-30 02:31 AM, Chris Mi wrote:\n> Currently, all filters with the same priority are linked in a doubly\n> linked list. Every filter should have a unique handle. To make the\n> handle unique, we need to iterate the list every time to see if the\n> handle exists or not when inserting a new filter. It is time-consuming.\n> For example, it takes about 5m3.169s to insert 64K rules.\n> \n> This patch changes cls_flower to use IDR. With this patch, it\n> takes about 0m1.127s to insert 64K rules. The improvement is huge.\n> \n> But please note that in this testing, all filters share the same action.\n> If every filter has a unique action, that is another bottleneck.\n> Follow-up patch in this patchset addresses that.\n> \n> Signed-off-by: Chris Mi \n> Signed-off-by: Jiri Pirko \n\nAcked-by: Jamal Hadi Salim \n\n\nBTW: I'd already acked this before but you left it out in this\nversion.\n\ncheers,\njamal","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"mu5mMmZb\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj4785xZ1z9sQl\n\tfor ;\n\tWed, 30 Aug 2017 22:09:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751382AbdH3MJW (ORCPT );\n\tWed, 30 Aug 2017 08:09:22 -0400","from mail-it0-f67.google.com ([209.85.214.67]:33239 \"EHLO\n\tmail-it0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751282AbdH3MJV (ORCPT\n\t); Wed, 30 Aug 2017 08:09:21 -0400","by mail-it0-f67.google.com with SMTP id 77so915740itj.0\n\tfor ; Wed, 30 Aug 2017 05:09:21 -0700 (PDT)","from [10.0.0.4] (135-23-93-187.cpe.pppoe.ca. [135.23.93.187])\n\tby smtp.googlemail.com with ESMTPSA id\n\tg75sm600706ita.4.2017.08.30.05.09.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 05:09:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=9cK2QLpSKARe3rY+H09V+8bCR7dPjx2ulqnorszrBXQ=;\n\tb=mu5mMmZbWn4g/5MonfIVSumtZFyLxAsr73pEWXTd4YTunAG7wU9rDH1isyaunFh2fG\n\tGuPUbGCAiP9Pl1ldi2/WYaXCbaReuGExKSJZaUyOTKbIF/tWnfmbdIQtECgFg8UEkMtP\n\tvf/r/+s5kxH4SSEbuoJUYsBctE5l6Nc6pmVwwuRezHz98k8/+t/uXbGFk/V06sdILWvR\n\t7tco0u/m02bdKunWv3zyJhOpSp65x8J11ZSzxjbV6HjodlBu7KBfbwte734V7ydwGoK9\n\tagqb3QnLAYV9d+RdZB1ffPe3gpmM12345j4Lx2VEDzvPQ1WTNJYOE0f+5uFAesVrZToS\n\toWyg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=9cK2QLpSKARe3rY+H09V+8bCR7dPjx2ulqnorszrBXQ=;\n\tb=SET1Ews9F8ea6UMeH8fCuYqISvY0GhAeVhtm7LnK3BbXZPnLRRpgxoB7ZZ27nVizTx\n\tDmB0HB+NAHv1MiQS38e+nAA0EI010i8CyGxkHbKQdtKwZwxsj/qS+UO4Mi+iMkYOj18T\n\ttno3327/LD0hdZ9aYQpz6/GaTqbugi+VewC28tUyI6njQ788z5TABZOK/FLO/Po+w/w5\n\tc7lcirmMkEUnuy4QYFokTqfdKYWXM7VrIC+sOEmqp7i1TVibkFe9W/gzmhvUYryfTRBZ\n\tSKG6lMH9JLSjIMucNOsKxFSKgxhCGt1RSlE3tu53ujttSzIxKvwqghBQzyWAasQKT6ul\n\tf2Tg==","X-Gm-Message-State":"AHYfb5jvXItqz1cm0l97uPt1YgUNUd7HNobgq2hf5giad8mf8SiDHn/5\n\tSGtao6eZ8k6X/YOuD3k=","X-Received":"by 10.36.132.136 with SMTP id h130mr1331395itd.44.1504094961325; \n\tWed, 30 Aug 2017 05:09:21 -0700 (PDT)","Subject":"Re: [patch net-next v2 2/3] net/sched: Change cls_flower to use IDR","To":"Chris Mi , netdev@vger.kernel.org","Cc":"xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,\n\tmawilcox@microsoft.com","References":"<1504074719-15147-1-git-send-email-chrism@mellanox.com>\n\t<1504074719-15147-3-git-send-email-chrism@mellanox.com>","From":"Jamal Hadi Salim ","Message-ID":"<38cea4fa-1ca2-1055-0595-4febf3c08e27@mojatatu.com>","Date":"Wed, 30 Aug 2017 08:09:14 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504074719-15147-3-git-send-email-chrism@mellanox.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]