[{"id":1774754,"web_url":"http://patchwork.ozlabs.org/comment/1774754/","msgid":"<aba307b9-2c7c-39e9-bd7e-c13c01789718@denx.de>","list_archive_url":null,"date":"2017-09-25T14:12:27","subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"Hi Peng,\n\nOn 30/08/2017 08:14, Peng Fan wrote:\n> Enable DM MMC/I2C/PMIC/GPIO/REGULATOR.\n> \n> Signed-off-by: Peng Fan <peng.fan@nxp.com>\n> Cc: Fabio Estevam <fabio.estevam@nxp.com>\n> Cc: Stefano Babic <sbabic@denx.de>\n> ---\n> \n> V2->V4: none\n> \n>  board/freescale/mx6sabresd/mx6sabresd.c | 326 +++++++++++++-------------------\n>  configs/mx6sabresd_defconfig            |  15 ++\n>  include/configs/mx6sabresd.h            |  15 +-\n>  3 files changed, 146 insertions(+), 210 deletions(-)\n> \n> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c\n> index fa75ab0..2123a9d 100644\n> --- a/board/freescale/mx6sabresd/mx6sabresd.c\n> +++ b/board/freescale/mx6sabresd/mx6sabresd.c\n> @@ -12,7 +12,6 @@\n>  #include <asm/arch/mx6-pins.h>\n>  #include <linux/errno.h>\n>  #include <asm/gpio.h>\n> -#include <asm/mach-imx/mxc_i2c.h>\n>  #include <asm/mach-imx/iomux-v3.h>\n>  #include <asm/mach-imx/boot_mode.h>\n>  #include <asm/mach-imx/video.h>\n> @@ -24,7 +23,6 @@\n>  #include <asm/arch/crm_regs.h>\n>  #include <asm/io.h>\n>  #include <asm/arch/sys_proto.h>\n> -#include <i2c.h>\n>  #include <power/pmic.h>\n>  #include <power/pfuze100_pmic.h>\n>  #include \"../common/pfuze.h\"\n> @@ -46,14 +44,6 @@ DECLARE_GLOBAL_DATA_PTR;\n>  #define SPI_PAD_CTRL (PAD_CTL_HYS | PAD_CTL_SPEED_MED | \\\n>  \t\t      PAD_CTL_DSE_40ohm | PAD_CTL_SRE_FAST)\n>  \n> -#define I2C_PAD_CTRL  (PAD_CTL_PUS_100K_UP |\t\t\t\\\n> -\tPAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm | PAD_CTL_HYS |\t\\\n> -\tPAD_CTL_ODE | PAD_CTL_SRE_FAST)\n> -\n> -#define I2C_PMIC\t1\n> -\n> -#define I2C_PAD MUX_PAD_CTRL(I2C_PAD_CTRL)\n> -\n>  #define DISP0_PWR_EN\tIMX_GPIO_NR(1, 21)\n>  \n>  #define KEY_VOL_UP\tIMX_GPIO_NR(1, 4)\n> @@ -93,6 +83,7 @@ static void setup_iomux_enet(void)\n>  {\n>  \tSETUP_IOMUX_PADS(enet_pads);\n>  \n> +\tgpio_request(IMX_GPIO_NR(1, 25), \"phy_rst\");\n>  \t/* Reset AR8031 PHY */\n>  \tgpio_direction_output(IMX_GPIO_NR(1, 25) , 0);\n>  \tmdelay(10);\n> @@ -100,47 +91,6 @@ static void setup_iomux_enet(void)\n>  \tudelay(100);\n>  }\n>  \n> -static iomux_v3_cfg_t const usdhc2_pads[] = {\n> -\tIOMUX_PADS(PAD_SD2_CLK__SD2_CLK\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD2_CMD__SD2_CMD\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD2_DAT0__SD2_DATA0\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD2_DAT1__SD2_DATA1\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD2_DAT2__SD2_DATA2\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD2_DAT3__SD2_DATA3\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_NANDF_D4__SD2_DATA4\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_NANDF_D5__SD2_DATA5\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_NANDF_D6__SD2_DATA6\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_NANDF_D7__SD2_DATA7\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_NANDF_D2__GPIO2_IO02\t| MUX_PAD_CTRL(NO_PAD_CTRL)), /* CD */\n> -};\n> -\n> -static iomux_v3_cfg_t const usdhc3_pads[] = {\n> -\tIOMUX_PADS(PAD_SD3_CLK__SD3_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_CMD__SD3_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT0__SD3_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT1__SD3_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT2__SD3_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT3__SD3_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT4__SD3_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT5__SD3_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT6__SD3_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD3_DAT7__SD3_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_NANDF_D0__GPIO2_IO00    | MUX_PAD_CTRL(NO_PAD_CTRL)), /* CD */\n> -};\n> -\n> -static iomux_v3_cfg_t const usdhc4_pads[] = {\n> -\tIOMUX_PADS(PAD_SD4_CLK__SD4_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_CMD__SD4_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT0__SD4_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT1__SD4_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT2__SD4_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT3__SD4_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT4__SD4_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT5__SD4_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT6__SD4_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -\tIOMUX_PADS(PAD_SD4_DAT7__SD4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> -};\n> -\n>  static iomux_v3_cfg_t const ecspi1_pads[] = {\n>  \tIOMUX_PADS(PAD_KEY_COL0__ECSPI1_SCLK | MUX_PAD_CTRL(SPI_PAD_CTRL)),\n>  \tIOMUX_PADS(PAD_KEY_COL1__ECSPI1_MISO | MUX_PAD_CTRL(SPI_PAD_CTRL)),\n> @@ -187,6 +137,7 @@ static iomux_v3_cfg_t const bl_pads[] = {\n>  static void enable_backlight(void)\n>  {\n>  \tSETUP_IOMUX_PADS(bl_pads);\n> +\tgpio_request(DISP0_PWR_EN, \"disp0_pwr_en\");\n>  \tgpio_direction_output(DISP0_PWR_EN, 1);\n>  }\n>  \n> @@ -201,32 +152,6 @@ static void enable_lvds(struct display_info_t const *dev)\n>  \tenable_backlight();\n>  }\n>  \n> -static struct i2c_pads_info mx6q_i2c_pad_info1 = {\n> -\t.scl = {\n> -\t\t.i2c_mode = MX6Q_PAD_KEY_COL3__I2C2_SCL | I2C_PAD,\n> -\t\t.gpio_mode = MX6Q_PAD_KEY_COL3__GPIO4_IO12 | I2C_PAD,\n> -\t\t.gp = IMX_GPIO_NR(4, 12)\n> -\t},\n> -\t.sda = {\n> -\t\t.i2c_mode = MX6Q_PAD_KEY_ROW3__I2C2_SDA | I2C_PAD,\n> -\t\t.gpio_mode = MX6Q_PAD_KEY_ROW3__GPIO4_IO13 | I2C_PAD,\n> -\t\t.gp = IMX_GPIO_NR(4, 13)\n> -\t}\n> -};\n> -\n> -static struct i2c_pads_info mx6dl_i2c_pad_info1 = {\n> -\t.scl = {\n> -\t\t.i2c_mode = MX6DL_PAD_KEY_COL3__I2C2_SCL | I2C_PAD,\n> -\t\t.gpio_mode = MX6DL_PAD_KEY_COL3__GPIO4_IO12 | I2C_PAD,\n> -\t\t.gp = IMX_GPIO_NR(4, 12)\n> -\t},\n> -\t.sda = {\n> -\t\t.i2c_mode = MX6DL_PAD_KEY_ROW3__I2C2_SDA | I2C_PAD,\n> -\t\t.gpio_mode = MX6DL_PAD_KEY_ROW3__GPIO4_IO13 | I2C_PAD,\n> -\t\t.gp = IMX_GPIO_NR(4, 13)\n> -\t}\n> -};\n> -\n>  static void setup_spi(void)\n>  {\n>  \tSETUP_IOMUX_PADS(ecspi1_pads);\n> @@ -253,121 +178,11 @@ static void setup_iomux_uart(void)\n>  \tSETUP_IOMUX_PADS(uart1_pads);\n>  }\n>  \n> -#ifdef CONFIG_FSL_ESDHC\n> -struct fsl_esdhc_cfg usdhc_cfg[3] = {\n> -\t{USDHC2_BASE_ADDR},\n> -\t{USDHC3_BASE_ADDR},\n> -\t{USDHC4_BASE_ADDR},\n> -};\n> -\n> -#define USDHC2_CD_GPIO\tIMX_GPIO_NR(2, 2)\n> -#define USDHC3_CD_GPIO\tIMX_GPIO_NR(2, 0)\n> -\n>  int board_mmc_get_env_dev(int devno)\n>  {\n>  \treturn devno - 1;\n>  }\n>  \n> -int board_mmc_getcd(struct mmc *mmc)\n> -{\n> -\tstruct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;\n> -\tint ret = 0;\n> -\n> -\tswitch (cfg->esdhc_base) {\n> -\tcase USDHC2_BASE_ADDR:\n> -\t\tret = !gpio_get_value(USDHC2_CD_GPIO);\n> -\t\tbreak;\n> -\tcase USDHC3_BASE_ADDR:\n> -\t\tret = !gpio_get_value(USDHC3_CD_GPIO);\n> -\t\tbreak;\n> -\tcase USDHC4_BASE_ADDR:\n> -\t\tret = 1; /* eMMC/uSDHC4 is always present */\n> -\t\tbreak;\n> -\t}\n> -\n> -\treturn ret;\n> -}\n> -\n> -int board_mmc_init(bd_t *bis)\n> -{\n> -#ifndef CONFIG_SPL_BUILD\n> -\tint ret;\n> -\tint i;\n> -\n> -\t/*\n> -\t * According to the board_mmc_init() the following map is done:\n> -\t * (U-Boot device node)    (Physical Port)\n> -\t * mmc0                    SD2\n> -\t * mmc1                    SD3\n> -\t * mmc2                    eMMC\n> -\t */\n> -\tfor (i = 0; i < CONFIG_SYS_FSL_USDHC_NUM; i++) {\n> -\t\tswitch (i) {\n> -\t\tcase 0:\n> -\t\t\tSETUP_IOMUX_PADS(usdhc2_pads);\n> -\t\t\tgpio_direction_input(USDHC2_CD_GPIO);\n> -\t\t\tusdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK);\n> -\t\t\tbreak;\n> -\t\tcase 1:\n> -\t\t\tSETUP_IOMUX_PADS(usdhc3_pads);\n> -\t\t\tgpio_direction_input(USDHC3_CD_GPIO);\n> -\t\t\tusdhc_cfg[1].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);\n> -\t\t\tbreak;\n> -\t\tcase 2:\n> -\t\t\tSETUP_IOMUX_PADS(usdhc4_pads);\n> -\t\t\tusdhc_cfg[2].sdhc_clk = mxc_get_clock(MXC_ESDHC4_CLK);\n> -\t\t\tbreak;\n> -\t\tdefault:\n> -\t\t\tprintf(\"Warning: you configured more USDHC controllers\"\n> -\t\t\t       \"(%d) then supported by the board (%d)\\n\",\n> -\t\t\t       i + 1, CONFIG_SYS_FSL_USDHC_NUM);\n> -\t\t\treturn -EINVAL;\n> -\t\t}\n> -\n> -\t\tret = fsl_esdhc_initialize(bis, &usdhc_cfg[i]);\n> -\t\tif (ret)\n> -\t\t\treturn ret;\n> -\t}\n> -\n> -\treturn 0;\n> -#else\n> -\tstruct src *psrc = (struct src *)SRC_BASE_ADDR;\n> -\tunsigned reg = readl(&psrc->sbmr1) >> 11;\n> -\t/*\n> -\t * Upon reading BOOT_CFG register the following map is done:\n> -\t * Bit 11 and 12 of BOOT_CFG register can determine the current\n> -\t * mmc port\n> -\t * 0x1                  SD1\n> -\t * 0x2                  SD2\n> -\t * 0x3                  SD4\n> -\t */\n> -\n> -\tswitch (reg & 0x3) {\n> -\tcase 0x1:\n> -\t\tSETUP_IOMUX_PADS(usdhc2_pads);\n> -\t\tusdhc_cfg[0].esdhc_base = USDHC2_BASE_ADDR;\n> -\t\tusdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK);\n> -\t\tgd->arch.sdhc_clk = usdhc_cfg[0].sdhc_clk;\n> -\t\tbreak;\n> -\tcase 0x2:\n> -\t\tSETUP_IOMUX_PADS(usdhc3_pads);\n> -\t\tusdhc_cfg[0].esdhc_base = USDHC3_BASE_ADDR;\n> -\t\tusdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);\n> -\t\tgd->arch.sdhc_clk = usdhc_cfg[0].sdhc_clk;\n> -\t\tbreak;\n> -\tcase 0x3:\n> -\t\tSETUP_IOMUX_PADS(usdhc4_pads);\n> -\t\tusdhc_cfg[0].esdhc_base = USDHC4_BASE_ADDR;\n> -\t\tusdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC4_CLK);\n> -\t\tgd->arch.sdhc_clk = usdhc_cfg[0].sdhc_clk;\n> -\t\tbreak;\n> -\t}\n> -\n> -\treturn fsl_esdhc_initialize(bis, &usdhc_cfg[0]);\n> -#endif\n> -}\n> -#endif\n> -\n>  static int ar8031_phy_fixup(struct phy_device *phydev)\n>  {\n>  \tunsigned short val;\n> @@ -580,6 +395,8 @@ static void setup_usb(void)\n>  \timx_iomux_set_gpr_register(1, 13, 1, 0);\n>  \n>  \tSETUP_IOMUX_PADS(usb_hc1_pads);\n> +\n> +\tgpio_request(IMX_GPIO_NR(1, 29), \"usb1\");\n>  }\n>  \n>  int board_ehci_hcd_init(int port)\n> @@ -632,13 +449,13 @@ int board_init(void)\n>  \t/* address of boot parameters */\n>  \tgd->bd->bi_boot_params = PHYS_SDRAM + 0x100;\n>  \n> +\tgpio_request(IMX_GPIO_NR(3, 19), \"pcie_power\");\n> +\tgpio_request(IMX_GPIO_NR(7, 12), \"pcie_reset\");\n> +\n>  #ifdef CONFIG_MXC_SPI\n>  \tsetup_spi();\n>  #endif\n> -\tif (is_mx6dq() || is_mx6dqp())\n> -\t\tsetup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6q_i2c_pad_info1);\n> -\telse\n> -\t\tsetup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c_pad_info1);\n> +\n>  #ifdef CONFIG_USB_EHCI_MX6\n>  \tsetup_usb();\n>  #endif\n> @@ -646,34 +463,36 @@ int board_init(void)\n>  \treturn 0;\n>  }\n>  \n> +#ifndef CONFIG_SPL_BUILD\n>  int power_init_board(void)\n>  {\n> -\tstruct pmic *p;\n> +\tstruct udevice *dev;\n>  \tunsigned int reg;\n>  \tint ret;\n>  \n> -\tp = pfuze_common_init(I2C_PMIC);\n> -\tif (!p)\n> +\tdev = pfuze_common_init();\n> +\tif (!dev)\n>  \t\treturn -ENODEV;\n>  \n> -\tret = pfuze_mode_init(p, APS_PFM);\n> +\tret = pfuze_mode_init(dev, APS_PFM);\n>  \tif (ret < 0)\n>  \t\treturn ret;\n>  \n>  \t/* Increase VGEN3 from 2.5 to 2.8V */\n> -\tpmic_reg_read(p, PFUZE100_VGEN3VOL, &reg);\n> +\treg = pmic_reg_read(dev, PFUZE100_VGEN3VOL);\n>  \treg &= ~LDO_VOL_MASK;\n>  \treg |= LDOB_2_80V;\n> -\tpmic_reg_write(p, PFUZE100_VGEN3VOL, reg);\n> +\tpmic_reg_write(dev, PFUZE100_VGEN3VOL, reg);\n>  \n>  \t/* Increase VGEN5 from 2.8 to 3V */\n> -\tpmic_reg_read(p, PFUZE100_VGEN5VOL, &reg);\n> +\treg = pmic_reg_read(dev, PFUZE100_VGEN5VOL);\n>  \treg &= ~LDO_VOL_MASK;\n>  \treg |= LDOB_3_00V;\n> -\tpmic_reg_write(p, PFUZE100_VGEN5VOL, reg);\n> +\tpmic_reg_write(dev, PFUZE100_VGEN5VOL, reg);\n>  \n>  \treturn 0;\n>  }\n> +#endif\n>  \n>  #ifdef CONFIG_MXC_SPI\n>  int board_spi_cs_gpio(unsigned bus, unsigned cs)\n> @@ -747,6 +566,115 @@ int board_fit_config_name_match(const char *name)\n>  }\n>  #endif\n>  \n> +#ifdef CONFIG_FSL_ESDHC\n> +static iomux_v3_cfg_t const usdhc2_pads[] = {\n> +\tIOMUX_PADS(PAD_SD2_CLK__SD2_CLK\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD2_CMD__SD2_CMD\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD2_DAT0__SD2_DATA0\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD2_DAT1__SD2_DATA1\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD2_DAT2__SD2_DATA2\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD2_DAT3__SD2_DATA3\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_NANDF_D4__SD2_DATA4\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_NANDF_D5__SD2_DATA5\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_NANDF_D6__SD2_DATA6\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_NANDF_D7__SD2_DATA7\t| MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_NANDF_D2__GPIO2_IO02\t| MUX_PAD_CTRL(NO_PAD_CTRL)), /* CD */\n> +};\n> +\n> +static iomux_v3_cfg_t const usdhc3_pads[] = {\n> +\tIOMUX_PADS(PAD_SD3_CLK__SD3_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_CMD__SD3_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT0__SD3_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT1__SD3_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT2__SD3_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT3__SD3_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT4__SD3_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT5__SD3_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT6__SD3_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD3_DAT7__SD3_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_NANDF_D0__GPIO2_IO00    | MUX_PAD_CTRL(NO_PAD_CTRL)), /* CD */\n> +};\n> +\n> +static iomux_v3_cfg_t const usdhc4_pads[] = {\n> +\tIOMUX_PADS(PAD_SD4_CLK__SD4_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_CMD__SD4_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT0__SD4_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT1__SD4_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT2__SD4_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT3__SD4_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT4__SD4_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT5__SD4_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT6__SD4_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +\tIOMUX_PADS(PAD_SD4_DAT7__SD4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL)),\n> +};\n> +\n> +struct fsl_esdhc_cfg usdhc_cfg[3] = {\n> +\t{USDHC2_BASE_ADDR},\n> +\t{USDHC3_BASE_ADDR},\n> +\t{USDHC4_BASE_ADDR},\n> +};\n> +\n> +#define USDHC2_CD_GPIO\tIMX_GPIO_NR(2, 2)\n> +#define USDHC3_CD_GPIO\tIMX_GPIO_NR(2, 0)\n> +\n> +int board_mmc_getcd(struct mmc *mmc)\n> +{\n> +\tstruct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;\n> +\tint ret = 0;\n> +\n> +\tswitch (cfg->esdhc_base) {\n> +\tcase USDHC2_BASE_ADDR:\n> +\t\tret = !gpio_get_value(USDHC2_CD_GPIO);\n> +\t\tbreak;\n> +\tcase USDHC3_BASE_ADDR:\n> +\t\tret = !gpio_get_value(USDHC3_CD_GPIO);\n> +\t\tbreak;\n> +\tcase USDHC4_BASE_ADDR:\n> +\t\tret = 1; /* eMMC/uSDHC4 is always present */\n> +\t\tbreak;\n> +\t}\n> +\n> +\treturn ret;\n> +}\n> +\n> +int board_mmc_init(bd_t *bis)\n> +{\n> +\tstruct src *psrc = (struct src *)SRC_BASE_ADDR;\n> +\tunsigned reg = readl(&psrc->sbmr1) >> 11;\n> +\t/*\n> +\t * Upon reading BOOT_CFG register the following map is done:\n> +\t * Bit 11 and 12 of BOOT_CFG register can determine the current\n> +\t * mmc port\n> +\t * 0x1                  SD1\n> +\t * 0x2                  SD2\n> +\t * 0x3                  SD4\n> +\t */\n> +\n> +\tswitch (reg & 0x3) {\n> +\tcase 0x1:\n> +\t\tSETUP_IOMUX_PADS(usdhc2_pads);\n> +\t\tusdhc_cfg[0].esdhc_base = USDHC2_BASE_ADDR;\n> +\t\tusdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK);\n> +\t\tgd->arch.sdhc_clk = usdhc_cfg[0].sdhc_clk;\n> +\t\tbreak;\n> +\tcase 0x2:\n> +\t\tSETUP_IOMUX_PADS(usdhc3_pads);\n> +\t\tusdhc_cfg[0].esdhc_base = USDHC3_BASE_ADDR;\n> +\t\tusdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);\n> +\t\tgd->arch.sdhc_clk = usdhc_cfg[0].sdhc_clk;\n> +\t\tbreak;\n> +\tcase 0x3:\n> +\t\tSETUP_IOMUX_PADS(usdhc4_pads);\n> +\t\tusdhc_cfg[0].esdhc_base = USDHC4_BASE_ADDR;\n> +\t\tusdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC4_CLK);\n> +\t\tgd->arch.sdhc_clk = usdhc_cfg[0].sdhc_clk;\n> +\t\tbreak;\n> +\t}\n> +\n> +\treturn fsl_esdhc_initialize(bis, &usdhc_cfg[0]);\n> +}\n> +#endif\n> +\n>  static void ccgr_init(void)\n>  {\n>  \tstruct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;\n> diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig\n> index 7491e9c..3eab67e 100644\n> --- a/configs/mx6sabresd_defconfig\n> +++ b/configs/mx6sabresd_defconfig\n> @@ -40,6 +40,8 @@ CONFIG_CMD_DHCP=y\n>  CONFIG_CMD_MII=y\n>  CONFIG_CMD_PING=y\n>  CONFIG_CMD_CACHE=y\n> +CONFIG_CMD_PMIC=y\n> +CONFIG_CMD_REGULATOR=y\n>  CONFIG_CMD_EXT2=y\n>  CONFIG_CMD_EXT4=y\n>  CONFIG_CMD_EXT4_WRITE=y\n> @@ -47,10 +49,23 @@ CONFIG_CMD_FAT=y\n>  CONFIG_CMD_FS_GENERIC=y\n>  CONFIG_OF_CONTROL=y\n>  CONFIG_OF_LIST=\"imx6q-sabresd imx6dl-sabresd imx6qp-sabresd\"\n> +# CONFIG_BLK is not set\n> +CONFIG_DM_GPIO=y\n> +CONFIG_DM_I2C=y\n> +CONFIG_DM_MMC=y\n> +# CONFIG_DM_MMC_OPS is not set\n>  CONFIG_SPI_FLASH=y\n>  CONFIG_SPI_FLASH_STMICRO=y\n>  CONFIG_PHYLIB=y\n>  CONFIG_PCI=y\n> +CONFIG_PINCTRL=y\n> +CONFIG_PINCTRL_IMX6=y\n> +CONFIG_DM_PMIC=y\n> +CONFIG_DM_PMIC_PFUZE100=y\n> +CONFIG_DM_REGULATOR=y\n> +CONFIG_DM_REGULATOR_PFUZE100=y\n> +CONFIG_DM_REGULATOR_FIXED=y\n> +CONFIG_DM_REGULATOR_GPIO=y\n>  CONFIG_USB=y\n>  CONFIG_USB_STORAGE=y\n>  CONFIG_USB_GADGET=y\n> diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h\n> index 5410881..a945641 100644\n> --- a/include/configs/mx6sabresd.h\n> +++ b/include/configs/mx6sabresd.h\n> @@ -43,20 +43,9 @@\n>  #define CONFIG_PCIE_IMX_POWER_GPIO\tIMX_GPIO_NR(3, 19)\n>  #endif\n>  \n> -/* I2C Configs */\n> -#define CONFIG_SYS_I2C\n>  #define CONFIG_SYS_I2C_MXC\n> -#define CONFIG_SYS_I2C_MXC_I2C1\t\t/* enable I2C bus 1 */\n> -#define CONFIG_SYS_I2C_MXC_I2C2\t\t/* enable I2C bus 2 */\n> -#define CONFIG_SYS_I2C_MXC_I2C3\t\t/* enable I2C bus 3 */\n>  #define CONFIG_SYS_I2C_SPEED\t\t  100000\n>  \n> -/* PMIC */\n> -#define CONFIG_POWER\n> -#define CONFIG_POWER_I2C\n> -#define CONFIG_POWER_PFUZE100\n> -#define CONFIG_POWER_PFUZE100_I2C_ADDR\t0x08\n> -\n>  /* USB Configs */\n>  #ifdef CONFIG_CMD_USB\n>  #define CONFIG_EHCI_HCD_INIT_AFTER_RESET\n> @@ -67,4 +56,8 @@\n>  #define CONFIG_USB_MAX_CONTROLLER_COUNT\t1 /* Enabled USB controller number */\n>  #endif\n>  \n> +#ifdef CONFIG_SPL_BUILD\n> +#undef CONFIG_SYS_I2C_MXC\n> +#endif\n> +\n>  #endif                         /* __MX6SABRESD_CONFIG_H */\n> \n\nEnabling DM drivers seems to break sabresd:\n\n      arm:  +   mx6sabresd\n+common/usb_storage.c: In function 'usb_stor_probe_device':\n+common/usb_storage.c:218:30: error: 'struct usb_device' has no member\nnamed 'dev'\n+  data = dev_get_platdata(udev->dev);\n+                              ^\n+common/usb_storage.c:228:32: error: 'struct usb_device' has no member\nnamed 'dev'\n+   ret = blk_create_devicef(udev->dev, \"usb_storage_blk\", str,\n+                                ^\n\n\nCan you take a look ?\n\nBest regards,\nStefano","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y15dX15wSz9tX8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 00:12:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3614DC21F1F; Mon, 25 Sep 2017 14:12:46 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 95B69C21DA6;\n\tMon, 25 Sep 2017 14:12:39 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1681EC21DA6; Mon, 25 Sep 2017 14:12:38 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 8146BC21D7C\n\tfor <u-boot@lists.denx.de>; Mon, 25 Sep 2017 14:12:37 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y15dK0RWKz1qwRV;\n\tMon, 25 Sep 2017 16:12:37 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y15dJ6xDhz1r0wf;\n\tMon, 25 Sep 2017 16:12:36 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id BN_DLAEVJyFo; Mon, 25 Sep 2017 16:12:34 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tMon, 25 Sep 2017 16:12:34 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 503B645405F1;\n\tMon, 25 Sep 2017 16:12:34 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id RIvxqNQmxY-c; Mon, 25 Sep 2017 16:12:27 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 7A90045403D2;\n\tMon, 25 Sep 2017 16:12:27 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Peng Fan <peng.fan@nxp.com>, sbabic@denx.de","References":"<1504073693-16900-1-git-send-email-peng.fan@nxp.com>\n\t<1504073693-16900-11-git-send-email-peng.fan@nxp.com>","From":"Stefano Babic <sbabic@denx.de>","Message-ID":"<aba307b9-2c7c-39e9-bd7e-c13c01789718@denx.de>","Date":"Mon, 25 Sep 2017 16:12:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504073693-16900-11-git-send-email-peng.fan@nxp.com>","Content-Language":"de-DE","Cc":"u-boot@lists.denx.de, Fabio Estevam <fabio.estevam@nxp.com>","Subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1775088,"web_url":"http://patchwork.ozlabs.org/comment/1775088/","msgid":"<DB6PR04MB3221328C69974BECF532C94A887B0@DB6PR04MB3221.eurprd04.prod.outlook.com>","list_archive_url":null,"date":"2017-09-26T02:03:59","subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","submitter":{"id":67896,"url":"http://patchwork.ozlabs.org/api/people/67896/","name":"Peng Fan","email":"peng.fan@nxp.com"},"content":"Hi Stefano,\r\n\r\n\r\n> -----Original Message-----\r\n> From: Stefano Babic [mailto:sbabic@denx.de]\r\n> Sent: Monday, September 25, 2017 10:12 PM\r\n> To: Peng Fan <peng.fan@nxp.com>; sbabic@denx.de\r\n> Cc: van.freenix@gmail.com; u-boot@lists.denx.de; Fabio Estevam\r\n> <fabio.estevam@nxp.com>\r\n> Subject: Re: [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers\r\n> \r\n> Hi Peng,\r\n> \r\n> On 30/08/2017 08:14, Peng Fan wrote:\r\n> > Enable DM MMC/I2C/PMIC/GPIO/REGULATOR.\r\n> >\r\n> > Signed-off-by: Peng Fan <peng.fan@nxp.com>\r\n> > Cc: Fabio Estevam <fabio.estevam@nxp.com>\r\n> > Cc: Stefano Babic <sbabic@denx.de>\r\n> > ---\r\n> >\r\n> > V2->V4: none\r\n> >\r\n[..........]\r\n\r\n> >\r\n> \r\n> Enabling DM drivers seems to break sabresd:\r\n> \r\n>       arm:  +   mx6sabresd\r\n> +common/usb_storage.c: In function 'usb_stor_probe_device':\r\n> +common/usb_storage.c:218:30: error: 'struct usb_device' has no member\r\n> named 'dev'\r\n> +  data = dev_get_platdata(udev->dev);\r\n> +                              ^\r\n> +common/usb_storage.c:228:32: error: 'struct usb_device' has no member\r\n> named 'dev'\r\n> +   ret = blk_create_devicef(udev->dev, \"usb_storage_blk\", str,\r\n> +                                ^\r\n> \r\n> \r\n> Can you take a look ?\r\n\r\nI build mx6sabresd_defconfig, I met the following warning based on imx master branch, but did not met the build error.\r\n  CC      spl/common/spl/spl_fit.o\r\ncommon/spl/spl_fit.c: In function 'spl_load_fit_image':\r\ncommon/spl/spl_fit.c:201:7: warning: passing argument 4 of 'gunzip' from incompatible pointer type [enabled by default]\r\n       src, &length)) {\r\n       ^\r\nIn file included from common/spl/spl_fit.c:8:0:\r\ninclude/common.h:627:5: note: expected 'long unsigned int *' but argument is of type 'size_t *'\r\n int gunzip(void *, int, unsigned char *, unsigned long *);\r\n     ^\r\n\r\nThanks,\r\nPeng.\r\n> \r\n> Best regards,\r\n> Stefano\r\n> \r\n> \r\n> --\r\n> ============================================================\r\n> =========\r\n> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk\r\n> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\r\n> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de\r\n> ============================================================\r\n> =========","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"ieaUeVDC\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=peng.fan@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1PQT22TDz9t3F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 12:04:15 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B4DFCC21ECA; Tue, 26 Sep 2017 02:04:06 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 3EF95C21D5B;\n\tTue, 26 Sep 2017 02:04:04 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8DF23C21D5B; Tue, 26 Sep 2017 02:04:03 +0000 (UTC)","from EUR03-DB5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr40063.outbound.protection.outlook.com [40.107.4.63])\n\tby lists.denx.de (Postfix) with ESMTPS id D9FFFC21C71\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 02:04:02 +0000 (UTC)","from DB6PR04MB3221.eurprd04.prod.outlook.com (10.170.211.17) by\n\tHE1PR0401MB2634.eurprd04.prod.outlook.com (10.168.148.139) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tTue, 26 Sep 2017 02:04:01 +0000","from DB6PR04MB3221.eurprd04.prod.outlook.com\n\t([fe80::9864:d27b:122a:5e12]) by\n\tDB6PR04MB3221.eurprd04.prod.outlook.com\n\t([fe80::9864:d27b:122a:5e12%13]) with mapi id 15.20.0077.011;\n\tTue, 26 Sep 2017 02:04:00 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=X77fxFOpnXEnznkf8Yl3ase4d/moqjZJpq3E0z7SZhU=;\n\tb=ieaUeVDClsVBsvfSj/YEiCfBixpBaRYcsfRRTEsUyy1iFkK61e/qwfczRl5jMjp/mI89/8eQW2m1YqgYNFDFdh3AGMxS/NOQqItbGJE794UlSo7RGB0vcpUj3O2XoLkYECiAjbA7xYIEHP+tXH4aYmGkJYcRB2/GxhppohUva3Q=","From":"Peng Fan <peng.fan@nxp.com>","To":"Stefano Babic <sbabic@denx.de>","Thread-Topic":"[PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","Thread-Index":"AQHTIVewyipgYiWCbUeBEqptKZiVrKLFzfKAgADGMnA=","Date":"Tue, 26 Sep 2017 02:03:59 +0000","Message-ID":"<DB6PR04MB3221328C69974BECF532C94A887B0@DB6PR04MB3221.eurprd04.prod.outlook.com>","References":"<1504073693-16900-1-git-send-email-peng.fan@nxp.com>\n\t<1504073693-16900-11-git-send-email-peng.fan@nxp.com>\n\t<aba307b9-2c7c-39e9-bd7e-c13c01789718@denx.de>","In-Reply-To":"<aba307b9-2c7c-39e9-bd7e-c13c01789718@denx.de>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"ieaUeVDC\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=peng.fan@nxp.com; "],"x-originating-ip":"[199.59.231.64]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; HE1PR0401MB2634;\n\t6:Ayk8mbb+pK4pphBmY6JYorNB0zG+aukGqp7KxnbnM7DA3rUffZnvD03/1JIJShHBzS09MhW9Lcm+DIyTVDH3gXTBvMacQpXvM43stbQHK/MauoZpRDGLnPVsv1JtvRPNrZdpcte061ecb3pVVoGa1BzmNsNDLJBobry+r3je8Z4GpJcfCygqiJLZMERnJskzK01gOmVbrXq5ww5F74THwZCdkCXAlcxPZDJxGIR9wIpCTSf/auVHxpwjIDNfV3TcoaLRUUUraHxd+CWia1s3y9POY7I+tLLuCQyc9+73tGQQajqz6b/zz7BxXb1Lpn4X9Z2l2JSbr0b/4KKzCQuwuQ==;\n\t5:nRbwpvVsEUPsvZb81QXu9YtdeUpvFu2kSfS65hGFnwXCdUZpdT9qrLJdEoYD8gIcrffWCYhUHZueXIU7hC+rfRcSjBKYJLeaTQ18eY9nh5qs/YTdINko6fdrhNxFHCGLFuGaMjvz1abPh/E1ey7gMg==;\n\t24:bTSa9QjtU1vjrVVhnA9o8CavxgtxWsULJACfl6tbdfKEx29yRcEBYs1Vs8IA1ZsNXvPhzrM1MjQPNYb8vAPteiEAJapjFj4Qvzh5+yClbzs=;\n\t7:kUSaPkdQDZvTjDTaoiCLvcBD0QHYlV2kzvijVXRXWd1HjTs/c6T/wjJK5S2fxbLZgxB0lhAGJ7eDfHcVJFEOjikxDvUqf8q+SOktazOAeQlbfxgsekxOul93mteFQVrfC8Qr85b44pXSdK2PIUF+a1bkNA1vuQH+yXBcmee2HWBe3Zw0RUlGWYhMfpKKBTh30ln80dy09+Hk2eGV92PV4lUCxlHRkCGDyjvydoZXQuQ=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(39860400002)(189002)(24454002)(377454003)(252514010)(199003)(13464003)(2900100001)(53936002)(316002)(8936002)(66066001)(105586002)(74316002)(7736002)(5250100002)(81156014)(8676002)(81166006)(305945005)(3280700002)(6116002)(68736007)(2906002)(189998001)(5660300001)(97736004)(7696004)(3660700001)(102836003)(106356001)(3846002)(86362001)(53546010)(101416001)(478600001)(25786009)(14454004)(39060400002)(2950100002)(6916009)(4326008)(33656002)(9686003)(6506006)(50986999)(6436002)(54356999)(55016002)(54906003)(6246003)(99286003)(76176999)(229853002)(32563001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB2634;\n\tH:DB6PR04MB3221.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"c7b23d18-9cfc-43d4-f48e-08d50482da94","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:HE1PR0401MB2634; ","x-ms-traffictypediagnostic":"HE1PR0401MB2634:","x-exchange-antispam-report-test":"UriScan:(185117386973197)(16074681357397);","x-microsoft-antispam-prvs":"<HE1PR0401MB2634E34A35BF4CF7FB0E88C5887B0@HE1PR0401MB2634.eurprd04.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR0401MB2634; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR0401MB2634; ","x-forefront-prvs":"0442E569BC","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"26 Sep 2017 02:04:00.1154\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"HE1PR0401MB2634","Cc":"\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>,\n\tFabio Estevam <fabio.estevam@nxp.com>","Subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1776781,"web_url":"http://patchwork.ozlabs.org/comment/1776781/","msgid":"<DB6PR04MB32219DA397B94BA212723D5688790@DB6PR04MB3221.eurprd04.prod.outlook.com>","list_archive_url":null,"date":"2017-09-28T05:34:16","subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","submitter":{"id":67896,"url":"http://patchwork.ozlabs.org/api/people/67896/","name":"Peng Fan","email":"peng.fan@nxp.com"},"content":"Hi Stefano,\r\n\r\n> -----Original Message-----\r\n> From: Peng Fan\r\n> Sent: Tuesday, September 26, 2017 10:04 AM\r\n> To: 'Stefano Babic' <sbabic@denx.de>\r\n> Cc: van.freenix@gmail.com; u-boot@lists.denx.de; Fabio Estevam\r\n> <fabio.estevam@nxp.com>\r\n> Subject: RE: [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers\r\n> \r\n> Hi Stefano,\r\n> \r\n> \r\n> > -----Original Message-----\r\n> > From: Stefano Babic [mailto:sbabic@denx.de]\r\n> > Sent: Monday, September 25, 2017 10:12 PM\r\n> > To: Peng Fan <peng.fan@nxp.com>; sbabic@denx.de\r\n> > Cc: van.freenix@gmail.com; u-boot@lists.denx.de; Fabio Estevam\r\n> > <fabio.estevam@nxp.com>\r\n> > Subject: Re: [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers\r\n> >\r\n> > Hi Peng,\r\n> >\r\n> > On 30/08/2017 08:14, Peng Fan wrote:\r\n> > > Enable DM MMC/I2C/PMIC/GPIO/REGULATOR.\r\n> > >\r\n> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>\r\n> > > Cc: Fabio Estevam <fabio.estevam@nxp.com>\r\n> > > Cc: Stefano Babic <sbabic@denx.de>\r\n> > > ---\r\n> > >\r\n> > > V2->V4: none\r\n> > >\r\n> [..........]\r\n> \r\n> > >\r\n> >\r\n> > Enabling DM drivers seems to break sabresd:\r\n> >\r\n> >       arm:  +   mx6sabresd\r\n> > +common/usb_storage.c: In function 'usb_stor_probe_device':\r\n> > +common/usb_storage.c:218:30: error: 'struct usb_device' has no member\r\n> > named 'dev'\r\n> > +  data = dev_get_platdata(udev->dev);\r\n> > +                              ^\r\n> > +common/usb_storage.c:228:32: error: 'struct usb_device' has no member\r\n> > named 'dev'\r\n> > +   ret = blk_create_devicef(udev->dev, \"usb_storage_blk\", str,\r\n> > +                                ^\r\n> >\r\n> >\r\n> > Can you take a look ?\r\n> \r\n> I build mx6sabresd_defconfig, I met the following warning based on imx\r\n> master branch, but did not met the build error.\r\n>   CC      spl/common/spl/spl_fit.o\r\n> common/spl/spl_fit.c: In function 'spl_load_fit_image':\r\n> common/spl/spl_fit.c:201:7: warning: passing argument 4 of 'gunzip' from\r\n> incompatible pointer type [enabled by default]\r\n>        src, &length)) {\r\n>        ^\r\n> In file included from common/spl/spl_fit.c:8:0:\r\n> include/common.h:627:5: note: expected 'long unsigned int *' but argument is\r\n> of type 'size_t *'\r\n>  int gunzip(void *, int, unsigned char *, unsigned long *);\r\n\r\nMissed to say that this is not introduced by my patch. \r\nDid not meet that error when build mx6sabresd_defconfig? I did not meet that error based on\r\nmaster or imx master branch.\r\n\r\nThanks,\r\nPeng.\r\n\r\n>      ^\r\n> \r\n> Thanks,\r\n> Peng.\r\n> >\r\n> > Best regards,\r\n> > Stefano\r\n> >\r\n> >\r\n> > --\r\n> >\r\n> ============================================================\r\n> > =========\r\n> > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk\r\n> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\r\n> > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de\r\n> >\r\n> ============================================================\r\n> > =========","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"KFSpe8j1\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=peng.fan@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2k095KxCz9t5C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 15:34:32 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 36B87C21D9E; Thu, 28 Sep 2017 05:34:24 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AE239C21CB0;\n\tThu, 28 Sep 2017 05:34:21 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid F262DC21CB0; Thu, 28 Sep 2017 05:34:19 +0000 (UTC)","from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00071.outbound.protection.outlook.com [40.107.0.71])\n\tby lists.denx.de (Postfix) with ESMTPS id 661A9C21C39\n\tfor <u-boot@lists.denx.de>; Thu, 28 Sep 2017 05:34:19 +0000 (UTC)","from DB6PR04MB3221.eurprd04.prod.outlook.com (10.170.211.17) by\n\tHE1PR0401MB2635.eurprd04.prod.outlook.com (10.168.148.140) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tThu, 28 Sep 2017 05:34:18 +0000","from DB6PR04MB3221.eurprd04.prod.outlook.com\n\t([fe80::9864:d27b:122a:5e12]) by\n\tDB6PR04MB3221.eurprd04.prod.outlook.com\n\t([fe80::9864:d27b:122a:5e12%13]) with mapi id 15.20.0077.016;\n\tThu, 28 Sep 2017 05:34:17 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2, SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=UdXMBvYuYNx0ti0T3O9Ul88748JnXIZlHc1QPDZDo+w=;\n\tb=KFSpe8j10ODXXKjgj1qM3jLeCA9tmEFS+Bn4Wx4WHwlg2mdrDfcRH/VyYtc9fBtHmXXpadmm73bhSg5ESoYCbEIBAp0BLlktuRKv1kI3Y55kN4C6CIdlSx82Ml37nHG3zrqib6ilNFMB27DEZLip9hMJZvSPA/OFXSopVVGmcTI=","From":"Peng Fan <peng.fan@nxp.com>","To":"Stefano Babic <sbabic@denx.de>","Thread-Topic":"[PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","Thread-Index":"AQHTIVewyipgYiWCbUeBEqptKZiVrKLFzfKAgADGMnCAA1+eEA==","Date":"Thu, 28 Sep 2017 05:34:16 +0000","Message-ID":"<DB6PR04MB32219DA397B94BA212723D5688790@DB6PR04MB3221.eurprd04.prod.outlook.com>","References":"<1504073693-16900-1-git-send-email-peng.fan@nxp.com>\n\t<1504073693-16900-11-git-send-email-peng.fan@nxp.com>\n\t<aba307b9-2c7c-39e9-bd7e-c13c01789718@denx.de>\n\t<DB6PR04MB3221328C69974BECF532C94A887B0@DB6PR04MB3221.eurprd04.prod.outlook.com>","In-Reply-To":"<DB6PR04MB3221328C69974BECF532C94A887B0@DB6PR04MB3221.eurprd04.prod.outlook.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"KFSpe8j1\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=peng.fan@nxp.com; "],"x-originating-ip":"[199.59.231.64]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; HE1PR0401MB2635;\n\t6:wMwNzU/FdN+08jQzt9weK0Fm2eL4NzEQlkBTnASpO++q2iy01fvXimwo+PZeRUe+EEZcfnruOPaT69vfXaMbMR3h/pi9vg1j0zYR+zYTxXdtkU5A/c0xKLD6UgdOJIHIIj81gbVKvFyXKiVM5ztHpfz3tE71/N6xWZogE83y29iF2RYS5p96orDbHbb/j8tX+TOic+ctzpVC4t0qTgvqACO07CPbBV2b7MjDEqmDrAE2FSDLoHHlJeagWcrKxHjqKsngE1fdqWlgQcA6B8QZkOhXYwUK/rdnjL4JbJSYvqQz/Foy8u8fgHBLsNCBM4RJOePTE3fAGFlM+DigYOGIzw==;\n\t5:I5BVtHra2gXN5GZSRaCadpsY4HxXroFljMiOz0nJ+CGutm0eT/q4LiHbY2ySPUTFjjoxvXFb6oUu5WcSIrvmxuDshUxa0pdi9qBAjrm4/OkqvH1e9DjNjxl7mopRdK8CEtB0dqWT+jDXnwnyKFj9JQ==;\n\t24:HeElaIVYlB2vYYxycAsOpXaaR5i1ljSwfR01H3Xo9erTljMlXJbaQU+wOEDW9RH45tD/QtWz+riSoO2zMLNFNX/d4LRLkjazPBl+CijgG0A=;\n\t7:KPZP367I3RQy1VuqqoOOAg/ldyTNsEb9Py4eCUWWlIh88IP3N253xyBIcEJ3Gf9mEesdTO31+wDoZsveWZE2X9te73T6pIIlLdgoDRzCMa/jA7aim1LyH1YMnWyOXrLgFP0UXymd1bUCOP3SsNQ5SLwggOmjyfrq6kaI8EaLU4gXQW3DUs/JfSc9EZHkvr2m/oGa4w2SnmUMpgzxau7879T6rUf1JvHEa7rWfirsJWM=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(346002)(376002)(199003)(252514010)(13464003)(377454003)(24454002)(189002)(478600001)(53546010)(68736007)(8676002)(305945005)(7736002)(6916009)(3660700001)(2906002)(3280700002)(74316002)(316002)(81166006)(81156014)(93886005)(9686003)(2950100002)(53936002)(5660300001)(33656002)(7696004)(99286003)(6436002)(55016002)(97736004)(8936002)(54906003)(5250100002)(102836003)(6116002)(3846002)(106356001)(189998001)(25786009)(2900100001)(6506006)(39060400002)(86362001)(6246003)(50986999)(76176999)(54356999)(66066001)(4326008)(105586002)(101416001)(14454004)(229853002)(32563001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0401MB2635;\n\tH:DB6PR04MB3221.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"21800f95-1b5b-4808-3b86-08d506328fb6","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:HE1PR0401MB2635; ","x-ms-traffictypediagnostic":"HE1PR0401MB2635:","x-exchange-antispam-report-test":"UriScan:(185117386973197)(16074681357397);","x-microsoft-antispam-prvs":"<HE1PR0401MB2635DB943511036606BA269488790@HE1PR0401MB2635.eurprd04.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR0401MB2635; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR0401MB2635; ","x-forefront-prvs":"0444EB1997","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"28 Sep 2017 05:34:17.0915\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"HE1PR0401MB2635","Cc":"\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>,\n\tFabio Estevam <fabio.estevam@nxp.com>","Subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1778322,"web_url":"http://patchwork.ozlabs.org/comment/1778322/","msgid":"<7a358dd0-90aa-e9ff-4855-22714834d8ec@denx.de>","list_archive_url":null,"date":"2017-10-02T13:16:28","subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 28/09/2017 07:34, Peng Fan wrote:\n> Hi Stefano,\n> \n>> -----Original Message-----\n>> From: Peng Fan\n>> Sent: Tuesday, September 26, 2017 10:04 AM\n>> To: 'Stefano Babic' <sbabic@denx.de>\n>> Cc: van.freenix@gmail.com; u-boot@lists.denx.de; Fabio Estevam\n>> <fabio.estevam@nxp.com>\n>> Subject: RE: [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers\n>>\n>> Hi Stefano,\n>>\n>>\n>>> -----Original Message-----\n>>> From: Stefano Babic [mailto:sbabic@denx.de]\n>>> Sent: Monday, September 25, 2017 10:12 PM\n>>> To: Peng Fan <peng.fan@nxp.com>; sbabic@denx.de\n>>> Cc: van.freenix@gmail.com; u-boot@lists.denx.de; Fabio Estevam\n>>> <fabio.estevam@nxp.com>\n>>> Subject: Re: [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers\n>>>\n>>> Hi Peng,\n>>>\n>>> On 30/08/2017 08:14, Peng Fan wrote:\n>>>> Enable DM MMC/I2C/PMIC/GPIO/REGULATOR.\n>>>>\n>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>\n>>>> Cc: Fabio Estevam <fabio.estevam@nxp.com>\n>>>> Cc: Stefano Babic <sbabic@denx.de>\n>>>> ---\n>>>>\n>>>> V2->V4: none\n>>>>\n>> [..........]\n>>\n>>>>\n>>>\n>>> Enabling DM drivers seems to break sabresd:\n>>>\n>>>       arm:  +   mx6sabresd\n>>> +common/usb_storage.c: In function 'usb_stor_probe_device':\n>>> +common/usb_storage.c:218:30: error: 'struct usb_device' has no member\n>>> named 'dev'\n>>> +  data = dev_get_platdata(udev->dev);\n>>> +                              ^\n>>> +common/usb_storage.c:228:32: error: 'struct usb_device' has no member\n>>> named 'dev'\n>>> +   ret = blk_create_devicef(udev->dev, \"usb_storage_blk\", str,\n>>> +                                ^\n>>>\n>>>\n>>> Can you take a look ?\n>>\n>> I build mx6sabresd_defconfig, I met the following warning based on imx\n>> master branch, but did not met the build error.\n>>   CC      spl/common/spl/spl_fit.o\n>> common/spl/spl_fit.c: In function 'spl_load_fit_image':\n>> common/spl/spl_fit.c:201:7: warning: passing argument 4 of 'gunzip' from\n>> incompatible pointer type [enabled by default]\n>>        src, &length)) {\n>>        ^\n>> In file included from common/spl/spl_fit.c:8:0:\n>> include/common.h:627:5: note: expected 'long unsigned int *' but argument is\n>> of type 'size_t *'\n>>  int gunzip(void *, int, unsigned char *, unsigned long *);\n> \n> Missed to say that this is not introduced by my patch. \n\nYes, it is not - it is due to concurrent mergfe of several patches.\n\n> Did not meet that error when build mx6sabresd_defconfig? I did not meet that error based on\n> master or imx master branch.\n\nI got some further errors because I have already merged Fabio's (and\nsomeone patch). Fixes look trivial, but I do not want to do this as I\ncannot test.\n\nCould you please take a look and rebase your set on top of current\nu-boot.imx ? Thanks !\n\nStefano","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5N3m1XGsz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  3 Oct 2017 00:16:52 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid E5F06C21EFB; Mon,  2 Oct 2017 13:16:50 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5F82AC21C41;\n\tMon,  2 Oct 2017 13:16:47 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9EDBEC21C41; Mon,  2 Oct 2017 13:16:45 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 4B206C21C29\n\tfor <u-boot@lists.denx.de>; Mon,  2 Oct 2017 13:16:45 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y5N3d0nBCz1qqyL;\n\tMon,  2 Oct 2017 15:16:45 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y5N3d0Dv2z1qr4S;\n\tMon,  2 Oct 2017 15:16:45 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id QzOFe9Kxt6d9; Mon,  2 Oct 2017 15:16:43 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tMon,  2 Oct 2017 15:16:43 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id CC0E745405F9;\n\tMon,  2 Oct 2017 15:16:38 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id iYdEYWGGQnO2; Mon,  2 Oct 2017 15:16:30 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 77A7E45405AB;\n\tMon,  2 Oct 2017 15:16:29 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Peng Fan <peng.fan@nxp.com>, Stefano Babic <sbabic@denx.de>","References":"<1504073693-16900-1-git-send-email-peng.fan@nxp.com>\n\t<1504073693-16900-11-git-send-email-peng.fan@nxp.com>\n\t<aba307b9-2c7c-39e9-bd7e-c13c01789718@denx.de>\n\t<DB6PR04MB3221328C69974BECF532C94A887B0@DB6PR04MB3221.eurprd04.prod.outlook.com>\n\t<DB6PR04MB32219DA397B94BA212723D5688790@DB6PR04MB3221.eurprd04.prod.outlook.com>","From":"Stefano Babic <sbabic@denx.de>","Message-ID":"<7a358dd0-90aa-e9ff-4855-22714834d8ec@denx.de>","Date":"Mon, 2 Oct 2017 15:16:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<DB6PR04MB32219DA397B94BA212723D5688790@DB6PR04MB3221.eurprd04.prod.outlook.com>","Content-Language":"de-DE","Cc":"\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>,\n\tFabio Estevam <fabio.estevam@nxp.com>","Subject":"Re: [U-Boot] [PATCH V4 11/12] imx: mx6sabresd: enable dm drivers","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]