[{"id":1776955,"web_url":"http://patchwork.ozlabs.org/comment/1776955/","msgid":"<1506595483.16112.137.camel@linux.intel.com>","list_archive_url":null,"date":"2017-09-28T10:44:43","subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio\n\tbus recovery","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Wed, 2017-08-30 at 14:17 +0800, Phil Reid wrote:\n> Currently the i2c gpio recovery code uses gpio integer interface\n> instead of the gpiod. This change switch the core code to use\n> the gpiod while still retaining compatibility with the gpio integer\n> interface. This will allow individual driver to be updated and tested\n> individual to switch to using the gpiod interface.\n\n> static int i2c_get_gpios_for_recovery(struct i2c_adapter *adap)\n> @@ -158,6 +158,7 @@ static int i2c_get_gpios_for_recovery(struct\n> i2c_adapter *adap)\n> \t\tdev_warn(dev, \"Can't get SCL gpio: %d\\n\", bri-\n> >scl_gpio);\n> \t\treturn ret;\n> \t}\n> +\tbri->scl_gpiod = gpio_to_desc(bri->scl_gpio);\n> \n> \tif (bri->get_sda) {\n> \t\tif (gpio_request_one(bri->sda_gpio, GPIOF_IN, \"i2c-\n> sda\")) {\n> @@ -167,6 +168,7 @@ static int i2c_get_gpios_for_recovery(struct\n> i2c_adapter *adap)\n> \t\t\tbri->get_sda = NULL;\n> \t\t}\n> \t}\n\n> +\tbri->sda_gpiod = gpio_to_desc(bri->sda_gpio);\n\nShouldn't it be inside conditional?\n\n> \treturn ret;\n> }\n> @@ -175,10 +177,13 @@ static void i2c_put_gpios_for_recovery(struct\n> i2c_adapter *adap)\n> {\n> \tstruct i2c_bus_recovery_info *bri = adap->bus_recovery_info;\n> \n> -\tif (bri->get_sda)\n> +\tif (bri->get_sda) {\n> \t\tgpio_free(bri->sda_gpio);\n> +\t\tbri->sda_gpiod = NULL;\n> +\t}\n> \n> \tgpio_free(bri->scl_gpio);\n> +\tbri->scl_gpiod = NULL;\n\nCan we go other way around, i.e. put descriptors and assign plain\nintegers to something like -ENOENT?\n\n> }\n\n\n> +\tif ((bri->scl_gpiod) &&\n\nRedundant parens.\n\n> +\t (bri->recover_bus == i2c_generic_scl_recovery)) {\n\nDitto, though here it might be slightly better to read.\n\n> +\t\tbri->get_scl = get_scl_gpio_value;\n> +\t\tbri->set_scl = set_scl_gpio_value;\n> +\t\tif (bri->sda_gpiod)\n> +\t\t\tbri->get_sda = get_sda_gpio_value;\n> +\t\treturn;\n> +\t}\n\n> \tint scl_gpio;\n> \tint sda_gpio;\n> +\tstruct gpio_desc *scl_gpiod;\n> +\tstruct gpio_desc *sda_gpiod;\n\nI think we even could get rid of plain integers completely.\nIn case some call needs it we can derive it still from the descriptor.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2rwC664zz9t38\n\tfor ;\n\tThu, 28 Sep 2017 20:46:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752838AbdI1KqT (ORCPT );\n\tThu, 28 Sep 2017 06:46:19 -0400","from mga09.intel.com ([134.134.136.24]:54990 \"EHLO mga09.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752834AbdI1KqR (ORCPT );\n\tThu, 28 Sep 2017 06:46:17 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2017 03:46:16 -0700","from smile.fi.intel.com (HELO smile) ([10.237.72.86])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2017 03:46:14 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,449,1500966000\"; d=\"scan'208\";a=\"904711446\"","Message-ID":"<1506595483.16112.137.camel@linux.intel.com>","Subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio\n\tbus recovery","From":"Andy Shevchenko ","To":"Phil Reid , jarkko.nikula@linux.intel.com,\n\tmika.westerberg@linux.intel.com, wsa@the-dreams.de,\n\ttim@krieglstein.org, linux-i2c@vger.kernel.org","Date":"Thu, 28 Sep 2017 13:44:43 +0300","In-Reply-To":"<1504073857-122449-2-git-send-email-preid@electromag.com.au>","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1504073857-122449-2-git-send-email-preid@electromag.com.au>","Organization":"Intel Finland Oy","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.26.0-1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1776958,"web_url":"http://patchwork.ozlabs.org/comment/1776958/","msgid":"<2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com>","list_archive_url":null,"date":"2017-09-28T10:54:55","subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus\n\trecovery","submitter":{"id":43309,"url":"http://patchwork.ozlabs.org/api/people/43309/","name":"Jarkko Nikula","email":"jarkko.nikula@linux.intel.com"},"content":"On 09/28/2017 01:44 PM, Andy Shevchenko wrote:\n>> interface. This will allow individual driver to be updated and tested\n>> individual to switch to using the gpiod interface.\n> \n>> \tint scl_gpio;\n>> \tint sda_gpio;\n>> +\tstruct gpio_desc *scl_gpiod;\n>> +\tstruct gpio_desc *sda_gpiod;\n> \n> I think we even could get rid of plain integers completely.\n> In case some call needs it we can derive it still from the descriptor.\n> \nI guess it's still worth to split that into multiple patches and those \ndriver conversion and integer removal can be follow up patches somewhere \nin the future?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2s5w1F0Tz9t5l\n\tfor ;\n\tThu, 28 Sep 2017 20:55:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752580AbdI1Ky6 (ORCPT );\n\tThu, 28 Sep 2017 06:54:58 -0400","from mga01.intel.com ([192.55.52.88]:18492 \"EHLO mga01.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751778AbdI1Ky6 (ORCPT );\n\tThu, 28 Sep 2017 06:54:58 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2017 03:54:58 -0700","from mylly.fi.intel.com (HELO [10.237.72.59]) ([10.237.72.59])\n\tby fmsmga002.fm.intel.com with ESMTP; 28 Sep 2017 03:54:56 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,449,1500966000\"; d=\"scan'208\";a=\"1224737008\"","Subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus\n\trecovery","To":"Andy Shevchenko ,\n\tPhil Reid ,\n\tmika.westerberg@linux.intel.com, wsa@the-dreams.de,\n\ttim@krieglstein.org, linux-i2c@vger.kernel.org","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1504073857-122449-2-git-send-email-preid@electromag.com.au>\n\t<1506595483.16112.137.camel@linux.intel.com>","From":"Jarkko Nikula ","Message-ID":"<2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com>","Date":"Thu, 28 Sep 2017 13:54:55 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506595483.16112.137.camel@linux.intel.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1776962,"web_url":"http://patchwork.ozlabs.org/comment/1776962/","msgid":"<1506596304.16112.155.camel@linux.intel.com>","list_archive_url":null,"date":"2017-09-28T10:58:24","subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio\n\tbus recovery","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Thu, 2017-09-28 at 13:54 +0300, Jarkko Nikula wrote:\n> On 09/28/2017 01:44 PM, Andy Shevchenko wrote:\n> > > interface. This will allow individual driver to be updated and\n> > > tested\n> > > individual to switch to using the gpiod interface.\n> > > \tint scl_gpio;\n> > > \tint sda_gpio;\n> > > +\tstruct gpio_desc *scl_gpiod;\n> > > +\tstruct gpio_desc *sda_gpiod;\n> > \n> > I think we even could get rid of plain integers completely.\n> > In case some call needs it we can derive it still from the\n> > descriptor.\n> > \n> \n> I guess it's still worth to split that into multiple patches and\n> those \n> driver conversion and integer removal can be follow up patches\n> somewhere \n> in the future?\n\nI didn't check and my memory is clean about users.\nSo, if there are users of those integers outside of I2C core, definitely\nwe need more patches / iterations.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2sJV2C6zz9tXj\n\tfor ;\n\tThu, 28 Sep 2017 21:04:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752755AbdI1LEJ (ORCPT );\n\tThu, 28 Sep 2017 07:04:09 -0400","from mga07.intel.com ([134.134.136.100]:20293 \"EHLO\n\tmga07.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752543AbdI1LEJ (ORCPT );\n\tThu, 28 Sep 2017 07:04:09 -0400","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga105.jf.intel.com with ESMTP; 28 Sep 2017 04:04:08 -0700","from smile.fi.intel.com (HELO smile) ([10.237.72.86])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Sep 2017 04:04:06 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,449,1500966000\"; d=\"scan'208\";a=\"140449794\"","Message-ID":"<1506596304.16112.155.camel@linux.intel.com>","Subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio\n\tbus recovery","From":"Andy Shevchenko ","To":"Jarkko Nikula ,\n\tPhil Reid ,\n\tmika.westerberg@linux.intel.com, wsa@the-dreams.de,\n\ttim@krieglstein.org, linux-i2c@vger.kernel.org","Date":"Thu, 28 Sep 2017 13:58:24 +0300","In-Reply-To":"<2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com>","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1504073857-122449-2-git-send-email-preid@electromag.com.au>\n\t<1506595483.16112.137.camel@linux.intel.com>\n\t<2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com>","Organization":"Intel Finland Oy","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.26.0-1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1777375,"web_url":"http://patchwork.ozlabs.org/comment/1777375/","msgid":"<249f3801-d7b0-dd27-a838-6e7ca6967447@electromag.com.au>","list_archive_url":null,"date":"2017-09-29T06:59:00","subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus\n\trecovery","submitter":{"id":66145,"url":"http://patchwork.ozlabs.org/api/people/66145/","name":"Phil Reid","email":"preid@electromag.com.au"},"content":"On 28/09/2017 18:58, Andy Shevchenko wrote:\n> On Thu, 2017-09-28 at 13:54 +0300, Jarkko Nikula wrote:\n>> On 09/28/2017 01:44 PM, Andy Shevchenko wrote:\n>>>> interface. This will allow individual driver to be updated and\n>>>> tested\n>>>> individual to switch to using the gpiod interface.\n>>>> \tint scl_gpio;\n>>>> \tint sda_gpio;\n>>>> +\tstruct gpio_desc *scl_gpiod;\n>>>> +\tstruct gpio_desc *sda_gpiod;\n>>>\n>>> I think we even could get rid of plain integers completely.\n>>> In case some call needs it we can derive it still from the\n>>> descriptor.\n>>>\n>>\n>> I guess it's still worth to split that into multiple patches and\n>> those\n>> driver conversion and integer removal can be follow up patches\n>> somewhere\n>> in the future?\n> \n> I didn't check and my memory is clean about users.\n> So, if there are users of those integers outside of I2C core, definitely\n> we need more patches / iterations.\n> \nThere's a couple of drivers using those.\nIf my approach looks good then I can try and update those as well.\n\nQuestion is does it all need to be in the one patch series?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3MqH60Dsz9t2c\n\tfor ;\n\tFri, 29 Sep 2017 16:59:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751037AbdI2G7G (ORCPT );\n\tFri, 29 Sep 2017 02:59:06 -0400","from anchovy2.45ru.net.au ([203.30.46.146]:53079 \"EHLO\n\tanchovy.45ru.net.au\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1750929AbdI2G7F (ORCPT\n\t); Fri, 29 Sep 2017 02:59:05 -0400","(qmail 15125 invoked by uid 5089); 29 Sep 2017 06:59:02 -0000","by simscan 1.2.0 ppid: 15028, pid: 15029, t: 0.0388s\n\tscanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950","from unknown (HELO ?192.168.0.122?)\n\t(preid@electromag.com.au@203.59.230.133)\n\tby anchovy3.45ru.net.au with ESMTPA; 29 Sep 2017 06:59:02 -0000"],"Subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus\n\trecovery","To":"Andy Shevchenko ,\n\tJarkko Nikula ,\n\tmika.westerberg@linux.intel.com, wsa@the-dreams.de,\n\ttim@krieglstein.org, linux-i2c@vger.kernel.org","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1504073857-122449-2-git-send-email-preid@electromag.com.au>\n\t<1506595483.16112.137.camel@linux.intel.com>\n\t<2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com>\n\t<1506596304.16112.155.camel@linux.intel.com>","From":"Phil Reid ","Message-ID":"<249f3801-d7b0-dd27-a838-6e7ca6967447@electromag.com.au>","Date":"Fri, 29 Sep 2017 14:59:00 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506596304.16112.155.camel@linux.intel.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-AU","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1777505,"web_url":"http://patchwork.ozlabs.org/comment/1777505/","msgid":"<1506685693.16112.172.camel@linux.intel.com>","list_archive_url":null,"date":"2017-09-29T11:48:13","subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio\n\tbus recovery","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Fri, 2017-09-29 at 14:59 +0800, Phil Reid wrote:\n> On 28/09/2017 18:58, Andy Shevchenko wrote:\n> > On Thu, 2017-09-28 at 13:54 +0300, Jarkko Nikula wrote:\n\n> > I didn't check and my memory is clean about users.\n> > So, if there are users of those integers outside of I2C core,\n> > definitely\n> > we need more patches / iterations.\n> > \n> \n> There's a couple of drivers using those.\n> If my approach looks good then I can try and update those as well.\n> \n> Question is does it all need to be in the one patch series?\n\nDepends on your choice.\nEither will work (at least for me).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3VDy0ZJvz9t2h\n\tfor ;\n\tFri, 29 Sep 2017 21:48:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751643AbdI2LsQ (ORCPT );\n\tFri, 29 Sep 2017 07:48:16 -0400","from mga11.intel.com ([192.55.52.93]:11720 \"EHLO mga11.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751091AbdI2LsQ (ORCPT );\n\tFri, 29 Sep 2017 07:48:16 -0400","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Sep 2017 04:48:15 -0700","from smile.fi.intel.com (HELO smile) ([10.237.72.86])\n\tby fmsmga001.fm.intel.com with ESMTP; 29 Sep 2017 04:48:13 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,452,1500966000\"; d=\"scan'208\";a=\"1200398208\"","Message-ID":"<1506685693.16112.172.camel@linux.intel.com>","Subject":"Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio\n\tbus recovery","From":"Andy Shevchenko ","To":"Phil Reid ,\n\tJarkko Nikula ,\n\tmika.westerberg@linux.intel.com, wsa@the-dreams.de,\n\ttim@krieglstein.org, linux-i2c@vger.kernel.org","Date":"Fri, 29 Sep 2017 14:48:13 +0300","In-Reply-To":"<249f3801-d7b0-dd27-a838-6e7ca6967447@electromag.com.au>","References":"<1504073857-122449-1-git-send-email-preid@electromag.com.au>\n\t<1504073857-122449-2-git-send-email-preid@electromag.com.au>\n\t<1506595483.16112.137.camel@linux.intel.com>\n\t<2ecc500b-42ec-8f30-b8cf-fd646eaaa198@linux.intel.com>\n\t<1506596304.16112.155.camel@linux.intel.com>\n\t<249f3801-d7b0-dd27-a838-6e7ca6967447@electromag.com.au>","Organization":"Intel Finland Oy","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.26.0-1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]