[{"id":1760154,"web_url":"http://patchwork.ozlabs.org/comment/1760154/","msgid":"","list_archive_url":null,"date":"2017-08-30T13:31:23","subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","submitter":{"id":6065,"url":"http://patchwork.ozlabs.org/api/people/6065/","name":"J. William Campbell","email":"jwilliamcampbell@comcast.net"},"content":"On 8/29/2017 10:15 PM, tien.fong.chee@intel.com wrote:\n> From: Tien Fong Chee \n>\n> Report Coverity log:\n> The code uses a variable that has not\n> been initialized, leading to unpredictable\n> or unintended results.\n>\n> Reported-by: Coverity (CID: 60519)\n> Signed-off-by: Tien Fong Chee \n> ---\n> lib/libfdt/fdt_wip.c | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/lib/libfdt/fdt_wip.c b/lib/libfdt/fdt_wip.c\n> index 45fb964..01adad0 100644\n> --- a/lib/libfdt/fdt_wip.c\n> +++ b/lib/libfdt/fdt_wip.c\n> @@ -115,7 +115,7 @@ int fdt_find_regions(const void *fdt, char * const inc[], int inc_count,\n> \t\t struct fdt_region region[], int max_regions,\n> \t\t char *path, int path_len, int add_string_tab)\n> {\n> -\tint stack[FDT_MAX_DEPTH];\n> +\tint stack[FDT_MAX_DEPTH] = { 0 };\nIt seems to me that one of three things must be true. 1) Coverity can't \ncorrectly analyze the code and stack[] is not used in an un-initialized \nmanner, 2) stack is used in an un-initialized manner but the result is \nnot used in that case and is a \"don't care\" or 3) there is a bug in the \ncode. It seems that just initializing the variable to 0 is a \"Bad \nIdea(tm)\". If it is case 1 or 2, there should be a Coverity code \nannotation comment added to that effect, and if it is case 3, it should \nbe fixed. Initializing this variable makes the binary larger to no \npurpose unless there is a bug already.\n\nBest Regards,\nJ. William Campbell\n> \tchar *end;\n> \tint nextoffset = 0;\n> \tuint32_t tag;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=comcast.net header.i=@comcast.net\n\theader.b=\"BwMVLPit\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj5xt52Gfz9sN7\n\tfor ;\n\tWed, 30 Aug 2017 23:31:30 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4E530C228F4; Wed, 30 Aug 2017 13:31:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A17E0C22865;\n\tWed, 30 Aug 2017 13:31:26 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid DCEF7C22894; Wed, 30 Aug 2017 13:31:24 +0000 (UTC)","from resqmta-po-01v.sys.comcast.net (resqmta-po-01v.sys.comcast.net\n\t[96.114.154.160])\n\tby lists.denx.de (Postfix) with ESMTPS id 403CCC22865\n\tfor ; Wed, 30 Aug 2017 13:31:24 +0000 (UTC)","from resomta-po-13v.sys.comcast.net ([96.114.154.237])\n\tby resqmta-po-01v.sys.comcast.net with ESMTP\n\tid n35HddmNWF100n35Wd67iE; Wed, 30 Aug 2017 13:31:22 +0000","from [192.168.1.100] ([76.21.4.126])\n\tby resomta-po-13v.sys.comcast.net with SMTP\n\tid n35UdhGxfJ0Rsn35Vdc19K; Wed, 30 Aug 2017 13:31:22 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\n\ts=q20161114; t=1504099882;\n\tbh=Wx+1P2LlcSs/tiCgcxH88VRVJxcTN+3H5jgsbfiVlr8=;\n\th=Received:Received:Reply-To:Subject:To:From:Message-ID:Date:\n\tMIME-Version:Content-Type;\n\tb=BwMVLPitdTSAY3mKnWW6rGvb9fVXnWQgXITUkCz7Jb6L3zpa0anfCdRu6ooKwRTpP\n\tjAleSY9Qw2NbV/gqVS17ost8JdG3GqF7dYq3VXPdvhvP2JH/qll9c49UXFSgMYxd77\n\tuP5m1pjLwJcf4u2z+uDcE3b4LFSsv/M3DqJKV1/UBDEyhfGXlGJQkyfL8rTpNzzoHx\n\tqlIcrE3O9HoD3lQfzE7bLjrMI3fGaNT3PQewSqOMPDuGIj87jwrPftNRXhwFFyp3oU\n\tQF0qx+AgZTPcN6gs1zo6WIHI3UWxAmZFAI9twHWsBVr2JiMqGbDG8P38HoFKzSSZ1A\n\t4g/dwllmeQiMQ==","To":"u-boot@lists.denx.de, tien.fong.chee@intel.com","References":"<1504070142-7951-1-git-send-email-tien.fong.chee@intel.com>","From":"\"J. William Campbell\" ","Organization":"Creative Software Systems","Message-ID":"","Date":"Wed, 30 Aug 2017 06:31:23 -0700","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504070142-7951-1-git-send-email-tien.fong.chee@intel.com>","Content-Language":"en-US","X-CMAE-Envelope":"MS4wfEHQOlp6AKZH4w9NebDTMbA7uKFOJKCEI91AwJ2OgYIhniq0qqpIaXK0kFngWqYaB/QVAPzkHbUdwkOoZwQcrs0TSMLb/Sa+yX58PVNiyxFcBcvjovjo\n\tGw7POs1bXqH8/Mk85h/PDyz1o4f7P+xlrWAcLW2b4YTTlKEkbjClONzRCY1SRID7oi2Z+hJBW/LH3zIbKjF53TwrMt8zzxJFjndjfTTQUnyE+04NleS3QFNP","Subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"jwilliamcampbell@comcast.net","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762947,"web_url":"http://patchwork.ozlabs.org/comment/1762947/","msgid":"<1504582870.7727.84.camel@intel.com>","list_archive_url":null,"date":"2017-09-05T03:41:11","subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","submitter":{"id":70549,"url":"http://patchwork.ozlabs.org/api/people/70549/","name":"Chee, Tien Fong","email":"tien.fong.chee@intel.com"},"content":"On Rab, 2017-08-30 at 06:31 -0700, J. William Campbell wrote:\r\n> On 8/29/2017 10:15 PM, tien.fong.chee@intel.com wrote:\r\n> > \r\n> > From: Tien Fong Chee \r\n> > \r\n> > Report Coverity log:\r\n> > The code uses a variable that has not\r\n> > been initialized, leading to unpredictable\r\n> > or unintended results.\r\n> > \r\n> > Reported-by: Coverity (CID: 60519)\r\n> > Signed-off-by: Tien Fong Chee \r\n> > ---\r\n> >   lib/libfdt/fdt_wip.c |    2 +-\r\n> >   1 files changed, 1 insertions(+), 1 deletions(-)\r\n> > \r\n> > diff --git a/lib/libfdt/fdt_wip.c b/lib/libfdt/fdt_wip.c\r\n> > index 45fb964..01adad0 100644\r\n> > --- a/lib/libfdt/fdt_wip.c\r\n> > +++ b/lib/libfdt/fdt_wip.c\r\n> > @@ -115,7 +115,7 @@ int fdt_find_regions(const void *fdt, char *\r\n> > const inc[], int inc_count,\r\n> >   \t\t     struct fdt_region region[], int max_regions,\r\n> >   \t\t     char *path, int path_len, int\r\n> > add_string_tab)\r\n> >   {\r\n> > -\tint stack[FDT_MAX_DEPTH];\r\n> > +\tint stack[FDT_MAX_DEPTH] = { 0 };\r\n> It seems to me that one of three things must be true. 1) Coverity\r\n> can't \r\n> correctly analyze the code and stack[] is not used in an un-\r\n> initialized \r\n> manner, 2) stack is used in an un-initialized manner but the result\r\n> is \r\n> not used in that case and is a \"don't care\" or 3) there is a bug in\r\n> the \r\n> code. It seems that just initializing the variable to 0 is a \"Bad \r\n> Idea(tm)\". If it is case 1 or 2, there should be a Coverity code \r\n> annotation comment added to that effect, and if it is case 3, it\r\n> should \r\n> be fixed. Initializing this variable makes the binary larger to no \r\n> purpose unless there is a bug already.\r\n> \r\n> Best Regards,\r\n> J. William Campbell\r\nYeah, i agree with you, state machine design should ensure stack[] is\r\nnot used in a uninitialized manner. Hence, i need input from whom\r\nfamiliar with this function, whether this warning fall in anyone of\r\nthese conditions. If we just direct init the stack[], and this solution\r\nwill make extra 128 bytes in binary, but having variable with default\r\nvalue is also good pratice from software quality perspective.\r\n> > \r\n> >   \tchar *end;\r\n> >   \tint nextoffset = 0;\r\n> >   \tuint32_t tag;\r\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmXZL1MBrz9sNr\n\tfor ;\n\tTue, 5 Sep 2017 13:41:28 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A1A3AC21F09; Tue, 5 Sep 2017 03:41:21 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 433FDC21C3F;\n\tTue, 5 Sep 2017 03:41:19 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 4252EC21C3F; Tue, 5 Sep 2017 03:41:17 +0000 (UTC)","from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby lists.denx.de (Postfix) with ESMTPS id 4E52AC21C2B\n\tfor ; Tue, 5 Sep 2017 03:41:16 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Sep 2017 20:41:14 -0700","from kmsmsx152.gar.corp.intel.com ([172.21.73.87])\n\tby fmsmga006.fm.intel.com with ESMTP; 04 Sep 2017 20:41:12 -0700","from pgsmsx109.gar.corp.intel.com ([169.254.14.159]) by\n\tKMSMSX152.gar.corp.intel.com ([169.254.11.206]) with mapi id\n\t14.03.0319.002; Tue, 5 Sep 2017 11:41:12 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,477,1498546800\"; d=\"scan'208\";a=\"148117578\"","From":"\"Chee, Tien Fong\" ","To":"\"jwilliamcampbell@comcast.net\" ,\n\t\"u-boot@lists.denx.de\" ","Thread-Topic":"[U-Boot] [PATCH] libfdt: Initialize the stack variable","Thread-Index":"AQHTIU8g8R5p/zKGVkyoqquZuzQgEqKcX9CAgAjJFQA=","Date":"Tue, 5 Sep 2017 03:41:11 +0000","Message-ID":"<1504582870.7727.84.camel@intel.com>","References":"<1504070142-7951-1-git-send-email-tien.fong.chee@intel.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.226.242.98]","Content-ID":"<51E62666FA43ED4F8612C139012703C8@intel.com>","MIME-Version":"1.0","Subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762949,"web_url":"http://patchwork.ozlabs.org/comment/1762949/","msgid":"<3a71c9ed-f7a8-d58e-ad77-0267809f72b5@comcast.net>","list_archive_url":null,"date":"2017-09-05T03:58:08","subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","submitter":{"id":6065,"url":"http://patchwork.ozlabs.org/api/people/6065/","name":"J. William Campbell","email":"jwilliamcampbell@comcast.net"},"content":"On 9/4/2017 8:41 PM, Chee, Tien Fong wrote:\n> On Rab, 2017-08-30 at 06:31 -0700, J. William Campbell wrote:\n>> On 8/29/2017 10:15 PM, tien.fong.chee@intel.com wrote:\n>>> From: Tien Fong Chee \n>>>\n>>> Report Coverity log:\n>>> The code uses a variable that has not\n>>> been initialized, leading to unpredictable\n>>> or unintended results.\n>>>\n>>> Reported-by: Coverity (CID: 60519)\n>>> Signed-off-by: Tien Fong Chee \n>>> ---\n>>>   lib/libfdt/fdt_wip.c |    2 +-\n>>>   1 files changed, 1 insertions(+), 1 deletions(-)\n>>>\n>>> diff --git a/lib/libfdt/fdt_wip.c b/lib/libfdt/fdt_wip.c\n>>> index 45fb964..01adad0 100644\n>>> --- a/lib/libfdt/fdt_wip.c\n>>> +++ b/lib/libfdt/fdt_wip.c\n>>> @@ -115,7 +115,7 @@ int fdt_find_regions(const void *fdt, char *\n>>> const inc[], int inc_count,\n>>>   \t\t     struct fdt_region region[], int max_regions,\n>>>   \t\t     char *path, int path_len, int\n>>> add_string_tab)\n>>>   {\n>>> -\tint stack[FDT_MAX_DEPTH];\n>>> +\tint stack[FDT_MAX_DEPTH] = { 0 };\n>> It seems to me that one of three things must be true. 1) Coverity\n>> can't\n>> correctly analyze the code and stack[] is not used in an un-\n>> initialized\n>> manner, 2) stack is used in an un-initialized manner but the result\n>> is\n>> not used in that case and is a \"don't care\" or 3) there is a bug in\n>> the\n>> code. It seems that just initializing the variable to 0 is a \"Bad\n>> Idea(tm)\". If it is case 1 or 2, there should be a Coverity code\n>> annotation comment added to that effect, and if it is case 3, it\n>> should\n>> be fixed. Initializing this variable makes the binary larger to no\n>> purpose unless there is a bug already.\n>>\n>> Best Regards,\n>> J. William Campbell\n> Yeah, i agree with you, state machine design should ensure stack[] is\n> not used in a uninitialized manner. Hence, i need input from whom\n> familiar with this function, whether this warning fall in anyone of\n> these conditions. If we just direct init the stack[], and this solution\n> will make extra 128 bytes in binary, but having variable with default\n> value is also good pratice from software quality perspective.\nYes, if the default value has a rationale. On the surface, there is no \nway to know that 0 is a \"good\" initial value. There may be a reason that \nit is, but if we don't know for sure, it is just a \"random\" number. I \nhope whoever wrote this will speak up and say why the variable is never \nused before it is initialized. Thank you for being so diligent.\n\nBest Regards,\nBill Campbell\n\n\n>>>   \tchar *end;\n>>>   \tint nextoffset = 0;\n>>>   \tuint32_t tag;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=comcast.net header.i=@comcast.net\n\theader.b=\"K4dl21zv\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmXxr4Bp5z9sNr\n\tfor ;\n\tTue, 5 Sep 2017 13:58:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4E51FC21E05; Tue, 5 Sep 2017 03:58:17 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 16162C21C41;\n\tTue, 5 Sep 2017 03:58:15 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5A231C21C41; Tue, 5 Sep 2017 03:58:13 +0000 (UTC)","from resqmta-po-06v.sys.comcast.net (resqmta-po-06v.sys.comcast.net\n\t[96.114.154.165])\n\tby lists.denx.de (Postfix) with ESMTPS id DF38FC21C2B\n\tfor ; Tue, 5 Sep 2017 03:58:10 +0000 (UTC)","from resomta-po-06v.sys.comcast.net ([96.114.154.230])\n\tby resqmta-po-06v.sys.comcast.net with ESMTP\n\tid p4zwd6RZ8qbkSp505dqDK5; Tue, 05 Sep 2017 03:58:09 +0000","from [192.168.1.100] ([76.21.4.126])\n\tby resomta-po-06v.sys.comcast.net with SMTP\n\tid p503dDJvsOVcep504dYbVp; Tue, 05 Sep 2017 03:58:08 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\n\ts=q20161114; t=1504583889;\n\tbh=lBnaeTiUUbf9KscJGSM6DCjSfjvMBpD5yCZBCy2qzRc=;\n\th=Received:Received:Reply-To:Subject:To:From:Message-ID:Date:\n\tMIME-Version:Content-Type;\n\tb=K4dl21zvc4qV/m8qknKgYnjRCENq0+AsW+fCERSwGE+VqFnAKY9l+pFZ/FqqVOadB\n\tOtv/ObICiuqG0BP5l/+wKAJZK6Kihwxq+HigpCpjNOJaI6qy5FBz5eRt0Z9sAXMTq/\n\tmdTOx7p64hspt0b2ULbyInbqt6CxQGhXumBctOlm/ehKGhpiWH+7Gjm8c+WX+ijar5\n\tci7xPUs+9ITzB2p8ecVZybYoY5LebS1kY3nT4vyTJVwjsXAKhQaJfzOV4vg+HqbRG8\n\tMDxAW2Fo7R/m4AxNQECRZxuYu4uU0s0bXstnAGqbzkG41u6ij1RYXxiV2fiYwaUOBz\n\t1TiGu5Mtm0dtA==","To":"\"Chee, Tien Fong\" ,\n\t\"u-boot@lists.denx.de\" ","References":"<1504070142-7951-1-git-send-email-tien.fong.chee@intel.com>\n\t\n\t<1504582870.7727.84.camel@intel.com>","From":"\"J. William Campbell\" ","Organization":"Creative Software Systems","Message-ID":"<3a71c9ed-f7a8-d58e-ad77-0267809f72b5@comcast.net>","Date":"Mon, 4 Sep 2017 20:58:08 -0700","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504582870.7727.84.camel@intel.com>","Content-Language":"en-US","X-CMAE-Envelope":"MS4wfBmOpPoemf0a1kFRdduudH2rlDiuYKxpth8cuqb/BGcsgGQ1ZhNl+qLIiPkLhFdj6bwzoeWDWkUWbuAUUsGDUNkYMC/4xuo8HliyOa7rv54olJHYtAVe\n\toqLfK6G35IH0uOhEp6SonWeS6XYJBW0ZLmhg09D5mjlYb9JNSeLlov2jbtXG92DW7+bxr0Ds7nUc6S3hyDVFTOturAi7ZIUrgZVM2PR59JgbxuTHZ/MC7DlS","Subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"jwilliamcampbell@comcast.net","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769393,"web_url":"http://patchwork.ozlabs.org/comment/1769393/","msgid":"","list_archive_url":null,"date":"2017-09-15T19:25:31","subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","submitter":{"id":12501,"url":"http://patchwork.ozlabs.org/api/people/12501/","name":"Simon Glass","email":"sjg@google.com"},"content":"On 9/4/2017 8:41 PM, Chee, Tien Fong wrote:\n> On Rab, 2017-08-30 at 06:31 -0700, J. William Campbell wrote:\n>> On 8/29/2017 10:15 PM, tien.fong.chee@intel.com wrote:\n>>> From: Tien Fong Chee \n>>>\n>>> Report Coverity log:\n>>> The code uses a variable that has not\n>>> been initialized, leading to unpredictable\n>>> or unintended results.\n>>>\n>>> Reported-by: Coverity (CID: 60519)\n>>> Signed-off-by: Tien Fong Chee \n>>> ---\n>>>   lib/libfdt/fdt_wip.c |    2 +-\n>>>   1 files changed, 1 insertions(+), 1 deletions(-)\n>>>\nApplied to u-boot-fdt thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Yk0ty1qm\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv5J013Bqz9s7g\n\tfor ;\n\tSat, 16 Sep 2017 05:36:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 54329C221FC; Fri, 15 Sep 2017 19:31:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C3BA1C21FBC;\n\tFri, 15 Sep 2017 19:31:08 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid F03FFC21F48; Fri, 15 Sep 2017 19:27:13 +0000 (UTC)","from mail-io0-f174.google.com (mail-io0-f174.google.com\n\t[209.85.223.174])\n\tby lists.denx.de (Postfix) with ESMTPS id B3459C21FD4\n\tfor ; Fri, 15 Sep 2017 19:25:34 +0000 (UTC)","by mail-io0-f174.google.com with SMTP id k101so10925420iod.0\n\tfor ; Fri, 15 Sep 2017 12:25:34 -0700 (PDT)","from 480794996271 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 15 Sep 2017 12:25:31 -0700"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2, T_DKIM_INVALID,\n\tUNPARSEABLE_RELAY autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:from:in-reply-to:references:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=yH3tKt1kSdzx8cQwau94N7zsvjmLKsZd3QCeUKSCIbc=;\n\tb=Yk0ty1qmEs3IszQJcfNbxLl2J4Leh8nDEI5wC3oMS1GNF1ihTr+WKelGQXPorDqtsE\n\taNXNLaGealGOLjQ/E5XT8TYZM8JOyAkGZlOJvOHEFEA7kB2fjTYg3m3XTr9lSqIJApsl\n\t7Fejlzp8Xc1HMsCK8GS5S0CkhDcMSr7mWEQk9uBZf8QOkFhYhf8HVnDAV7NIJ22y3Jfy\n\tU9MTTJJKYLvNkKlaOpvI937CvmiU5e1UiExV87xf25oi+4T9MJTWR8MxzyzTHhSJYblB\n\txEDsBEo6Apehbnk8HbS/MStkMrEuiJu6Q4BmzHUhsZfy9BnMH6knynQlhuqgezAEjUXz\n\t17Tg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:from:in-reply-to:references\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=yH3tKt1kSdzx8cQwau94N7zsvjmLKsZd3QCeUKSCIbc=;\n\tb=DiITWFPhi/QJzN8sD8xDkikbuRXemrPcIq3H9Z9jI+wZZNGRv/ktBUQ9NOpAdmJPN+\n\tC2ITaBdU53YMwsgOidHIxGcEQKo1qpJnu30IPVpXw6VcVHX5vv2+VRKw1fK4ExuYwWSr\n\t+tFG1UXTfX0diKqpyAnK9a+uRlSTDgkZhkdIuF8v3ecaDoUbhtYanjRlEjPrpFMphBl+\n\t5/uiuHs/CBtK3X2n6tjB0H7VkdvQPGycFvO+HAh62REILDOGHujtVaQQKISsTy0b6Qsf\n\tcqmVDY/MFHvvvuuXKpCJ0P3FzuOad0DrK+xDHeMPIs6pmfsr++znnj+5rELkiiqQBi+a\n\tc20A==","X-Gm-Message-State":"AHPjjUj+nZVswUJkiNGPStIP0RjRvTXkAufyK/zv1PDNoY9dknnGWQA4\n\tpE7OMiyux/cewpuVuJNzRjZ/DerxcUVhwgVgsB5qMXTl","X-Google-Smtp-Source":"AOwi7QB2dwrArBW//VkT/EOSIj/0eM6u0wHgPkP68hZgTZHH6A9atax7j+DuCCDjXVE+2epyocN8kmHA7S17pdKpmdk=","X-Received":"by 10.202.67.139 with SMTP id\n\tq133mr10669945oia.257.1505503533273; \n\tFri, 15 Sep 2017 12:25:33 -0700 (PDT)","MIME-Version":"1.0","From":"sjg@google.com","In-Reply-To":"<3a71c9ed-f7a8-d58e-ad77-0267809f72b5@comcast.net>","References":"<3a71c9ed-f7a8-d58e-ad77-0267809f72b5@comcast.net>\n\t<1504070142-7951-1-git-send-email-tien.fong.chee@intel.com>\n\t\n\t<1504582870.7727.84.camel@intel.com>","Date":"Fri, 15 Sep 2017 12:25:31 -0700","X-Google-Sender-Auth":"Z66i0GJg9TKpjWzIkXmolK9UA14","Message-ID":"","To":"jwilliamcampbell@comcast.net","Cc":"\"u-boot@lists.denx.de\" , \"Chee,\n\tTien Fong\" ","Subject":"Re: [U-Boot] [PATCH] libfdt: Initialize the stack variable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]