[{"id":1760156,"web_url":"http://patchwork.ozlabs.org/comment/1760156/","msgid":"<063D6719AE5E284EB5DD2968C1650D6DD0069953@AcuExch.aculab.com>","date":"2017-08-30T13:32:07","subject":"RE: [PATCH 1/2] powerpc/xmon: hdec is now 64bits","submitter":{"id":6689,"url":"http://patchwork.ozlabs.org/api/people/6689/","name":"David Laight","email":"David.Laight@ACULAB.COM"},"content":"From: Balbir Singh\n> Sent: 30 August 2017 01:28\n> ISA 300 defines hypervisor decrementer to be 64 bits in length.\n> This patch extends the print format for all archs to be 64 bits\n> \n> Signed-off-by: Balbir Singh \n> ---\n> arch/powerpc/xmon/xmon.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c\n> index 9e68f1d..1b26d53 100644\n> --- a/arch/powerpc/xmon/xmon.c\n> +++ b/arch/powerpc/xmon/xmon.c\n> @@ -1749,7 +1749,7 @@ static void dump_206_sprs(void)\n> \n> \tprintf(\"sdr1 = %.16lx hdar = %.16lx hdsisr = %.8x\\n\",\n> \t\tmfspr(SPRN_SDR1), mfspr(SPRN_HDAR), mfspr(SPRN_HDSISR));\n> -\tprintf(\"hsrr0 = %.16lx hsrr1 = %.16lx hdec = %.8x\\n\",\n> +\tprintf(\"hsrr0 = %.16lx hsrr1 = %.16lx hdec = %.16lx\\n\",\n> \t\tmfspr(SPRN_HSRR0), mfspr(SPRN_HSRR1), mfspr(SPRN_HDEC));\n> \tprintf(\"lpcr = %.16lx pcr = %.16lx lpidr = %.8x\\n\",\n> \t\tmfspr(SPRN_LPCR), mfspr(SPRN_PCR), mfspr(SPRN_LPID));\n\nOn the face of it the patch doesn't do what the commit message says.\nNot only that it is really silly to print a 32bit value with 8 extra\nleading zero digits.\n\nSomething more subtle was also wrong:\nThere were 3 mfspr() calls, 2 printed with %lx and one with %x.\nThat ought to generate a warning from gcc.\n\n\tDavid","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj60C4R2tz9sN7\n\tfor ;\n\tWed, 30 Aug 2017 23:33:31 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xj60C3L5pzDqYc\n\tfor ;\n\tWed, 30 Aug 2017 23:33:31 +1000 (AEST)","from smtp-out4.electric.net (smtp-out4.electric.net\n\t[192.162.216.186])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xj5yn2QjTzDqMY\n\tfor ;\n\tWed, 30 Aug 2017 23:32:17 +1000 (AEST)","from 1dn36J-0007OX-U4 by out4d.electric.net with emc1-ok (Exim\n\t4.87) (envelope-from )\n\tid 1dn36K-0007TX-Ua; Wed, 30 Aug 2017 06:32:12 -0700","by emcmailer; Wed, 30 Aug 2017 06:32:12 -0700","from [156.67.243.126] (helo=AcuExch.aculab.com)\n\tby out4d.electric.net with esmtps (TLSv1:AES128-SHA:128) (Exim 4.87)\n\t(envelope-from )\n\tid 1dn36J-0007OX-U4; Wed, 30 Aug 2017 06:32:11 -0700","from ACUEXCH.Aculab.com ([::1]) by AcuExch.aculab.com ([::1]) with\n\tmapi id 14.03.0123.003; Wed, 30 Aug 2017 14:32:08 +0100"],"From":"David Laight ","To":"'Balbir Singh' , \"mpe@ellerman.id.au\"\n\t","Subject":"RE: [PATCH 1/2] powerpc/xmon: hdec is now 64bits","Thread-Topic":"[PATCH 1/2] powerpc/xmon: hdec is now 64bits","Thread-Index":"AQHTIScHJ3Y+0/uDskefEmaaVt84BqKc5QAA","Date":"Wed, 30 Aug 2017 13:32:07 +0000","Message-ID":"<063D6719AE5E284EB5DD2968C1650D6DD0069953@AcuExch.aculab.com>","References":"<20170830002745.29526-1-bsingharora@gmail.com>","In-Reply-To":"<20170830002745.29526-1-bsingharora@gmail.com>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.202.99.200]","Content-Type":"text/plain; charset=\"Windows-1252\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Outbound-IP":"156.67.243.126","X-Env-From":"David.Laight@ACULAB.COM","X-Proto":"esmtps","X-Revdns":"","X-HELO":"AcuExch.aculab.com","X-TLS":"TLSv1:AES128-SHA:128","X-Authenticated_ID":"","X-PolicySMART":"3396946, 3397078","X-Virus-Status":["Scanned by VirusSMART (c)","Scanned by VirusSMART (s)"],"X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"linuxppc-dev@lists.ozlabs.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1760914,"web_url":"http://patchwork.ozlabs.org/comment/1760914/","msgid":"<3xjgLl3sjNz9t3s@ozlabs.org>","date":"2017-08-31T11:36:31","subject":"Re: [1/2] powerpc/xmon: hdec is now 64bits","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Wed, 2017-08-30 at 00:27:44 UTC, Balbir Singh wrote:\n> ISA 300 defines hypervisor decrementer to be 64 bits in length.\n> This patch extends the print format for all archs to be 64 bits\n> \n> Signed-off-by: Balbir Singh \n\nSeries applied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/cf9159c36cca6b3d82a6eb620055b3\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjhX44QtXz9sMN\n\tfor ;\n\tThu, 31 Aug 2017 22:29:40 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjhX43bYFzDrCk\n\tfor ;\n\tThu, 31 Aug 2017 22:29:40 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjgLm22KyzDqTc\n\tfor ;\n\tThu, 31 Aug 2017 21:36:32 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3xjgLl3sjNz9t3s; Thu, 31 Aug 2017 21:36:31 +1000 (AEST)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"cf9159c36cca6b3d82a6eb620055b321af3c5b9b","In-Reply-To":"<20170830002745.29526-1-bsingharora@gmail.com>","To":"Balbir Singh ","From":"Michael Ellerman ","Subject":"Re: [1/2] powerpc/xmon: hdec is now 64bits","Message-Id":"<3xjgLl3sjNz9t3s@ozlabs.org>","Date":"Thu, 31 Aug 2017 21:36:31 +1000 (AEST)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]