[{"id":1760055,"web_url":"http://patchwork.ozlabs.org/comment/1760055/","msgid":"<20170830105930.GE27835@eguan.usersys.redhat.com>","list_archive_url":null,"date":"2017-08-30T10:59:30","subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","submitter":{"id":64769,"url":"http://patchwork.ozlabs.org/api/people/64769/","name":"Eryu Guan","email":"eguan@redhat.com"},"content":"On Tue, Aug 29, 2017 at 04:37:15PM -0600, Ross Zwisler wrote:\n> This adds a regression test for the following kernel patch:\n> \n> commit 42d4a99b09cb (\"ext4: fix fault handling when mounted with -o dax,ro\")\n> \n> The above patch fixes an issue with ext4 where executables cannot be run on\n> read-only filesystems mounted with the DAX option.\n> \n> This issue does not appear to be present in ext2 or XFS, as they both pass\n> the test. I've also confirmed outside of the test that they are both\n> indeed able to execute binaries on read-only DAX mounts.\n> \n> Thanks to Randy Dodgen for the bug report and reproduction steps.\n> \n> Signed-off-by: Ross Zwisler \n> Cc: Randy Dodgen \n> Cc: Christoph Hellwig \n> Cc: Theodore Ts'o \n> \n> ---\n> \n> Sorry if we collided, Randy, but I was 90% done with the test by the time I\n> saw your mail. :)\n> ---\n> tests/generic/452 | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++\n> tests/generic/452.out | 2 ++\n> tests/generic/group | 1 +\n> 3 files changed, 90 insertions(+)\n> create mode 100755 tests/generic/452\n> create mode 100644 tests/generic/452.out\n> \n> diff --git a/tests/generic/452 b/tests/generic/452\n> new file mode 100755\n> index 0000000..54dda8c\n> --- /dev/null\n> +++ b/tests/generic/452\n> @@ -0,0 +1,87 @@\n> +#! /bin/bash\n> +# FS QA Test 452\n> +#\n> +# This is a regression test for kernel patch:\n> +# commit 42d4a99b09cb (\"ext4: fix fault handling when mounted with -o dax,ro\")\n> +# created by Ross Zwisler \n> +#\n> +#-----------------------------------------------------------------------\n> +# Copyright (c) 2017 Intel Corporation. All Rights Reserved.\n> +#\n> +# This program is free software; you can redistribute it and/or\n> +# modify it under the terms of the GNU General Public License as\n> +# published by the Free Software Foundation.\n> +#\n> +# This program is distributed in the hope that it would be useful,\n> +# but WITHOUT ANY WARRANTY; without even the implied warranty of\n> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> +# GNU General Public License for more details.\n> +#\n> +# You should have received a copy of the GNU General Public License\n> +# along with this program; if not, write the Free Software Foundation,\n> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA\n> +#-----------------------------------------------------------------------\n> +#\n> +\n> +seq=`basename $0`\n> +seqres=$RESULT_DIR/$seq\n> +echo \"QA output created by $seq\"\n> +\n> +here=`pwd`\n> +tmp=/tmp/$$\n> +status=1\t# failure is the default!\n> +trap \"_cleanup; exit \\$status\" 0 1 2 3 15\n> +\n> +_cleanup()\n> +{\n> +\tcd /\n> +\trm -f $tmp.*\n> +}\n> +\n> +# get standard environment, filters and checks\n> +. ./common/rc\n> +. ./common/filter\n> +\n> +# remove previous $seqres.full before test\n> +rm -f $seqres.full\n> +\n> +# Modify as appropriate.\n> +_supported_fs generic\n> +_supported_os Linux\n> +_require_scratch\n> +\n> +# real QA test starts here\n> +# format and mount\n> +_scratch_mkfs > $seqres.full 2>&1\n> +_scratch_mount >> $seqres.full 2>&1\n\nNeed to _notrun if scratch device was mounted with \"noexec\" option.\n\n_exclude_scratch_mount_option \"noexec\"\n\n> +\n> +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null\n> +if [ $? -ne 0 ]; then\n> +\tstatus=$?\n> +\techo \"Couldn't find 'ls'!?\"\n> +\texit\n> +fi\n> +\n> +cp $LS $SCRATCH_MNT\n> +SCRATCH_LS=$SCRATCH_MNT/ls\n> +\n> +$SCRATCH_LS >/dev/null 2>&1\n> +if [ $? -ne 0 ]; then\n> +\tstatus=$?\n> +\techo \"$SCRATCH_LS not working before remount\"\n> +\texit\n> +fi\n> +\n> +_scratch_remount ro\n> +\n> +$SCRATCH_LS >/dev/null 2>&1\n> +if [ $? -ne 0 ]; then\n> +\tstatus=$?\n> +\techo \"$SCRATCH_LS not working after remount\"\n> +\texit\n> +fi\n\nHmm, I don't think all these checks on return value are needed, just\nprint out the error messages on failure and that will break the golden\nimage, as this is not a destructive test, continuing with errors only\nfail the test :)\n\nI think this can be simplified to something like:\n\nLS=$(which ls ....)\nSCRATCH_LS=$SCRATCH_MNT/ls_on_scratch\ncp $LS $SCRATCH_LS\n\n$SCRATCH_LS $SCRATCH_LS | _filter_scratch\n\n_scratch_remount ro\n\n$SCRATCH_LS $SCRATCH_LS | _filter_scratch\n\nAnd update .out file accordingly.\n\nThanks,\nEryu\n\n> +\n> +# success, all done\n> +echo \"Silence is golden\"\n> +status=0\n> +exit\n> diff --git a/tests/generic/452.out b/tests/generic/452.out\n> new file mode 100644\n> index 0000000..db92441\n> --- /dev/null\n> +++ b/tests/generic/452.out\n> @@ -0,0 +1,2 @@\n> +QA output created by 452\n> +Silence is golden\n> diff --git a/tests/generic/group b/tests/generic/group\n> index 044ec3f..45f5789 100644\n> --- a/tests/generic/group\n> +++ b/tests/generic/group\n> @@ -453,3 +453,4 @@\n> 449 auto quick acl enospc\n> 450 auto quick rw\n> 451 auto quick rw aio\n> +452 auto quick\n> -- \n> 2.9.5\n> \n> --\n> To unsubscribe from this list: send the line \"unsubscribe fstests\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eguan@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj2Zc1MJKz9sMN\n\tfor ;\n\tWed, 30 Aug 2017 20:59:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751385AbdH3K7d (ORCPT );\n\tWed, 30 Aug 2017 06:59:33 -0400","from mx1.redhat.com ([209.132.183.28]:33446 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751263AbdH3K7c (ORCPT );\n\tWed, 30 Aug 2017 06:59:32 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7F768356D9;\n\tWed, 30 Aug 2017 10:59:32 +0000 (UTC)","from localhost (dhcp-12-147.nay.redhat.com [10.66.12.147])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E07A487CBC;\n\tWed, 30 Aug 2017 10:59:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7F768356D9","Date":"Wed, 30 Aug 2017 18:59:30 +0800","From":"Eryu Guan ","To":"Ross Zwisler ","Cc":"fstests@vger.kernel.org, linux-ext4@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,\n\tRandy Dodgen , Christoph Hellwig ,\n\tTheodore Ts'o ","Subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","Message-ID":"<20170830105930.GE27835@eguan.usersys.redhat.com>","References":"<20170829213721.GA27686@linux.intel.com>\n\t<20170829223715.26507-1-ross.zwisler@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829223715.26507-1-ross.zwisler@linux.intel.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 30 Aug 2017 10:59:32 +0000 (UTC)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1760238,"web_url":"http://patchwork.ozlabs.org/comment/1760238/","msgid":"<20170830145103.GA10163@infradead.org>","list_archive_url":null,"date":"2017-08-30T14:51:03","subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","submitter":{"id":178,"url":"http://patchwork.ozlabs.org/api/people/178/","name":"Christoph Hellwig","email":"hch@infradead.org"},"content":"> The above patch fixes an issue with ext4 where executables cannot be run on\n> read-only filesystems mounted with the DAX option.\n> \n> This issue does not appear to be present in ext2 or XFS, as they both pass\n> the test. I've also confirmed outside of the test that they are both\n> indeed able to execute binaries on read-only DAX mounts.\n\nIt works for me on XFS. But I don't really understand why, as the fault\nhandler doesn't look very different.\n\nMaybe the problem is that in ext4_journal_start_sb will fail on\na read-only fs?\n\nEven for xfs/ext2 it would seem odd that things like sb_start_pagefault\njust work. \n\n> +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null\n> +if [ $? -ne 0 ]; then\n> +\tstatus=$?\n> +\techo \"Couldn't find 'ls'!?\"\n> +\texit\n> +fi\n\nThese checks all fail for me..","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"OAFm3lPK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj7jn5S7Xz9s9Y\n\tfor ;\n\tThu, 31 Aug 2017 00:51:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751724AbdH3OvI (ORCPT );\n\tWed, 30 Aug 2017 10:51:08 -0400","from bombadil.infradead.org ([65.50.211.133]:41791 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751700AbdH3OvG (ORCPT\n\t); Wed, 30 Aug 2017 10:51:06 -0400","from hch by bombadil.infradead.org with local (Exim 4.87 #1 (Red\n\tHat Linux)) id 1dn4Kd-0005o4-QP; Wed, 30 Aug 2017 14:51:03 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209;\n\th=In-Reply-To:Content-Type:MIME-Version\n\t:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=R4zx5adaQJlnXPJDc9WumLLNcXVIYCrCBJaapzez6g0=;\n\tb=OAFm3lPKdRBJPWwEITd6LfMdb\n\t2ei4EPvA5/tuKoGX69M2qpUv9Hc4H60dzgfoe9t3JQtDPVqwsHRYSoyA5FVDToZDAyNx9/c9O0yZz\n\tyU6ahc2LkEVv8vdiyLJGNB4stvWu3sQ+ANYeAXlB3s3mqCKWPv67sDRPUM5sNzyplmstfQFyd58tV\n\t0xw9/qO5iRU8pthqpcp74Mvn+yM8kdY5LL1rcwqmXEMQ/gl7PncXsKjMiiCYewwJzYkwg8RytZNvo\n\tLHbJ/gEIoznXEKMdZRACf5W9Cas1nSHwt0AHQBRKPvWNWshWqjtHRcfwptQIsf2qajgrmHOE6zwIV\n\tmWJdj7qRw==;","Date":"Wed, 30 Aug 2017 07:51:03 -0700","From":"Christoph Hellwig ","To":"Ross Zwisler ","Cc":"fstests@vger.kernel.org, Eryu Guan ,\n\tlinux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-fsdevel@vger.kernel.org, Randy Dodgen ,\n\tChristoph Hellwig , Theodore Ts'o ","Subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","Message-ID":"<20170830145103.GA10163@infradead.org>","References":"<20170829213721.GA27686@linux.intel.com>\n\t<20170829223715.26507-1-ross.zwisler@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829223715.26507-1-ross.zwisler@linux.intel.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-SRS-Rewrite":"SMTP reverse-path rewritten from by\n\tbombadil.infradead.org. See http://www.infradead.org/rpr.html","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1760627,"web_url":"http://patchwork.ozlabs.org/comment/1760627/","msgid":"<20170831040146.GA17095@linux.intel.com>","list_archive_url":null,"date":"2017-08-31T04:01:46","subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","submitter":{"id":46514,"url":"http://patchwork.ozlabs.org/api/people/46514/","name":"Ross Zwisler","email":"ross.zwisler@linux.intel.com"},"content":"On Wed, Aug 30, 2017 at 06:59:30PM +0800, Eryu Guan wrote:\n> On Tue, Aug 29, 2017 at 04:37:15PM -0600, Ross Zwisler wrote:\n> > This adds a regression test for the following kernel patch:\n> > \n> > commit 42d4a99b09cb (\"ext4: fix fault handling when mounted with -o dax,ro\")\n> > \n> > The above patch fixes an issue with ext4 where executables cannot be run on\n> > read-only filesystems mounted with the DAX option.\n> > \n> > This issue does not appear to be present in ext2 or XFS, as they both pass\n> > the test. I've also confirmed outside of the test that they are both\n> > indeed able to execute binaries on read-only DAX mounts.\n> > \n> > Thanks to Randy Dodgen for the bug report and reproduction steps.\n> > \n> > Signed-off-by: Ross Zwisler \n> > Cc: Randy Dodgen \n> > Cc: Christoph Hellwig \n> > Cc: Theodore Ts'o \n> > \n> > ---\n> > \n> > Sorry if we collided, Randy, but I was 90% done with the test by the time I\n> > saw your mail. :)\n> > ---\n> > tests/generic/452 | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++\n> > tests/generic/452.out | 2 ++\n> > tests/generic/group | 1 +\n> > 3 files changed, 90 insertions(+)\n> > create mode 100755 tests/generic/452\n> > create mode 100644 tests/generic/452.out\n> > \n> > diff --git a/tests/generic/452 b/tests/generic/452\n> > new file mode 100755\n> > index 0000000..54dda8c\n> > --- /dev/null\n> > +++ b/tests/generic/452\n> > @@ -0,0 +1,87 @@\n> > +#! /bin/bash\n> > +# FS QA Test 452\n> > +#\n> > +# This is a regression test for kernel patch:\n> > +# commit 42d4a99b09cb (\"ext4: fix fault handling when mounted with -o dax,ro\")\n> > +# created by Ross Zwisler \n> > +#\n> > +#-----------------------------------------------------------------------\n> > +# Copyright (c) 2017 Intel Corporation. All Rights Reserved.\n> > +#\n> > +# This program is free software; you can redistribute it and/or\n> > +# modify it under the terms of the GNU General Public License as\n> > +# published by the Free Software Foundation.\n> > +#\n> > +# This program is distributed in the hope that it would be useful,\n> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of\n> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> > +# GNU General Public License for more details.\n> > +#\n> > +# You should have received a copy of the GNU General Public License\n> > +# along with this program; if not, write the Free Software Foundation,\n> > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA\n> > +#-----------------------------------------------------------------------\n> > +#\n> > +\n> > +seq=`basename $0`\n> > +seqres=$RESULT_DIR/$seq\n> > +echo \"QA output created by $seq\"\n> > +\n> > +here=`pwd`\n> > +tmp=/tmp/$$\n> > +status=1\t# failure is the default!\n> > +trap \"_cleanup; exit \\$status\" 0 1 2 3 15\n> > +\n> > +_cleanup()\n> > +{\n> > +\tcd /\n> > +\trm -f $tmp.*\n> > +}\n> > +\n> > +# get standard environment, filters and checks\n> > +. ./common/rc\n> > +. ./common/filter\n> > +\n> > +# remove previous $seqres.full before test\n> > +rm -f $seqres.full\n> > +\n> > +# Modify as appropriate.\n> > +_supported_fs generic\n> > +_supported_os Linux\n> > +_require_scratch\n> > +\n> > +# real QA test starts here\n> > +# format and mount\n> > +_scratch_mkfs > $seqres.full 2>&1\n> > +_scratch_mount >> $seqres.full 2>&1\n> \n> Need to _notrun if scratch device was mounted with \"noexec\" option.\n> \n> _exclude_scratch_mount_option \"noexec\"\n> \n> > +\n> > +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null\n> > +if [ $? -ne 0 ]; then\n> > +\tstatus=$?\n> > +\techo \"Couldn't find 'ls'!?\"\n> > +\texit\n> > +fi\n> > +\n> > +cp $LS $SCRATCH_MNT\n> > +SCRATCH_LS=$SCRATCH_MNT/ls\n> > +\n> > +$SCRATCH_LS >/dev/null 2>&1\n> > +if [ $? -ne 0 ]; then\n> > +\tstatus=$?\n> > +\techo \"$SCRATCH_LS not working before remount\"\n> > +\texit\n> > +fi\n> > +\n> > +_scratch_remount ro\n> > +\n> > +$SCRATCH_LS >/dev/null 2>&1\n> > +if [ $? -ne 0 ]; then\n> > +\tstatus=$?\n> > +\techo \"$SCRATCH_LS not working after remount\"\n> > +\texit\n> > +fi\n> \n> Hmm, I don't think all these checks on return value are needed, just\n> print out the error messages on failure and that will break the golden\n> image, as this is not a destructive test, continuing with errors only\n> fail the test :)\n> \n> I think this can be simplified to something like:\n> \n> LS=$(which ls ....)\n> SCRATCH_LS=$SCRATCH_MNT/ls_on_scratch\n> cp $LS $SCRATCH_LS\n> \n> $SCRATCH_LS $SCRATCH_LS | _filter_scratch\n> \n> _scratch_remount ro\n> \n> $SCRATCH_LS $SCRATCH_LS | _filter_scratch\n> \n> And update .out file accordingly.\n> \n> Thanks,\n> Eryu\n\nAwesome, thanks for the review! I'll fix all of these in v2.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjTG66L6lz9s71\n\tfor ;\n\tThu, 31 Aug 2017 14:01:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750816AbdHaEBs (ORCPT );\n\tThu, 31 Aug 2017 00:01:48 -0400","from mga01.intel.com ([192.55.52.88]:28977 \"EHLO mga01.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750711AbdHaEBr (ORCPT );\n\tThu, 31 Aug 2017 00:01:47 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Aug 2017 21:01:46 -0700","from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.77])\n\tby fmsmga002.fm.intel.com with ESMTP; 30 Aug 2017 21:01:46 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,451,1498546800\"; d=\"scan'208\";a=\"1212809260\"","Date":"Wed, 30 Aug 2017 22:01:46 -0600","From":"Ross Zwisler ","To":"Eryu Guan ","Cc":"Ross Zwisler ,\n\tfstests@vger.kernel.org, linux-ext4@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,\n\tRandy Dodgen , Christoph Hellwig ,\n\tTheodore Ts'o ","Subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","Message-ID":"<20170831040146.GA17095@linux.intel.com>","Mail-Followup-To":"Ross Zwisler ,\n\tEryu Guan , fstests@vger.kernel.org,\n\tlinux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-fsdevel@vger.kernel.org, Randy Dodgen ,\n\tChristoph Hellwig ,\n\tTheodore Ts'o ","References":"<20170829213721.GA27686@linux.intel.com>\n\t<20170829223715.26507-1-ross.zwisler@linux.intel.com>\n\t<20170830105930.GE27835@eguan.usersys.redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830105930.GE27835@eguan.usersys.redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1760628,"web_url":"http://patchwork.ozlabs.org/comment/1760628/","msgid":"<20170831040255.GB17095@linux.intel.com>","list_archive_url":null,"date":"2017-08-31T04:02:55","subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","submitter":{"id":46514,"url":"http://patchwork.ozlabs.org/api/people/46514/","name":"Ross Zwisler","email":"ross.zwisler@linux.intel.com"},"content":"On Wed, Aug 30, 2017 at 07:51:03AM -0700, Christoph Hellwig wrote:\n> > The above patch fixes an issue with ext4 where executables cannot be run on\n> > read-only filesystems mounted with the DAX option.\n> > \n> > This issue does not appear to be present in ext2 or XFS, as they both pass\n> > the test. I've also confirmed outside of the test that they are both\n> > indeed able to execute binaries on read-only DAX mounts.\n> \n> It works for me on XFS. But I don't really understand why, as the fault\n> handler doesn't look very different.\n> \n> Maybe the problem is that in ext4_journal_start_sb will fail on\n> a read-only fs?\n> \n> Even for xfs/ext2 it would seem odd that things like sb_start_pagefault\n> just work. \n> \n> > +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null\n> > +if [ $? -ne 0 ]; then\n> > +\tstatus=$?\n> > +\techo \"Couldn't find 'ls'!?\"\n> > +\texit\n> > +fi\n> \n> These checks all fail for me..\n\nHuh...really? I'll send out v2 in a second, but if that fails for you as well\ncan you try and give me a hint as to what's going wrong with the test in your\nsetup?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjTHV2vz6z9s71\n\tfor ;\n\tThu, 31 Aug 2017 14:03:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751103AbdHaEDB (ORCPT );\n\tThu, 31 Aug 2017 00:03:01 -0400","from mga11.intel.com ([192.55.52.93]:41011 \"EHLO mga11.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750790AbdHaEDA (ORCPT );\n\tThu, 31 Aug 2017 00:03:00 -0400","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Aug 2017 21:02:59 -0700","from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.77])\n\tby orsmga002.jf.intel.com with ESMTP; 30 Aug 2017 21:02:58 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,451,1498546800\"; d=\"scan'208\";a=\"130180260\"","Date":"Wed, 30 Aug 2017 22:02:55 -0600","From":"Ross Zwisler ","To":"Christoph Hellwig ","Cc":"Ross Zwisler ,\n\tfstests@vger.kernel.org, Eryu Guan ,\n\tlinux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,\n\tlinux-fsdevel@vger.kernel.org, Randy Dodgen ,\n\tTheodore Ts'o ","Subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","Message-ID":"<20170831040255.GB17095@linux.intel.com>","Mail-Followup-To":"Ross Zwisler ,\n\tChristoph Hellwig , fstests@vger.kernel.org,\n\tEryu Guan , linux-ext4@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,\n\tRandy Dodgen , Theodore Ts'o ","References":"<20170829213721.GA27686@linux.intel.com>\n\t<20170829223715.26507-1-ross.zwisler@linux.intel.com>\n\t<20170830145103.GA10163@infradead.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830145103.GA10163@infradead.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1760969,"web_url":"http://patchwork.ozlabs.org/comment/1760969/","msgid":"<20170831130933.GB19544@infradead.org>","list_archive_url":null,"date":"2017-08-31T13:09:33","subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","submitter":{"id":178,"url":"http://patchwork.ozlabs.org/api/people/178/","name":"Christoph Hellwig","email":"hch@infradead.org"},"content":"On Wed, Aug 30, 2017 at 10:02:55PM -0600, Ross Zwisler wrote:\n> > > +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null\n> > > +if [ $? -ne 0 ]; then\n> > > +\tstatus=$?\n> > > +\techo \"Couldn't find 'ls'!?\"\n> > > +\texit\n> > > +fi\n> > \n> > These checks all fail for me..\n> \n> Huh...really? I'll send out v2 in a second, but if that fails for you as well\n> can you try and give me a hint as to what's going wrong with the test in your\n> setup?\n\nThe v2 one works fine for me.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"Yo8df/Qq\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjQ8549Bz9s72\n\tfor ;\n\tThu, 31 Aug 2017 23:09:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751425AbdHaNJf (ORCPT );\n\tThu, 31 Aug 2017 09:09:35 -0400","from bombadil.infradead.org ([65.50.211.133]:45123 \"EHLO\n\tbombadil.infradead.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750895AbdHaNJe (ORCPT\n\t); Thu, 31 Aug 2017 09:09:34 -0400","from hch by bombadil.infradead.org with local (Exim 4.87 #1 (Red\n\tHat Linux)) id 1dnPDx-0005cd-JI; Thu, 31 Aug 2017 13:09:33 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=bombadil.20170209;\n\th=In-Reply-To:Content-Type:MIME-Version\n\t:References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=HgFRbY24f5Pc1H+efHvFiKo/fuYGxHLXPaqMAgGZOEk=;\n\tb=Yo8df/QqghtQhuWtjQltgKySu\n\tMFwdmXIUw/VJpIQLfiw9gPbp/ZjLjqKfvuf66wb4m+1rPEL9hnbHRm4FmnGhgEz5kPksm9p7LVXUd\n\tOsctu9wItU8eATlogUOApHadk56UEXdw6vlNO8h8Ly4MfnVyZYar5d0DjsV6Mk2wOBRMSTd2piuUP\n\t3ApUQXsPvPo39FdMRp5HskLz0xdgH2lOLSQkVUagjlLnn/iPCNwWSKb3WweA5IJSHHV9ZLom4ozRR\n\tTtXJ0fy9v9nq5AUuX8IxGISs43Q3HjBMrxWAS50DEYquW4WAA7kzc2CeVFyICAqhfOnwypsVF9hNw\n\t8KP9h1nag==;","Date":"Thu, 31 Aug 2017 06:09:33 -0700","From":"Christoph Hellwig ","To":"Ross Zwisler ,\n\tChristoph Hellwig , fstests@vger.kernel.org,\n\tEryu Guan , linux-ext4@vger.kernel.org,\n\tlinux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,\n\tRandy Dodgen , Theodore Ts'o ","Subject":"Re: [fstests PATCH] generic: add test for executables on read-only\n\tDAX mounts","Message-ID":"<20170831130933.GB19544@infradead.org>","References":"<20170829213721.GA27686@linux.intel.com>\n\t<20170829223715.26507-1-ross.zwisler@linux.intel.com>\n\t<20170830145103.GA10163@infradead.org>\n\t<20170831040255.GB17095@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170831040255.GB17095@linux.intel.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-SRS-Rewrite":"SMTP reverse-path rewritten from by\n\tbombadil.infradead.org. See http://www.infradead.org/rpr.html","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}}]