[{"id":1759750,"web_url":"http://patchwork.ozlabs.org/comment/1759750/","msgid":"<20170829153449.5f2cfadb@xeon-e3>","list_archive_url":null,"date":"2017-08-29T22:34:49","subject":"Re: [PATCH net-next v3 1/2] inet_diag: allow protocols to provide\n\tadditional data","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Tue, 29 Aug 2017 15:29:53 -0700\nIvan Delalande wrote:\n\n> @@ -452,13 +466,14 @@ int inet_diag_dump_one_icsk(struct inet_hashinfo *hashinfo,\n> \tstruct net *net = sock_net(in_skb->sk);\n> \tstruct sk_buff *rep;\n> \tstruct sock *sk;\n> +\tbool net_admin = netlink_net_capable(in_skb, CAP_NET_ADMIN);\n\nPlease keep declarations in Christmas tree order if possible.\n\nint inet_sk_diag_fill(struct sock *sk, struct inet_connection_sock *icsk,\n\t\t struct sk_buff *skb, const struct inet_diag_req_v2 *req,\n\t\t struct user_namespace *user_ns,\n\t\t u32 portid, u32 seq, u16 nlmsg_flags,\n\t\t const struct nlmsghdr *unlh,\n\t\t bool net_admin)\n{\n\tbool net_admin = netlink_net_capable(in_skb, CAP_NET_ADMIN);\n\tconst struct tcp_congestion_ops *ca_ops;\n\tconst struct inet_diag_handler *handler;\n\tint ext = req->idiag_ext;\n\tstruct inet_diag_msg *r;\n\tstruct nlmsghdr *nlh;\n\tstruct nlattr *attr;\n\tvoid *info = NULL;","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"L7l8QWvd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhk3N0Pcbz9s8J\n\tfor ;\n\tWed, 30 Aug 2017 08:34:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751463AbdH2Wex (ORCPT );\n\tTue, 29 Aug 2017 18:34:53 -0400","from mail-pf0-f169.google.com ([209.85.192.169]:33302 \"EHLO\n\tmail-pf0-f169.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751270AbdH2Wew (ORCPT\n\t); Tue, 29 Aug 2017 18:34:52 -0400","by mail-pf0-f169.google.com with SMTP id r62so14082024pfj.0\n\tfor ; Tue, 29 Aug 2017 15:34:51 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\tu187sm6004946pfu.140.2017.08.29.15.34.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 29 Aug 2017 15:34:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=n1iGVzue4XtN9EUV6ENpg+qVzzSayIhweGqlMk99kgM=;\n\tb=L7l8QWvdUHAZN9bD4e3mCdWORn/t+lZBWsxxAa6+eFl1pUGOqswUPpyjPyePyj17YN\n\tv96D/ISDLVeMYUw5BDmx6Ge/feobr+ZLY0Rf/mmMynyNzBlU93vPJgSGJC9wDhjVVygw\n\tJz9wqvX0DmLIchYs+WhU2dYHE1bGQJoYcMP1Lp9gT9ta723C0ucdOM3mshJZtN8l4EgE\n\t4RqsGqXDio4ox45sdg2tnTcfKnoOSWa+j5ygsL0nMlmUXbahEjF3Kq0dYmEIh7IPebvl\n\tYZ5oEjkgKqb+9vo5hwA9I0gWg0eJRFTjqSMBmm07wkUmrQjxA1RcnJzeNbhgYeLNs6OX\n\tlFLQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=n1iGVzue4XtN9EUV6ENpg+qVzzSayIhweGqlMk99kgM=;\n\tb=h1KkGhswk9EWE4sulxAfDscO+7O6XWWeE5kGVF5OSDM/fQ17FQr4A99amSfrm7444A\n\tDh65IQje2JExN0/ixC+EDMclqOj9J0MaYfEww3gbYFG2vYMRvyJEEoMNFd18meeR4xVp\n\tKjsbMp6zTrmFrz9Teq/Hp2SJb7/VSZ7p58g4BRhRMkaadAJmXWr3tv5vs8F1EntSRL45\n\tDL4jqe5oL38Ta1oHOz2fEPLPUIC7rq+KZckayUIKCb5LCn/VfALEA1QHHml8IjvFA39q\n\tSX93B8Ux2CIygovil6MfvJiA7V6mCxTlXX5VQasixd9cob9g7qJx+9ne+AS3rtJ9JCdj\n\tTzOg==","X-Gm-Message-State":"AHYfb5hMLHu8zz9O8f4VYT7cvSARZs8dK4uOgQW2igKpxyXDY2yXi8zH\n\t8MzA4nKgoRNbfgkY","X-Received":"by 10.101.91.13 with SMTP id y13mr1832772pgq.342.1504046091585; \n\tTue, 29 Aug 2017 15:34:51 -0700 (PDT)","Date":"Tue, 29 Aug 2017 15:34:49 -0700","From":"Stephen Hemminger ","To":"Ivan Delalande ","Cc":"David Miller ,\n\tEric Dumazet , netdev@vger.kernel.org","Subject":"Re: [PATCH net-next v3 1/2] inet_diag: allow protocols to provide\n\tadditional data","Message-ID":"<20170829153449.5f2cfadb@xeon-e3>","In-Reply-To":"<20170829222954.24863-2-colona@arista.com>","References":"<20170829222954.24863-1-colona@arista.com>\n\t<20170829222954.24863-2-colona@arista.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]