[{"id":1796255,"web_url":"http://patchwork.ozlabs.org/comment/1796255/","msgid":"<20171030204602.GS27530@ovn.org>","list_archive_url":null,"date":"2017-10-30T20:46:02","subject":"Re: [ovs-dev] [PATCH] ovn-controller: support configurable acl log\n\tfile rate limit","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Tue, Aug 29, 2017 at 03:27:53PM -0700, Han Zhou wrote:\n> Add parameters in local Open_vSwitch DB external-ids for rate-\n> limiting the log file writing:\n> ovn-acl-log-rl-rate\n> ovn-acl-log-rl-burst\n> \n> Note: this has nothing to do with packet-in rate-limiting.\n> Signed-off-by: Han Zhou \n\nThanks for working on this.\n\nJustin is probably the right person to review this, but here are a few\npreliminary comments.\n\nI'd prefer to see a new vlog_rate_limit_set() function, which could do\nthe actual work of changing the rate limit. This is partly just to\nimprove the abstraction, but also partly because vlog_rate_limit\ncontains a mutex that should be taken whenever its data is accessed. I\ndon't think that thread safety is a problem in this particular case, but\nI don't know of a downside to being careful here.\n\nThe commit message doesn't explain the change to tests/automake.mk.\n\nIn acl-log.h, we normally write prototypes without a line break.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yQmjJ75HMz9t61\n\tfor ;\n\tTue, 31 Oct 2017 07:46:12 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 33ECAD1C;\n\tMon, 30 Oct 2017 20:46:10 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 8D716D08\n\tfor ; Mon, 30 Oct 2017 20:46:08 +0000 (UTC)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1DDE914B\n\tfor ; Mon, 30 Oct 2017 20:46:08 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 48B85A80C7;\n\tMon, 30 Oct 2017 21:46:04 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Mon, 30 Oct 2017 13:46:02 -0700","From":"Ben Pfaff ","To":"Han Zhou , Justin Pettit ","Message-ID":"<20171030204602.GS27530@ovn.org>","References":"<1504045673-12430-1-git-send-email-zhouhan@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504045673-12430-1-git-send-email-zhouhan@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] ovn-controller: support configurable acl log\n\tfile rate limit","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1796813,"web_url":"http://patchwork.ozlabs.org/comment/1796813/","msgid":"","list_archive_url":null,"date":"2017-10-31T17:47:11","subject":"Re: [ovs-dev] [PATCH] ovn-controller: support configurable acl log\n\tfile rate limit","submitter":{"id":67381,"url":"http://patchwork.ozlabs.org/api/people/67381/","name":"Han Zhou","email":"zhouhan@gmail.com"},"content":"On Mon, Oct 30, 2017 at 1:46 PM, Ben Pfaff wrote:\n>\n> On Tue, Aug 29, 2017 at 03:27:53PM -0700, Han Zhou wrote:\n> > Add parameters in local Open_vSwitch DB external-ids for rate-\n> > limiting the log file writing:\n> > ovn-acl-log-rl-rate\n> > ovn-acl-log-rl-burst\n> >\n> > Note: this has nothing to do with packet-in rate-limiting.\n> > Signed-off-by: Han Zhou \n>\n> Thanks for working on this.\n>\n> Justin is probably the right person to review this, but here are a few\n> preliminary comments.\n>\n> I'd prefer to see a new vlog_rate_limit_set() function, which could do\n> the actual work of changing the rate limit. This is partly just to\n> improve the abstraction, but also partly because vlog_rate_limit\n> contains a mutex that should be taken whenever its data is accessed. I\n> don't think that thread safety is a problem in this particular case, but\n> I don't know of a downside to being careful here.\n>\n> The commit message doesn't explain the change to tests/automake.mk.\n>\n> In acl-log.h, we normally write prototypes without a line break.\n\nThanks Ben for the review. I will wait for Justin's comments and then work\non V2.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AvFZpfCq\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yRJhP3pgQz9sNx\n\tfor ;\n\tWed, 1 Nov 2017 04:47:17 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 3E9AEC94;\n\tTue, 31 Oct 2017 17:47:14 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 28E68C8A\n\tfor ; Tue, 31 Oct 2017 17:47:13 +0000 (UTC)","from mail-vk0-f54.google.com (mail-vk0-f54.google.com\n\t[209.85.213.54])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 99DAEF8\n\tfor ; Tue, 31 Oct 2017 17:47:12 +0000 (UTC)","by mail-vk0-f54.google.com with SMTP id t203so10921674vke.0\n\tfor ; Tue, 31 Oct 2017 10:47:12 -0700 (PDT)","by 10.176.29.2 with HTTP; Tue, 31 Oct 2017 10:47:11 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=y8r4MqUSaMdDNZgLE2zG9nbgs0PpjuYfC8eSOfmsXEk=;\n\tb=AvFZpfCq3OsUqxvKJbbROeEr/Rzs1Jd+0yKAMpc2fJ3sZIvE4+3bAaZYoyWvkc96hh\n\tj0EeD33epVwT/FOXxu/Q+hn1FWzT1kq8nVlmPzqQDgY1gJGzuAjZos3+cwWKRukO/2tr\n\tca3J56Viadx4+wKTS/Ey0Zt0J0RCB8bX+w0h4jIzz4tojeMg+OFxNU3poDMjLDB4Bf1B\n\tDfp6d71Xy+YUzrz8RNGfQv5S/Jz3C+hCq/NjT0MOv6kweybmXTVN0WYpHxzAUYuWjftg\n\tKDsNtFc9C9Uo0gHyZL6Qm/Y/mtmbqkb6JrNDPonmXJNbmuUStyMxbPtDrDTX6aF9ui29\n\tEgew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=y8r4MqUSaMdDNZgLE2zG9nbgs0PpjuYfC8eSOfmsXEk=;\n\tb=ORUZ8jflbIJrftwG9W4ZKynwsG91nc6BKfTkhkByevP0XK9A39KDtI3mwWwm6nhlWf\n\tCi1wvNbX9ZNAxTCtnaZDgWE3T20RSzqztdSGT9sQ5WacpAo4QnJ93SK2TVuc2dPyQut4\n\t3477Aao9o7u+zZNkOfyapb8IZsnan7hT9BzxsbOcCffULJh9IbOzdM43WgoRyZQ/iem6\n\t0/1LMaWpQVHixp36tT/PuwBXkAUttWYLd/iieV0L6GxnK1UdTtlIUb3ZeLfru2DvMxv9\n\tHxZWMe1SAPUtTstNP4TbBBs/UZ+hPSUZudNKst05oaeGNI7VbUxjkCmm7RkZfsDSiFus\n\t2oTw==","X-Gm-Message-State":"AMCzsaW2+xqIC1hOBXLPo5NWMWu3CMaaL8s3C87SLtwbTsmJX2Gq2UpV\n\tDwnJTNRn1pFYwHsu6KasdRbl5v4ZBIYh2G8njC4=","X-Google-Smtp-Source":"ABhQp+TgAl/nmwVBHv2fyZLwP9veYULIyF7y2cI+HhkEnL/S3HYeLuvdbSwHCFFhJ1RO6K6BL3LlvKPqhDy1mjRa/qk=","X-Received":"by 10.31.47.142 with SMTP id v136mr1399424vkv.187.1509472031633; \n\tTue, 31 Oct 2017 10:47:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171030204602.GS27530@ovn.org>","References":"<1504045673-12430-1-git-send-email-zhouhan@gmail.com>\n\t<20171030204602.GS27530@ovn.org>","From":"Han Zhou ","Date":"Tue, 31 Oct 2017 10:47:11 -0700","Message-ID":"","To":"Ben Pfaff ","X-Spam-Status":"No, score=0.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","X-Content-Filtered-By":"Mailman/MimeDel 2.1.12","Cc":"\"dev@openvswitch.org\" ","Subject":"Re: [ovs-dev] [PATCH] ovn-controller: support configurable acl log\n\tfile rate limit","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]