[{"id":1761575,"web_url":"http://patchwork.ozlabs.org/comment/1761575/","msgid":"<20170901103841.GA29876@fergus.ozlabs.ibm.com>","date":"2017-09-01T10:38:41","subject":"Re: [PATCH RFC] KVM: PPC: Book3S: Add MMIO emulation for VMX\n\tinstructions","submitter":{"id":67079,"url":"http://patchwork.ozlabs.org/api/people/67079/","name":"Paul Mackerras","email":"paulus@ozlabs.org"},"content":"On Tue, Aug 29, 2017 at 07:18:02PM -0300, Jose Ricardo Ziviani wrote:\n> This patch provides the MMIO load/store vector indexed\n> X-Form emulation.\n> \n> Instructions implemented: lvx, stvx\n> \n> Signed-off-by: Jose Ricardo Ziviani \n\nThanks for the patch. The basic outline of it looks fine. The parts\nwhere you are accessing the VMX register image in memory are a bit\nhard to follow, and I'll have to check them in detail.\n\nLonger term, I want to switch over to using the instruction emulation\ninfrastructure in arch/powerpc/lib/sstep.c that I have recently\nexpanded to handle almost all load and store instructions. That will\nreduce duplication and should simplify all of this code enormously.\n\nRegards,\nPaul.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkG3R5Z53z9t32\n\tfor ;\n\tFri, 1 Sep 2017 20:40:19 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xkG3R4FZ3zDqF4\n\tfor ;\n\tFri, 1 Sep 2017 20:40:19 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xkG1d0X3fzDqXy\n\tfor ;\n\tFri, 1 Sep 2017 20:38:45 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1003)\n\tid 3xkG1c6Fh2z9t2x; Fri, 1 Sep 2017 20:38:44 +1000 (AEST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"Be7BJYtS\";\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"Be7BJYtS\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"Be7BJYtS\"; \n\tdkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1504262324; bh=dNR2QgDusAGszMeMhlnl9H372XjrFk12Rps6OaMuJzs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Be7BJYtSXJXOAYrxAzJ2wQ07JN6GQ/Md/k0nJSPJx4FDwwiNI9neLJxv3gn+gya20\n\topv8AW6lBQugq5LWrwVDMF4enB6MTnIaIPJEwuNC9wxAFStSeXI/aXXtlVuau+82XI\n\t+q91oaqWR1gJgqilYEemEfhCIYllGyBbxzVw3JeYeDxp9EjjGFSg8xwVSgBHcO9mmK\n\tbF8PTK1d/9YZj6hZZ2IyyZFJbf15AwyZUf6C9tjCI9kwBF1h8iANLeLRLerM4erWvk\n\tvSfSh5LaFfUesJoucWjSvBdVNhQUStyplzMHsau+jQoWmjB7oqs9PdK9+OCoNjUE2G\n\tGGHaSSjBuIz6g==","Date":"Fri, 1 Sep 2017 20:38:41 +1000","From":"Paul Mackerras ","To":"Jose Ricardo Ziviani ","Subject":"Re: [PATCH RFC] KVM: PPC: Book3S: Add MMIO emulation for VMX\n\tinstructions","Message-ID":"<20170901103841.GA29876@fergus.ozlabs.ibm.com>","References":"<1504045082-16178-1-git-send-email-joserz@linux.vnet.ibm.com>\n\t<1504045082-16178-2-git-send-email-joserz@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504045082-16178-2-git-send-email-joserz@linux.vnet.ibm.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, agraf@suse.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]