[{"id":1763509,"web_url":"http://patchwork.ozlabs.org/comment/1763509/","msgid":"<20170905170351.GA13471@gate.crashing.org>","list_archive_url":null,"date":"2017-09-05T17:03:51","subject":"Re: [PATCH v2, rs6000] Fix PR81833","submitter":{"id":134,"url":"http://patchwork.ozlabs.org/api/people/134/","name":"Segher Boessenkool","email":"segher@kernel.crashing.org"},"content":"Hi!\n\nOn Tue, Aug 29, 2017 at 04:47:18PM -0500, Bill Schmidt wrote:\n> Thanks for approving the previous patch with changes. I've made those and also\n> modified the test case to require VSX hardware for execution. I duplicated the\n> test so we get coverage on P7 BE 32/64 and P8 BE/LE. I'd appreciate it if you\n> could look over the dejagnu instructions once more on these. Thanks!\n\n> --- gcc/testsuite/gcc.target/powerpc/pr81833-1.c\t(nonexistent)\n> +++ gcc/testsuite/gcc.target/powerpc/pr81833-1.c\t(working copy)\n> @@ -0,0 +1,59 @@\n> +/* PR81833: This used to fail due to improper implementation of vec_msum. */\n> +/* Test case relies on -mcpu=power7 or later. Currently we don't have\n> + machinery to express that, so we have two separate tests for -mcpu=power7\n> + and -mcpu=power8 to catch 32-bit BE on P7 and 64-bit BE/LE on P8. */\n> +\n> +/* { dg-do run } */\n> +/* { dg-require-effective-target vsx_hw } */\n> +/* { dg-skip-if \"do not override -mcpu\" { powerpc*-*-* } { \"-mcpu=*\" } { \"-mcpu=power8\" } } */\n> +/* { dg-options \"-mcpu=power8 -O2\" } */\n\nAs I explained off-list, but here's for the record:\n\nSince this is a run test and you use -mcpu=power8, you probably should\nuse p8vector_hw instead of vsx_hw.\n\nOkay with that. Thanks!\n\n\nSegher","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461522-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"q+Wi6IFI\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmtNT1JpXz9sP3\n\tfor ;\n\tWed, 6 Sep 2017 03:04:08 +1000 (AEST)","(qmail 36172 invoked by alias); 5 Sep 2017 17:04:01 -0000","(qmail 36162 invoked by uid 89); 5 Sep 2017 17:04:01 -0000","from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tTue, 05 Sep 2017 17:03:56 +0000","from gate.crashing.org (localhost.localdomain [127.0.0.1])\tby\n\tgate.crashing.org (8.14.1/8.13.8) with ESMTP id\n\tv85H3q3U017687; Tue, 5 Sep 2017 12:03:52 -0500","(from segher@localhost)\tby gate.crashing.org\n\t(8.14.1/8.14.1/Submit) id v85H3qun017686;\n\tTue, 5 Sep 2017 12:03:52 -0500"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=x2K+ZVLkW0PXHYH07\n\tbPKDixrem7v4+cKvB6O8FYFZ4ZoApmm83jO8Q3ZNkNiOeqLGDTuwpNDhLYpLbiCP\n\tGlJVeH42nb+nnFIQl8wN3nHWsLFkrCey4cSq6D7I68i5QyjEw4J0WsZkFKJSJLIS\n\tgnaMnYv0RROktWlpQN6xQ/mZys=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=7GYhTXNoWA1ldz6kWlhofJK\n\thoX8=; b=q+Wi6IFII5/j3ik1PYAcXA0MUIeh4HNHSCpyqg/2+Ycldo8XfPsoIai\n\tnhG4/LAZ6lxmfzMgslnyIlR9xIqgwlGcjANVaA9YXjQDVuP64TJsc4cKLgC+NGWH\n\tTprV4RXel7VYkqIFDGaBaxLDB3qGhL8nNzcMJFEER1EnLCCcKE+M=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.1 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_2, GIT_PATCH_3,\n\tRP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=","X-HELO":"gate.crashing.org","Date":"Tue, 5 Sep 2017 12:03:51 -0500","From":"Segher Boessenkool ","To":"Bill Schmidt ","Cc":"GCC Patches , David Edelsohn ","Subject":"Re: [PATCH v2, rs6000] Fix PR81833","Message-ID":"<20170905170351.GA13471@gate.crashing.org>","References":"<75124dce-5afd-12bf-26a9-3370904c869f@linux.vnet.ibm.com>","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<75124dce-5afd-12bf-26a9-3370904c869f@linux.vnet.ibm.com>","User-Agent":"Mutt/1.4.2.3i","X-IsSubscribed":"yes"}}]