[{"id":1759820,"web_url":"http://patchwork.ozlabs.org/comment/1759820/","msgid":"","list_archive_url":null,"date":"2017-08-30T02:28:20","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"Hi,\n\nOn Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote:\n> Add device tree binding documentation for Broadcom BCM43430\n> AMPAK AP6212A has this chip.\n>\n> e.g\n> compatible = \"brcm,bcm43430-fmac\";\n>\n> NanoPi NEO Plus2 has an AMPAK AP6212A WiFi module\n> with BCM43430 rev=1 inside.\n> brcmf_chip_recognition found AXI chip: BCM43430, rev=1\n> brcmf_ops_sdio_probe sdio vendor ID: 0x02d0\n> brcmf_ops_sdio_probe sdio device ID: 0xa9a6\n>\n> Signed-off-by: Antony Antony \n> ---\n> Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> NanoPi Neo Plus2 Kernel DT propsed patch\n> https://patchwork.kernel.org/patch/9925387/\n>\n> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> index 590f622..9107e1a 100644\n> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> @@ -6,7 +6,9 @@ connects the device to the system.\n>\n> Required properties:\n>\n> - - compatible : Should be \"brcm,bcm4329-fmac\".\n> + - compatible : should be one of the following:\n> + * \"brcm,bcm4329-fmac\"\n> + * \"brcm,bcm43430-fmac\"\n\nYou updated the bindings, but not the driver. So it's not actually\ngoing to work. More specifically, OOB interrupts won't work.\n\nIIRC, The compatible string for this particular case, as it was\noriginally proposed, only serves as a placeholder for the driver\nto check against. None of the instances in sunxi device trees\nmatch the actual chip model. Actual model matching is done\nthrough SDIO, as you've already seen.\n\nChenYu\n\n\n>\n> Optional properties:\n> - brcm,drive-strength : drive strength used for SDIO pins on device in mA\n> --\n> 2.9.3\n>\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhqFH3x2wz9sMN\n\tfor ;\n\tWed, 30 Aug 2017 12:28:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751314AbdH3C2u (ORCPT\n\t);\n\tTue, 29 Aug 2017 22:28:50 -0400","from smtp.csie.ntu.edu.tw ([140.112.30.61]:45430 \"EHLO\n\tsmtp.csie.ntu.edu.tw\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751297AbdH3C2t (ORCPT\n\t); Tue, 29 Aug 2017 22:28:49 -0400","from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id 6CF542032F;\n\tWed, 30 Aug 2017 10:28:44 +0800 (CST)","by mail-wm0-f52.google.com with SMTP id b14so23917362wme.0;\n\tTue, 29 Aug 2017 19:28:44 -0700 (PDT)","by 10.223.133.253 with HTTP; Tue, 29 Aug 2017 19:28:20 -0700 (PDT)"],"X-Gm-Message-State":"AHPjjUgdJbuTVxT4F7ezSz4+QU8ir3iG9QtCZyLqszSjm1+Eau1IdCuJ\n\tPTQ7tXyopdtL9zcOvoizyIAsU8m/rg==","X-Google-Smtp-Source":"ADKCNb5f9R3YGLKTAlLy1EiAuccf28iEoQMA8H5xgn756UUMHnii5Xe2Y839fm87kVLipiTqPYz5vTId3tfMaMDCixc=","X-Received":"by 10.28.138.84 with SMTP id m81mr215620wmd.61.1504060121051;\n\tTue, 29 Aug 2017 19:28:41 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170829214309.34466-1-antony@phenome.org>","References":"<20170829214309.34466-1-antony@phenome.org>","From":"Chen-Yu Tsai ","Date":"Wed, 30 Aug 2017 10:28:20 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","To":"Antony Antony ","Cc":"Kalle Valo , Rob Herring ,\n\tMark Rutland , Icenowy Zheng , \n\tdevicetree ,\n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ,\n\tChen-Yu Tsai ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1760091,"web_url":"http://patchwork.ozlabs.org/comment/1760091/","msgid":"<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>","list_archive_url":null,"date":"2017-08-30T12:02:18","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":71638,"url":"http://patchwork.ozlabs.org/api/people/71638/","name":"Antony Antony","email":"antony@phenome.org"},"content":"hi,\n\nOn Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote:\n> On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote:\n\n> > a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> > @@ -6,7 +6,9 @@ connects the device to the system.\n> >\n> > Required properties:\n> >\n> > - - compatible : Should be \"brcm,bcm4329-fmac\".\n> > + - compatible : should be one of the following:\n> > + * \"brcm,bcm4329-fmac\"\n> > + * \"brcm,bcm43430-fmac\"\n> \n> You updated the bindings, but not the driver. So it's not actually\n> going to work. More specifically, OOB interrupts won't work.\n>\n\nunderstood, ignore this patch for now. Thanks Chen-Yu.\n\n> IIRC, The compatible string for this particular case, as it was\n> originally proposed, only serves as a placeholder for the driver\n> to check against. None of the instances in sunxi device trees\n> match the actual chip model. Actual model matching is done\n> through SDIO, as you've already seen.\n\nyes it seems SDIO driveer code is smarter, once it initialize \nbrcm,bcm4329-fmac it ignore the DT info and read the chip details to locate \nfirmware file.\n\nI also noticed other boards using bcm4329-fmac in similar situations.\nhttps://patchwork.kernel.org/patch/9739181/\n\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts?h=v4.13-rc7\n\nI will resend \"NanoPi NEO Plus2\" dts with \"brcm,bcm4329-fmac\" and see where \nit goes. \n\nregards,\n-antony\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj3z40ttxz9s8P\n\tfor ;\n\tWed, 30 Aug 2017 22:02:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751366AbdH3MCW (ORCPT\n\t);\n\tWed, 30 Aug 2017 08:02:22 -0400","from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:53761 \"EHLO\n\tlb3-smtp-cloud9.xs4all.net\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751334AbdH3MCV (ORCPT\n\t); Wed, 30 Aug 2017 08:02:21 -0400","from AntonyAntony.local ([83.163.117.153])\n\tby smtp-cloud9.xs4all.net with ESMTPSA\n\tid n1hKdNuLUdRLjn1hLdDLz2; Wed, 30 Aug 2017 14:02:19 +0200"],"Date":"Wed, 30 Aug 2017 14:02:18 +0200","From":"Antony Antony ","To":"Chen-Yu Tsai ","Cc":"Antony Antony , Kalle Valo ,\n\tRob Herring , Mark Rutland ,\n\tIcenowy Zheng ,\n\tdevicetree , \n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","Message-ID":"<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>","References":"<20170829214309.34466-1-antony@phenome.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170602 (1.8.3)","X-CMAE-Envelope":"MS4wfEpNcryX3O7D35jT2e8HP8qsSTOGR4UAB0dL2qigWrBaxkV8hi+GmCzvp8wh6z1KZSLkBhbHzEaOhY+vAoQ9UAmYvT6LRvWKJt1383zmBYnG1+dFImDb\n\tUpemggpotsysKGFyeQ1kXny8CTnDazdbAEMqhfsrLyo9vhXe9LR8EKFOGVLZnSncns+8ymsY60j89PhJDpZP+AKt3yWDr2DZa62/LPsVYxVpMPBYiqrdCKq1\n\tmu8l9keudSHWep/RrRm/oKbzTb62dw+b3FpoJ9R6q1W66x1n1FBnKCZn+9XW+0tYp4JN0fRzoQ2lWK3xNtRNoyTOu7cIpLO/mmdGLr+qVo1gIFHoudTt/lC8\n\tr2EaZHnXFBGqfYWlJT0JekOMJQL66ybxG7ti1kpN0biWoEUbvy7nY6U9YWne+3ZBW23GpjhhCbzEM95uyMuCx/uFajBlLQqp9/hmfPQHiPjK7CS7cKM=","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1761818,"web_url":"http://patchwork.ozlabs.org/comment/1761818/","msgid":"<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-01T16:49:11","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote:\n> hi,\n> \n> On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote:\n> > On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote:\n> \n> > > a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> > > @@ -6,7 +6,9 @@ connects the device to the system.\n> > >\n> > > Required properties:\n> > >\n> > > - - compatible : Should be \"brcm,bcm4329-fmac\".\n> > > + - compatible : should be one of the following:\n> > > + * \"brcm,bcm4329-fmac\"\n> > > + * \"brcm,bcm43430-fmac\"\n> > \n> > You updated the bindings, but not the driver. So it's not actually\n> > going to work. More specifically, OOB interrupts won't work.\n> >\n> \n> understood, ignore this patch for now. Thanks Chen-Yu.\n> \n> > IIRC, The compatible string for this particular case, as it was\n> > originally proposed, only serves as a placeholder for the driver\n> > to check against. None of the instances in sunxi device trees\n> > match the actual chip model. Actual model matching is done\n> > through SDIO, as you've already seen.\n> \n> yes it seems SDIO driveer code is smarter, once it initialize \n> brcm,bcm4329-fmac it ignore the DT info and read the chip details to locate \n> firmware file.\n> \n> I also noticed other boards using bcm4329-fmac in similar situations.\n> https://patchwork.kernel.org/patch/9739181/\n> \n> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts?h=v4.13-rc7\n> \n> I will resend \"NanoPi NEO Plus2\" dts with \"brcm,bcm4329-fmac\" and see where \n> it goes. \n\nAdding the compatible or instead of? The former would be better. You \nshould still have the actual chip in case you do have some difference to \nhandle.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkQF83Hqpz9t2x\n\tfor ;\n\tSat, 2 Sep 2017 02:49:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752118AbdIAQtO (ORCPT\n\t);\n\tFri, 1 Sep 2017 12:49:14 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:37173 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751863AbdIAQtO (ORCPT\n\t); Fri, 1 Sep 2017 12:49:14 -0400","by mail-oi0-f68.google.com with SMTP id b184so590781oih.4;\n\tFri, 01 Sep 2017 09:49:13 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tq84sm525602oif.45.2017.09.01.09.49.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 09:49:12 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=hNMiBPweO4f3WSUhd4yiBrLghPMyxRh3XzLUxxzH8d4=;\n\tb=LCgHCEDf3orWnpCudflhwWdWohuWfNKR3oPGsOPgk1iO1HFZR8mjOtz9xin98SBROh\n\tw/k/snFqJdHvaxRtJTQNehWG7bZA1SA74pUXJbCUPi+Y5GqIJGT5qY13dHgVay5QVnLg\n\t+zsy0w4HnC/Chrs6GaroDZv17wmtBshgDPDnV6fuHxLaXeJNBcIfqUbuNO/tpvgkDtm6\n\tWplyAhrte6Qx7BTy8wn0g6Dsl8apzqtkIPFUKm1/5U14ii16NNQVVmdcMFjb/SlEPUxI\n\tuiPS8Q0V7svN/8sM4vrFJZUkzbCEZRFpbJEeCJ9fsz7ZaEbYDG7bdKuAYALnIV/9DBy6\n\tDmiw==","X-Gm-Message-State":"AHPjjUjuifcRvqTJXfP/UPhmNhdosRw+Bjjgk8GVgGzDOwH2GBoh0vEq\n\tRb4QH39DIRjdnQ==","X-Google-Smtp-Source":"ADKCNb5RkiPm1YdSM/Lar+0FJdPtIn2RU7hOIB6VtTFqRKG+T4FbhOemshiym82ZE1MbPU03Iw18NQ==","X-Received":"by 10.202.72.17 with SMTP id v17mr2226096oia.127.1504284553322; \n\tFri, 01 Sep 2017 09:49:13 -0700 (PDT)","Date":"Fri, 1 Sep 2017 11:49:11 -0500","From":"Rob Herring ","To":"Antony Antony ","Cc":"Chen-Yu Tsai , Kalle Valo ,\n\tMark Rutland , Icenowy Zheng , \n\tdevicetree ,\n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","Message-ID":"<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1761926,"web_url":"http://patchwork.ozlabs.org/comment/1761926/","msgid":"","list_archive_url":null,"date":"2017-09-01T19:10:41","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":68761,"url":"http://patchwork.ozlabs.org/api/people/68761/","name":"Arend van Spriel","email":"arend.vanspriel@broadcom.com"},"content":"On 01-09-17 18:49, Rob Herring wrote:\n> On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote:\n>> hi,\n>>\n>> On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote:\n>>> On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote:\n>>\n>>>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>> @@ -6,7 +6,9 @@ connects the device to the system.\n>>>>\n>>>> Required properties:\n>>>>\n>>>> - - compatible : Should be \"brcm,bcm4329-fmac\".\n>>>> + - compatible : should be one of the following:\n>>>> + * \"brcm,bcm4329-fmac\"\n>>>> + * \"brcm,bcm43430-fmac\"\n>>>\n>>> You updated the bindings, but not the driver. So it's not actually\n>>> going to work. More specifically, OOB interrupts won't work.\n>>>\n>>\n>> understood, ignore this patch for now. Thanks Chen-Yu.\n>>\n>>> IIRC, The compatible string for this particular case, as it was\n>>> originally proposed, only serves as a placeholder for the driver\n>>> to check against. None of the instances in sunxi device trees\n>>> match the actual chip model. Actual model matching is done\n>>> through SDIO, as you've already seen.\n>>\n>> yes it seems SDIO driveer code is smarter, once it initialize\n>> brcm,bcm4329-fmac it ignore the DT info and read the chip details to locate\n>> firmware file.\n>>\n>> I also noticed other boards using bcm4329-fmac in similar situations.\n>> https://patchwork.kernel.org/patch/9739181/\n>>\n>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts?h=v4.13-rc7\n>>\n>> I will resend \"NanoPi NEO Plus2\" dts with \"brcm,bcm4329-fmac\" and see where\n>> it goes.\n> \n> Adding the compatible or instead of? The former would be better. You\n> should still have the actual chip in case you do have some difference to\n> handle.\n\nHi Rob,\n\nActually the Broadcom wifi chips themselves are discoverable. So once \nthe driver has access to the register space of the device it can \ndetermine the actual chip, its revision, and exactly what cores (and \ntheir revision) are present in the chip. Hence there is a single \ncompatible string as there is no need to convey the same information \nthrough device tree data.\n\nRegards,\nArend\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"AWRmm6K8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkTNS0K8Dz9sPm\n\tfor ;\n\tSat, 2 Sep 2017 05:10:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752392AbdIATKp (ORCPT\n\t);\n\tFri, 1 Sep 2017 15:10:45 -0400","from mail-wr0-f171.google.com ([209.85.128.171]:36168 \"EHLO\n\tmail-wr0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752367AbdIATKo (ORCPT\n\t); Fri, 1 Sep 2017 15:10:44 -0400","by mail-wr0-f171.google.com with SMTP id p14so2689042wrg.3\n\tfor ;\n\tFri, 01 Sep 2017 12:10:44 -0700 (PDT)","from [10.177.251.201] ([192.19.248.250])\n\tby smtp.gmail.com with ESMTPSA id\n\tr12sm789050wrr.28.2017.09.01.12.10.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 12:10:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=WsIsADFaZ7HEtXFr87Xay5AfEncfY6lDYQncxVGffv8=;\n\tb=AWRmm6K8uDLEFX6Ls3elhIslqoHytqq0aIcWOqr6SCUcHZb5Bc39CNZv3dP4vTGyJR\n\tUsOqUyuvdMTTvM9zeweyXY8hhqJ+gVKFX9MZOjRsXER2pTYAleSKqDBQtlNBUQppby8W\n\t7FdZsdNJ3zJcj2ZigcWglKv5ssGr7UeaRC90c=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=WsIsADFaZ7HEtXFr87Xay5AfEncfY6lDYQncxVGffv8=;\n\tb=HXll2NVGK4ms7/3akqIEwVOFBcRq4tgMasL6nHokd+J05LEbKVneix3kY1DR7vy/IV\n\tWUB0hS+m2ZYKZMvRfJqDAgU92nkq22na1HWsKArwJ0in3TYuip93mIizDGPVHrIVOizm\n\tVmpJY293Fp2VP4omX71MXhJuP8TIYH+o/GXYmYFkRN/C7LJzHLQ0GPFdPHphec4gvNXV\n\tFYxNjtk+IY/j6hU6tmaCTRL5glZ4u5au24RLm6JKK6RK69GIkY0LqvEg8KdJXKIMHMcy\n\t3l4+1qqpXN9izsMRBvIEzsMGIvCLNYoZsDXY/qg6PUkA5TdOLD/AcbfUhn/vgZkQHiu4\n\tKFmQ==","X-Gm-Message-State":"AHPjjUhC7HLuofQL6fVHoaZ97xbQLhcURxonL6xWM+cznLUbGz6NHTNZ\n\tlRVxLHDg7lffxrMO","X-Google-Smtp-Source":"ADKCNb4hnP2LJW34U9fe1DmcC7x8YztRnROi9JNnzesrrSY2v1DjJwK9yZfg7ZN8YQsVvuYRgHaOGw==","X-Received":"by 10.223.186.69 with SMTP id t5mr2060739wrg.165.1504293043395; \n\tFri, 01 Sep 2017 12:10:43 -0700 (PDT)","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","To":"Rob Herring , Antony Antony ","Cc":"Chen-Yu Tsai , Kalle Valo ,\n\tMark Rutland , Icenowy Zheng , \n\tdevicetree ,\n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>\n\t<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>","From":"Arend van Spriel ","Message-ID":"","Date":"Fri, 1 Sep 2017 21:10:41 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1761972,"web_url":"http://patchwork.ozlabs.org/comment/1761972/","msgid":"<20170901204030.2zpsoa4i53tdegs3@AntonyAntony.local>","list_archive_url":null,"date":"2017-09-01T20:40:30","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":71638,"url":"http://patchwork.ozlabs.org/api/people/71638/","name":"Antony Antony","email":"antony@phenome.org"},"content":"On Fri, Sep 01, 2017 at 09:10:41PM +0200, Arend van Spriel wrote:\n> On 01-09-17 18:49, Rob Herring wrote:\n> > On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote:\n> > > hi,\n> > > \n> > > On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote:\n> > > > On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote:\n> > > \n> > > > > a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> > > > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n> > > > > @@ -6,7 +6,9 @@ connects the device to the system.\n> > > > > \n> > > > > Required properties:\n> > > > > \n> > > > > - - compatible : Should be \"brcm,bcm4329-fmac\".\n> > > > > + - compatible : should be one of the following:\n> > > > > + * \"brcm,bcm4329-fmac\"\n> > > > > + * \"brcm,bcm43430-fmac\"\n> > > > \n> > > > You updated the bindings, but not the driver. So it's not actually\n> > > > going to work. More specifically, OOB interrupts won't work.\n> > > > \n> > > \n> > > understood, ignore this patch for now. Thanks Chen-Yu.\n> > > \n> > > > IIRC, The compatible string for this particular case, as it was\n> > > > originally proposed, only serves as a placeholder for the driver\n> > > > to check against. None of the instances in sunxi device trees\n> > > > match the actual chip model. Actual model matching is done\n> > > > through SDIO, as you've already seen.\n> > > \n> > > yes it seems SDIO driveer code is smarter, once it initialize\n> > > brcm,bcm4329-fmac it ignore the DT info and read the chip details to locate\n> > > firmware file.\n> > > \n> > > I also noticed other boards using bcm4329-fmac in similar situations.\n> > > https://patchwork.kernel.org/patch/9739181/\n> > > \n> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts?h=v4.13-rc7\n> > > \n> > > I will resend \"NanoPi NEO Plus2\" dts with \"brcm,bcm4329-fmac\" and see where\n> > > it goes.\n> > \n> > Adding the compatible or instead of? The former would be better. You\n> > should still have the actual chip in case you do have some difference to\n> > handle.\n> \n> Hi Rob,\n> \n> Actually the Broadcom wifi chips themselves are discoverable. So once the\n> driver has access to the register space of the device it can determine the\n> actual chip, its revision, and exactly what cores (and their revision) are\n> present in the chip. Hence there is a single compatible string as there is\n> no need to convey the same information through device tree data.\n\nIn my expereince this how it seems to work.\n\nI jsut discovered s/brcm,bcm4329-fmac/brcm/ can load the broadcom driver.\n\nbrcmf: wifi@1 {\n\treg = <1>;\n\tcompatible = \"brcm\";\n}; \n\nThis looks better to me. Maxime, Would this work? \n\nregards,\n-antony\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkWN65D24z9sPt\n\tfor ;\n\tSat, 2 Sep 2017 06:40:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752393AbdIAUkg (ORCPT\n\t);\n\tFri, 1 Sep 2017 16:40:36 -0400","from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:39834 \"EHLO\n\tlb2-smtp-cloud9.xs4all.net\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752367AbdIAUkg (ORCPT\n\t); Fri, 1 Sep 2017 16:40:36 -0400","from AntonyAntony.local ([83.163.117.153])\n\tby smtp-cloud9.xs4all.net with ESMTPSA\n\tid nsjudiIFfdRLjnsjvdNbcY; Fri, 01 Sep 2017 22:40:33 +0200"],"Date":"Fri, 1 Sep 2017 22:40:30 +0200","From":"Antony Antony ","To":"Arend van Spriel ","Cc":"Rob Herring , Antony Antony ,\n\tChen-Yu Tsai , Kalle Valo ,\n\tMark Rutland , Icenowy Zheng , \n\tdevicetree ,\n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","Message-ID":"<20170901204030.2zpsoa4i53tdegs3@AntonyAntony.local>","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>\n\t<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170602 (1.8.3)","X-CMAE-Envelope":"MS4wfNYHAl8K837u8GLRHQu5NItshsFdvE3wyNjEAJ1BMFZyinfp6P+CbHedkipuOrRyt4lEPLPKs+B+Lm6X/QKkwn1F5+SwBUcRdjHl6DkeWlFFNe0c9ynz\n\tHZLBi0LpvC3Tpr0K+oGnoFYnnNR3O6/bS6N9lOF0WurmuOOxax386VYKusJEiYhocwQGen8gbKEuCd08f/wx7IMMPPO34OcggwUjK3kiqX7MAoXxSgaudVal\n\tTW3eMqEQ6biJthbXvZpjSAZFj/QiDpWZ2sWLJDsSXOvJ5zeKAfblcRqzW4HPrKwbg8VKj16xo04CSHQqXKsTqjCNrCFjGFhIPZc7m0H+7LdQZZCkOdYFazrj\n\taH6zq1q9lAWGhMYy0Rxt4KVWRFSvdWsARKIzg4e4/bdlFoArnPGjxTSfblPV4XhDbZdjLHsf7V2G5yafK+2OBDhDoOdbL1sWARONw7rsve+k0sylNd27go8J\n\t9bg7mx6DW5eRG+lX4vIyVmQFMp4rQScLc+IvPw==","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1761996,"web_url":"http://patchwork.ozlabs.org/comment/1761996/","msgid":"<8af0e096-f4b1-213f-d543-fa711e1961ad@broadcom.com>","list_archive_url":null,"date":"2017-09-01T21:30:59","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":68761,"url":"http://patchwork.ozlabs.org/api/people/68761/","name":"Arend van Spriel","email":"arend.vanspriel@broadcom.com"},"content":"On 01-09-17 22:40, Antony Antony wrote:\n> On Fri, Sep 01, 2017 at 09:10:41PM +0200, Arend van Spriel wrote:\n>> On 01-09-17 18:49, Rob Herring wrote:\n>>> On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote:\n>>>> hi,\n>>>>\n>>>> On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote:\n>>>>> On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony wrote:\n>>>>\n>>>>>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>>>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>>>> @@ -6,7 +6,9 @@ connects the device to the system.\n>>>>>>\n>>>>>> Required properties:\n>>>>>>\n>>>>>> - - compatible : Should be \"brcm,bcm4329-fmac\".\n>>>>>> + - compatible : should be one of the following:\n>>>>>> + * \"brcm,bcm4329-fmac\"\n>>>>>> + * \"brcm,bcm43430-fmac\"\n>>>>>\n>>>>> You updated the bindings, but not the driver. So it's not actually\n>>>>> going to work. More specifically, OOB interrupts won't work.\n>>>>>\n>>>>\n>>>> understood, ignore this patch for now. Thanks Chen-Yu.\n>>>>\n>>>>> IIRC, The compatible string for this particular case, as it was\n>>>>> originally proposed, only serves as a placeholder for the driver\n>>>>> to check against. None of the instances in sunxi device trees\n>>>>> match the actual chip model. Actual model matching is done\n>>>>> through SDIO, as you've already seen.\n>>>>\n>>>> yes it seems SDIO driveer code is smarter, once it initialize\n>>>> brcm,bcm4329-fmac it ignore the DT info and read the chip details to locate\n>>>> firmware file.\n>>>>\n>>>> I also noticed other boards using bcm4329-fmac in similar situations.\n>>>> https://patchwork.kernel.org/patch/9739181/\n>>>>\n>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts?h=v4.13-rc7\n>>>>\n>>>> I will resend \"NanoPi NEO Plus2\" dts with \"brcm,bcm4329-fmac\" and see where\n>>>> it goes.\n>>>\n>>> Adding the compatible or instead of? The former would be better. You\n>>> should still have the actual chip in case you do have some difference to\n>>> handle.\n>>\n>> Hi Rob,\n>>\n>> Actually the Broadcom wifi chips themselves are discoverable. So once the\n>> driver has access to the register space of the device it can determine the\n>> actual chip, its revision, and exactly what cores (and their revision) are\n>> present in the chip. Hence there is a single compatible string as there is\n>> no need to convey the same information through device tree data.\n> \n> In my expereince this how it seems to work.\n> \n> I jsut discovered s/brcm,bcm4329-fmac/brcm/ can load the broadcom driver.\n> \n> brcmf: wifi@1 {\n> \treg = <1>;\n> \tcompatible = \"brcm\";\n> };\n> \n> This looks better to me. Maxime, Would this work?\n\nI have no idea what you are saying here. To what exactly do you apply \nthat substitute. In brcmfmac I have:\n\n if (!np || bus_type != BRCMF_BUSTYPE_SDIO ||\n !of_device_is_compatible(np, \"brcm,bcm4329-fmac\"))\n return;\n\nIn my perception using \"brcm\" goes against DT compatible naming convention.\n\nRegards,\nArend\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"OgM67/Hh\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkXVS0ScPz9sQl\n\tfor ;\n\tSat, 2 Sep 2017 07:31:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752473AbdIAVbI (ORCPT\n\t);\n\tFri, 1 Sep 2017 17:31:08 -0400","from mail-wm0-f51.google.com ([74.125.82.51]:35061 \"EHLO\n\tmail-wm0-f51.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752423AbdIAVbB (ORCPT\n\t); Fri, 1 Sep 2017 17:31:01 -0400","by mail-wm0-f51.google.com with SMTP id v2so8313038wmf.0\n\tfor ;\n\tFri, 01 Sep 2017 14:31:01 -0700 (PDT)","from [192.168.178.39] (f140230.upc-f.chello.nl. [80.56.140.230])\n\tby smtp.gmail.com with ESMTPSA id\n\ta10sm623724eda.17.2017.09.01.14.30.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 14:31:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=+enEOzHlCymKn3OtmWvDBup4mRtxKGqXjQmXL/TxORc=;\n\tb=OgM67/Hh5qiDlltzQicYIqQNtI4Hw58wrDiUd3eysLWOtyrcEIqMsliG2Skxoh0n3a\n\t+JwPahheky1oOlnRaWzcG04vy7N04MpI4ro+u5VRHwbb+OwYD2P+npp+W+TITp23awOP\n\tsLnVhIOlGEvGj3J9e3R+Hy4PCls/aUlFi4v5A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=+enEOzHlCymKn3OtmWvDBup4mRtxKGqXjQmXL/TxORc=;\n\tb=AI5p8rKiaNb3WZwx+dD6bPxs4q+dneElyaSD8Q4aMKBuNhXVzZfOVYiWhbfUlpUSCs\n\th+HatGbZE5UENuL1LIMJhVInhl/UDvGETOcxqe1ZLATGOnDIcL+NdfKlxiEDoot18b85\n\ttE6m9x3nXDjI/hbZPn12xxE0r3sqZS/gI6/QBwaf7J0d6kIFmX/XRJwwtJlzxFeBzkPe\n\tAHtsCtjS/Nk3sScKJ2t6Omhuu/rZquNh1+4U0axKOlaHZqa0bIj+xlh+iOSR2Jj1LYl1\n\tZjxNlF2aClWefX02TbHjxo2C3+p0E+gieBOls/QFb2C6pVaM6cacfdb3UbmM09zD2HaB\n\tPFcw==","X-Gm-Message-State":"AHPjjUin6Tu8H8SwzGL3H3sDmDtHfMs0BXpt3coCyAlyxypUNBA65okD\n\tUWrOAA9pR/KFNlqc","X-Google-Smtp-Source":"ADKCNb5XAJqp7kv8J28zgM3NRCwf3fhC3j/X/EAhDzPodjBUzOFLetrZOrwByIWHk5t0/urZaWV6hQ==","X-Received":"by 10.80.182.213 with SMTP id f21mr2819209ede.10.1504301460548; \n\tFri, 01 Sep 2017 14:31:00 -0700 (PDT)","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","To":"Antony Antony ","Cc":"Rob Herring , Chen-Yu Tsai ,\n\tKalle Valo , Mark Rutland ,\n\tIcenowy Zheng ,\n\tdevicetree , \n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>\n\t<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>\n\t\n\t<20170901204030.2zpsoa4i53tdegs3@AntonyAntony.local>","From":"Arend van Spriel ","Message-ID":"<8af0e096-f4b1-213f-d543-fa711e1961ad@broadcom.com>","Date":"Fri, 1 Sep 2017 23:30:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901204030.2zpsoa4i53tdegs3@AntonyAntony.local>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762004,"web_url":"http://patchwork.ozlabs.org/comment/1762004/","msgid":"","list_archive_url":null,"date":"2017-09-01T21:38:32","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, Sep 1, 2017 at 2:10 PM, Arend van Spriel\n wrote:\n> On 01-09-17 18:49, Rob Herring wrote:\n>>\n>> On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote:\n>>>\n>>> hi,\n>>>\n>>> On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote:\n>>>>\n>>>> On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony \n>>>> wrote:\n>>>\n>>>\n>>>>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>>> +++\n>>>>> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>>> @@ -6,7 +6,9 @@ connects the device to the system.\n>>>>>\n>>>>> Required properties:\n>>>>>\n>>>>> - - compatible : Should be \"brcm,bcm4329-fmac\".\n>>>>> + - compatible : should be one of the following:\n>>>>> + * \"brcm,bcm4329-fmac\"\n>>>>> + * \"brcm,bcm43430-fmac\"\n>>>>\n>>>>\n>>>> You updated the bindings, but not the driver. So it's not actually\n>>>> going to work. More specifically, OOB interrupts won't work.\n>>>>\n>>>\n>>> understood, ignore this patch for now. Thanks Chen-Yu.\n>>>\n>>>> IIRC, The compatible string for this particular case, as it was\n>>>> originally proposed, only serves as a placeholder for the driver\n>>>> to check against. None of the instances in sunxi device trees\n>>>> match the actual chip model. Actual model matching is done\n>>>> through SDIO, as you've already seen.\n>>>\n>>>\n>>> yes it seems SDIO driveer code is smarter, once it initialize\n>>> brcm,bcm4329-fmac it ignore the DT info and read the chip details to\n>>> locate\n>>> firmware file.\n>>>\n>>> I also noticed other boards using bcm4329-fmac in similar situations.\n>>> https://patchwork.kernel.org/patch/9739181/\n>>>\n>>>\n>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts?h=v4.13-rc7\n>>>\n>>> I will resend \"NanoPi NEO Plus2\" dts with \"brcm,bcm4329-fmac\" and see\n>>> where\n>>> it goes.\n>>\n>>\n>> Adding the compatible or instead of? The former would be better. You\n>> should still have the actual chip in case you do have some difference to\n>> handle.\n>\n>\n> Hi Rob,\n>\n> Actually the Broadcom wifi chips themselves are discoverable. So once the\n> driver has access to the register space of the device it can determine the\n> actual chip, its revision, and exactly what cores (and their revision) are\n> present in the chip. Hence there is a single compatible string as there is\n> no need to convey the same information through device tree data.\n\nSo if a chip has different power on/off sequencing you can discover that?\n\nI realize that most often you don't need it, but a more specific\ncompatible is there in case you do and so it doesn't require a DTB\nupdate to handle some difference. But you can keep using one\ncompatible because I can't really enforce any of that.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkXgN61Y1z9sRY\n\tfor ;\n\tSat, 2 Sep 2017 07:38:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752554AbdIAViz (ORCPT\n\t);\n\tFri, 1 Sep 2017 17:38:55 -0400","from mail.kernel.org ([198.145.29.99]:39084 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752503AbdIAViy (ORCPT );\n\tFri, 1 Sep 2017 17:38:54 -0400","from mail-qk0-f179.google.com (mail-qk0-f179.google.com\n\t[209.85.220.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id E718921BB7;\n\tFri, 1 Sep 2017 21:38:53 +0000 (UTC)","by mail-qk0-f179.google.com with SMTP id k126so6070512qkb.4;\n\tFri, 01 Sep 2017 14:38:53 -0700 (PDT)","by 10.12.153.1 with HTTP; Fri, 1 Sep 2017 14:38:32 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org E718921BB7","X-Gm-Message-State":"AHPjjUhgmGo8HZ1zKDJvd4cx5Kikxbr1/NVSrwksT42Ql2R8G9qL+VPZ\n\tBk1LBSp/nsmlE7vfRIOkm5+ikG8R9A==","X-Google-Smtp-Source":"ADKCNb4CubtG5gFupeS7+U+1V7MwUPNTZpFL2SD44607Q0wEe04c/iWmhdiZBPjEBS1mmyMltuqlBvo0PBVuidSg2JI=","X-Received":"by 10.55.126.195 with SMTP id z186mr4551963qkc.210.1504301933043;\n\tFri, 01 Sep 2017 14:38:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>\n\t<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>\n\t","From":"Rob Herring ","Date":"Fri, 1 Sep 2017 16:38:32 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","To":"Arend van Spriel ","Cc":"Antony Antony , Chen-Yu Tsai ,\n\tKalle Valo , Mark Rutland ,\n\tIcenowy Zheng ,\n\tdevicetree , \n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762007,"web_url":"http://patchwork.ozlabs.org/comment/1762007/","msgid":"<73188868-3809-b94e-d08b-56b83b981558@broadcom.com>","list_archive_url":null,"date":"2017-09-01T22:01:43","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":68761,"url":"http://patchwork.ozlabs.org/api/people/68761/","name":"Arend van Spriel","email":"arend.vanspriel@broadcom.com"},"content":"On 01-09-17 23:38, Rob Herring wrote:\n> On Fri, Sep 1, 2017 at 2:10 PM, Arend van Spriel\n> wrote:\n>> On 01-09-17 18:49, Rob Herring wrote:\n>>>\n>>> On Wed, Aug 30, 2017 at 02:02:18PM +0200, Antony Antony wrote:\n>>>>\n>>>> hi,\n>>>>\n>>>> On Wed, Aug 30, 2017 at 10:28:20AM +0800, Chen-Yu Tsai wrote:\n>>>>>\n>>>>> On Wed, Aug 30, 2017 at 5:43 AM, Antony Antony \n>>>>> wrote:\n>>>>\n>>>>\n>>>>>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>>>> +++\n>>>>>> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt\n>>>>>> @@ -6,7 +6,9 @@ connects the device to the system.\n>>>>>>\n>>>>>> Required properties:\n>>>>>>\n>>>>>> - - compatible : Should be \"brcm,bcm4329-fmac\".\n>>>>>> + - compatible : should be one of the following:\n>>>>>> + * \"brcm,bcm4329-fmac\"\n>>>>>> + * \"brcm,bcm43430-fmac\"\n>>>>>\n>>>>>\n>>>>> You updated the bindings, but not the driver. So it's not actually\n>>>>> going to work. More specifically, OOB interrupts won't work.\n>>>>>\n>>>>\n>>>> understood, ignore this patch for now. Thanks Chen-Yu.\n>>>>\n>>>>> IIRC, The compatible string for this particular case, as it was\n>>>>> originally proposed, only serves as a placeholder for the driver\n>>>>> to check against. None of the instances in sunxi device trees\n>>>>> match the actual chip model. Actual model matching is done\n>>>>> through SDIO, as you've already seen.\n>>>>\n>>>>\n>>>> yes it seems SDIO driveer code is smarter, once it initialize\n>>>> brcm,bcm4329-fmac it ignore the DT info and read the chip details to\n>>>> locate\n>>>> firmware file.\n>>>>\n>>>> I also noticed other boards using bcm4329-fmac in similar situations.\n>>>> https://patchwork.kernel.org/patch/9739181/\n>>>>\n>>>>\n>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dts?h=v4.13-rc7\n>>>>\n>>>> I will resend \"NanoPi NEO Plus2\" dts with \"brcm,bcm4329-fmac\" and see\n>>>> where\n>>>> it goes.\n>>>\n>>>\n>>> Adding the compatible or instead of? The former would be better. You\n>>> should still have the actual chip in case you do have some difference to\n>>> handle.\n>>\n>>\n>> Hi Rob,\n>>\n>> Actually the Broadcom wifi chips themselves are discoverable. So once the\n>> driver has access to the register space of the device it can determine the\n>> actual chip, its revision, and exactly what cores (and their revision) are\n>> present in the chip. Hence there is a single compatible string as there is\n>> no need to convey the same information through device tree data.\n> \n> So if a chip has different power on/off sequencing you can discover that?\n> \n> I realize that most often you don't need it, but a more specific\n> compatible is there in case you do and so it doesn't require a DTB\n> update to handle some difference. But you can keep using one\n> compatible because I can't really enforce any of that.\n\nFor SDIO chips the power sequencing is defined by power-seq-* in \nbindings/mmc and handled by the MMC stack itself. So the wifi driver is \nnot dealing with that.\n\nRegards,\nArend\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"UyyoBrPL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkY9m0ygwz9sQl\n\tfor ;\n\tSat, 2 Sep 2017 08:01:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752582AbdIAWBr (ORCPT\n\t);\n\tFri, 1 Sep 2017 18:01:47 -0400","from mail-wm0-f46.google.com ([74.125.82.46]:36401 \"EHLO\n\tmail-wm0-f46.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752519AbdIAWBq (ORCPT\n\t); Fri, 1 Sep 2017 18:01:46 -0400","by mail-wm0-f46.google.com with SMTP id f127so8502271wmf.1\n\tfor ;\n\tFri, 01 Sep 2017 15:01:45 -0700 (PDT)","from [192.168.178.39] (f140230.upc-f.chello.nl. [80.56.140.230])\n\tby smtp.gmail.com with ESMTPSA id\n\tx37sm741605edx.3.2017.09.01.15.01.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 15:01:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=3DKcgmFNUOJZswGyUoxrRS14sRMzBOgNo9zmD8Se2lo=;\n\tb=UyyoBrPLnnIqZ2ZSE+RcP/0uU5qe8jl3+A5UXjULoh4v7NFy1hHVsNn6I6kRBH2UfD\n\toZGNh0or40tJyOjLkmK7ylP/TMdHUD9LrtxyvVyGhJ/gTVFLdsnqkw7tyHUAFKuxenQy\n\tRq9K+Q0zxWfnAOjoiV1TOoqlgFZ/j5ypFt3YU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=3DKcgmFNUOJZswGyUoxrRS14sRMzBOgNo9zmD8Se2lo=;\n\tb=WMbtjetSmDUiVnBcKqtGLGdlUhGjO0crWc4/uCz3GhRrxOVgcc/iuKx1dz4RTqra5y\n\tuNTCaXtqAcrZBGT6jF5gNSEwjI393DQ8ozv4CFIGHgZg2K8yNUm4vi4yYmz5NqID0Gl/\n\t7I/KDo8U8WYbdrftm8TwKChK7nV/BBhUqrhoa2SPJt9Y1b6GNV/uI7DvDhM7QzuAGxLL\n\tKj/1JdReFNmgly8G5atKYue4B7eSQTgNZYjZ/IUJG+o3x53UU1wIYhQpQeQM3Ar+3wDh\n\tvxbv4l1CCdCSAoc0q5q2RPZdXkXdpSHrmklBnOSrWNGD6nA2xqyEZczLM69UESJFHJkB\n\tnyBw==","X-Gm-Message-State":"AHPjjUhtroiSDkr7FWYuChOmCcPOsMiMZiHN6XqmsYQVudQRHMs/UroU\n\tgSGjKgUb9YZHik+6","X-Google-Smtp-Source":"ADKCNb7cbmT8a2nxgwKCa0AJX2p6ioLjWO1MMzgw7iLk4Jc3VsG4JoLsrpfK/TDxAQRCO7ZyzYPlPg==","X-Received":"by 10.80.144.234 with SMTP id d39mr2824246eda.164.1504303304954; \n\tFri, 01 Sep 2017 15:01:44 -0700 (PDT)","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","To":"Rob Herring ","Cc":"Antony Antony , Chen-Yu Tsai ,\n\tKalle Valo , Mark Rutland ,\n\tIcenowy Zheng ,\n\tdevicetree , \n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>\n\t<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>\n\t\n\t","From":"Arend van Spriel ","Message-ID":"<73188868-3809-b94e-d08b-56b83b981558@broadcom.com>","Date":"Sat, 2 Sep 2017 00:01:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762696,"web_url":"http://patchwork.ozlabs.org/comment/1762696/","msgid":"<20170904144230.yuadvqiruj73q5t3@AntonyAntony.local>","list_archive_url":null,"date":"2017-09-04T14:42:30","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":71638,"url":"http://patchwork.ozlabs.org/api/people/71638/","name":"Antony Antony","email":"antony@phenome.org"},"content":"Hi Arend,\n\nOn Fri, Sep 01, 2017 at 11:30:59PM +0200, Arend van Spriel wrote:\n> > > Hi Rob,\n> > > \n> > > Actually the Broadcom wifi chips themselves are discoverable. So once the\n> > > driver has access to the register space of the device it can determine the\n> > > actual chip, its revision, and exactly what cores (and their revision) are\n> > > present in the chip. Hence there is a single compatible string as there is\n> > > no need to convey the same information through device tree data.\n> > \n> > In my expereince this how it seems to work.\n> > \n> > I jsut discovered s/brcm,bcm4329-fmac/brcm/ can load the broadcom driver.\n> > \n> > brcmf: wifi@1 {\n> > \treg = <1>;\n> > \tcompatible = \"brcm\";\n> > };\n> > \n> > This looks better to me. Maxime, Would this work?\n> \n> I have no idea what you are saying here. To what exactly do you apply that\n> substitute. In brcmfmac I have: \n\nThanks for pointing me to the relevent code. I was asking about DT support I \nsubmitted. \n\n> \n> if (!np || bus_type != BRCMF_BUSTYPE_SDIO ||\n> !of_device_is_compatible(np, \"brcm,bcm4329-fmac\"))\n> return;\n> \n> In my perception using \"brcm\" goes against DT compatible naming convention.\n\nIt seems the driver has a special place holder, bcm4329-fmac.\nI am still wondering what is acceptable in the DT. \n\ncompatible = \"\"brcm,bcm4329-fmac\";\nor \ncompatible = \"brcm\";\n\nThe last one does not generate any warnings.\nHere it the DT I am proposing. https://patchwork.kernel.org/patch/9937263/\n\nregards,\n-antony\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmCHh1qQBz9sNc\n\tfor ;\n\tTue, 5 Sep 2017 00:42:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753697AbdIDOmi (ORCPT\n\t);\n\tMon, 4 Sep 2017 10:42:38 -0400","from lb2-smtp-cloud8.xs4all.net ([194.109.24.25]:40588 \"EHLO\n\tlb2-smtp-cloud8.xs4all.net\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753706AbdIDOmh (ORCPT\n\t); Mon, 4 Sep 2017 10:42:37 -0400","from AntonyAntony.local ([83.163.117.153])\n\tby smtp-cloud8.xs4all.net with ESMTPSA\n\tid osa8dR4OecQyLosaAdMJgT; Mon, 04 Sep 2017 16:42:36 +0200"],"Date":"Mon, 4 Sep 2017 16:42:30 +0200","From":"Antony Antony ","To":"Arend van Spriel ","Cc":"Antony Antony , Rob Herring ,\n\tChen-Yu Tsai , Kalle Valo ,\n\tMark Rutland , Icenowy Zheng , \n\tdevicetree ,\n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","Message-ID":"<20170904144230.yuadvqiruj73q5t3@AntonyAntony.local>","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>\n\t<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>\n\t\n\t<20170901204030.2zpsoa4i53tdegs3@AntonyAntony.local>\n\t<8af0e096-f4b1-213f-d543-fa711e1961ad@broadcom.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<8af0e096-f4b1-213f-d543-fa711e1961ad@broadcom.com>","User-Agent":"NeoMutt/20170602 (1.8.3)","X-CMAE-Envelope":"MS4wfIvPmEdI/kDMmZIYCTwbJ3hOCykQc7uDvc/J3QGg8BsfkJydsxZ8HB/wGgVlUGxh7GDHysa0CefLltC/PHSYyOg/x/hPYKPI2VJfc6Ku2NUYUg2ARoZa\n\t9v9wV5H962iynHJ5k8ZxDSrzPT+UBNTV7U5tFvFfkPs1spZ3VyYQWRvNsTeTA0m6o81KcTYXfg81JlTCt2Ng+Pg6jC/T8al0iA6ZfLm2fPR6/ZF/IniC635y\n\tth/47HeWOE9pbH8p6NkGe7c+FgvuLsyp4gEbui59nU6cAB05AlSJUueZFoizEhb4cykT7UJpyQNrh5BKH6W0uqNWQnmwwvJzuiPKcV2forkWiHxb6GnVWS/c\n\tuGnjFk+ooRH0Hrv0xrqlgJ9LtT9fA1+svehLCyZKc7O0twjRZpwKEIUf0EMu5hdLeMX3Jvd6CRWPlc7pgeY+Vd6c2K6SKX9a3jsaENe8K2tOD7X7/i5KI8uB\n\tN8NZXV6yYLk+GnTWeOHxvPL6xCrZMWDRSxFuZw==","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762810,"web_url":"http://patchwork.ozlabs.org/comment/1762810/","msgid":"<7f07455d-88b6-3ab5-4cdd-dc38e019ac2a@broadcom.com>","list_archive_url":null,"date":"2017-09-04T17:37:15","subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","submitter":{"id":68761,"url":"http://patchwork.ozlabs.org/api/people/68761/","name":"Arend van Spriel","email":"arend.vanspriel@broadcom.com"},"content":"On 04-09-17 16:42, Antony Antony wrote:\n> Hi Arend,\n> \n> On Fri, Sep 01, 2017 at 11:30:59PM +0200, Arend van Spriel wrote:\n>>>> Hi Rob,\n>>>>\n>>>> Actually the Broadcom wifi chips themselves are discoverable. So once the\n>>>> driver has access to the register space of the device it can determine the\n>>>> actual chip, its revision, and exactly what cores (and their revision) are\n>>>> present in the chip. Hence there is a single compatible string as there is\n>>>> no need to convey the same information through device tree data.\n>>>\n>>> In my expereince this how it seems to work.\n>>>\n>>> I jsut discovered s/brcm,bcm4329-fmac/brcm/ can load the broadcom driver.\n>>>\n>>> brcmf: wifi@1 {\n>>> \treg = <1>;\n>>> \tcompatible = \"brcm\";\n>>> };\n>>>\n>>> This looks better to me. Maxime, Would this work?\n>>\n>> I have no idea what you are saying here. To what exactly do you apply that\n>> substitute. In brcmfmac I have:\n> \n> Thanks for pointing me to the relevent code. I was asking about DT support I\n> submitted.\n> \n>>\n>> if (!np || bus_type != BRCMF_BUSTYPE_SDIO ||\n>> !of_device_is_compatible(np, \"brcm,bcm4329-fmac\"))\n>> return;\n>>\n>> In my perception using \"brcm\" goes against DT compatible naming convention.\n> \n> It seems the driver has a special place holder, bcm4329-fmac.\n> I am still wondering what is acceptable in the DT.\n> \n> compatible = \"\"brcm,bcm4329-fmac\";\n> or\n> compatible = \"brcm\";\n> \n> The last one does not generate any warnings.\n\nOk. So what warning do you get when using \"brcm,bcm4329-fmac\"? Or did \nyou really try \"\"brcm,bcm4329-fmac\" as mentioned above?\n\nRegards,\nArend\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"XCXDH0uW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmH9G4yJQz9t32\n\tfor ;\n\tTue, 5 Sep 2017 03:37:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753913AbdIDRhV (ORCPT\n\t);\n\tMon, 4 Sep 2017 13:37:21 -0400","from mail-qt0-f170.google.com ([209.85.216.170]:33710 \"EHLO\n\tmail-qt0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753928AbdIDRhU (ORCPT\n\t); Mon, 4 Sep 2017 13:37:20 -0400","by mail-qt0-f170.google.com with SMTP id i50so4346442qtf.0\n\tfor ;\n\tMon, 04 Sep 2017 10:37:20 -0700 (PDT)","from [10.177.251.150] ([192.19.248.250])\n\tby smtp.gmail.com with ESMTPSA id\n\td50sm5383748qtd.37.2017.09.04.10.37.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 10:37:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=PWMoS587+zteHT+J9z8xY0wErsKknwnOlfgf6TLSziM=;\n\tb=XCXDH0uWM7F6fvz9h39F1RAFby/VnRZm/GZrYGxWiiN4lHIo5UQA+A8K98WYw3PPZ9\n\tYXwiIfoTV9yrYcfj2twdEd/BTNFLP2pZFOAnNvyt/F4yP+5gEclmXa0ae9++DnttIeSi\n\timw2uOmqR94YXhkwrBA7ajJAmSduJEVz4DonA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=PWMoS587+zteHT+J9z8xY0wErsKknwnOlfgf6TLSziM=;\n\tb=SXThAqanCa+ZN0i9hqKH6eoZ1f4Gz2ZQewVtBeOgOHWHLT6YuDknQd2FN/a2jC3Pzg\n\tjXLEadJHYHwy96sg2J+kTok7eOvmNNET8obP1YSLJgoUAZKgH9ZiYSffthIjk3zYz898\n\tn63OAcmU7nLxPVZhq23xFNNU1mW+9HpaU32FwujYlhg+CK5MfrRywr7SrtaW/kUTvk26\n\tN4HoGY0G8aPqFXephVujuZt4r2KIPPzepj4CHAEo6YNU7GI5GzKgrrJSbl5k/av+Ui1s\n\tftdH7B6410B/fcWPpA9WiA9SS+OAZ6SjwwYGjkXTMkZID2r76KismK2U5YDpzHqs7dm+\n\tbFHw==","X-Gm-Message-State":"AHPjjUhl6DwLBSjYc/wyMABll0snkvIPQ7j+/H8zErfh8pLW5KMB1Wre\n\tzlsd84wsWPHVqrxGuTZ2Eg==","X-Google-Smtp-Source":"ADKCNb47AB1Rm3Y7CM5b23azm3s3mfd1ssFKJ4g3JBx+5V/1OPCyMqQDakzX5854b+dFIKXQpeZbrQ==","X-Received":"by 10.200.13.8 with SMTP id q8mr1595280qti.99.1504546640079;\n\tMon, 04 Sep 2017 10:37:20 -0700 (PDT)","Subject":"Re: [PATCH] Documentation: dt-binding: net: wireless: add\n\tbcm43430-fmac","To":"Antony Antony ","Cc":"Rob Herring , Chen-Yu Tsai ,\n\tKalle Valo , Mark Rutland ,\n\tIcenowy Zheng ,\n\tdevicetree , \n\tHans de Goede ,\n\tlinux-wireless ,\n\tMaxime Ripard ","References":"<20170829214309.34466-1-antony@phenome.org>\n\t\n\t<20170830120218.ms3xuhp4qsibistv@AntonyAntony.local>\n\t<20170901164911.aiu5ej5u546z5kow@rob-hp-laptop>\n\t\n\t<20170901204030.2zpsoa4i53tdegs3@AntonyAntony.local>\n\t<8af0e096-f4b1-213f-d543-fa711e1961ad@broadcom.com>\n\t<20170904144230.yuadvqiruj73q5t3@AntonyAntony.local>","From":"Arend van Spriel ","Message-ID":"<7f07455d-88b6-3ab5-4cdd-dc38e019ac2a@broadcom.com>","Date":"Mon, 4 Sep 2017 19:37:15 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904144230.yuadvqiruj73q5t3@AntonyAntony.local>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]