[{"id":1761165,"web_url":"http://patchwork.ozlabs.org/comment/1761165/","msgid":"<59A837D2.8040907@arm.com>","list_archive_url":null,"date":"2017-08-31T16:22:42","subject":"Re: [PATCH] [AArch64] ILP32 math changes","submitter":{"id":65667,"url":"http://patchwork.ozlabs.org/api/people/65667/","name":"Szabolcs Nagy","email":"szabolcs.nagy@arm.com"},"content":"On 29/08/17 22:16, Steve Ellcey wrote:\n> Since Szabolcs has expressed interest in getting some aarch64 ILP32\n> changes into glibc mainline (if they don't affect the kernel or glibc\n> ABI) I am resubmitting this patch for approval in advance of the main\n> ILP32 support patches. I updated it with Richard Henderson's code (but\n> only doing it when the incoming argument is large). I tested it on\n> aarch64 ILP32 and LP64 with no regressions.\n> \n> Is this something that can be checked in now withnout waiting for the\n> kernel ILP32 support?\n> \n\nOK.\n\n(we plan to change the math functions to use gcc builtins\nin some places instead of asm which will simplify things,\nbut that can go in later on top of this.)\n\n> Steve Ellcey\n> sellcey@cavium.com\n> \n> \n> 2017-08-29 Steve Ellcey \n> \t Richard Henderson \n> \n> \t* sysdeps/aarch64/fpu/s_llrint.c (OREG_SIZE): New macro.\n> \t* sysdeps/aarch64/fpu/s_llround.c (OREG_SIZE): Likewise.\n> \t* sysdeps/aarch64/fpu/s_llrintf.c (OREGS, IREGS): Remove.\n> \t(IREG_SIZE, OREG_SIZE): New macros.\n> \t* sysdeps/aarch64/fpu/s_llroundf.c: (OREGS, IREGS): Remove.\n> \t(IREG_SIZE, OREG_SIZE): New macros.\n> \t* sysdeps/aarch64/fpu/s_lrintf.c (IREGS): Remove.\n> \t(IREG_SIZE): New macro.\n> \t* sysdeps/aarch64/fpu/s_lroundf.c (IREGS): Remove.\n> \t(IREG_SIZE): New macro.\n> \t* sysdeps/aarch64/fpu/s_lrint.c (get-rounding-mode.h, stdint.h):\n> \tNew includes.\n> \t(IREG_SIZE, OREG_SIZE): Initialize if not already set.\n> \t(OREGS, IREGS): Set based on IREG_SIZE and OREG_SIZE.\n> \t(__CONCATX): Handle exceptions correctly on large values that may\n> \tset FE_INVALID.\n> \t* sysdeps/aarch64/fpu/s_lround.c (IREG_SIZE, OREG_SIZE):\n> \tInitialize if not already set.\n> (OREGS, IREGS): Set based on IREG_SIZE and OREG_SIZE.\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83947-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"R86MsiqA\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Szabolcs.Nagy@arm.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnjR6ctVz9sPm\n\tfor ;\n\tFri, 1 Sep 2017 02:23:07 +1000 (AEST)","(qmail 8280 invoked by alias); 31 Aug 2017 16:23:02 -0000","(qmail 8268 invoked by uid 89); 31 Aug 2017 16:23:01 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:date:from:mime-version:to:cc\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=tv8DF9kBXIIxossv\n\thn/WtgD7xEnA6Y6rpZQXT2ohWshjZfMM3y0oB1CRHlGDTCPYEPHc35CFcR0TtSb1\n\t708DQudDT6DtxXSmo71kmS09+vZnNYFH6dciIjKjI98hEyIK+72nzzS8N/QpiGDz\n\tbIk5BruDGeifHiRPIqU1RnQbDcg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:message-id:date:from:mime-version:to:cc\n\t:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=gciOfrgc+VbmNzuVL0Bt1J\n\tysTrc=; b=R86MsiqAvVyYLhsuDOgyviqQAxbKz3xPTQrIsuADpiZWvZAbmWJWTt\n\ty8TqMd2J9ws+Ts3/SYXskWrQyh14eWk2Y43a3mipAHIQcV1Y4b0j1thc8N/GeIPq\n\toPRaRx+Yy1BG81LQrIz6oRCg1h0D7hS4DeISAOec69NkqiFRa3I5w=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.1 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE, SPF_HELO_PASS,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"EUR01-HE1-obe.outbound.protection.outlook.com","Message-ID":"<59A837D2.8040907@arm.com>","Date":"Thu, 31 Aug 2017 17:22:42 +0100","From":"Szabolcs Nagy ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.8.0","MIME-Version":"1.0","To":"sellcey@cavium.com, libc-alpha ","CC":"nd@arm.com, rth@twiddle.net, Joseph Myers , \n\tWilco Dijkstra ","Subject":"Re: [PATCH] [AArch64] ILP32 math changes","References":"<1504041387.5204.20.camel@cavium.com>","In-Reply-To":"<1504041387.5204.20.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"VI1PR09CA0050.eurprd09.prod.outlook.com\n\t(2603:10a6:802:28::18) To VI1PR0802MB2496.eurprd08.prod.outlook.com\n\t(2603:10a6:800:b8::23)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"4066f03d-64cc-4ab7-8b1e-08d4f08c8412","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR0802MB2496; ","X-Microsoft-Exchange-Diagnostics":["1; VI1PR0802MB2496;\n\t3:hS5IVTUcnqMHWLrhzu34XmFQ0Q/JrYpg1KgRDnIHB7Nj5qHb6plW+TktSUW1eQvrzKgEhYP9RucT30vfYHEZux2kUJba+56VtPmXhnjqUwTpaeJehQjQJbFw9gFzQvdpg1IGR7kPBAfMIQyToYnAq3tpi17WplxxJFQqTaTH3OktzDN59XgX5FiEnrrgNRIBlkg8PeuYcryL7s96en2EW5Klc7P0e/1ozm1SCUExkaAYzNo1FFZswq07NpIt2WPO;\n\t25:nsK3ZqZDGZAyzXXwHh/XXHW5JT9LYTs2woyniLpVyYW44ekNh+qRx/As7e/jI3KmvIC61+qRZVjfHnNjjbukH3l0g+CuTqaoZDUFjI60KSWnbC8hvAPcPjWUv8B8PYv0ly7tbKCUpvxarmwme9U7YcJ8VilHUp6qtKcxOtubWbhyHSDVz/uRddhY4Hj/HCpreQ+0kxmfqwLlxYrJ+gzkawvQYAB28iV3pY/+lVsCTODBLROPNytTNOJiw8jPJuj4neiySBMF4l55FrymTNvAU73CEIboa+ZoB9qfAgiZkLxzYVp/63L5HjKAK0C7w5nTNqgIqrl5NCyHpisbemzPbA==;\n\t31:TOU3dv7QBj/9jLdNTeDkzyaNvrBcecyrkOMeDS+2MwWFMPKAj90MoNu2MKEWd+RlyNxtTy7CyWgel3H0+R7C2s3Afp7YEdmY4DAZCxwmsugMhIRDSYwK4jPb5aFUZ8OI/GIBYocPxGLVBL3oaOIcTNrRWcEtmvE76lpX7O8OG3Y2fVlg9j4/kre10P5t+vtHwrjpLE1Gj+cGy4IaH15/rjV8y13AVew9gIWbuUK8aYI=","1; VI1PR0802MB2496;\n\t20:kFV7Z+LmV0myyGxMk6ZqhroZHHQKsaFrb8rhxCufrQ+iwLvWAtXq2m6nJhR2o3o8yk+cV7GEa5Wg1kNsE5tRDb20TxNcpas9HRq0VVPuN5DvwZDO9hboE0KE1tX4bJF8JtgjLzj+b3HsgK1FhDq+qdIlxfrEwVXbxb4/WvNyFHY=;\n\t4:+TVAR93qz18bvVxtlccLjZK7mhuS/hqzttLi8V563DuqjsCM1P8CK92uLI7+Q8GbI7M4+mzWKvNrX5EcWyKt112Q4H6T/CwU2ThBb22112Zks8kn0UT10JrZHLTHBfKsk53YktwSfx7vWECeAsUHExAwxW60mKPfCynV5opfWM6Lp0cBttQStYyh4wVRQ+gadwWF6eymZ0RX85VHaLgHVgKhyNg+2b6n5jSI2E+EXFD1/vyWUhUc3LE0F5n8hIjz","=?utf-8?q?1=3BVI1PR0802MB2496=3B23=3A5b?=\n\t=?utf-8?q?CGKpRsxcSQHC2jFMjbYi4Z5mH25ZT8rrnX70bBtG/R33WS5kEaO4rSdq?=\n\t=?utf-8?q?sGIFwCb+BECxnLEvOv5yROD8/mrrTUSta+EMh1otDclgKlqSt4+e+6+j?=\n\t=?utf-8?q?czA98vp9SK2EEob5k48A5rkhRH/2O8msRSSs5HDD0Hc4IkrjQg42H5bs?=\n\t=?utf-8?q?ry/TGzBdytzMU1cpThSIC1yUgxCPUNvhaIEeUR/+FPn1Wn4irbNQmMm5?=\n\t=?utf-8?q?rsBxYTBmfnQO0AarjjLeGMLMEQ3V2MIpScCZLrYwRQ7xsHIqPS7Am0aa?=\n\t=?utf-8?q?6V1dPTU1IjNcBcw4UPTCluAmHgv3YLgLjQEN3k3ndOuVc7QNPxlxWjmc?=\n\t=?utf-8?q?TXp+i+GUrB71WLYY9Ea1NJ5jE1i9jsbiFHiyeNQLTvEX4XYipni3d6O5?=\n\t=?utf-8?q?SvjWLYPCjhv/qi9qdh2SnGKf+FdSEUKIjUgcE4nv/qBPlZ5/wP1HyBFF?=\n\t=?utf-8?q?yGP+chlaHCK87H6BTULiu9zWS0qH94mEytkznWmdgn4bUBZDtdch877q?=\n\t=?utf-8?q?g0WEllDXqXQMMRXZneQ8mlFB7ZmsOCNQOhQHmlvxvYGc9m1jbyAf/CwJ?=\n\t=?utf-8?q?mbje/XffAPXtPmluMgi0+YJy4tfeSL3qXgwJ6SuBVtYPUP8rszHBksTO?=\n\t=?utf-8?q?qI4aEv2yZqeRLNBJ+g0zoIJETiIuYmsNuq2ARkF8CCwUfqVFenTpGgcu?=\n\t=?utf-8?q?9s88pR7SAMSte/cBeOJTMzOSzFaEpedLeO+WphWC7Xg9cTCr1Ygziwv2?=\n\t=?utf-8?q?4eMHMZLfWjhh7vqsxBKxlJcEy3OMfSE/spJC/nhB/SkhBvrPfarGfE2b?=\n\t=?utf-8?q?9KDsBb0GjJNTg1mR9ETF6pWjpSPrzoGsJ6/jPhk8onvdM+Und1Ji/kzC?=\n\t=?utf-8?q?xl7taVPRvCdlFyqeH3DWFtBAjC66oF+fotrNkUkewp4uDXpINpO7L/yf?=\n\t=?utf-8?q?3GQhVF+ndh8yRwxxlmbL8jT85O086jpvv2G+FTZPuEtVYVq5f8rnK5fs?=\n\t=?utf-8?q?d3kVJJj4Z40jSM2L34L/QAJtl8d32lN1O7xiynEmBdpt0DrxRRQAB+3I?=\n\t=?utf-8?q?XBlBRrdoP9dawm+1yTFtLQf7bukC6aLuJkPBMUFQ/7iPSG8sq4SzFRTZ?=\n\t=?utf-8?q?BIsPZ8fPHjoFOSUlwmlRM1589j5zq+WfywdqL4IoAveWzctxrp193suj?=\n\t=?utf-8?q?3Uswr4pBr2mOzxSxI5+fgmwdEQ6OnERlM3OAKz1Z2wwRRTF7FDSqzs1W?=\n\t=?utf-8?q?x3BEAgGxi/uWh3rGHgMeSmUExokL/kLB0RjrxOxOI/oZbm/WwWQrMQZ4?=\n\t=?utf-8?q?Y9c/LhdJUJLuJwUuSE/YciTiivXe1/HXKoMDzRphVR3Lrw5NcmzjEgpR?=\n\t=?utf-8?q?JWE58gJiCWr6d3ZDCictrgxEnEo6fZNVxhokjsCSZD+1QgvctRf1cqtP?=\n\t=?utf-8?q?BVbb22sjszKZLvuwOAYH02fqNnDCcYUPS+wGmFC3jwJ9DGOCU0LA13Ca?=\n\t=?utf-8?q?WgCPiZXi8rxFEgVVpXY5IB76VBMTAq7U5gpv8+b5f8+DsHfwteTbxykw?=\n\t=?utf-8?q?hjgKNIWmRef8K4?=","1; VI1PR0802MB2496;\n\t6:Je5KYJKq9jSZgrwsNk9DA/ALgiTvMaLgu5aCRNEsbtrqvclBHTguXlL7T1Rifu+0Gw8Uvis4sKZx+OosTd2Mxahg9WXERLBqJrp9btDgQpWVCrnj68qIMC26CfHf8OrNKlyofpIN3lRZca2xUvJ6CkyEbpxbR8g38fNpCpBp7QMTvX9FXyoV8T4Zj8W7uHrdSqK1/Rbg5ShxBYgvd0kmVh36OZqzf14clcw0kil6Fxk5Min6exhvFq7rmQXaHvE66tEcjXLbgBAmDE5ETVaa5DazRYT0PUQZcmjJl2qn1W3OYrbiTzvSeOBfOrfYtXoFZDJvl0tkwwqNp91nIwfyAA==;\n\t5:btexph1Sn8MeOyu2m32dW++sPeFNSQ2EEqfbSKAeg18KjRlJsSfa5aQTpz9akskmx280YttdeO04jjHy8O4300VqKcz9WI/g55NyJDmNxS7Oh/UeDaN5Q4p0UcBMXrau9XwDR12MTcvDvkIE/IyB7g==;\n\t24:uVjb8Ev7skyFeBAyDDjbF/GlVrDc2G2ti7mClSGTxBv6K+SHL0W+hgmHkZwrFMNW6wohU1eqsjDh5pYZzA/zenLQJtagLdDCLqQWkuDNlRI=;\n\t7:0cB7143qyrbTVnTveE72CD7WgSXAxFdCX8OjVbYKLhUWTa2IVETtA3hNv2F1hY8ag6150cISA4ZRiOSsXRzzmPa/+2Z0I8NwhQ8279MuE/KnciBh3HsOK46AOH+CCZM/qL8e0x30X4DCkrdlz5SB1Qao1eXkDh7r162Pt0e+2bFYIwkxzn6UbCVOU1QfXxq1/vyDQ5w2Gi4iF5yj4i/PNqv6qxMOc/2Z++KKutyYk8w="],"X-MS-TrafficTypeDiagnostic":"VI1PR0802MB2496:","NoDisclaimer":"True","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR0802MB2496; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR0802MB2496; ","X-Forefront-PRVS":"04163EF38A","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6049001)(6009001)(39860400002)(189002)(199003)(377424004)(24454002)(6116002)(229853002)(6486002)(42186005)(5660300001)(53546010)(36756003)(7350300001)(110136004)(6246003)(25786009)(80316001)(2950100002)(65806001)(6666003)(65956001)(66066001)(47776003)(77096006)(6916009)(86362001)(189998001)(4326008)(23676002)(33656002)(97736004)(54906002)(50986999)(3846002)(76176999)(4001350100001)(68736007)(72206003)(50466002)(305945005)(54356999)(53936002)(7736002)(106356001)(64126003)(65816999)(478600001)(87266999)(83506001)(59896002)(8676002)(2906002)(81166006)(230700001)(101416001)(105586002)(81156014);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0802MB2496;\n\tH:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1;\n\tLANG:en; ","Received-SPF":"None (protection.outlook.com: arm.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"arm.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Aug 2017 16:22:46.1727\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR0802MB2496"}}]