[{"id":1759746,"web_url":"http://patchwork.ozlabs.org/comment/1759746/","msgid":"","list_archive_url":null,"date":"2017-08-29T22:24:51","subject":"Re: [Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 08/29/2017 05:49 PM, John Snow wrote:\n> Signed-off-by: John Snow \n\nReviewed-by: Philippe Mathieu-Daudé \nTested-by: Philippe Mathieu-Daudé \n\n> ---\n> hw/ide/ahci.c | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c\n> index 2e75f9b..57bb59d 100644\n> --- a/hw/ide/ahci.c\n> +++ b/hw/ide/ahci.c\n> @@ -34,17 +34,8 @@\n> #include \"hw/ide/pci.h\"\n> #include \"hw/ide/ahci_internal.h\"\n> \n> -#define DEBUG_AHCI 0\n> #include \"trace.h\"\n> \n> -#define DPRINTF(port, fmt, ...) \\\n> -do { \\\n> - if (DEBUG_AHCI) { \\\n> - fprintf(stderr, \"ahci: %s: [%d] \", __func__, port); \\\n> - fprintf(stderr, fmt, ## __VA_ARGS__); \\\n> - } \\\n> -} while (0)\n> -\n> static void check_cmd(AHCIState *s, int port);\n> static int handle_cmd(AHCIState *s, int port, uint8_t slot);\n> static void ahci_reset_port(AHCIState *s, int port);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hF7KrTki\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhjsG1rz6z9sPt\n\tfor ;\n\tWed, 30 Aug 2017 08:26:10 +1000 (AEST)","from localhost ([::1]:47307 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmoxU-0001B1-3x\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 18:26:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44715)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dmowz-0001As-DB\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 18:25:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dmowy-0005c5-HP\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 18:25:37 -0400","from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35715)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmowx-0005bK-T0; Tue, 29 Aug 2017 18:25:36 -0400","by mail-qt0-x243.google.com with SMTP id u11so3945429qtu.2;\n\tTue, 29 Aug 2017 15:25:35 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\te67sm2618800qkb.67.2017.08.29.15.25.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 15:25:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=RGXfChAN+sq/bPFkq3Aez1HiJ4uuH+C7cjanfCH3/uw=;\n\tb=hF7KrTkiCCPBOtURIL18iZNqtQ4hyIZG+r/4jYae5j/NqvkNvZuIs4Q83pFIVnGuvP\n\tiu55B9R32ODSt+eb1aGtpUaP92XbdLxqInejR7Odm9ftoRqfA13f01Hqw2I6YhQoaDQN\n\tcpSdL2KAX0XAaOvwrP+Ug/HbgFbkhUoO6DOifpeC5HFbsQPyh4mfTikUcVK9Wc9mGXt2\n\t5KwkXKrpSg/QcQAKnt+GoTC6te9LrEIVGePW/JzIT7cnRus9pJqkYplNmo2vJi0SHSG/\n\tS2Ib0h4fVuFoqU3kHvVa69vOhbpPCjpcr3x5C0c6X6WzALKH/+UUogKY2YpGpTbgg2Ue\n\tvMHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=RGXfChAN+sq/bPFkq3Aez1HiJ4uuH+C7cjanfCH3/uw=;\n\tb=CShMePyqDYk/pAZh54sdKvrSxPRr9CdIFHkg3l7cz8bIMLJJeFSQXMOt3AOFmxA8VU\n\tFFJTeZFMdrpgmAGvpLFGo395U8XseAkuJTa7acIwTHkRb9arUkDLslzNo1+d6RbBW8pR\n\tq1RgBFxAjl4dFbMce+VGAiY9qcb6tWVizfjBcTQt5LQYCLmfoJvuTBeGjbQbR4hTyewD\n\tu0i9bM1f7PtW5INOmhMjb4jEjoX2a5xePtL8RMGGu7fjWFA9dWwmGS8WZxwk5i+UnW90\n\tuhZ3QZL7kmYmLUOe3Fnjtet+4a5uiMJJ8efL9z1W5mt/JQPlVxPeePJG/Ub2PXil6ADX\n\tbjNQ==","X-Gm-Message-State":"AHYfb5gMwGaPIwgWaERIRNDjZ0OIIl2odQq4jJI2nvHno+FduTNWCNZ6\n\t9J9nC6VEBCKJiwWVR2s=","X-Received":"by 10.200.28.35 with SMTP id a32mr8719556qtk.288.1504045535226; \n\tTue, 29 Aug 2017 15:25:35 -0700 (PDT)","To":"John Snow , qemu-block@nongnu.org","References":"<20170829204934.9039-1-jsnow@redhat.com>\n\t<20170829204934.9039-10-jsnow@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Tue, 29 Aug 2017 19:24:51 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170829204934.9039-10-jsnow@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::243","Subject":"Re: [Qemu-devel] [PATCH v2 9/9] AHCI: remove DPRINTF macro","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]