[{"id":1768728,"web_url":"http://patchwork.ozlabs.org/comment/1768728/","msgid":"","list_archive_url":null,"date":"2017-09-14T16:53:30","subject":"Re: [PATCH 2/2] arm: AT91: fix DT duplicate node name","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 29/08/2017 at 22:08, Michał Mirosław wrote:\n> Fix following warning at bootup:\n> \n> device-tree: Duplicate name in fb@0x00500000, renamed to \"display#1\"\n> \n> Signed-off-by: Michał Mirosław \n> ---\n> arch/arm/boot/dts/at91sam9m10g45ek.dts | 48 +++++++++++++++++-----------------\n> 1 file changed, 24 insertions(+), 24 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts\n> index 9cf1f5163fbd..272af5867403 100644\n> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts\n> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts\n> @@ -223,30 +223,6 @@\n> \t\tfb0: fb@0x00500000 {\n> \t\t\tdisplay = <&display0>;\n> \t\t\tstatus = \"okay\";\n> -\n> -\t\t\tdisplay0: display {\n\nMichał, thanks for your patch.\n\nActually the DT binding requires this:\nDocumentation/devicetree/bindings/video/atmel,lcdc.txt\n\nSo it's somehow a bigger issue.\nMoreover, several boards have exactly the same arrangement than the\nat91sam9m10g45ek, so you probably need to modify them all at the same time.\n\nAfter a brief look at drivers/video/fbdev/atmel_lcdfb.c it seems that\nthe name of the node is not so much important, so we can modify it\n(something like display0: lcd-display {}) .\n\nI suggest that you modify the binding, the board files affected and\nre-submit a patch.\n\nBest regards,\n\n> -\t\t\t\tbits-per-pixel = <32>;\n> -\t\t\t\tatmel,lcdcon-backlight;\n> -\t\t\t\tatmel,dmacon = <0x1>;\n> -\t\t\t\tatmel,lcdcon2 = <0x80008002>;\n> -\t\t\t\tatmel,guard-time = <9>;\n> -\t\t\t\tatmel,lcd-wiring-mode = \"RGB\";\n> -\n> -\t\t\t\tdisplay-timings {\n> -\t\t\t\t\tnative-mode = <&timing0>;\n> -\t\t\t\t\ttiming0: timing0 {\n> -\t\t\t\t\t\tclock-frequency = <9000000>;\n> -\t\t\t\t\t\thactive = <480>;\n> -\t\t\t\t\t\tvactive = <272>;\n> -\t\t\t\t\t\thback-porch = <1>;\n> -\t\t\t\t\t\thfront-porch = <1>;\n> -\t\t\t\t\t\tvback-porch = <40>;\n> -\t\t\t\t\t\tvfront-porch = <1>;\n> -\t\t\t\t\t\thsync-len = <45>;\n> -\t\t\t\t\t\tvsync-len = <1>;\n> -\t\t\t\t\t};\n> -\t\t\t\t};\n> -\t\t\t};\n> \t\t};\n> \n> \t\tnand0: nand@40000000 {\n> @@ -293,6 +269,30 @@\n> \t\t};\n> \t};\n> \n> +\tdisplay0: display {\n> +\t\tbits-per-pixel = <32>;\n> +\t\tatmel,lcdcon-backlight;\n> +\t\tatmel,dmacon = <0x1>;\n> +\t\tatmel,lcdcon2 = <0x80008002>;\n> +\t\tatmel,guard-time = <9>;\n> +\t\tatmel,lcd-wiring-mode = \"RGB\";\n> +\n> +\t\tdisplay-timings {\n> +\t\t\tnative-mode = <&timing0>;\n> +\t\t\ttiming0: 480x272 {\n> +\t\t\t\tclock-frequency = <9000000>;\n> +\t\t\t\thactive = <480>;\n> +\t\t\t\tvactive = <272>;\n> +\t\t\t\thback-porch = <1>;\n> +\t\t\t\thfront-porch = <1>;\n> +\t\t\t\tvback-porch = <40>;\n> +\t\t\t\tvfront-porch = <1>;\n> +\t\t\t\thsync-len = <45>;\n> +\t\t\t\tvsync-len = <1>;\n> +\t\t\t};\n> +\t\t};\n> +\t};\n> +\n> \tpwmleds {\n> \t\tcompatible = \"pwm-leds\";\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"hGF3JLZe\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtPjD1h2Yz9sP1\n\tfor ;\n\tFri, 15 Sep 2017 02:52:48 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsXNc-00014f-NY; Thu, 14 Sep 2017 16:52:44 +0000","from esa6.microchip.iphmx.com ([216.71.154.253])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsXNY-00012c-RY for linux-arm-kernel@lists.infradead.org;\n\tThu, 14 Sep 2017 16:52:42 +0000","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa6.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t14 Sep 2017 09:52:19 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch06.mchp-main.com\n\t(10.10.76.107) with Microsoft SMTP Server id 14.3.352.0;\n\tThu, 14 Sep 2017 09:52:19 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=4PUrEaAeNXG/W7e4c4so9QxAOkgovlgJkTpHSVjqxeM=;\n\tb=hGF3JLZesUyN80\n\tdj6UftpIspZSM5xeuxr2wDYV2Yx3sY2GkDQWR8Q3DwsqgFk477x6fbVSK2eaVhWfO6HZ2zFOEd0za\n\teZ4Op/EgU2VFttBAfFGdrBceq0ztOyhKFO66gz26AI982KCmdGJoPkB7OgFL504i2kiWZybXLsQuI\n\tNZsrpoWOBOr09mKYubi0ps0EGF7OjdtS7JgaaUkHl9lLMwUTXax+XAb5+AFhdKPKWgdJhKRkEJmO+\n\tqndRZ81Cm/Sb01RNLo2xrD587P43H93+CpQeSIvo0PdBfL7xtxFGiI0NVsk5iMwTwN1JEXimCsULl\n\tyItzuEUpeMAJ7fkyUStQ==;","X-IronPort-AV":"E=Sophos;i=\"5.42,394,1500966000\"; d=\"scan'208\";a=\"4467947\"","Subject":"Re: [PATCH 2/2] arm: AT91: fix DT duplicate node name","To":"=?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= , Alexandre\n\tBelloni ","References":"\n\t<910fee2eb99b2d95e59fa6b997645b498f167022.1504037038.git.mirq-linux@rere.qmqm.pl>","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"","Date":"Thu, 14 Sep 2017 18:53:30 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<910fee2eb99b2d95e59fa6b997645b498f167022.1504037038.git.mirq-linux@rere.qmqm.pl>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170914_095240_944999_11ED9297 ","X-CRM114-Status":"GOOD ( 11.85 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [216.71.154.253 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"devicetree@vger.kernel.org\" ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1780128,"web_url":"http://patchwork.ozlabs.org/comment/1780128/","msgid":"<20171004212034.6znvbdfe2wbd7uvh@qmqm.qmqm.pl>","list_archive_url":null,"date":"2017-10-04T21:20:34","subject":"Re: [PATCH 2/2] arm: AT91: fix DT duplicate node name","submitter":{"id":524,"url":"http://patchwork.ozlabs.org/api/people/524/","name":"Michał Mirosław","email":"mirq-linux@rere.qmqm.pl"},"content":"On Thu, Sep 14, 2017 at 06:53:30PM +0200, Nicolas Ferre wrote:\n> On 29/08/2017 at 22:08, Michał Mirosław wrote:\n> > Fix following warning at bootup:\n> > \n> > device-tree: Duplicate name in fb@0x00500000, renamed to \"display#1\"\n> > \n> > Signed-off-by: Michał Mirosław \n> > ---\n> > arch/arm/boot/dts/at91sam9m10g45ek.dts | 48 +++++++++++++++++-----------------\n> > 1 file changed, 24 insertions(+), 24 deletions(-)\n> > \n> > diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts\n> > index 9cf1f5163fbd..272af5867403 100644\n> > --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts\n> > +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts\n> > @@ -223,30 +223,6 @@\n> > \t\tfb0: fb@0x00500000 {\n> > \t\t\tdisplay = <&display0>;\n> > \t\t\tstatus = \"okay\";\n> > -\n> > -\t\t\tdisplay0: display {\n> \n> Michał, thanks for your patch.\n> \n> Actually the DT binding requires this:\n> Documentation/devicetree/bindings/video/atmel,lcdc.txt\n> \n> So it's somehow a bigger issue.\n> Moreover, several boards have exactly the same arrangement than the\n> at91sam9m10g45ek, so you probably need to modify them all at the same time.\n> \n> After a brief look at drivers/video/fbdev/atmel_lcdfb.c it seems that\n> the name of the node is not so much important, so we can modify it\n> (something like display0: lcd-display {}) .\n> \n> I suggest that you modify the binding, the board files affected and\n> re-submit a patch.\n\nIt looks like the binding documentation is wrong. The driver code does\n\n\tof_parse_phandle(np, \"display\", 0);\n\nso it expects a phandle, not a node.\n\nBest Regards,\nMichał Mirosław","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"rqHP+BWH\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl\n\theader.b=\"lTTXYCsW\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6pjn1w1wz9t5l\n\tfor ;\n\tThu, 5 Oct 2017 08:21:17 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dzr6P-000526-L3; Wed, 04 Oct 2017 21:21:13 +0000","from rere.qmqm.pl ([91.227.64.183])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dzr6M-0004xe-0p for linux-arm-kernel@lists.infradead.org;\n\tWed, 04 Oct 2017 21:21:12 +0000","from remote.user (localhost [127.0.0.1])\n\tby rere.qmqm.pl (Postfix) with ESMTPSA id 3y6pj019SRzJ3;\n\tWed, 4 Oct 2017 23:20:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=/f/IZZqk+0x2ZEZxditZZkjvFmwV5SmFqLkF2lTu3Vg=;\n\tb=rqHP+BWHv1ZHn3\n\tR2QqIfrA4J0McnmSlV/zZcC8+w9d4OCK1korRGNotR6+6owK5BCAogz76eDqrR6ONKgAsAjm/9fdS\n\tWCdBexP5rMAxznjzVyAfD5tZUmvgkMVFPblZMuA0ofkO4xyf/5CY2ax26mBRv3Nc2o6XrqIaqNOCj\n\tM7ZXU1LNrDWrLHMD0eH6kfoy9++7K2p800Uxdv1/t+3QTDORAv9y1W0DNZ9kSSASK7lass8CTa5s3\n\tIMzJc59a3WiDCGKF9Fy5AY18ZeID5G8+wRtyWgQfJiT319A8sChH/mPN71q4a7HI5PrZF0IFnRMFP\n\tWA6vTwKwypywYlJQzbLQ==;","v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1;\n\tt=1507152036; bh=Ju9LNo6rDOrlUBXz0tIcyXef0SqBS4kM4ledMD/lwNw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lTTXYCsW0iAWkC+hO52Nyk+SXP5hKKIdJEiOurlNBBvkKxK633zL/0zCkM2Ia31Fe\n\tU05w9iF3ts+BHsZQOZBuMRYGUyqT930N+1c0YVhV3PS3I58elsSrJMO0AVQOfsd2Me\n\tBgW9HK+S01s/M8yXlAzFHk/KPkY+ymLUSyj2nDzmmklDhxgkgzE6fSAPy7QFk17yU1\n\tf1YV+GqQhGgOJ+h+3d+d5Pi10pHLDQ/6O/Yn9Ml9Q/3mrERWX5myB5k6nO1AxvOnXO\n\t5w+TT3TQ/HO9jabTlabUyUiR401kXYB6IJ5DGan1K1akN4/1tV6wdh/bl3OEZD7ia2\n\t0u0GsIU2OzVkg=="],"X-Virus-Status":"Clean","X-Virus-Scanned":"clamav-milter 0.99.2 at rere","Date":"Wed, 4 Oct 2017 23:20:34 +0200","From":"=?iso-8859-2?q?Micha=B3_Miros=B3aw?= ","To":"Nicolas Ferre ","Subject":"Re: [PATCH 2/2] arm: AT91: fix DT duplicate node name","Message-ID":"<20171004212034.6znvbdfe2wbd7uvh@qmqm.qmqm.pl>","References":"\n\t<910fee2eb99b2d95e59fa6b997645b498f167022.1504037038.git.mirq-linux@rere.qmqm.pl>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171004_142110_438980_E0123894 ","X-CRM114-Status":"GOOD ( 14.37 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"devicetree@vger.kernel.org\" ,\n\tAlexandre Belloni ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-2\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]