[{"id":1763597,"web_url":"http://patchwork.ozlabs.org/comment/1763597/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9982@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-05T19:31:16","subject":"Re: [Intel-wired-lan] [PATCH] ixgbe: split Tx/Rx ring clearing\n\tfor\tethtool loopback test","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Emil Tantilov\n> Sent: Tuesday, August 29, 2017 12:22 PM\n> To: intel-wired-lan@lists.osuosl.org\n> Subject: [Intel-wired-lan] [PATCH] ixgbe: split Tx/Rx ring clearing for ethtool\n> loopback test\n> \n> Commit: fed21bcee7a5\n> (\"ixgbe: Don't bother clearing buffer memory for descriptor rings)\n> \n> exposed some issues with the logic in the current implementation of\n> ixgbe_clean_test_rings() that are being addressed in this patch:\n> \n> - Split the clearing of the Tx and Rx rings in separate loops. Previously both Tx\n> and Rx rings were cleared in a rx_desc->wb.upper.length based loop which\n> could lead to issues if for w/e reason packets were received outside of the\n> frames transmitted for the loopback test.\n> \n> - Add check for IXGBE_TXD_STAT_DD to avoid clearing the rings if the\n> transmits have not comlpeted by the time we enter ixgbe_clean_test_rings()\n> \n> - Exit early on ixgbe_check_lbtest_frame() failure.\n> \n> This change fixes a crash during ethtool diagnostic (ethtool -t).\n> \n> Signed-off-by: Emil Tantilov \n> ---\n> drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 53 ++++++++++++++---\n> -----\n> 1 file changed, 34 insertions(+), 19 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmxfM5l8Nz9s83\n\tfor ;\n\tWed, 6 Sep 2017 05:31:23 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 16E193090B;\n\tTue, 5 Sep 2017 19:31:22 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id x7GGvrl6VLfx; Tue, 5 Sep 2017 19:31:20 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2BE4F30906;\n\tTue, 5 Sep 2017 19:31:20 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6C4771C0E93\n\tfor ;\n\tTue, 5 Sep 2017 19:31:18 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6441A30906\n\tfor ;\n\tTue, 5 Sep 2017 19:31:18 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3xTzZT97L5wY for ;\n\tTue, 5 Sep 2017 19:31:17 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id AEEEC308D0\n\tfor ;\n\tTue, 5 Sep 2017 19:31:17 +0000 (UTC)","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga105.fm.intel.com with ESMTP; 05 Sep 2017 12:31:17 -0700","from orsmsx101.amr.corp.intel.com ([10.22.225.128])\n\tby fmsmga004.fm.intel.com with ESMTP; 05 Sep 2017 12:31:17 -0700","from orsmsx160.amr.corp.intel.com (10.22.226.43) by\n\tORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Tue, 5 Sep 2017 12:31:16 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX160.amr.corp.intel.com ([169.254.13.154]) with mapi id\n\t14.03.0319.002; Tue, 5 Sep 2017 12:31:16 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,480,1498546800\"; d=\"scan'208\";a=\"308258357\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [PATCH] ixgbe: split Tx/Rx ring clearing for\n\tethtool loopback test","Thread-Index":"AQHTIPwNDM5gCObfhUmfrkW/eeBpd6KmuQag","Date":"Tue, 5 Sep 2017 19:31:16 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9982@ORSMSX104.amr.corp.intel.com>","References":"<20170829192148.19519.80519.stgit@localhost6.localdomain6>","In-Reply-To":"<20170829192148.19519.80519.stgit@localhost6.localdomain6>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFlYjA0MzAtZThjZS00MWExLWFlNmMtZjM4OGJhY2ZjMTZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InpTM3dsUHFNQXR5VnFCQUFcL21jbTczb0pnRE1WTzNSVWhRcUlFS0dCbDAwPSJ9","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [PATCH] ixgbe: split Tx/Rx ring clearing\n\tfor\tethtool loopback test","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]