[{"id":1759625,"web_url":"http://patchwork.ozlabs.org/comment/1759625/","msgid":"","list_archive_url":null,"date":"2017-08-29T19:46:40","subject":"Re: [PATCH net] sch_hhf: fix null pointer dereference on init\n\tfailure","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 29/08/17 22:02, Nikolay Aleksandrov wrote:\n> If sch_hhf fails in its ->init() function (either due to wrong\n> user-space arguments as below or memory alloc failure of hh_flows) it\n> will do a null pointer deref of q->hh_flows in its ->destroy() function.\n> \n> To reproduce the crash:\n> $ tc qdisc add dev eth0 root hhf quantum 2000000 non_hh_weight 10000000\n> \n\nUh, sorry about sending these out separately. I'll send the rest as a set for\neasier review once I test them, should be just a couple more.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"eukyLFSc\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhfKT4xHSz9sQl\n\tfor ;\n\tWed, 30 Aug 2017 05:46:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751958AbdH2Tqp (ORCPT );\n\tTue, 29 Aug 2017 15:46:45 -0400","from mail-wm0-f48.google.com ([74.125.82.48]:36800 \"EHLO\n\tmail-wm0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751664AbdH2Tqn (ORCPT\n\t); Tue, 29 Aug 2017 15:46:43 -0400","by mail-wm0-f48.google.com with SMTP id u126so2630233wmg.1\n\tfor ; Tue, 29 Aug 2017 12:46:42 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\to191sm1749356wmd.35.2017.08.29.12.46.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 12:46:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=nhjCV+oPm3oPlXogxRjTSnUw7dd5hWMXOk3RknkpiS4=;\n\tb=eukyLFSc2gw3PkW/LhSS1SxOlHL+5a/unZTHEO9tSxdUbBt5KKGmKcf2/nRfPPnbRW\n\td4owRt/YIsXCZtrkoOe37ZGCQUlsTZ40Xau/7+2x61jgLJ/1wG/aMx9uJufjWlW1G5zE\n\thK9WOqVTQc6S04Z0PIP0tla1VxkkxaeFlOIz4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=nhjCV+oPm3oPlXogxRjTSnUw7dd5hWMXOk3RknkpiS4=;\n\tb=HP55WmEvxaw64FrIw16wbB8gmx6sKrvoeZMa5BSp3AFhmY+uQxij7vm2NO+llm+6MC\n\tDM8abfNoT6Gahhz34qE4byk8bFgj6/xj3Pg4QFmU78UTThjg6Eg4s+7DRATLhhI++URM\n\t6TXwRCEFzxbrY1OVDiIVA3L1zCtyH6EUI7EG8Pze8TrJ4EGW8uZvwkn3DFfI8JxOcs9i\n\tGTbAUlTp0HFzF+RsTWGlsacoNSAF/pPyHfJ7orblBMJYbhGLPvuy/B2EE7jZYWk74MC7\n\tIrTmrB+0nMIOlqSSm7IHmrB4jZrzX4B0bP2X8CgmtkYYLJw9w6oIFcdsMUeY2ZQLF75h\n\tXRKA==","X-Gm-Message-State":"AHYfb5i6MH9NlbOIWYvVvuqwgu6KwRFP/bWYI2GR26886tqtfwTib/A+\n\tyYRXT9iniAgioga2","X-Received":"by 10.28.127.145 with SMTP id a139mr466777wmd.18.1504036002284; \n\tTue, 29 Aug 2017 12:46:42 -0700 (PDT)","Subject":"Re: [PATCH net] sch_hhf: fix null pointer dereference on init\n\tfailure","To":"netdev@vger.kernel.org","References":"<1504033335-19098-1-git-send-email-nikolay@cumulusnetworks.com>","Cc":"edumazet@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,\n\tjiri@resnulli.us, roopa@cumulusnetworks.com","From":"Nikolay Aleksandrov ","Message-ID":"","Date":"Tue, 29 Aug 2017 22:46:40 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<1504033335-19098-1-git-send-email-nikolay@cumulusnetworks.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759805,"web_url":"http://patchwork.ozlabs.org/comment/1759805/","msgid":"","list_archive_url":null,"date":"2017-08-30T01:24:44","subject":"Re: [PATCH net] sch_hhf: fix null pointer dereference on init\n\tfailure","submitter":{"id":211,"url":"http://patchwork.ozlabs.org/api/people/211/","name":"Cong Wang","email":"xiyou.wangcong@gmail.com"},"content":"On Tue, Aug 29, 2017 at 12:02 PM, Nikolay Aleksandrov\n wrote:\n> First I did it with the check in the for () conditional, but this is more\n> visible and explicit. Let me know if you'd like the shorter version. :-)\n\nOr, if you want to make the patch size smaller, just check NULL\nbefore for():\n\nif (!q->hh_flows)\n return;\n\nfor (...)\n\nUp to you, I have no strong opinion here, slightly prefer a smaller\none for backport.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Sn/VITVN\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhnqr5zDFz9sNc\n\tfor ;\n\tWed, 30 Aug 2017 11:25:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751684AbdH3BZG (ORCPT );\n\tTue, 29 Aug 2017 21:25:06 -0400","from mail-pf0-f174.google.com ([209.85.192.174]:32854 \"EHLO\n\tmail-pf0-f174.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751380AbdH3BZF (ORCPT\n\t); Tue, 29 Aug 2017 21:25:05 -0400","by mail-pf0-f174.google.com with SMTP id r62so15031120pfj.0\n\tfor ; Tue, 29 Aug 2017 18:25:05 -0700 (PDT)","by 10.100.166.199 with HTTP; Tue, 29 Aug 2017 18:24:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=efgHd4YGQ58jxWp637hKMDNUWrrQu5q1i2/6wlvASNU=;\n\tb=Sn/VITVN7WKWcg80q3GKzshPk/78sjYp1Vtsk8h3sKyZOYoU0oJOvtKMZWt6+S+7/W\n\tAsIrGvAEdVQ8CcEmck88VV6qnRepgw1Zq26cnGrzJECqADjJoN6loEuDaKy1cRYCBRdf\n\t54BhW6ZCEgL9YMAGxZ+qL1k1n5E2V7EkZCRtRyZKT6CtEDQln7XVwiucBhRvicZh140R\n\t7frbgdHhZ9+bKWhyvJv0UuaHAKbq7aNZEsnC7GX3qP7X4BQO7Bvg209RPe99s/cY93Jm\n\t99I0fjRHZxPCSVcZIB+MYCbVJDzJVWuMRL3dbVK5BjeWDLvSDOK5jv7P+KOl3hKgmHUw\n\th5tA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=efgHd4YGQ58jxWp637hKMDNUWrrQu5q1i2/6wlvASNU=;\n\tb=SVAn4aCE82bNP+mIAtE6iBQC7T8OaTILJ68tZxrBlr1ovyrBGjL8EsY+mFPT46Bf/x\n\t0cvWAJOlXNew/mheJlnjvOLQt6KH9jFCSAFe2UvWsArF0QkvLb1oiP6HOILYLGd95Prj\n\tgziefOOZOWL1Mq9dR/91NLtlTcwCiiGgHur6qcvjc46IkyugJ+pruw9LBWA4PsqMQwlm\n\tLDy6w7T1h314kslME9ShlLoMDElKgvkrS7U6jGGh2z/REx+VqjefueeLKAOF4z7Vj81G\n\txyfgOKkW7SAkvOgQCnhgO7ThaZPVel0Cg+GYfGsQk2D2+CDTcPdFmaYDr1lMv8o7vj0w\n\tFpag==","X-Gm-Message-State":"AHYfb5iyxJaZV0iVewPzjLd2t2wuGU0dIat/UtxpWtEdRnYSHChaHDFf\n\tKb/84ZCnZeIysdZkRTSldALNGvZoAw==","X-Received":"by 10.99.43.140 with SMTP id r134mr2187965pgr.206.1504056304652; \n\tTue, 29 Aug 2017 18:25:04 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504033335-19098-1-git-send-email-nikolay@cumulusnetworks.com>","References":"<1504033335-19098-1-git-send-email-nikolay@cumulusnetworks.com>","From":"Cong Wang ","Date":"Tue, 29 Aug 2017 18:24:44 -0700","Message-ID":"","Subject":"Re: [PATCH net] sch_hhf: fix null pointer dereference on init\n\tfailure","To":"Nikolay Aleksandrov ","Cc":"Linux Kernel Network Developers ,\n\tEric Dumazet , Jamal Hadi Salim ,\n\tJiri Pirko , Roopa Prabhu ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759927,"web_url":"http://patchwork.ozlabs.org/comment/1759927/","msgid":"<04bea369-e2d9-954a-0da0-eb3ff831a1c7@cumulusnetworks.com>","list_archive_url":null,"date":"2017-08-30T07:27:20","subject":"Re: [PATCH net] sch_hhf: fix null pointer dereference on init\n\tfailure","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 30/08/17 04:24, Cong Wang wrote:\n> On Tue, Aug 29, 2017 at 12:02 PM, Nikolay Aleksandrov\n> wrote:\n>> First I did it with the check in the for () conditional, but this is more\n>> visible and explicit. Let me know if you'd like the shorter version. :-)\n> \n> Or, if you want to make the patch size smaller, just check NULL\n> before for():\n> \n> if (!q->hh_flows)\n> return;\n> \n> for (...)\n> \n> Up to you, I have no strong opinion here, slightly prefer a smaller\n> one for backport.\n> \n\nSure, either one is fine with me too. Since I'll be resubmitting these in a set\nI'll use the smaller version for this one.\n\nThanks,\n Nik","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"Qg2FiJIa\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhxsp455Wz9sP5\n\tfor ;\n\tWed, 30 Aug 2017 17:27:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751316AbdH3H1Y (ORCPT );\n\tWed, 30 Aug 2017 03:27:24 -0400","from mail-wr0-f173.google.com ([209.85.128.173]:36199 \"EHLO\n\tmail-wr0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751242AbdH3H1X (ORCPT\n\t); Wed, 30 Aug 2017 03:27:23 -0400","by mail-wr0-f173.google.com with SMTP id p14so16020202wrg.3\n\tfor ; Wed, 30 Aug 2017 00:27:23 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\t7sm3534196wrd.22.2017.08.30.00.27.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 00:27:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=TK1FA777zUX1tKTxclxJtBpM3WH7n6WIE7pjBXq9Sp8=;\n\tb=Qg2FiJIaobMRKgS/R5aDV0fad96EiQNacYaSfQJ3gWzsBSB0/Lk57uGuOrUMoGYHFv\n\tGszUsOc5Wy7YitA0oFY3PZF0Jo1pwjwVIw3EGtryC1GASUQv69avmTJbTGfxL/pZnIX1\n\tCBnIH9uDNiA5oY+dd1aaYUdcZbeNh3VUgblrA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=TK1FA777zUX1tKTxclxJtBpM3WH7n6WIE7pjBXq9Sp8=;\n\tb=rfGj3Xu4fLaXUnzqtEyAlXbIOT+PP8ug03iJP5oboRow8AAKJXq52UlUfzKFFzBRex\n\tMVskTHq4mi2/Jxbxcc3fLdGHN2hVaDHlALFgxFTdnLtdgKrRkKGOLPR39HVQyiJQZOQx\n\tfyT2Jcja2sZeUbFR144FPbftflGGSzKtyBBI4sTBa8bDvPkeWcn/v9+lxTYV38TJLYvn\n\t13MMZtMmKbRhHus+NKNMfSyGCXb0Odh+My6m1vH8bmJGrVJYC06zBUrjqeXeK3uYZU1u\n\tl7Xfl+Uk2Upw+R1pvT4Ykta/DdcJ5dkFFZX1nKbvOlsGUFmlV+yNaGMnd8RmbCU5QuFB\n\tYqlQ==","X-Gm-Message-State":"AHYfb5geNkGzFImm4qbPXEYbFoZ/OJ9olMmUGvwJsSxUmSztx2MzavO8\n\t/AbvfPAkh8QNPqd7","X-Received":"by 10.223.178.230 with SMTP id g93mr392307wrd.20.1504078042335; \n\tWed, 30 Aug 2017 00:27:22 -0700 (PDT)","Subject":"Re: [PATCH net] sch_hhf: fix null pointer dereference on init\n\tfailure","To":"Cong Wang ","References":"<1504033335-19098-1-git-send-email-nikolay@cumulusnetworks.com>\n\t","Cc":"Linux Kernel Network Developers ,\n\tEric Dumazet , Jamal Hadi Salim ,\n\tJiri Pirko , Roopa Prabhu ","From":"Nikolay Aleksandrov ","Message-ID":"<04bea369-e2d9-954a-0da0-eb3ff831a1c7@cumulusnetworks.com>","Date":"Wed, 30 Aug 2017 10:27:20 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]