[{"id":1759816,"web_url":"http://patchwork.ozlabs.org/comment/1759816/","msgid":"<20170830021132.GC3386@umbus.fritz.box>","list_archive_url":null,"date":"2017-08-30T02:11:33","subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Tue, Aug 29, 2017 at 08:13:36PM +0200, Thomas Huth wrote:\n> Broken with commit b4ba67d9a7025 (\"libqos: Change PCI accessors to take\n> opaque BAR handle\") a while ago, but nobody noticed since the tests are\n> only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized\n> anymore if bir_pba has the same value as bir_table. With this fix,\n> \"make check SPEED=slow\" should work fine again.\n> \n> Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b\n> Signed-off-by: Thomas Huth \n\nReviewed-by: David Gibson \n\n> ---\n> tests/libqos/pci.c | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c\n> index 2dcdead..28d576c 100644\n> --- a/tests/libqos/pci.c\n> +++ b/tests/libqos/pci.c\n> @@ -120,6 +120,8 @@ void qpci_msix_enable(QPCIDevice *dev)\n> bir_pba = table & PCI_MSIX_FLAGS_BIRMASK;\n> if (bir_pba != bir_table) {\n> dev->msix_pba_bar = qpci_iomap(dev, bir_pba, NULL);\n> + } else {\n> + dev->msix_pba_bar = dev->msix_table_bar;\n> }\n> dev->msix_pba_off = table & ~PCI_MSIX_FLAGS_BIRMASK;\n> \n> @@ -138,8 +140,11 @@ void qpci_msix_disable(QPCIDevice *dev)\n> qpci_config_writew(dev, addr + PCI_MSIX_FLAGS,\n> val & ~PCI_MSIX_FLAGS_ENABLE);\n> \n> + if (dev->msix_pba_bar.addr != dev->msix_table_bar.addr) {\n> + qpci_iounmap(dev, dev->msix_pba_bar);\n> + }\n> qpci_iounmap(dev, dev->msix_table_bar);\n> - qpci_iounmap(dev, dev->msix_pba_bar);\n> +\n> dev->msix_enabled = 0;\n> dev->msix_table_off = 0;\n> dev->msix_pba_off = 0;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"exX6BfBU\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhptP6qMgz9s8P\n\tfor ;\n\tWed, 30 Aug 2017 12:12:29 +1000 (AEST)","from localhost ([::1]:47733 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmsUV-0005iX-QN\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 22:12:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48092)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmsTr-0005fq-V7\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 22:11:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmsTo-0006Tk-09\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 22:11:47 -0400","from ozlabs.org ([103.22.144.67]:46611)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmsTn-0006Pf-Bz; Tue, 29 Aug 2017 22:11:43 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xhpsQ2B4Cz9sNr; Wed, 30 Aug 2017 12:11:38 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504059098;\n\tbh=1qAiCzEXC+x54XBKk1cv+ZKyJgJ3A6ZXr8M6lej0P+g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=exX6BfBU9J4vyHTFVPCFzmy7youCwxoPc3xqkNCsV8t7qCV+IN+3O0gVbC8v5HV+p\n\tGs569uOdjGpNLRSZEXWQDf02FJ352lBIMsG3X31EAI6nWGp0OY6FwdTNqdDemyf5Vm\n\tXsjvzttFv+04N4v/eLpexGW2INDwJRT7ghABRt2E=","Date":"Wed, 30 Aug 2017 12:11:33 +1000","From":"David Gibson ","To":"Thomas Huth ","Message-ID":"<20170830021132.GC3386@umbus.fritz.box>","References":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"z4+8/lEcDcG5Ke9S\"","Content-Disposition":"inline","In-Reply-To":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Laurent Vivier ,\n\tqemu-devel@nongnu.org, =?iso-8859-1?q?Marc-Andr=E9?=\n\tLureau , Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1760264,"web_url":"http://patchwork.ozlabs.org/comment/1760264/","msgid":"<20170830170850.631d1f8c.cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T15:08:50","subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 29 Aug 2017 20:13:36 +0200\nThomas Huth wrote:\n\n> Broken with commit b4ba67d9a7025 (\"libqos: Change PCI accessors to take\n> opaque BAR handle\") a while ago, but nobody noticed since the tests are\n> only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized\n> anymore if bir_pba has the same value as bir_table. With this fix,\n> \"make check SPEED=slow\" should work fine again.\n> \n> Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b\n> Signed-off-by: Thomas Huth \n> ---\n> tests/libqos/pci.c | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n\nWith that (and \"hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on\nbig endian systems\"), \"make check SPEED=slow\" now works for me both on\nx86_64 and s390x, so\n\nTested-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj87867TKz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 01:09:40 +1000 (AEST)","from localhost ([::1]:51074 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn4cc-0001I3-IZ\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 11:09:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56674)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn4c1-0001Fr-Ti\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:09:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn4by-0007qf-FO\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 11:09:01 -0400","from mx1.redhat.com ([209.132.183.28]:53668)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn4by-0007qO-8h; Wed, 30 Aug 2017 11:08:58 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1601AC0587D1;\n\tWed, 30 Aug 2017 15:08:57 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EB81291552;\n\tWed, 30 Aug 2017 15:08:52 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1601AC0587D1","Date":"Wed, 30 Aug 2017 17:08:50 +0200","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20170830170850.631d1f8c.cohuck@redhat.com>","In-Reply-To":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","References":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 30 Aug 2017 15:08:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , qemu-trivial@nongnu.org,\n\tqemu-devel@nongnu.org, Philippe =?utf-8?q?Mathieu-Daud=C3=A9?=\n\t, =?utf-8?q?Marc-Andr=C3=A9?=\n\tLureau , David Gibson\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762455,"web_url":"http://patchwork.ozlabs.org/comment/1762455/","msgid":"","list_archive_url":null,"date":"2017-09-04T06:53:37","subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","submitter":{"id":66421,"url":"http://patchwork.ozlabs.org/api/people/66421/","name":"Laurent Vivier","email":"lvivier@redhat.com"},"content":"On 29/08/2017 20:13, Thomas Huth wrote:\n> Broken with commit b4ba67d9a7025 (\"libqos: Change PCI accessors to take\n> opaque BAR handle\") a while ago, but nobody noticed since the tests are\n> only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized\n\nyou mean \"SPEED=quick\"?\n\n> anymore if bir_pba has the same value as bir_table. With this fix,\n> \"make check SPEED=slow\" should work fine again.\n> \n> Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b\n> Signed-off-by: Thomas Huth \n> ---\n> tests/libqos/pci.c | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c\n> index 2dcdead..28d576c 100644\n> --- a/tests/libqos/pci.c\n> +++ b/tests/libqos/pci.c\n> @@ -120,6 +120,8 @@ void qpci_msix_enable(QPCIDevice *dev)\n> bir_pba = table & PCI_MSIX_FLAGS_BIRMASK;\n> if (bir_pba != bir_table) {\n> dev->msix_pba_bar = qpci_iomap(dev, bir_pba, NULL);\n> + } else {\n> + dev->msix_pba_bar = dev->msix_table_bar;\n> }\n> dev->msix_pba_off = table & ~PCI_MSIX_FLAGS_BIRMASK;\n> \n> @@ -138,8 +140,11 @@ void qpci_msix_disable(QPCIDevice *dev)\n> qpci_config_writew(dev, addr + PCI_MSIX_FLAGS,\n> val & ~PCI_MSIX_FLAGS_ENABLE);\n> \n> + if (dev->msix_pba_bar.addr != dev->msix_table_bar.addr) {\n> + qpci_iounmap(dev, dev->msix_pba_bar);\n> + }\n> qpci_iounmap(dev, dev->msix_table_bar);\n> - qpci_iounmap(dev, dev->msix_pba_bar);\n> +\n> dev->msix_enabled = 0;\n> dev->msix_table_off = 0;\n> dev->msix_pba_off = 0;\n> \n\nReviewed-by: Laurent Vivier ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm0vK2rrXz9s78\n\tfor ;\n\tMon, 4 Sep 2017 16:54:20 +1000 (AEST)","from localhost ([::1]:37314 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dolGz-0004wS-R7\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 02:54:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:32959)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dolGY-0004vb-3O\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 02:53:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dolGS-0006uC-5g\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 02:53:50 -0400","from mx1.redhat.com ([209.132.183.28]:45696)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dolGR-0006sX-V7; Mon, 04 Sep 2017 02:53:44 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C48A1C058EAF;\n\tMon, 4 Sep 2017 06:53:41 +0000 (UTC)","from [10.36.116.175] (ovpn-116-175.ams2.redhat.com [10.36.116.175])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id ED6EB7DDE0;\n\tMon, 4 Sep 2017 06:53:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C48A1C058EAF","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","From":"Laurent Vivier ","Message-ID":"","Date":"Mon, 4 Sep 2017 08:53:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tMon, 04 Sep 2017 06:53:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762470,"web_url":"http://patchwork.ozlabs.org/comment/1762470/","msgid":"","list_archive_url":null,"date":"2017-09-04T07:17:20","subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 04.09.2017 08:53, Laurent Vivier wrote:\n> On 29/08/2017 20:13, Thomas Huth wrote:\n>> Broken with commit b4ba67d9a7025 (\"libqos: Change PCI accessors to take\n>> opaque BAR handle\") a while ago, but nobody noticed since the tests are\n>> only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized\n> \n> you mean \"SPEED=quick\"?\n\nAh, well, that sentence was ambiguous - I meant \"nobody noticed since\nthe *ivshmem* tests are only run in SPEED=slow mode *and we are running\nthe tests in quick mode only by default*\".\nMaybe this could be fixed up when the patch is picked up...\n\n>> anymore if bir_pba has the same value as bir_table. With this fix,\n>> \"make check SPEED=slow\" should work fine again.\n>>\n>> Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b\n>> Signed-off-by: Thomas Huth \n>> ---\n>> tests/libqos/pci.c | 7 ++++++-\n>> 1 file changed, 6 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c\n>> index 2dcdead..28d576c 100644\n>> --- a/tests/libqos/pci.c\n>> +++ b/tests/libqos/pci.c\n>> @@ -120,6 +120,8 @@ void qpci_msix_enable(QPCIDevice *dev)\n>> bir_pba = table & PCI_MSIX_FLAGS_BIRMASK;\n>> if (bir_pba != bir_table) {\n>> dev->msix_pba_bar = qpci_iomap(dev, bir_pba, NULL);\n>> + } else {\n>> + dev->msix_pba_bar = dev->msix_table_bar;\n>> }\n>> dev->msix_pba_off = table & ~PCI_MSIX_FLAGS_BIRMASK;\n>> \n>> @@ -138,8 +140,11 @@ void qpci_msix_disable(QPCIDevice *dev)\n>> qpci_config_writew(dev, addr + PCI_MSIX_FLAGS,\n>> val & ~PCI_MSIX_FLAGS_ENABLE);\n>> \n>> + if (dev->msix_pba_bar.addr != dev->msix_table_bar.addr) {\n>> + qpci_iounmap(dev, dev->msix_pba_bar);\n>> + }\n>> qpci_iounmap(dev, dev->msix_table_bar);\n>> - qpci_iounmap(dev, dev->msix_pba_bar);\n>> +\n>> dev->msix_enabled = 0;\n>> dev->msix_table_off = 0;\n>> dev->msix_pba_off = 0;\n>>\n> \n> Reviewed-by: Laurent Vivier \n\nThanks!\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm1Ql1Hy5z9s82\n\tfor ;\n\tMon, 4 Sep 2017 17:18:05 +1000 (AEST)","from localhost ([::1]:38744 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doldv-0003nj-Gl\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 03:17:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45512)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doldU-0003nN-92\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 03:17:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doldR-0001cr-0W\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 03:17:32 -0400","from mx1.redhat.com ([209.132.183.28]:55526)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1doldQ-0001ak-Qj; Mon, 04 Sep 2017 03:17:28 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CE735806A1;\n\tMon, 4 Sep 2017 07:17:25 +0000 (UTC)","from [10.36.116.102] (ovpn-116-102.ams2.redhat.com [10.36.116.102])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 047A417136;\n\tMon, 4 Sep 2017 07:17:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CE735806A1","To":"Laurent Vivier , qemu-devel@nongnu.org","References":"<1504030416-18618-1-git-send-email-thuth@redhat.com>\n\t","From":"Thomas Huth ","Message-ID":"","Date":"Mon, 4 Sep 2017 09:17:20 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 04 Sep 2017 07:17:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766098,"web_url":"http://patchwork.ozlabs.org/comment/1766098/","msgid":"<20170911093207.4375c534.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-11T07:32:07","subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 29 Aug 2017 20:13:36 +0200\nThomas Huth wrote:\n\n> Broken with commit b4ba67d9a7025 (\"libqos: Change PCI accessors to take\n> opaque BAR handle\") a while ago, but nobody noticed since the tests are\n> only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized\n> anymore if bir_pba has the same value as bir_table. With this fix,\n> \"make check SPEED=slow\" should work fine again.\n> \n> Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b\n> Signed-off-by: Thomas Huth \n> ---\n> tests/libqos/pci.c | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n\nThere really should be a better tree for that than my s390 tree, but\nthe other ivshmem patch was feeling a bit lonely, so I queued this as\nwell. Better than having the patch languish on the list.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrKQX2064z9s4q\n\tfor ;\n\tMon, 11 Sep 2017 17:32:52 +1000 (AEST)","from localhost ([::1]:55935 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drJD8-0000MD-DN\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 03:32:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42454)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drJCc-0000Lb-SZ\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 03:32:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drJCZ-0005xV-Pf\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 03:32:18 -0400","from mx1.redhat.com ([209.132.183.28]:57424)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drJCZ-0005xL-In; Mon, 11 Sep 2017 03:32:15 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8DBD6101722;\n\tMon, 11 Sep 2017 07:32:14 +0000 (UTC)","from gondolin (ovpn-116-234.ams2.redhat.com [10.36.116.234])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D72356365E;\n\tMon, 11 Sep 2017 07:32:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8DBD6101722","Date":"Mon, 11 Sep 2017 09:32:07 +0200","From":"Cornelia Huck ","To":"Thomas Huth ","Message-ID":"<20170911093207.4375c534.cohuck@redhat.com>","In-Reply-To":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","References":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 11 Sep 2017 07:32:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , qemu-trivial@nongnu.org,\n\tqemu-devel@nongnu.org, Philippe =?utf-8?q?Mathieu-Daud=C3=A9?=\n\t, =?utf-8?q?Marc-Andr=C3=A9?=\n\tLureau , David Gibson\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766220,"web_url":"http://patchwork.ozlabs.org/comment/1766220/","msgid":"<20170911094950.GA2784@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-11T09:49:50","subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Mon, Sep 11, 2017 at 09:32:07AM +0200, Cornelia Huck wrote:\n> On Tue, 29 Aug 2017 20:13:36 +0200\n> Thomas Huth wrote:\n> \n> > Broken with commit b4ba67d9a7025 (\"libqos: Change PCI accessors to take\n> > opaque BAR handle\") a while ago, but nobody noticed since the tests are\n> > only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized\n> > anymore if bir_pba has the same value as bir_table. With this fix,\n> > \"make check SPEED=slow\" should work fine again.\n> > \n> > Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b\n> > Signed-off-by: Thomas Huth \n> > ---\n> > tests/libqos/pci.c | 7 ++++++-\n> > 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> There really should be a better tree for that than my s390 tree, but\n> the other ivshmem patch was feeling a bit lonely, so I queued this as\n> well. Better than having the patch languish on the list.\n\nThanks, Cornelia.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"B14il6vn\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrQ2B0C1pz9sBd\n\tfor ;\n\tMon, 11 Sep 2017 21:00:33 +1000 (AEST)","from localhost ([::1]:56697 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drMS8-0001Aw-1N\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 07:00:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39428)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drMPT-0007oN-SB\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:57:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drMPP-0002HU-Or\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:57:47 -0400","from ozlabs.org ([103.22.144.67]:60731)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drMPP-0002Ei-9F; Mon, 11 Sep 2017 06:57:43 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xrPyq3RDbz9sBd; Mon, 11 Sep 2017 20:57:39 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505127459;\n\tbh=FnqVP91w7LoI3iUx+85ta1eBZ6kw8sPlNeRF6pf/Uvk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=B14il6vnqOW0MaeokikbfTb9ePZXS0vtwAWx1V/lHuV/vwxXDk7OkkIrlADfz6tDN\n\tjSh3LGCWlyKljRMvpKRvldTqs287AeurXAuoonFEyk2QgIqHPl0X9Ai/jc/kPDY0Z3\n\tiTF9+HS4avsut15FAEOrD6NhmX00hefbhgRRajjk=","Date":"Mon, 11 Sep 2017 19:49:50 +1000","From":"David Gibson ","To":"Cornelia Huck ","Message-ID":"<20170911094950.GA2784@umbus.fritz.box>","References":"<1504030416-18618-1-git-send-email-thuth@redhat.com>\n\t<20170911093207.4375c534.cohuck@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"oyUTqETQ0mS9luUI\"","Content-Disposition":"inline","In-Reply-To":"<20170911093207.4375c534.cohuck@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Thomas Huth ,\n\tqemu-trivial@nongnu.org, qemu-devel@nongnu.org, Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\t=?iso-8859-1?q?Marc-Andr=E9?= Lureau ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768383,"web_url":"http://patchwork.ozlabs.org/comment/1768383/","msgid":"","list_archive_url":null,"date":"2017-09-14T07:46:23","subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","submitter":{"id":183,"url":"http://patchwork.ozlabs.org/api/people/183/","name":"Michael Tokarev","email":"mjt@tls.msk.ru"},"content":"29.08.2017 21:13, Thomas Huth wrote:\n> Broken with commit b4ba67d9a7025 (\"libqos: Change PCI accessors to take\n> opaque BAR handle\") a while ago, but nobody noticed since the tests are\n> only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized\n> anymore if bir_pba has the same value as bir_table. With this fix,\n> \"make check SPEED=slow\" should work fine again.\n\nApplied to -trivial, thanks!\n\n/mjt","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9bM6SKsz9s72\n\tfor ;\n\tThu, 14 Sep 2017 17:46:55 +1000 (AEST)","from localhost ([::1]:46170 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsOrO-0002fy-0O\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 03:46:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49061)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsOqx-0002fn-An\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:46:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsOqu-0001oA-71\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:46:27 -0400","from isrv.corpit.ru ([86.62.121.231]:41979)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dsOqt-0001ni-VT; Thu, 14 Sep 2017 03:46:24 -0400","from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2])\n\tby isrv.corpit.ru (Postfix) with ESMTP id 36A97412D1;\n\tThu, 14 Sep 2017 10:46:23 +0300 (MSK)","from [192.168.177.99] (mjt.vpn.tls.msk.ru [192.168.177.99])\n\tby tsrv.corpit.ru (Postfix) with ESMTP id 13B005B9;\n\tThu, 14 Sep 2017 10:46:21 +0300 (MSK)"],"To":"Thomas Huth , qemu-devel@nongnu.org","References":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","From":"Michael Tokarev ","Message-ID":"","Date":"Thu, 14 Sep 2017 10:46:23 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504030416-18618-1-git-send-email-thuth@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"86.62.121.231","Subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.11] tests: Fix broken\n\tivshmem-server-msi/-irq tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Laurent Vivier , David\n\tGibson , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]