[{"id":1759577,"web_url":"http://patchwork.ozlabs.org/comment/1759577/","msgid":"<20170829.104945.1786969849973428586.davem@davemloft.net>","list_archive_url":null,"date":"2017-08-29T17:49:45","subject":"Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into\n\tthe kernel","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Greg KH \nDate: Tue, 29 Aug 2017 19:46:22 +0200\n\n> When moving the IRDA code out of net/ into drivers/staging/irda/net, the\n> link order changes when IRDA is built into the kernel. That causes a\n> kernel crash at boot time as netfilter isn't initialized yet.\n> \n> To fix this, build and link the irda networking code in the same exact\n> order that it was previously before the move.\n> \n> Reported-by: kernel test robot \n> Reported-by: Geert Uytterhoeven \n> Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org\n\nGreg, just change the initializer in IRDA so that it will run\nafter subsys_init() when built statically.\n\nIRDA is definitely not the first pontentially statically built\nthing that needs netlink up and available.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhbkc5zMVz9s8w\n\tfor ;\n\tWed, 30 Aug 2017 03:50:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751295AbdH2Rts (ORCPT );\n\tTue, 29 Aug 2017 13:49:48 -0400","from shards.monkeyblade.net ([184.105.139.130]:36110 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750822AbdH2Rtr (ORCPT\n\t); Tue, 29 Aug 2017 13:49:47 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 66C3413CBA03C;\n\tTue, 29 Aug 2017 10:49:46 -0700 (PDT)"],"Date":"Tue, 29 Aug 2017 10:49:45 -0700 (PDT)","Message-Id":"<20170829.104945.1786969849973428586.davem@davemloft.net>","To":"gregkh@linuxfoundation.org","Cc":"devel@driverdev.osuosl.org, netdev@vger.kernel.org,\n\tsamuel@sortiz.org, linux-kernel@vger.kernel.org,\n\tfengguang.wu@intel.com, geert@linux-m68k.org","Subject":"Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into\n\tthe kernel","From":"David Miller ","In-Reply-To":"<20170829174622.GA25926@kroah.com>","References":"<20170829172608.GA4700@kroah.com>\n\t<20170829173129.GA11029@kroah.com>\n\t<20170829174622.GA25926@kroah.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 29 Aug 2017 10:49:46 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1759607,"web_url":"http://patchwork.ozlabs.org/comment/1759607/","msgid":"<20170829190503.GA31452@kroah.com>","list_archive_url":null,"date":"2017-08-29T19:05:03","subject":"Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into\n\tthe kernel","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Tue, Aug 29, 2017 at 10:49:45AM -0700, David Miller wrote:\n> From: Greg KH \n> Date: Tue, 29 Aug 2017 19:46:22 +0200\n> \n> > When moving the IRDA code out of net/ into drivers/staging/irda/net, the\n> > link order changes when IRDA is built into the kernel. That causes a\n> > kernel crash at boot time as netfilter isn't initialized yet.\n> > \n> > To fix this, build and link the irda networking code in the same exact\n> > order that it was previously before the move.\n> > \n> > Reported-by: kernel test robot \n> > Reported-by: Geert Uytterhoeven \n> > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org\n> \n> Greg, just change the initializer in IRDA so that it will run\n> after subsys_init() when built statically.\n> \n> IRDA is definitely not the first pontentially statically built\n> thing that needs netlink up and available.\n\nOk, will do that tomorrow and test it and send you the patch.\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhdPM4j5Qz9sQl\n\tfor ;\n\tWed, 30 Aug 2017 05:05:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751488AbdH2TE7 (ORCPT );\n\tTue, 29 Aug 2017 15:04:59 -0400","from mail.linuxfoundation.org ([140.211.169.12]:37286 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751186AbdH2TE6 (ORCPT\n\t); Tue, 29 Aug 2017 15:04:58 -0400","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 9A3A4AAC;\n\tTue, 29 Aug 2017 19:04:57 +0000 (UTC)"],"Date":"Tue, 29 Aug 2017 21:05:03 +0200","From":"Greg KH ","To":"David Miller ","Cc":"devel@driverdev.osuosl.org, netdev@vger.kernel.org,\n\tsamuel@sortiz.org, linux-kernel@vger.kernel.org,\n\tfengguang.wu@intel.com, geert@linux-m68k.org","Subject":"Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into\n\tthe kernel","Message-ID":"<20170829190503.GA31452@kroah.com>","References":"<20170829172608.GA4700@kroah.com>\n\t<20170829173129.GA11029@kroah.com>\n\t<20170829174622.GA25926@kroah.com>\n\t<20170829.104945.1786969849973428586.davem@davemloft.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170829.104945.1786969849973428586.davem@davemloft.net>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]